* [ISSUE] Packaging: get git commit sha?
@ 2020-10-04 19:38 classabbyamp
2020-10-04 19:53 ` ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: classabbyamp @ 2020-10-04 19:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
New issue by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/25343
Description:
I am working on packaging `chezmoi` for void, and the project maintainer requests that the git commit hash be added as a linker flag (see [here](https://github.com/twpayne/chezmoi/blob/master/docs/CONTRIBUTING.md#packaging)).
Is there a preferred way to do this in the template, other than hard-coding it?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Packaging: get git commit sha?
2020-10-04 19:38 [ISSUE] Packaging: get git commit sha? classabbyamp
@ 2020-10-04 19:53 ` ericonr
2020-10-04 19:54 ` ericonr
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-10-04 19:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/issues/25343#issuecomment-703307116
Comment:
Hard coding is the way to go, unfortunately. I'm not sure it's entirely necessary, since we would be using tagged releases, which should be directly linkable to a specific commit.
The `-X main.date=$DATE` part is bad, though, and upstream should be told not to require it (or even suggest it, for that matter). It hurts reproducible builds for no gain.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Packaging: get git commit sha?
2020-10-04 19:38 [ISSUE] Packaging: get git commit sha? classabbyamp
2020-10-04 19:53 ` ericonr
@ 2020-10-04 19:54 ` ericonr
2020-10-04 20:13 ` classabbyamp
2020-10-04 20:13 ` [ISSUE] [CLOSED] " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-10-04 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/issues/25343#issuecomment-703307116
Comment:
Hard coding is the way to go if you really want to respect their requirements, unfortunately. I'm not sure it's entirely necessary, since we would be using tagged releases, which should be directly linkable to a specific commit.
The `-X main.date=$DATE` part is bad, though, and upstream should be told not to require it (or even suggest it, for that matter). It hurts reproducible builds for no gain.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Packaging: get git commit sha?
2020-10-04 19:38 [ISSUE] Packaging: get git commit sha? classabbyamp
2020-10-04 19:53 ` ericonr
2020-10-04 19:54 ` ericonr
@ 2020-10-04 20:13 ` classabbyamp
2020-10-04 20:13 ` [ISSUE] [CLOSED] " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2020-10-04 20:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/25343#issuecomment-703309655
Comment:
Thanks! I'll take that into advisement
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ISSUE] [CLOSED] Packaging: get git commit sha?
2020-10-04 19:38 [ISSUE] Packaging: get git commit sha? classabbyamp
` (2 preceding siblings ...)
2020-10-04 20:13 ` classabbyamp
@ 2020-10-04 20:13 ` classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2020-10-04 20:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
Closed issue by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/25343
Description:
I am working on packaging `chezmoi` for void, and the project maintainer requests that the git commit hash be added as a linker flag (see [here](https://github.com/twpayne/chezmoi/blob/master/docs/CONTRIBUTING.md#packaging)).
Is there a preferred way to do this in the template, other than hard-coding it?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-04 20:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-04 19:38 [ISSUE] Packaging: get git commit sha? classabbyamp
2020-10-04 19:53 ` ericonr
2020-10-04 19:54 ` ericonr
2020-10-04 20:13 ` classabbyamp
2020-10-04 20:13 ` [ISSUE] [CLOSED] " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).