* Re: [PR REVIEW] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
@ 2020-10-09 22:20 ` jnbr
2020-10-09 22:27 ` [PR PATCH] [Updated] " Skirmisher
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-10-09 22:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New review comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25482#discussion_r502690942
Comment:
Is --disable-strip really necessary, now with the strip wrapper being in place again?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
2020-10-09 22:20 ` [PR REVIEW] " jnbr
@ 2020-10-09 22:27 ` Skirmisher
2020-10-09 22:29 ` [PR REVIEW] " Skirmisher
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Skirmisher @ 2020-10-09 22:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
There is an updated pull request by Skirmisher against master on the void-packages repository
https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/25482
qemu: enable debug package
qemu package has had -dbg disabled for a long time (looks like an xtraeme anachronism), but the amount of space used by debuginfo is comparable to other large packages, so it seems reasonable to enable. This simplifies the template a little too.
A patch file from https://github.com/void-linux/void-packages/pull/25482.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-25482.patch --]
[-- Type: text/x-diff, Size: 2158 bytes --]
From 9184df00e8ea81c505f30760c1243ab0cb409da8 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Fri, 9 Oct 2020 14:22:38 -0700
Subject: [PATCH] qemu: enable debug package
Disk space used by debuginfo is comparable to other large
packages, so enabling debug package seems reasonable.
Removed now-redundant do_build().
---
srcpkgs/qemu/template | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 944a9bd5837..4c1a127b136 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,15 +1,16 @@
# Template file for 'qemu'
pkgname=qemu
version=5.1.0
-revision=3
+revision=4
short_desc="Open Source Processor Emulator"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
license="GPL-2.0-or-later, LGPL-2.1-or-later"
homepage="https://www.qemu.org"
distfiles="https://wiki.qemu.org/download/qemu-${version}.tar.bz2"
checksum=8314b6e5fcc7bf9fa3915d504de6586a69cba30ffa27cbe9ba85d2cb9987fb3a
-
-nostrip=yes
+build_style=configure
+nostrip_files="hppa-firmware.img openbios-ppc openbios-sparc32 openbios-sparc64
+ palcode-clipper s390-ccw.img s390-netboot.img u-boot.e500"
hostmakedepends="gettext pkg-config perl python3 automake libtool flex
python3-Sphinx texinfo"
makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
@@ -64,22 +65,14 @@ do_configure() {
--disable-xen --enable-tpm \
--enable-vhost-net --enable-vnc-png --enable-virtfs \
--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
- --enable-pie --localstatedir=/var --enable-docs \
+ --enable-pie --localstatedir=/var --enable-docs --disable-strip \
$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
${want_sdl} \
$(vopt_enable smartcard) \
$(vopt_if gtk3 "--enable-gtk") ${args}
}
-do_build() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
- make ${makejobs}
-}
do_install() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
-
vsed -i Makefile -e 's;dtc/%:;dtc/libfdt:;'
make DESTDIR=${DESTDIR} install
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
2020-10-09 22:20 ` [PR REVIEW] " jnbr
2020-10-09 22:27 ` [PR PATCH] [Updated] " Skirmisher
@ 2020-10-09 22:29 ` Skirmisher
2020-10-09 22:29 ` Skirmisher
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Skirmisher @ 2020-10-09 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
New review comment by Skirmisher on void-packages repository
https://github.com/void-linux/void-packages/pull/25482#discussion_r502693723
Comment:
If that's SOP then no. I threw that in because the whole template was put together without consideration of debuginfo so I didn't know what would be missing. I can remove it if it would be cleaner.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (2 preceding siblings ...)
2020-10-09 22:29 ` [PR REVIEW] " Skirmisher
@ 2020-10-09 22:29 ` Skirmisher
2020-10-09 22:29 ` [PR PATCH] [Updated] " Skirmisher
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Skirmisher @ 2020-10-09 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by Skirmisher on void-packages repository
https://github.com/void-linux/void-packages/pull/25482#discussion_r502694035
Comment:
...and the strip wrapper fires anyway so yeah I'll remove the flag
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (3 preceding siblings ...)
2020-10-09 22:29 ` Skirmisher
@ 2020-10-09 22:29 ` Skirmisher
2020-10-09 22:30 ` [PR REVIEW] " jnbr
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Skirmisher @ 2020-10-09 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
There is an updated pull request by Skirmisher against master on the void-packages repository
https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/25482
qemu: enable debug package
qemu package has had -dbg disabled for a long time (looks like an xtraeme anachronism), but the amount of space used by debuginfo is comparable to other large packages, so it seems reasonable to enable. This simplifies the template a little too.
A patch file from https://github.com/void-linux/void-packages/pull/25482.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-25482.patch --]
[-- Type: text/x-diff, Size: 2158 bytes --]
From 7bb40b9dae47070c0f8e9b1db4d4c6643bdc0b57 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Fri, 9 Oct 2020 14:22:38 -0700
Subject: [PATCH] qemu: enable debug package
Disk space used by debuginfo is comparable to other large
packages, so enabling debug package seems reasonable.
Removed now-redundant do_build().
---
srcpkgs/qemu/template | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 944a9bd5837..4c1a127b136 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,15 +1,16 @@
# Template file for 'qemu'
pkgname=qemu
version=5.1.0
-revision=3
+revision=4
short_desc="Open Source Processor Emulator"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
license="GPL-2.0-or-later, LGPL-2.1-or-later"
homepage="https://www.qemu.org"
distfiles="https://wiki.qemu.org/download/qemu-${version}.tar.bz2"
checksum=8314b6e5fcc7bf9fa3915d504de6586a69cba30ffa27cbe9ba85d2cb9987fb3a
-
-nostrip=yes
+build_style=configure
+nostrip_files="hppa-firmware.img openbios-ppc openbios-sparc32 openbios-sparc64
+ palcode-clipper s390-ccw.img s390-netboot.img u-boot.e500"
hostmakedepends="gettext pkg-config perl python3 automake libtool flex
python3-Sphinx texinfo"
makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
@@ -64,22 +65,14 @@ do_configure() {
--disable-xen --enable-tpm \
--enable-vhost-net --enable-vnc-png --enable-virtfs \
--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
- --enable-pie --localstatedir=/var --enable-docs \
+ --enable-pie --localstatedir=/var --enable-docs --disable-strip \
$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
${want_sdl} \
$(vopt_enable smartcard) \
$(vopt_if gtk3 "--enable-gtk") ${args}
}
-do_build() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
- make ${makejobs}
-}
do_install() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
-
vsed -i Makefile -e 's;dtc/%:;dtc/libfdt:;'
make DESTDIR=${DESTDIR} install
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (4 preceding siblings ...)
2020-10-09 22:29 ` [PR PATCH] [Updated] " Skirmisher
@ 2020-10-09 22:30 ` jnbr
2020-10-09 22:52 ` [PR PATCH] [Updated] " Skirmisher
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-10-09 22:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
New review comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25482#discussion_r502694396
Comment:
If it is not needed, leave it out. Templates should not require any special handling for debug packages to work.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (5 preceding siblings ...)
2020-10-09 22:30 ` [PR REVIEW] " jnbr
@ 2020-10-09 22:52 ` Skirmisher
2020-10-15 18:18 ` Hoshpak
2020-11-02 4:08 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: Skirmisher @ 2020-10-09 22:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
There is an updated pull request by Skirmisher against master on the void-packages repository
https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/25482
qemu: enable debug package
qemu package has had -dbg disabled for a long time (looks like an xtraeme anachronism), but the amount of space used by debuginfo is comparable to other large packages, so it seems reasonable to enable. This simplifies the template a little too.
A patch file from https://github.com/void-linux/void-packages/pull/25482.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-25482.patch --]
[-- Type: text/x-diff, Size: 2535 bytes --]
From 41c66b96e3ea5a71a12fb46d7a686b8b0881b5dd Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Fri, 9 Oct 2020 14:22:38 -0700
Subject: [PATCH] qemu: enable debug package
Disk space used by debuginfo is comparable to other large
packages, so enabling debug package seems reasonable.
Removed now-redundant do_build().
---
srcpkgs/qemu/template | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 944a9bd5837..c6b4b1a661f 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,15 +1,8 @@
# Template file for 'qemu'
pkgname=qemu
version=5.1.0
-revision=3
-short_desc="Open Source Processor Emulator"
-maintainer="Helmut Pozimski <helmut@pozimski.eu>"
-license="GPL-2.0-or-later, LGPL-2.1-or-later"
-homepage="https://www.qemu.org"
-distfiles="https://wiki.qemu.org/download/qemu-${version}.tar.bz2"
-checksum=8314b6e5fcc7bf9fa3915d504de6586a69cba30ffa27cbe9ba85d2cb9987fb3a
-
-nostrip=yes
+revision=4
+build_style=configure
hostmakedepends="gettext pkg-config perl python3 automake libtool flex
python3-Sphinx texinfo"
makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
@@ -23,7 +16,15 @@ makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
$(vopt_if opengl 'libepoxy-devel libdrm-devel MesaLib-devel')
$(vopt_if iscsi 'libiscsi-devel')
$(vopt_if smartcard libcacard-devel) $(vopt_if numa 'libnuma-devel')"
+short_desc="Open Source Processor Emulator"
+maintainer="Helmut Pozimski <helmut@pozimski.eu>"
+license="GPL-2.0-or-later, LGPL-2.1-or-later"
+homepage="https://www.qemu.org"
+distfiles="https://wiki.qemu.org/download/qemu-${version}.tar.bz2"
+checksum=8314b6e5fcc7bf9fa3915d504de6586a69cba30ffa27cbe9ba85d2cb9987fb3a
ignore_elf_dirs="/usr/share/qemu"
+nostrip_files="hppa-firmware.img openbios-ppc openbios-sparc32 openbios-sparc64
+ palcode-clipper s390-ccw.img s390-netboot.img u-boot.e500"
build_options="gtk3 opengl sdl2 spice virgl smartcard numa iscsi"
build_options_default="opengl gtk3 virgl smartcard sdl2 numa iscsi"
@@ -70,16 +71,8 @@ do_configure() {
$(vopt_enable smartcard) \
$(vopt_if gtk3 "--enable-gtk") ${args}
}
-do_build() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
- make ${makejobs}
-}
do_install() {
- # Remove our strip(1) wrapper... E2BIG.
- rm -f ${XBPS_WRAPPERDIR}/strip
-
vsed -i Makefile -e 's;dtc/%:;dtc/libfdt:;'
make DESTDIR=${DESTDIR} install
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (6 preceding siblings ...)
2020-10-09 22:52 ` [PR PATCH] [Updated] " Skirmisher
@ 2020-10-15 18:18 ` Hoshpak
2020-11-02 4:08 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: Hoshpak @ 2020-10-15 18:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/25482#issuecomment-709504927
Comment:
Am Donnerstag, den 15.10.2020, 03:14 -0700 schrieb Piraty:
> @Piraty requested your review on: void-linux/void-packages#25482
> qemu: enable debug package.
>
fine with me.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Merged]: qemu: enable debug package
2020-10-09 22:19 [PR PATCH] qemu: enable debug package Skirmisher
` (7 preceding siblings ...)
2020-10-15 18:18 ` Hoshpak
@ 2020-11-02 4:08 ` ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-11-02 4:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
There's a merged pull request on the void-packages repository
qemu: enable debug package
https://github.com/void-linux/void-packages/pull/25482
Description:
qemu package has had -dbg disabled for a long time (looks like an xtraeme anachronism), but the amount of space used by debuginfo is comparable to other large packages, so it seems reasonable to enable. This simplifies the template a little too.
^ permalink raw reply [flat|nested] 10+ messages in thread