Re: [PR REVIEW] mdocml: backport patches for #9868

Re: [PR REVIEW] mdocml: backport patches for #9868

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r475261235

Comment:
Why indent this? Why add `-`? Imho this whole block should be kept as is.

Re: [PR REVIEW] mdocml: backport patches for #9868

[gt7-void]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

New review comment by gt7-void on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r475272167

Comment:
I just took the chance to make some (mostly) noop changes to the template to make xlint happy. The proposed commit fixes all of the following warnings in the current template:
```
$ xlint srcpkgs/mdocml/template
srcpkgs/mdocml/template: Place checkdepends= after depends=
srcpkgs/mdocml/template: Place provides= after checksum=
srcpkgs/mdocml/template:14: short_desc should not start with an article
srcpkgs/mdocml/template:33: trailing whitespace
srcpkgs/mdocml/template:40: custom variables should use _ prefix: PREFIX=/usr
srcpkgs/mdocml/template:41: custom variables should use _ prefix: SBINDIR=/usr/bin
srcpkgs/mdocml/template:42: custom variables should use _ prefix: MANDIR=/usr/share/man
srcpkgs/mdocml/template:43: custom variables should use _ prefix: OSNAME="Void Linux"
srcpkgs/mdocml/template:44: custom variables should use _ prefix: BINM_SOELIM=mandoc-soelim
srcpkgs/mdocml/template:45: custom variables should use _ prefix: MANM_ROFF="mandoc_roff"
srcpkgs/mdocml/template:49: custom variables should use _ prefix: HAVE_REWB_BSD=0
srcpkgs/mdocml/template:54: trailing whitespace
```

What's the recommended way to fix the warnings for lines 40-49?
The `-` means to strip leading tab characters (https://www.gnu.org/software/bash/manual/html_node/Redirections.html#Here-Documents)

Several templates use this pattern of indented heredoc (for one example see the git template).

I think the indented version is easier to read (either with two tabs or just one tab as in the git template) but I don't really care either way.

Re: mdocml: backport patches for #9868

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#issuecomment-700384860

Comment:
Have you noticed any weird behavior with these patches applied?

Re: mdocml: backport patches for #9868

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#issuecomment-700395102

Comment:
@leahneukirchen are you ok with these patches being applied?

Re: [PR REVIEW] mdocml: backport patches for #9868

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r496433178

Comment:
@gt7-void I believe the point here is that it's ok to fail some `xlint` checks to avoid adding diffs to the templates.

Re: mdocml: backport patches for #9868

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#issuecomment-702757017

Comment:
Yes, I expected an upstream release sooner, but alas.

Re: [PR REVIEW] mdocml: backport patches for #9868

[gt7-void]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

New review comment by gt7-void on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r498880451

Comment:
> @gt7-void I believe the point here is that it's ok to fail some `xlint` checks to avoid adding diffs to the templates.

I thought it was preferred to fix all `xlint` checks any time a template is changed.

In any case: is there a clear preference for heredocs (indented vs. unindented)?

If unindented heredocs are preferred (or accepted), should `xlint` be able to ignore the heredoc block (or check that the heredoc is in the preferred format)?

Re: [PR REVIEW] mdocml: backport patches for #9868

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r466554836

Comment:
please
* `vsed`
* put to `post_patch()`

Re: [PR REVIEW] mdocml: backport patches for #9868

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23108#discussion_r530520514

Comment:
Could this config simply go in `files/` instead?

Re: [PR PATCH] [Closed]: mdocml: backport patches for #9868

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

There's a closed pull request on the void-packages repository

mdocml: backport patches for #9868
https://github.com/void-linux/void-packages/pull/23108

Description:
Fixes #9868 until a new upstream release.
Closes #13125.

It is important since some man pages are inaccessible without this.

For example: `man parallel` displays `moreutils_parallel.1` instead of `parallel.1`.

Also: `man vi` displays `nvi.1` instead of `vi.1` even when `vi` is the choosen alternative (this is less important since `man vim` works)

I took the patches verbatim from #9868, except I had to remove a hunk from the first patch for the file `TODO`.