* Re: [PR REVIEW] go-ipfs: add runit service.
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
@ 2020-10-21 20:25 ` jcgruenhage
2020-10-21 21:09 ` sirikid
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-21 20:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r509665892
Comment:
These are the default directories for the ipfs mounts, I'm not 100% happy here. We could also take the initialising apart instead of doing it idempotently in the daemon command, which would allow us configure the daemon after initialising it, which in turn enables us to use custom paths here. What would the right place here be? `/var/run/go-ipfs/<ipfs/ipns>` or `/var/lib/go-ipfs/<ipfs/ipns>` is what I'd say, but I'm not 100% sure on this.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] go-ipfs: add runit service.
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
2020-10-21 20:25 ` [PR REVIEW] " jcgruenhage
@ 2020-10-21 21:09 ` sirikid
2020-10-22 21:46 ` jcgruenhage
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sirikid @ 2020-10-21 21:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New review comment by sirikid on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r509699295
Comment:
There is an [optional variable `make_dirs`][1], maybe you can use it.
[1]: https://github.com/void-linux/void-packages/blob/master/Manual.md#optional-variables
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] go-ipfs: add runit service.
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
2020-10-21 20:25 ` [PR REVIEW] " jcgruenhage
2020-10-21 21:09 ` sirikid
@ 2020-10-22 21:46 ` jcgruenhage
2020-10-22 22:36 ` [PR PATCH] [Updated] " jcgruenhage
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-22 21:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r510476875
Comment:
Nice! Will definitely use that. Still doesn't answer where these mounts should be though...
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] go-ipfs: add runit service.
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (2 preceding siblings ...)
2020-10-22 21:46 ` jcgruenhage
@ 2020-10-22 22:36 ` jcgruenhage
2020-10-22 23:37 ` [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion jcgruenhage
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-22 22:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by jcgruenhage against master on the void-packages repository
https://github.com/jcgruenhage/void-packages go-ipfs-0.7.0_2
https://github.com/void-linux/void-packages/pull/25777
go-ipfs: add runit service.
A patch file from https://github.com/void-linux/void-packages/pull/25777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-ipfs-0.7.0_2-25777.patch --]
[-- Type: text/x-diff, Size: 2401 bytes --]
From 7ad13aeb4cd8c813a605b7e365015a19d8acb4c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Wed, 21 Oct 2020 22:18:49 +0200
Subject: [PATCH 1/2] go-ipfs: add runit service.
---
srcpkgs/go-ipfs/files/ipfs/run | 4 ++++
srcpkgs/go-ipfs/template | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
create mode 100755 srcpkgs/go-ipfs/files/ipfs/run
diff --git a/srcpkgs/go-ipfs/files/ipfs/run b/srcpkgs/go-ipfs/files/ipfs/run
new file mode 100755
index 00000000000..291e47879c0
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+export IPFS_PATH=${IPFS_PATH:=/var/lib/ipfs}
+exec chpst -u _ipfs ipfs daemon ${OPTS:=--init --enable-gc --migrate} 1>/dev/null
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index 96509787305..6120b2300c2 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -1,7 +1,7 @@
# Template file for 'go-ipfs'
pkgname=go-ipfs
version=0.7.0
-revision=1
+revision=2
build_style=go
go_import_path="github.com/ipfs/${pkgname}"
go_package="${go_import_path}/cmd/ipfs"
@@ -15,6 +15,9 @@ changelog="https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md"
distfiles="https://${go_import_path}/archive/v${version}.tar.gz"
checksum=152986ebb30657ab706bee708fbe929114f5e8c39fbe602e3bbec93fe74c9123
+system_accounts="_ipfs"
+_ipfs_homedir="/var/lib/ipfs"
+
pre_build() {
if [ "$CROSS_BUILD" ]; then
export CGO_ENABLED=0
@@ -26,4 +29,5 @@ post_install() {
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
+ vsv ipfs
}
From a4debb8299ec64d55af96aa68b0b055c1d5ac20c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Fri, 23 Oct 2020 00:35:14 +0200
Subject: [PATCH 2/2] go-ipfs: use vcompletion for completions
---
srcpkgs/go-ipfs/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index 6120b2300c2..7733e5cf971 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -25,7 +25,7 @@ pre_build() {
}
post_install() {
- vinstall misc/completion/ipfs-completion.bash 644 usr/share/bash-completion/completions ipfs
+ vcompletion misc/completion/ipfs-completion.bash bash ipfs
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (3 preceding siblings ...)
2020-10-22 22:36 ` [PR PATCH] [Updated] " jcgruenhage
@ 2020-10-22 23:37 ` jcgruenhage
2020-10-23 11:00 ` jcgruenhage
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-22 23:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
There is an updated pull request by jcgruenhage against master on the void-packages repository
https://github.com/jcgruenhage/void-packages go-ipfs-0.7.0_2
https://github.com/void-linux/void-packages/pull/25777
go-ipfs: add runit service and use vcompletion
A patch file from https://github.com/void-linux/void-packages/pull/25777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-ipfs-0.7.0_2-25777.patch --]
[-- Type: text/x-diff, Size: 2448 bytes --]
From 6504283f1c0c2c83f0f129b3094be36528cca283 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Wed, 21 Oct 2020 22:18:49 +0200
Subject: [PATCH 1/2] go-ipfs: add runit service.
---
srcpkgs/go-ipfs/files/ipfs/run | 4 ++++
srcpkgs/go-ipfs/template | 7 ++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
create mode 100755 srcpkgs/go-ipfs/files/ipfs/run
diff --git a/srcpkgs/go-ipfs/files/ipfs/run b/srcpkgs/go-ipfs/files/ipfs/run
new file mode 100755
index 00000000000..291e47879c0
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+export IPFS_PATH=${IPFS_PATH:=/var/lib/ipfs}
+exec chpst -u _ipfs ipfs daemon ${OPTS:=--init --enable-gc --migrate} 1>/dev/null
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index 96509787305..b03ead0e5ba 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -1,7 +1,7 @@
# Template file for 'go-ipfs'
pkgname=go-ipfs
version=0.7.0
-revision=1
+revision=2
build_style=go
go_import_path="github.com/ipfs/${pkgname}"
go_package="${go_import_path}/cmd/ipfs"
@@ -15,6 +15,10 @@ changelog="https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md"
distfiles="https://${go_import_path}/archive/v${version}.tar.gz"
checksum=152986ebb30657ab706bee708fbe929114f5e8c39fbe602e3bbec93fe74c9123
+system_accounts="_ipfs"
+make_dirs="/var/lib/ipfs 0700 _ipfs _ipfs"
+_ipfs_homedir="/var/lib/ipfs"
+
pre_build() {
if [ "$CROSS_BUILD" ]; then
export CGO_ENABLED=0
@@ -26,4 +30,5 @@ post_install() {
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
+ vsv ipfs
}
From d6d1fbea425a5fa3f0abc873ec3f4deb4ddd2fc9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Fri, 23 Oct 2020 00:35:14 +0200
Subject: [PATCH 2/2] go-ipfs: use vcompletion for completions
---
srcpkgs/go-ipfs/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index b03ead0e5ba..4f0a7e98403 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -26,7 +26,7 @@ pre_build() {
}
post_install() {
- vinstall misc/completion/ipfs-completion.bash 644 usr/share/bash-completion/completions ipfs
+ vcompletion misc/completion/ipfs-completion.bash bash ipfs
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (4 preceding siblings ...)
2020-10-22 23:37 ` [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion jcgruenhage
@ 2020-10-23 11:00 ` jcgruenhage
2020-10-23 11:10 ` [PR REVIEW] " Duncaen
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-23 11:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
There is an updated pull request by jcgruenhage against master on the void-packages repository
https://github.com/jcgruenhage/void-packages go-ipfs-0.7.0_2
https://github.com/void-linux/void-packages/pull/25777
go-ipfs: add runit service and use vcompletion
A patch file from https://github.com/void-linux/void-packages/pull/25777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-ipfs-0.7.0_2-25777.patch --]
[-- Type: text/x-diff, Size: 2207 bytes --]
From e2ed24a6ed16a8e575914b19bc5310758d161b8e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Wed, 21 Oct 2020 22:18:49 +0200
Subject: [PATCH] go-ipfs: add runit service and use vcompletion
---
srcpkgs/go-ipfs/files/ipfs/log/run | 2 ++
srcpkgs/go-ipfs/files/ipfs/run | 4 ++++
srcpkgs/go-ipfs/template | 9 +++++++--
3 files changed, 13 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/go-ipfs/files/ipfs/log/run
create mode 100755 srcpkgs/go-ipfs/files/ipfs/run
diff --git a/srcpkgs/go-ipfs/files/ipfs/log/run b/srcpkgs/go-ipfs/files/ipfs/log/run
new file mode 100644
index 00000000000..a402e8fae39
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t ipfs
diff --git a/srcpkgs/go-ipfs/files/ipfs/run b/srcpkgs/go-ipfs/files/ipfs/run
new file mode 100755
index 00000000000..29690e65659
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+export IPFS_PATH=${IPFS_PATH:=/var/lib/ipfs}
+exec chpst -u _ipfs ipfs daemon ${OPTS:=--init --enable-gc --migrate} 2>&1
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index 96509787305..4f0a7e98403 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -1,7 +1,7 @@
# Template file for 'go-ipfs'
pkgname=go-ipfs
version=0.7.0
-revision=1
+revision=2
build_style=go
go_import_path="github.com/ipfs/${pkgname}"
go_package="${go_import_path}/cmd/ipfs"
@@ -15,6 +15,10 @@ changelog="https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md"
distfiles="https://${go_import_path}/archive/v${version}.tar.gz"
checksum=152986ebb30657ab706bee708fbe929114f5e8c39fbe602e3bbec93fe74c9123
+system_accounts="_ipfs"
+make_dirs="/var/lib/ipfs 0700 _ipfs _ipfs"
+_ipfs_homedir="/var/lib/ipfs"
+
pre_build() {
if [ "$CROSS_BUILD" ]; then
export CGO_ENABLED=0
@@ -22,8 +26,9 @@ pre_build() {
}
post_install() {
- vinstall misc/completion/ipfs-completion.bash 644 usr/share/bash-completion/completions ipfs
+ vcompletion misc/completion/ipfs-completion.bash bash ipfs
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
+ vsv ipfs
}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (5 preceding siblings ...)
2020-10-23 11:00 ` jcgruenhage
@ 2020-10-23 11:10 ` Duncaen
2020-10-23 11:28 ` [PR PATCH] [Updated] " jcgruenhage
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2020-10-23 11:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r510809919
Comment:
the run file can be replaced with a link to `/usr/bin/vlogger`, vlogger will get the tag from the service name.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (6 preceding siblings ...)
2020-10-23 11:10 ` [PR REVIEW] " Duncaen
@ 2020-10-23 11:28 ` jcgruenhage
2020-10-23 11:28 ` [PR REVIEW] " jcgruenhage
2020-10-24 21:06 ` [PR PATCH] [Merged]: " Piraty
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-23 11:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
There is an updated pull request by jcgruenhage against master on the void-packages repository
https://github.com/jcgruenhage/void-packages go-ipfs-0.7.0_2
https://github.com/void-linux/void-packages/pull/25777
go-ipfs: add runit service and use vcompletion
A patch file from https://github.com/void-linux/void-packages/pull/25777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-ipfs-0.7.0_2-25777.patch --]
[-- Type: text/x-diff, Size: 2217 bytes --]
From f18c4586971674207337a8e02ffbf29d3dd46984 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
<jan.christian@gruenhage.xyz>
Date: Wed, 21 Oct 2020 22:18:49 +0200
Subject: [PATCH] go-ipfs: add runit service and use vcompletion
---
srcpkgs/go-ipfs/files/ipfs/log/run | 1 +
srcpkgs/go-ipfs/files/ipfs/run | 4 ++++
srcpkgs/go-ipfs/template | 9 +++++++--
3 files changed, 12 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/go-ipfs/files/ipfs/log/run
create mode 100755 srcpkgs/go-ipfs/files/ipfs/run
diff --git a/srcpkgs/go-ipfs/files/ipfs/log/run b/srcpkgs/go-ipfs/files/ipfs/log/run
new file mode 120000
index 00000000000..3a5b4a58605
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/go-ipfs/files/ipfs/run b/srcpkgs/go-ipfs/files/ipfs/run
new file mode 100755
index 00000000000..29690e65659
--- /dev/null
+++ b/srcpkgs/go-ipfs/files/ipfs/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+export IPFS_PATH=${IPFS_PATH:=/var/lib/ipfs}
+exec chpst -u _ipfs ipfs daemon ${OPTS:=--init --enable-gc --migrate} 2>&1
diff --git a/srcpkgs/go-ipfs/template b/srcpkgs/go-ipfs/template
index 96509787305..4f0a7e98403 100644
--- a/srcpkgs/go-ipfs/template
+++ b/srcpkgs/go-ipfs/template
@@ -1,7 +1,7 @@
# Template file for 'go-ipfs'
pkgname=go-ipfs
version=0.7.0
-revision=1
+revision=2
build_style=go
go_import_path="github.com/ipfs/${pkgname}"
go_package="${go_import_path}/cmd/ipfs"
@@ -15,6 +15,10 @@ changelog="https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md"
distfiles="https://${go_import_path}/archive/v${version}.tar.gz"
checksum=152986ebb30657ab706bee708fbe929114f5e8c39fbe602e3bbec93fe74c9123
+system_accounts="_ipfs"
+make_dirs="/var/lib/ipfs 0700 _ipfs _ipfs"
+_ipfs_homedir="/var/lib/ipfs"
+
pre_build() {
if [ "$CROSS_BUILD" ]; then
export CGO_ENABLED=0
@@ -22,8 +26,9 @@ pre_build() {
}
post_install() {
- vinstall misc/completion/ipfs-completion.bash 644 usr/share/bash-completion/completions ipfs
+ vcompletion misc/completion/ipfs-completion.bash bash ipfs
vlicense LICENSE-MIT
vdoc README.md
vdoc CHANGELOG.md
+ vsv ipfs
}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (7 preceding siblings ...)
2020-10-23 11:28 ` [PR PATCH] [Updated] " jcgruenhage
@ 2020-10-23 11:28 ` jcgruenhage
2020-10-24 21:06 ` [PR PATCH] [Merged]: " Piraty
9 siblings, 0 replies; 11+ messages in thread
From: jcgruenhage @ 2020-10-23 11:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r510818340
Comment:
Done
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: go-ipfs: add runit service and use vcompletion
2020-10-21 20:20 [PR PATCH] go-ipfs: add runit service jcgruenhage
` (8 preceding siblings ...)
2020-10-23 11:28 ` [PR REVIEW] " jcgruenhage
@ 2020-10-24 21:06 ` Piraty
9 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-10-24 21:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
There's a merged pull request on the void-packages repository
go-ipfs: add runit service and use vcompletion
https://github.com/void-linux/void-packages/pull/25777
Description:
^ permalink raw reply [flat|nested] 11+ messages in thread