* [PR PATCH] verilator: create package
@ 2020-10-30 5:50 save-buffer
2020-10-30 11:59 ` ericonr
` (20 more replies)
0 siblings, 21 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 5:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
There is a new pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux. Verilator needs autoconf to be built, so I added autoconf as a build style.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 2410 bytes --]
From ad97c00f6e0ff9648075945f1405e37d77b075d1 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH] verilator: create package
---
common/build-style/autoconf.sh | 40 ++++++++++++++++++++++
common/environment/build-style/autoconf.sh | 1 +
srcpkgs/verilator/template | 12 +++++++
3 files changed, 53 insertions(+)
create mode 100644 common/build-style/autoconf.sh
create mode 100644 common/environment/build-style/autoconf.sh
create mode 100644 srcpkgs/verilator/template
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
new file mode 100644
index 00000000000..8bb4a2f5a9a
--- /dev/null
+++ b/common/build-style/autoconf.sh
@@ -0,0 +1,40 @@
+#
+# THis helper is for templates using autoconf.
+#
+do_configure() {
+ autoconf
+ ./configure ${configure_args} --prefix /usr
+}
+
+do_build() {
+ : ${make_cmd:=make}
+
+ ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
+}
+
+do_check() {
+ if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
+ if make -q check 2>/dev/null; then
+ :
+ else
+ if [ $? -eq 2 ]; then
+ msg_warn 'No target to "make check".\n'
+ return 0
+ fi
+ fi
+ fi
+
+ : ${make_cmd:=make}
+ : ${make_check_target:=check}
+
+ ${make_cmd} ${make_check_args} ${make_check_target}
+}
+
+do_install() {
+ : ${make_cmd:=make}
+ : ${make_install_target:=install}
+
+ ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+}
+
+
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
new file mode 100644
index 00000000000..881f67e0e1f
--- /dev/null
+++ b/common/environment/build-style/autoconf.sh
@@ -0,0 +1 @@
+hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..1d527973075
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,12 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=autoconf
+makedepends="flex"
+short_desc="C++ Library for RTL emulation"
+maintainer="krassovskysasha@gmail.com"
+license="GPL-3.0"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
@ 2020-10-30 11:59 ` ericonr
2020-10-30 18:35 ` [PR PATCH] [Updated] " save-buffer
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-10-30 11:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#issuecomment-719511906
Comment:
I believe it's preferrable to add a `pre_configure` step that runs `autoconf` (or `autoreconf`, which is more common) than a whole new build style.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
2020-10-30 11:59 ` ericonr
@ 2020-10-30 18:35 ` save-buffer
2020-10-30 18:36 ` save-buffer
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 18:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux. Verilator needs autoconf to be built, so I added autoconf as a build style.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 4954 bytes --]
From ad97c00f6e0ff9648075945f1405e37d77b075d1 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH 1/2] verilator: create package
---
common/build-style/autoconf.sh | 40 ++++++++++++++++++++++
common/environment/build-style/autoconf.sh | 1 +
srcpkgs/verilator/template | 12 +++++++
3 files changed, 53 insertions(+)
create mode 100644 common/build-style/autoconf.sh
create mode 100644 common/environment/build-style/autoconf.sh
create mode 100644 srcpkgs/verilator/template
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
new file mode 100644
index 00000000000..8bb4a2f5a9a
--- /dev/null
+++ b/common/build-style/autoconf.sh
@@ -0,0 +1,40 @@
+#
+# THis helper is for templates using autoconf.
+#
+do_configure() {
+ autoconf
+ ./configure ${configure_args} --prefix /usr
+}
+
+do_build() {
+ : ${make_cmd:=make}
+
+ ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
+}
+
+do_check() {
+ if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
+ if make -q check 2>/dev/null; then
+ :
+ else
+ if [ $? -eq 2 ]; then
+ msg_warn 'No target to "make check".\n'
+ return 0
+ fi
+ fi
+ fi
+
+ : ${make_cmd:=make}
+ : ${make_check_target:=check}
+
+ ${make_cmd} ${make_check_args} ${make_check_target}
+}
+
+do_install() {
+ : ${make_cmd:=make}
+ : ${make_install_target:=install}
+
+ ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+}
+
+
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
new file mode 100644
index 00000000000..881f67e0e1f
--- /dev/null
+++ b/common/environment/build-style/autoconf.sh
@@ -0,0 +1 @@
+hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..1d527973075
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,12 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=autoconf
+makedepends="flex"
+short_desc="C++ Library for RTL emulation"
+maintainer="krassovskysasha@gmail.com"
+license="GPL-3.0"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
From a0823f8a3e8678539dba9a00502a8d7b0efdf7b5 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Fri, 30 Oct 2020 11:35:12 -0700
Subject: [PATCH 2/2] Change autoconf to pre_configure
---
common/build-style/autoconf.sh | 40 ----------------------
common/environment/build-style/autoconf.sh | 1 -
srcpkgs/verilator/template | 8 ++++-
3 files changed, 7 insertions(+), 42 deletions(-)
delete mode 100644 common/build-style/autoconf.sh
delete mode 100644 common/environment/build-style/autoconf.sh
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
deleted file mode 100644
index 8bb4a2f5a9a..00000000000
--- a/common/build-style/autoconf.sh
+++ /dev/null
@@ -1,40 +0,0 @@
-#
-# THis helper is for templates using autoconf.
-#
-do_configure() {
- autoconf
- ./configure ${configure_args} --prefix /usr
-}
-
-do_build() {
- : ${make_cmd:=make}
-
- ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
-}
-
-do_check() {
- if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
- if make -q check 2>/dev/null; then
- :
- else
- if [ $? -eq 2 ]; then
- msg_warn 'No target to "make check".\n'
- return 0
- fi
- fi
- fi
-
- : ${make_cmd:=make}
- : ${make_check_target:=check}
-
- ${make_cmd} ${make_check_args} ${make_check_target}
-}
-
-do_install() {
- : ${make_cmd:=make}
- : ${make_install_target:=install}
-
- ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
-}
-
-
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
deleted file mode 100644
index 881f67e0e1f..00000000000
--- a/common/environment/build-style/autoconf.sh
+++ /dev/null
@@ -1 +0,0 @@
-hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
index 1d527973075..89a29766ba6 100644
--- a/srcpkgs/verilator/template
+++ b/srcpkgs/verilator/template
@@ -2,7 +2,9 @@
pkgname=verilator
version=4.102
revision=1
-build_style=autoconf
+build_style=configure
+configure_args="--prefix /usr"
+hostmakedepends="autoconf"
makedepends="flex"
short_desc="C++ Library for RTL emulation"
maintainer="krassovskysasha@gmail.com"
@@ -10,3 +12,7 @@ license="GPL-3.0"
homepage="https://veripool.org/wiki/verilator"
distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
\ No newline at end of file
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
2020-10-30 11:59 ` ericonr
2020-10-30 18:35 ` [PR PATCH] [Updated] " save-buffer
@ 2020-10-30 18:36 ` save-buffer
2020-10-30 18:37 ` save-buffer
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 18:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux. Verilator needs autoconf to be built, so I added autoconf as a build style.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 4954 bytes --]
From cd49c186e560ca1308f2f9df11ddd14a8e032b69 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH 1/2] verilator: create package
---
common/build-style/autoconf.sh | 40 ++++++++++++++++++++++
common/environment/build-style/autoconf.sh | 1 +
srcpkgs/verilator/template | 12 +++++++
3 files changed, 53 insertions(+)
create mode 100644 common/build-style/autoconf.sh
create mode 100644 common/environment/build-style/autoconf.sh
create mode 100644 srcpkgs/verilator/template
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
new file mode 100644
index 00000000000..8bb4a2f5a9a
--- /dev/null
+++ b/common/build-style/autoconf.sh
@@ -0,0 +1,40 @@
+#
+# THis helper is for templates using autoconf.
+#
+do_configure() {
+ autoconf
+ ./configure ${configure_args} --prefix /usr
+}
+
+do_build() {
+ : ${make_cmd:=make}
+
+ ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
+}
+
+do_check() {
+ if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
+ if make -q check 2>/dev/null; then
+ :
+ else
+ if [ $? -eq 2 ]; then
+ msg_warn 'No target to "make check".\n'
+ return 0
+ fi
+ fi
+ fi
+
+ : ${make_cmd:=make}
+ : ${make_check_target:=check}
+
+ ${make_cmd} ${make_check_args} ${make_check_target}
+}
+
+do_install() {
+ : ${make_cmd:=make}
+ : ${make_install_target:=install}
+
+ ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+}
+
+
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
new file mode 100644
index 00000000000..881f67e0e1f
--- /dev/null
+++ b/common/environment/build-style/autoconf.sh
@@ -0,0 +1 @@
+hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..1d527973075
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,12 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=autoconf
+makedepends="flex"
+short_desc="C++ Library for RTL emulation"
+maintainer="krassovskysasha@gmail.com"
+license="GPL-3.0"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
From a38723d78c65948f43fb9a81057544829abf48e3 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Fri, 30 Oct 2020 11:35:12 -0700
Subject: [PATCH 2/2] Change autoconf to pre_configure
---
common/build-style/autoconf.sh | 40 ----------------------
common/environment/build-style/autoconf.sh | 1 -
srcpkgs/verilator/template | 8 ++++-
3 files changed, 7 insertions(+), 42 deletions(-)
delete mode 100644 common/build-style/autoconf.sh
delete mode 100644 common/environment/build-style/autoconf.sh
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
deleted file mode 100644
index 8bb4a2f5a9a..00000000000
--- a/common/build-style/autoconf.sh
+++ /dev/null
@@ -1,40 +0,0 @@
-#
-# THis helper is for templates using autoconf.
-#
-do_configure() {
- autoconf
- ./configure ${configure_args} --prefix /usr
-}
-
-do_build() {
- : ${make_cmd:=make}
-
- ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
-}
-
-do_check() {
- if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
- if make -q check 2>/dev/null; then
- :
- else
- if [ $? -eq 2 ]; then
- msg_warn 'No target to "make check".\n'
- return 0
- fi
- fi
- fi
-
- : ${make_cmd:=make}
- : ${make_check_target:=check}
-
- ${make_cmd} ${make_check_args} ${make_check_target}
-}
-
-do_install() {
- : ${make_cmd:=make}
- : ${make_install_target:=install}
-
- ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
-}
-
-
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
deleted file mode 100644
index 881f67e0e1f..00000000000
--- a/common/environment/build-style/autoconf.sh
+++ /dev/null
@@ -1 +0,0 @@
-hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
index 1d527973075..89a29766ba6 100644
--- a/srcpkgs/verilator/template
+++ b/srcpkgs/verilator/template
@@ -2,7 +2,9 @@
pkgname=verilator
version=4.102
revision=1
-build_style=autoconf
+build_style=configure
+configure_args="--prefix /usr"
+hostmakedepends="autoconf"
makedepends="flex"
short_desc="C++ Library for RTL emulation"
maintainer="krassovskysasha@gmail.com"
@@ -10,3 +12,7 @@ license="GPL-3.0"
homepage="https://veripool.org/wiki/verilator"
distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
\ No newline at end of file
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (2 preceding siblings ...)
2020-10-30 18:36 ` save-buffer
@ 2020-10-30 18:37 ` save-buffer
2020-10-30 18:37 ` save-buffer
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 18:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux. Verilator needs autoconf to be built, so I added autoconf as a build style.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 4926 bytes --]
From cd49c186e560ca1308f2f9df11ddd14a8e032b69 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH 1/2] verilator: create package
---
common/build-style/autoconf.sh | 40 ++++++++++++++++++++++
common/environment/build-style/autoconf.sh | 1 +
srcpkgs/verilator/template | 12 +++++++
3 files changed, 53 insertions(+)
create mode 100644 common/build-style/autoconf.sh
create mode 100644 common/environment/build-style/autoconf.sh
create mode 100644 srcpkgs/verilator/template
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
new file mode 100644
index 00000000000..8bb4a2f5a9a
--- /dev/null
+++ b/common/build-style/autoconf.sh
@@ -0,0 +1,40 @@
+#
+# THis helper is for templates using autoconf.
+#
+do_configure() {
+ autoconf
+ ./configure ${configure_args} --prefix /usr
+}
+
+do_build() {
+ : ${make_cmd:=make}
+
+ ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
+}
+
+do_check() {
+ if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
+ if make -q check 2>/dev/null; then
+ :
+ else
+ if [ $? -eq 2 ]; then
+ msg_warn 'No target to "make check".\n'
+ return 0
+ fi
+ fi
+ fi
+
+ : ${make_cmd:=make}
+ : ${make_check_target:=check}
+
+ ${make_cmd} ${make_check_args} ${make_check_target}
+}
+
+do_install() {
+ : ${make_cmd:=make}
+ : ${make_install_target:=install}
+
+ ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+}
+
+
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
new file mode 100644
index 00000000000..881f67e0e1f
--- /dev/null
+++ b/common/environment/build-style/autoconf.sh
@@ -0,0 +1 @@
+hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..1d527973075
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,12 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=autoconf
+makedepends="flex"
+short_desc="C++ Library for RTL emulation"
+maintainer="krassovskysasha@gmail.com"
+license="GPL-3.0"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
From a4e08fce24202f12b40317ece005d81f61654e16 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Fri, 30 Oct 2020 11:35:12 -0700
Subject: [PATCH 2/2] Change autoconf to pre_configure
---
common/build-style/autoconf.sh | 40 ----------------------
common/environment/build-style/autoconf.sh | 1 -
srcpkgs/verilator/template | 8 ++++-
3 files changed, 7 insertions(+), 42 deletions(-)
delete mode 100644 common/build-style/autoconf.sh
delete mode 100644 common/environment/build-style/autoconf.sh
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
deleted file mode 100644
index 8bb4a2f5a9a..00000000000
--- a/common/build-style/autoconf.sh
+++ /dev/null
@@ -1,40 +0,0 @@
-#
-# THis helper is for templates using autoconf.
-#
-do_configure() {
- autoconf
- ./configure ${configure_args} --prefix /usr
-}
-
-do_build() {
- : ${make_cmd:=make}
-
- ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
-}
-
-do_check() {
- if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
- if make -q check 2>/dev/null; then
- :
- else
- if [ $? -eq 2 ]; then
- msg_warn 'No target to "make check".\n'
- return 0
- fi
- fi
- fi
-
- : ${make_cmd:=make}
- : ${make_check_target:=check}
-
- ${make_cmd} ${make_check_args} ${make_check_target}
-}
-
-do_install() {
- : ${make_cmd:=make}
- : ${make_install_target:=install}
-
- ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
-}
-
-
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
deleted file mode 100644
index 881f67e0e1f..00000000000
--- a/common/environment/build-style/autoconf.sh
+++ /dev/null
@@ -1 +0,0 @@
-hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
index 1d527973075..fac09e70359 100644
--- a/srcpkgs/verilator/template
+++ b/srcpkgs/verilator/template
@@ -2,7 +2,9 @@
pkgname=verilator
version=4.102
revision=1
-build_style=autoconf
+build_style=configure
+configure_args="--prefix /usr"
+hostmakedepends="autoconf"
makedepends="flex"
short_desc="C++ Library for RTL emulation"
maintainer="krassovskysasha@gmail.com"
@@ -10,3 +12,7 @@ license="GPL-3.0"
homepage="https://veripool.org/wiki/verilator"
distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (3 preceding siblings ...)
2020-10-30 18:37 ` save-buffer
@ 2020-10-30 18:37 ` save-buffer
2020-10-30 18:39 ` save-buffer
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 18:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
New comment by save-buffer on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#issuecomment-719728371
Comment:
> I believe it's preferrable to add a `pre_configure` step that runs `autoconf` (or `autoreconf`, which is more common) than a whole new build style.
Oh thanks for telling me! I've updated the PR.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (4 preceding siblings ...)
2020-10-30 18:37 ` save-buffer
@ 2020-10-30 18:39 ` save-buffer
2020-10-30 19:12 ` abenson
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 18:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
New comment by save-buffer on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#issuecomment-719729372
Comment:
Also one question I had about the maintainer field: is this the maintainer of the package template or the actual package? I have no relation to verilator personally, I just needed it and thought I'd contribute my template.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (5 preceding siblings ...)
2020-10-30 18:39 ` save-buffer
@ 2020-10-30 19:12 ` abenson
2020-10-30 19:14 ` [PR REVIEW] " abenson
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
New comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#issuecomment-719745324
Comment:
1. [Squash](https://levelup.gitconnected.com/how-to-squash-git-commits-9a095c1bc1fc) these to a single commit
2. Edit the commit message to follow convention, should be "New package: verilator-4.102"
> is this the maintainer of the package template or the actual package?
The maintainer of the template.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (6 preceding siblings ...)
2020-10-30 19:12 ` abenson
@ 2020-10-30 19:14 ` abenson
2020-10-30 19:14 ` abenson
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515322101
Comment:
This should be gnu-configure
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (7 preceding siblings ...)
2020-10-30 19:14 ` [PR REVIEW] " abenson
@ 2020-10-30 19:14 ` abenson
2020-10-30 19:15 ` abenson
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515322170
Comment:
This can be dropped
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (8 preceding siblings ...)
2020-10-30 19:14 ` abenson
@ 2020-10-30 19:15 ` abenson
2020-10-30 19:16 ` abenson
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515322351
Comment:
flex should be in hostmakedepends
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (9 preceding siblings ...)
2020-10-30 19:15 ` abenson
@ 2020-10-30 19:16 ` abenson
2020-10-30 19:17 ` abenson
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515322608
Comment:
Should be LGPL-3.0-only
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (10 preceding siblings ...)
2020-10-30 19:16 ` abenson
@ 2020-10-30 19:17 ` abenson
2020-10-30 19:17 ` abenson
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515323033
Comment:
Why not use verilator's official description, "SystemVerilog simulator and lint system"
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (11 preceding siblings ...)
2020-10-30 19:17 ` abenson
@ 2020-10-30 19:17 ` abenson
2020-10-30 19:22 ` [PR PATCH] [Updated] " save-buffer
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 19:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515323357
Comment:
Please use "Name <email>" format
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (12 preceding siblings ...)
2020-10-30 19:17 ` abenson
@ 2020-10-30 19:22 ` save-buffer
2020-10-30 20:42 ` [PR REVIEW] " abenson
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 19:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 1041 bytes --]
From 05b25af7c73fb950df859e21257e2af7dc85312c Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH] New package: verilator-4.102
---
srcpkgs/verilator/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/verilator/template
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..693faeecb56
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,16 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf flex"
+short_desc="SystemVerilog simulator and lint system"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="LGPL-3.0-only"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (13 preceding siblings ...)
2020-10-30 19:22 ` [PR PATCH] [Updated] " save-buffer
@ 2020-10-30 20:42 ` abenson
2020-10-30 20:42 ` abenson
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515371625
Comment:
`# Template file for 'verilator'`
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (14 preceding siblings ...)
2020-10-30 20:42 ` [PR REVIEW] " abenson
@ 2020-10-30 20:42 ` abenson
2020-10-30 21:08 ` [PR PATCH] [Updated] " save-buffer
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515372096
Comment:
Use tabs.
A good idea is to run `xlint` on the template.
```
% xlint srcpkgs/verilator/template
srcpkgs/verilator/template:1: Header should be: # Template file for 'verilator'
srcpkgs/verilator/template:15: indent with tabs
```
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (15 preceding siblings ...)
2020-10-30 20:42 ` abenson
@ 2020-10-30 21:08 ` save-buffer
2020-10-30 21:12 ` [PR REVIEW] " abenson
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 21:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 1044 bytes --]
From 11ca5af4ffc26a65f6fa3b15b29a45550dd050fd Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH] New package: verilator-4.102
---
srcpkgs/verilator/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/verilator/template
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..64bdfcf7426
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,16 @@
+# Template file for 'verilator'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf flex"
+short_desc="SystemVerilog simulator and lint system"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="LGPL-3.0-only"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (16 preceding siblings ...)
2020-10-30 21:08 ` [PR PATCH] [Updated] " save-buffer
@ 2020-10-30 21:12 ` abenson
2020-10-30 21:20 ` [PR PATCH] [Updated] " save-buffer
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2020-10-30 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#discussion_r515385131
Comment:
I needed to add `libfl-devel` to `makedepends`
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (17 preceding siblings ...)
2020-10-30 21:12 ` [PR REVIEW] " abenson
@ 2020-10-30 21:20 ` save-buffer
2020-10-30 23:22 ` jnbr
2020-10-30 23:22 ` [PR PATCH] [Merged]: " jnbr
20 siblings, 0 replies; 22+ messages in thread
From: save-buffer @ 2020-10-30 21:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 1072 bytes --]
From 181fbad64a45a148b0e096605e5bd7a3c629998e Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH] New package: verilator-4.102
---
srcpkgs/verilator/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/verilator/template
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..74b448a5519
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,17 @@
+# Template file for 'verilator'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf flex"
+makedepends="libfl-devel"
+short_desc="SystemVerilog simulator and lint system"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="LGPL-3.0-only"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (18 preceding siblings ...)
2020-10-30 21:20 ` [PR PATCH] [Updated] " save-buffer
@ 2020-10-30 23:22 ` jnbr
2020-10-30 23:22 ` [PR PATCH] [Merged]: " jnbr
20 siblings, 0 replies; 22+ messages in thread
From: jnbr @ 2020-10-30 23:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25979#issuecomment-719841862
Comment:
Tested locally, builds for all targets and xlint passes.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Merged]: verilator: create package
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
` (19 preceding siblings ...)
2020-10-30 23:22 ` jnbr
@ 2020-10-30 23:22 ` jnbr
20 siblings, 0 replies; 22+ messages in thread
From: jnbr @ 2020-10-30 23:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
There's a merged pull request on the void-packages repository
verilator: create package
https://github.com/void-linux/void-packages/pull/25979
Description:
Creates verilator package for void linux.
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2020-10-30 23:22 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 5:50 [PR PATCH] verilator: create package save-buffer
2020-10-30 11:59 ` ericonr
2020-10-30 18:35 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 18:36 ` save-buffer
2020-10-30 18:37 ` save-buffer
2020-10-30 18:37 ` save-buffer
2020-10-30 18:39 ` save-buffer
2020-10-30 19:12 ` abenson
2020-10-30 19:14 ` [PR REVIEW] " abenson
2020-10-30 19:14 ` abenson
2020-10-30 19:15 ` abenson
2020-10-30 19:16 ` abenson
2020-10-30 19:17 ` abenson
2020-10-30 19:17 ` abenson
2020-10-30 19:22 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 20:42 ` [PR REVIEW] " abenson
2020-10-30 20:42 ` abenson
2020-10-30 21:08 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 21:12 ` [PR REVIEW] " abenson
2020-10-30 21:20 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 23:22 ` jnbr
2020-10-30 23:22 ` [PR PATCH] [Merged]: " jnbr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).