* [PR PATCH] New package: fcitx-m17n-0.2.4
@ 2020-11-11 14:47 sham1
2020-11-11 15:12 ` [PR REVIEW] " ericonr
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: sham1 @ 2020-11-11 14:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
There is a new pull request by sham1 against master on the void-packages repository
https://github.com/sham1/void-packages fcitx-m17n
https://github.com/void-linux/void-packages/pull/26289
New package: fcitx-m17n-0.2.4
A patch file from https://github.com/void-linux/void-packages/pull/26289.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fcitx-m17n-26289.patch --]
[-- Type: text/x-diff, Size: 1031 bytes --]
From 6e207e09fd0ad651c2cd5f7e911122e3df47974e Mon Sep 17 00:00:00 2001
From: Jani Juhani Sinervo <jani@sinervo.fi>
Date: Wed, 11 Nov 2020 16:43:43 +0200
Subject: [PATCH] New package: fcitx-m17n-0.2.4
---
srcpkgs/fcitx-m17n/template | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 srcpkgs/fcitx-m17n/template
diff --git a/srcpkgs/fcitx-m17n/template b/srcpkgs/fcitx-m17n/template
new file mode 100644
index 00000000000..9e9edada8c4
--- /dev/null
+++ b/srcpkgs/fcitx-m17n/template
@@ -0,0 +1,14 @@
+# Template file for 'fcitx-m17n'
+pkgname=fcitx-m17n
+version=0.2.4
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="m17n-lib-devel fcitx-devel"
+depends="fcitx m17n-db"
+short_desc="Fcitx wrapper for M17n engine"
+maintainer="Jani Juhani Sinervo <jani@sinervo.fi>"
+license="LGPL-2.1-or-later"
+homepage="https://fcitx-im.org/"
+distfiles="https://github.com/fcitx/fcitx-m17n/archive/${version}.tar.gz"
+checksum=1cbb2768929767b2d0741892953d54155c26d72256987fe13c9a898d9ee06dab
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
@ 2020-11-11 15:12 ` ericonr
2020-11-11 17:34 ` sham1
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-11 15:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r521426274
Comment:
Does it need to depend on these?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
2020-11-11 15:12 ` [PR REVIEW] " ericonr
@ 2020-11-11 17:34 ` sham1
2020-11-11 17:55 ` ericonr
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sham1 @ 2020-11-11 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
New review comment by sham1 on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r521523657
Comment:
Well the dependency on `m17n-db` is there since M17n is not very useful if one doesn't also have the database, so might as well depend on it since the user would probably install it anyway. Besides, similar thing is done by `ibus-m17n` so it seemed like a good idea.
As for depending on `fcitx` explicitly, other packages that also add these sorts of IM engines to it also tend to do that, so that's what I'm basing it upon.
Should I remove those dependencies?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
2020-11-11 15:12 ` [PR REVIEW] " ericonr
2020-11-11 17:34 ` sham1
@ 2020-11-11 17:55 ` ericonr
2020-11-11 18:17 ` sham1
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-11 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r521538262
Comment:
I don't think so, I was just checking! Those sound like good justifications for it.
That said, any easy way to test this? Just install and launch?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
` (2 preceding siblings ...)
2020-11-11 17:55 ` ericonr
@ 2020-11-11 18:17 ` sham1
2020-11-15 17:11 ` sgn
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sham1 @ 2020-11-11 18:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
New review comment by sham1 on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r521550481
Comment:
Yeah, testing shouldn't be too hard, assuming one already has fcitx set up on their computer. Just install and reload the daemon.
If one doesn't use fcitx, the way one would have to ensure that various applications use the proper input method would be to set the following environment flags as follows:
```sh
export GTK_IM_MODULE=fcitx
export QT_IM_MODULE=fcitx
export XMODIFIERS=@im=fcitx
```
After this, one could launch the daemon and an application to verify that this works.
At least on my (somewhat limited) testing it seems to work like it's supposed to.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
` (3 preceding siblings ...)
2020-11-11 18:17 ` sham1
@ 2020-11-15 17:11 ` sgn
2020-11-15 17:22 ` sgn
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-11-15 17:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r523785964
Comment:
The dependency is correct. Normally, I work with all fcitx package, hopefully, I can find some time to experience with this one, soon.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
` (4 preceding siblings ...)
2020-11-15 17:11 ` sgn
@ 2020-11-15 17:22 ` sgn
2020-11-15 21:04 ` [PR PATCH] [Updated] " sham1
2020-11-16 1:12 ` [PR PATCH] [Closed]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-11-15 17:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#issuecomment-727605158
Comment:
```diff
diff --git a/srcpkgs/fcitx-m17n/template b/srcpkgs/fcitx-m17n/template
index 9e9edada8c..463e90a9b6 100644
--- a/srcpkgs/fcitx-m17n/template
+++ b/srcpkgs/fcitx-m17n/template
@@ -3,7 +3,7 @@ pkgname=fcitx-m17n
version=0.2.4
revision=1
build_style=cmake
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config libfcitx"
makedepends="m17n-lib-devel fcitx-devel"
depends="fcitx m17n-db"
short_desc="Fcitx wrapper for M17n engine"
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
` (5 preceding siblings ...)
2020-11-15 17:22 ` sgn
@ 2020-11-15 21:04 ` sham1
2020-11-16 1:12 ` [PR PATCH] [Closed]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: sham1 @ 2020-11-15 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
There is an updated pull request by sham1 against master on the void-packages repository
https://github.com/sham1/void-packages fcitx-m17n
https://github.com/void-linux/void-packages/pull/26289
New package: fcitx-m17n-0.2.4
A patch file from https://github.com/void-linux/void-packages/pull/26289.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fcitx-m17n-26289.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]
From 7abd6809e979e1ed46e1845101f95136fe45a0d6 Mon Sep 17 00:00:00 2001
From: Jani Juhani Sinervo <jani@sinervo.fi>
Date: Wed, 11 Nov 2020 16:43:43 +0200
Subject: [PATCH] New package: fcitx-m17n-0.2.4
---
srcpkgs/fcitx-m17n/template | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 srcpkgs/fcitx-m17n/template
diff --git a/srcpkgs/fcitx-m17n/template b/srcpkgs/fcitx-m17n/template
new file mode 100644
index 00000000000..463e90a9b68
--- /dev/null
+++ b/srcpkgs/fcitx-m17n/template
@@ -0,0 +1,14 @@
+# Template file for 'fcitx-m17n'
+pkgname=fcitx-m17n
+version=0.2.4
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config libfcitx"
+makedepends="m17n-lib-devel fcitx-devel"
+depends="fcitx m17n-db"
+short_desc="Fcitx wrapper for M17n engine"
+maintainer="Jani Juhani Sinervo <jani@sinervo.fi>"
+license="LGPL-2.1-or-later"
+homepage="https://fcitx-im.org/"
+distfiles="https://github.com/fcitx/fcitx-m17n/archive/${version}.tar.gz"
+checksum=1cbb2768929767b2d0741892953d54155c26d72256987fe13c9a898d9ee06dab
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Closed]: New package: fcitx-m17n-0.2.4
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
` (6 preceding siblings ...)
2020-11-15 21:04 ` [PR PATCH] [Updated] " sham1
@ 2020-11-16 1:12 ` sgn
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-11-16 1:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
There's a closed pull request on the void-packages repository
New package: fcitx-m17n-0.2.4
https://github.com/void-linux/void-packages/pull/26289
Description:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-11-16 1:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 14:47 [PR PATCH] New package: fcitx-m17n-0.2.4 sham1
2020-11-11 15:12 ` [PR REVIEW] " ericonr
2020-11-11 17:34 ` sham1
2020-11-11 17:55 ` ericonr
2020-11-11 18:17 ` sham1
2020-11-15 17:11 ` sgn
2020-11-15 17:22 ` sgn
2020-11-15 21:04 ` [PR PATCH] [Updated] " sham1
2020-11-16 1:12 ` [PR PATCH] [Closed]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).