[PR PATCH] mumble: fix plugin path

[PR PATCH] mumble: fix plugin path

[krkk]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

There is a new pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages fix-mumble-plugin
https://github.com/void-linux/void-packages/pull/27065

mumble: fix plugin path
https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220

Mumble was searching plugins in `/usr/bin/plugins/` because `MumbleApplication::applicationVersionRootPath()`(basically the `QCoreApplication::applicationDirPath()`) returns the path of the application executable.

A patch file from https://github.com/void-linux/void-packages/pull/27065.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-mumble-plugin-27065.patch --]
[-- Type: text/x-diff, Size: 1124 bytes --]

From c1a4061d557a6ee645613471c02191d504b5199c Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 10 Dec 2020 08:46:00 +0100
Subject: [PATCH] mumble: fix plugin path

---
 srcpkgs/mumble/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index 981e3ab8f06..ad50b5ae954 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -1,12 +1,12 @@
 # Template file for 'mumble'
 pkgname=mumble
 version=1.3.3
-revision=2
+revision=3
 build_style=qmake
 configure_args="CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-update
  CONFIG+=no-bundled-speex CONFIG+=no-g15 CONFIG+=no-xevie CONFIG+=pulseaudio
  $(vopt_if jack CONFIG+=jackaudio) CONFIG+=no-embed-qt-translations
- CONFIG+=no-oss CONFIG+=portaudio"
+ CONFIG+=no-oss CONFIG+=portaudio DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
 hostmakedepends="Ice pkg-config protobuf qt5-host-tools qt5-qmake python3 which"
 makedepends="Ice-devel MesaLib-devel avahi-compat-libs-devel boost-devel
  libcap-devel libressl-devel libsndfile-devel opus-devel protobuf-devel

Re: mumble: fix plugin path

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27065#issuecomment-742521884

Comment:
Could you include the information from the PR comment into the commit body? Otherwise looks good to me.

Re: [PR PATCH] [Updated] mumble: fix plugin path

[krkk]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

There is an updated pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages fix-mumble-plugin
https://github.com/void-linux/void-packages/pull/27065

mumble: fix plugin path
https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220

Mumble was searching plugins in `/usr/bin/plugins/` because `MumbleApplication::applicationVersionRootPath()`(basically the `QCoreApplication::applicationDirPath()`) returns the path of the application executable.

A patch file from https://github.com/void-linux/void-packages/pull/27065.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-mumble-plugin-27065.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]

From a818e000817fd8ea922ee59ffa3bd709fc9768ba Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 10 Dec 2020 08:46:00 +0100
Subject: [PATCH] mumble: fix plugin path

Mumble was searching plugins in /usr/bin/plugins/
because MumbleApplication::applicationVersionRootPath()
(basically the QCoreApplication::applicationDirPath()) returns the path
of the application executable.

https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220
---
 srcpkgs/mumble/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index 981e3ab8f06..ad50b5ae954 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -1,12 +1,12 @@
 # Template file for 'mumble'
 pkgname=mumble
 version=1.3.3
-revision=2
+revision=3
 build_style=qmake
 configure_args="CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-update
  CONFIG+=no-bundled-speex CONFIG+=no-g15 CONFIG+=no-xevie CONFIG+=pulseaudio
  $(vopt_if jack CONFIG+=jackaudio) CONFIG+=no-embed-qt-translations
- CONFIG+=no-oss CONFIG+=portaudio"
+ CONFIG+=no-oss CONFIG+=portaudio DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
 hostmakedepends="Ice pkg-config protobuf qt5-host-tools qt5-qmake python3 which"
 makedepends="Ice-devel MesaLib-devel avahi-compat-libs-devel boost-devel
  libcap-devel libressl-devel libsndfile-devel opus-devel protobuf-devel

Re: mumble: fix plugin path

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27065#issuecomment-742950476

Comment:
@krkk please ping me when done with changes :) 

Re: [PR PATCH] [Merged]: mumble: fix plugin path

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

There's a merged pull request on the void-packages repository

mumble: fix plugin path
https://github.com/void-linux/void-packages/pull/27065

Description:
https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220

Mumble was searching plugins in `/usr/bin/plugins/` because `MumbleApplication::applicationVersionRootPath()`(basically the `QCoreApplication::applicationDirPath()`) returns the path of the application executable.