Re: [PR PATCH] [Updated] pam-base: update to 0.4, adopt.

Re: [PR PATCH] [Updated] pam-base: update to 0.4, adopt.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pam-base
https://github.com/void-linux/void-packages/pull/26707

pam-base: update to 0.4, adopt.
Remove pam_tally from system-login. The pam_tally module is deprecated
as of PAM 1.4.0 and was removed on PAM 1.5.0.

Make pam_lastlog optional, since it's no longer built on musl.

Fix license name.

Necessary for #25506 , still up for discussion. It might make sense to ship the INSTALL.msg from #25506 here as well, or a similar one.

@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/26707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-base-26707.patch --]
[-- Type: text/x-diff, Size: 2590 bytes --]

From ddc6969cc84c81866391660b68a09435d09b2d95 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 25 Nov 2020 18:28:06 -0300
Subject: [PATCH] pam-base: update to 0.4, adopt.

Remove pam_tally from system-login. The pam_tally module is deprecated
as of PAM 1.4.0 and was removed on PAM 1.5.0.

Remove pam_lastlog optional, since it's no longer built on musl and
conflicts with the logs recorded by login(1).

Remove pam_ck_connector, since it's no longer provided.

Fix license name.
---
 srcpkgs/pam-base/INSTALL.msg        | 5 +++++
 srcpkgs/pam-base/files/system-login | 3 ---
 srcpkgs/pam-base/template           | 8 ++++----
 3 files changed, 9 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/pam-base/INSTALL.msg

diff --git a/srcpkgs/pam-base/INSTALL.msg b/srcpkgs/pam-base/INSTALL.msg
new file mode 100644
index 00000000000..da74023b230
--- /dev/null
+++ b/srcpkgs/pam-base/INSTALL.msg
@@ -0,0 +1,5 @@
+WARNING: the default PAM configuration has changed. PAM 1.5.1
+will remove some deprecated modules, and this can break if you
+have custom configs. Please check that your PAM configuration
+in /etc/pam.d doesn't use the pam_tally, pam_tally2 or
+pam_lastlog (this last one only on musl systems) modules.
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index ecfe0627049..97852710936 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -1,6 +1,5 @@
 #%PAM-1.0
 
-auth       required   pam_tally.so         onerr=succeed file=/var/log/faillog
 auth       required   pam_shells.so
 auth       requisite  pam_nologin.so
 auth       include    system-auth
@@ -16,6 +15,4 @@ session    include    system-auth
 session    optional   pam_motd.so          motd=/etc/motd
 session    optional   pam_mail.so          dir=/var/mail standard quiet
 -session   optional   pam_elogind.so
--session   optional   pam_ck_connector.so  nox11
 session    required   pam_env.so
-session    required   pam_lastlog.so       silent
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 883f3d4f465..621b1da4412 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,10 +1,10 @@
 # Template file for 'pam-base'
 pkgname=pam-base
-version=0.3
-revision=6
+version=0.4
+revision=1
 short_desc="PAM base configuration files"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="custom:Public Domain"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="Public Domain"
 homepage="http://www.voidlinux.org"
 
 conf_files="