[PR PATCH] xdm.pam: update for elogind support

[PR PATCH] xdm.pam: update for elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

There is a new pull request by furryfixer against master on the void-packages repository

https://github.com/furryfixer/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27099

xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.

A patch file from https://github.com/void-linux/void-packages/pull/27099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27099.patch --]
[-- Type: text/x-diff, Size: 772 bytes --]

From bcc285499f76baf3e4e5704279fe7f6a86d45082 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Fri, 11 Dec 2020 22:22:49 -0500
Subject: [PATCH] xdm.pam: update for elogind support

Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
 srcpkgs/xdm/files/xdm.pam | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/xdm/files/xdm.pam b/srcpkgs/xdm/files/xdm.pam
index 06f88746d3d..8c243370d68 100644
--- a/srcpkgs/xdm/files/xdm.pam
+++ b/srcpkgs/xdm/files/xdm.pam
@@ -6,3 +6,4 @@ password	required	pam_unix.so
 session		required	pam_unix.so
 session		required	pam_limits.so
 session		required	pam_loginuid.so
+session        optional        pam_elogind.so

Re: [PR REVIEW] xdm.pam: update for elogind support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#discussion_r541493143

Comment:
Think you could align with the other entries?

Re: xdm.pam: update for elogind support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#issuecomment-743696769

Comment:
The package itself is `xdm`, so I think the commit message should be `xdm: update xdm.pam for ...`, perhaps. What do you think?

Re: xdm.pam: update for elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by furryfixer on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#issuecomment-743704893

Comment:
Agree, it should be update to xdm package, with revision bump.

Re: [PR PATCH] [Updated] xdm.pam: update for elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

There is an updated pull request by furryfixer against master on the void-packages repository

https://github.com/furryfixer/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27099

xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.

A patch file from https://github.com/void-linux/void-packages/pull/27099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27099.patch --]
[-- Type: text/x-diff, Size: 1564 bytes --]

From bcc285499f76baf3e4e5704279fe7f6a86d45082 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Fri, 11 Dec 2020 22:22:49 -0500
Subject: [PATCH 1/2] xdm.pam: update for elogind support

Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
 srcpkgs/xdm/files/xdm.pam | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/xdm/files/xdm.pam b/srcpkgs/xdm/files/xdm.pam
index 06f88746d3d..8c243370d68 100644
--- a/srcpkgs/xdm/files/xdm.pam
+++ b/srcpkgs/xdm/files/xdm.pam
@@ -6,3 +6,4 @@ password	required	pam_unix.so
 session		required	pam_unix.so
 session		required	pam_limits.so
 session		required	pam_loginuid.so
+session        optional        pam_elogind.so

From fefd0c45008bc24c771f25ecc329096f0c3c68d5 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Sat, 12 Dec 2020 00:53:25 -0500
Subject: [PATCH 2/2] xdm: Add elogind support to xdm.pam file

Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
 srcpkgs/xdm/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xdm/template b/srcpkgs/xdm/template
index 2c723ddd5d4..cf3d1de3f8d 100644
--- a/srcpkgs/xdm/template
+++ b/srcpkgs/xdm/template
@@ -1,7 +1,7 @@
 # Template file for 'xdm'
 pkgname=xdm
 version=1.1.12
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-random-device=/dev/urandom
  --with-utmp-file=/var/run/utmp

Re: [PR PATCH] [Updated] xdm.pam: update for elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

There is an updated pull request by furryfixer against master on the void-packages repository

https://github.com/furryfixer/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27099

xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.

A patch file from https://github.com/void-linux/void-packages/pull/27099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27099.patch --]
[-- Type: text/x-diff, Size: 1564 bytes --]

From bcc285499f76baf3e4e5704279fe7f6a86d45082 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Fri, 11 Dec 2020 22:22:49 -0500
Subject: [PATCH 1/2] xdm.pam: update for elogind support

Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
 srcpkgs/xdm/files/xdm.pam | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/xdm/files/xdm.pam b/srcpkgs/xdm/files/xdm.pam
index 06f88746d3d..8c243370d68 100644
--- a/srcpkgs/xdm/files/xdm.pam
+++ b/srcpkgs/xdm/files/xdm.pam
@@ -6,3 +6,4 @@ password	required	pam_unix.so
 session		required	pam_unix.so
 session		required	pam_limits.so
 session		required	pam_loginuid.so
+session        optional        pam_elogind.so

From fefd0c45008bc24c771f25ecc329096f0c3c68d5 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Sat, 12 Dec 2020 00:53:25 -0500
Subject: [PATCH 2/2] xdm: Add elogind support to xdm.pam file

Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
 srcpkgs/xdm/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xdm/template b/srcpkgs/xdm/template
index 2c723ddd5d4..cf3d1de3f8d 100644
--- a/srcpkgs/xdm/template
+++ b/srcpkgs/xdm/template
@@ -1,7 +1,7 @@
 # Template file for 'xdm'
 pkgname=xdm
 version=1.1.12
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-random-device=/dev/urandom
  --with-utmp-file=/var/run/utmp

Re: [PR REVIEW] xdm: update xdm.pam file with elogind support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#discussion_r545319371

Comment:
I believe this should use `-session` instead. It's what `system-login` uses.

Re: [PR REVIEW] xdm: update xdm.pam file with elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New review comment by furryfixer on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#discussion_r545333506

Comment:
Good idea on the “-“. Apologies that this PR is a mess because of my stubborn experiment in doing it online without actually using git, which is a fail.  I will clean it up in a day or two, or just close it and reissue a clean version.

Re: [PR REVIEW] xdm: update xdm.pam file with elogind support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#discussion_r545339040

Comment:
No problem. I can fix and merge it myself, if you want.

Re: [PR REVIEW] xdm: update xdm.pam file with elogind support

[furryfixer]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New review comment by furryfixer on void-packages repository

https://github.com/void-linux/void-packages/pull/27099#discussion_r545483408

Comment:
Go ahead ericonr,  I was going to have to work out how to merge or rebase and squash this when I did not create it from a downloaded repository to begin with.  Thanks!

Re: [PR PATCH] [Closed]: xdm: update xdm.pam file with elogind support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

There's a closed pull request on the void-packages repository

xdm: update xdm.pam file with elogind support
https://github.com/void-linux/void-packages/pull/27099

Description:
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.