* Re: [PR REVIEW] xdm.pam: update for elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
@ 2020-12-12 3:54 ` ericonr
2020-12-12 3:55 ` ericonr
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-12 3:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#discussion_r541493143
Comment:
Think you could align with the other entries?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: xdm.pam: update for elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
2020-12-12 3:54 ` [PR REVIEW] " ericonr
@ 2020-12-12 3:55 ` ericonr
2020-12-12 5:13 ` furryfixer
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-12 3:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#issuecomment-743696769
Comment:
The package itself is `xdm`, so I think the commit message should be `xdm: update xdm.pam for ...`, perhaps. What do you think?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: xdm.pam: update for elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
2020-12-12 3:54 ` [PR REVIEW] " ericonr
2020-12-12 3:55 ` ericonr
@ 2020-12-12 5:13 ` furryfixer
2020-12-12 5:53 ` [PR PATCH] [Updated] " furryfixer
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: furryfixer @ 2020-12-12 5:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by furryfixer on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#issuecomment-743704893
Comment:
Agree, it should be update to xdm package, with revision bump.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] xdm.pam: update for elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (2 preceding siblings ...)
2020-12-12 5:13 ` furryfixer
@ 2020-12-12 5:53 ` furryfixer
2020-12-12 5:54 ` furryfixer
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: furryfixer @ 2020-12-12 5:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
There is an updated pull request by furryfixer against master on the void-packages repository
https://github.com/furryfixer/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27099
xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
A patch file from https://github.com/void-linux/void-packages/pull/27099.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27099.patch --]
[-- Type: text/x-diff, Size: 1564 bytes --]
From bcc285499f76baf3e4e5704279fe7f6a86d45082 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Fri, 11 Dec 2020 22:22:49 -0500
Subject: [PATCH 1/2] xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
srcpkgs/xdm/files/xdm.pam | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/xdm/files/xdm.pam b/srcpkgs/xdm/files/xdm.pam
index 06f88746d3d..8c243370d68 100644
--- a/srcpkgs/xdm/files/xdm.pam
+++ b/srcpkgs/xdm/files/xdm.pam
@@ -6,3 +6,4 @@ password required pam_unix.so
session required pam_unix.so
session required pam_limits.so
session required pam_loginuid.so
+session optional pam_elogind.so
From fefd0c45008bc24c771f25ecc329096f0c3c68d5 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Sat, 12 Dec 2020 00:53:25 -0500
Subject: [PATCH 2/2] xdm: Add elogind support to xdm.pam file
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
srcpkgs/xdm/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/xdm/template b/srcpkgs/xdm/template
index 2c723ddd5d4..cf3d1de3f8d 100644
--- a/srcpkgs/xdm/template
+++ b/srcpkgs/xdm/template
@@ -1,7 +1,7 @@
# Template file for 'xdm'
pkgname=xdm
version=1.1.12
-revision=3
+revision=4
build_style=gnu-configure
configure_args="--with-random-device=/dev/urandom
--with-utmp-file=/var/run/utmp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] xdm.pam: update for elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (3 preceding siblings ...)
2020-12-12 5:53 ` [PR PATCH] [Updated] " furryfixer
@ 2020-12-12 5:54 ` furryfixer
2020-12-17 18:44 ` [PR REVIEW] xdm: update xdm.pam file with " ericonr
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: furryfixer @ 2020-12-12 5:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
There is an updated pull request by furryfixer against master on the void-packages repository
https://github.com/furryfixer/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27099
xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
A patch file from https://github.com/void-linux/void-packages/pull/27099.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27099.patch --]
[-- Type: text/x-diff, Size: 1564 bytes --]
From bcc285499f76baf3e4e5704279fe7f6a86d45082 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Fri, 11 Dec 2020 22:22:49 -0500
Subject: [PATCH 1/2] xdm.pam: update for elogind support
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
srcpkgs/xdm/files/xdm.pam | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/xdm/files/xdm.pam b/srcpkgs/xdm/files/xdm.pam
index 06f88746d3d..8c243370d68 100644
--- a/srcpkgs/xdm/files/xdm.pam
+++ b/srcpkgs/xdm/files/xdm.pam
@@ -6,3 +6,4 @@ password required pam_unix.so
session required pam_unix.so
session required pam_limits.so
session required pam_loginuid.so
+session optional pam_elogind.so
From fefd0c45008bc24c771f25ecc329096f0c3c68d5 Mon Sep 17 00:00:00 2001
From: William Rueger <spammer.victim@gmail.com>
Date: Sat, 12 Dec 2020 00:53:25 -0500
Subject: [PATCH 2/2] xdm: Add elogind support to xdm.pam file
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
---
srcpkgs/xdm/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/xdm/template b/srcpkgs/xdm/template
index 2c723ddd5d4..cf3d1de3f8d 100644
--- a/srcpkgs/xdm/template
+++ b/srcpkgs/xdm/template
@@ -1,7 +1,7 @@
# Template file for 'xdm'
pkgname=xdm
version=1.1.12
-revision=3
+revision=4
build_style=gnu-configure
configure_args="--with-random-device=/dev/urandom
--with-utmp-file=/var/run/utmp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] xdm: update xdm.pam file with elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (4 preceding siblings ...)
2020-12-12 5:54 ` furryfixer
@ 2020-12-17 18:44 ` ericonr
2020-12-17 19:05 ` furryfixer
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-17 18:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#discussion_r545319371
Comment:
I believe this should use `-session` instead. It's what `system-login` uses.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] xdm: update xdm.pam file with elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (5 preceding siblings ...)
2020-12-17 18:44 ` [PR REVIEW] xdm: update xdm.pam file with " ericonr
@ 2020-12-17 19:05 ` furryfixer
2020-12-17 19:15 ` ericonr
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: furryfixer @ 2020-12-17 19:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
New review comment by furryfixer on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#discussion_r545333506
Comment:
Good idea on the “-“. Apologies that this PR is a mess because of my stubborn experiment in doing it online without actually using git, which is a fail. I will clean it up in a day or two, or just close it and reissue a clean version.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] xdm: update xdm.pam file with elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (6 preceding siblings ...)
2020-12-17 19:05 ` furryfixer
@ 2020-12-17 19:15 ` ericonr
2020-12-17 23:57 ` furryfixer
2020-12-19 6:21 ` [PR PATCH] [Closed]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-17 19:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#discussion_r545339040
Comment:
No problem. I can fix and merge it myself, if you want.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] xdm: update xdm.pam file with elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (7 preceding siblings ...)
2020-12-17 19:15 ` ericonr
@ 2020-12-17 23:57 ` furryfixer
2020-12-19 6:21 ` [PR PATCH] [Closed]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: furryfixer @ 2020-12-17 23:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New review comment by furryfixer on void-packages repository
https://github.com/void-linux/void-packages/pull/27099#discussion_r545483408
Comment:
Go ahead ericonr, I was going to have to work out how to merge or rebase and squash this when I did not create it from a downloaded repository to begin with. Thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Closed]: xdm: update xdm.pam file with elogind support
2020-12-12 3:27 [PR PATCH] xdm.pam: update for elogind support furryfixer
` (8 preceding siblings ...)
2020-12-17 23:57 ` furryfixer
@ 2020-12-19 6:21 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-19 6:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
There's a closed pull request on the void-packages repository
xdm: update xdm.pam file with elogind support
https://github.com/void-linux/void-packages/pull/27099
Description:
Add optional access to "pam_elogind.so" to prevent polkit agent malfunction in multiple Desktop Environments if started from xdm.
^ permalink raw reply [flat|nested] 11+ messages in thread