[PR PATCH] volta: update to 0.9.99

[PR PATCH] volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

There is a new pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages volta-0.9.99
https://github.com/void-linux/void-packages/pull/27197

volta: update to 0.9.99


A patch file from https://github.com/void-linux/void-packages/pull/27197.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volta-0.9.99-27197.patch --]
[-- Type: text/x-diff, Size: 1244 bytes --]

From aae08bfc81e3757e941e4408c896383c744d8bf5 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Wed, 16 Dec 2020 11:48:12 +0100
Subject: [PATCH] volta: update to 0.9.99

---
 srcpkgs/volta/template | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/volta/template b/srcpkgs/volta/template
index 45ebad762e8..41394a189c9 100644
--- a/srcpkgs/volta/template
+++ b/srcpkgs/volta/template
@@ -1,21 +1,17 @@
 # Template file for 'volta'
 pkgname=volta
-version=0.9.3
+version=0.9.99
 revision=1
 archs="x86_64 i686" # Due to volta pulling pre-built binaries later. Evil.
-build_helper="rust"
-hostmakedepends="cargo pkg-config"
+build_style="cargo"
+hostmakedepends="pkg-config"
 makedepends="libressl-devel"
 short_desc="JavaScript tool version sync helper"
 maintainer="Alex Lohr <alex.lohr@logmein.com>"
 license="BSD-2-Clause"
 homepage="https://volta.sh/"
 distfiles="https://github.com/volta-cli/volta/archive/v${version}.tar.gz"
-checksum=3777585d5ebd24f9f53ac5d41c378c471211ded0d8e0e126110648fefbd0d316
-
-do_build() {
-	cargo build --release --target ${RUST_TARGET}
-}
+checksum=7485db7471f44de574523152ed14bbda549954794e6c2fd920a9d80b2ebcdb9b
 
 do_install() {
 	vlicense LICENSE

Re: [PR REVIEW] volta: update to 0.9.99

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27197#discussion_r544341387

Comment:
Can you replace do install as well, and only use a post install for the license?

Re: [PR PATCH] [Updated] volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

There is an updated pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages volta-0.9.99
https://github.com/void-linux/void-packages/pull/27197

volta: update to 0.9.99


A patch file from https://github.com/void-linux/void-packages/pull/27197.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volta-0.9.99-27197.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]

From bd4c9d7a6612c8cc07340fd72f2ca3fdeedbd0f4 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Wed, 16 Dec 2020 11:48:12 +0100
Subject: [PATCH] volta: update to 0.9.99

---
 srcpkgs/volta/template | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/volta/template b/srcpkgs/volta/template
index 45ebad762e8..84e2144f1e8 100644
--- a/srcpkgs/volta/template
+++ b/srcpkgs/volta/template
@@ -1,26 +1,18 @@
 # Template file for 'volta'
 pkgname=volta
-version=0.9.3
+version=0.9.99
 revision=1
 archs="x86_64 i686" # Due to volta pulling pre-built binaries later. Evil.
-build_helper="rust"
-hostmakedepends="cargo pkg-config"
+build_style="cargo"
+hostmakedepends="pkg-config"
 makedepends="libressl-devel"
 short_desc="JavaScript tool version sync helper"
 maintainer="Alex Lohr <alex.lohr@logmein.com>"
 license="BSD-2-Clause"
 homepage="https://volta.sh/"
 distfiles="https://github.com/volta-cli/volta/archive/v${version}.tar.gz"
-checksum=3777585d5ebd24f9f53ac5d41c378c471211ded0d8e0e126110648fefbd0d316
+checksum=7485db7471f44de574523152ed14bbda549954794e6c2fd920a9d80b2ebcdb9b
 
-do_build() {
-	cargo build --release --target ${RUST_TARGET}
-}
-
-do_install() {
+post_install() {
 	vlicense LICENSE
-
-	vbin target/${RUST_TARGET}/release/volta
-	vbin target/${RUST_TARGET}/release/volta-shim
-	vbin target/${RUST_TARGET}/release/volta-migrate
 }

Re: [PR REVIEW] volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/27197#discussion_r545398604

Comment:
Thanks for the suggestion. I'll do it at once.

Re: [PR REVIEW] volta: update to 0.9.99

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27197#discussion_r545404700

Comment:
All this done, according to https://github.com/volta-cli/volta/releases/tag/v0.9.99 , this is a pre-release version. I don't think we should be shipping it.

Re: [PR REVIEW] volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New review comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/27197#discussion_r545414837

Comment:
I will leave that decision to you. I haven't found any regressions since yesterday morning. The new support for npm link is pretty useful in some cases, though, but I guess we can wait the few days until 1.0.0 is released.

Re: volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/27197#issuecomment-748520275

Comment:
And 1.0.0 is out, so I can close this PR and open a new one for that.

Re: [PR PATCH] [Closed]: volta: update to 0.9.99

[atk]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

There's a closed pull request on the void-packages repository

volta: update to 0.9.99
https://github.com/void-linux/void-packages/pull/27197

Description: