* [PR PATCH] volta: update to 0.9.99
@ 2020-12-16 10:48 atk
2020-12-16 14:28 ` [PR REVIEW] " ericonr
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: atk @ 2020-12-16 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
There is a new pull request by atk against master on the void-packages repository
https://github.com/atk/void-packages volta-0.9.99
https://github.com/void-linux/void-packages/pull/27197
volta: update to 0.9.99
A patch file from https://github.com/void-linux/void-packages/pull/27197.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volta-0.9.99-27197.patch --]
[-- Type: text/x-diff, Size: 1244 bytes --]
From aae08bfc81e3757e941e4408c896383c744d8bf5 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Wed, 16 Dec 2020 11:48:12 +0100
Subject: [PATCH] volta: update to 0.9.99
---
srcpkgs/volta/template | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/volta/template b/srcpkgs/volta/template
index 45ebad762e8..41394a189c9 100644
--- a/srcpkgs/volta/template
+++ b/srcpkgs/volta/template
@@ -1,21 +1,17 @@
# Template file for 'volta'
pkgname=volta
-version=0.9.3
+version=0.9.99
revision=1
archs="x86_64 i686" # Due to volta pulling pre-built binaries later. Evil.
-build_helper="rust"
-hostmakedepends="cargo pkg-config"
+build_style="cargo"
+hostmakedepends="pkg-config"
makedepends="libressl-devel"
short_desc="JavaScript tool version sync helper"
maintainer="Alex Lohr <alex.lohr@logmein.com>"
license="BSD-2-Clause"
homepage="https://volta.sh/"
distfiles="https://github.com/volta-cli/volta/archive/v${version}.tar.gz"
-checksum=3777585d5ebd24f9f53ac5d41c378c471211ded0d8e0e126110648fefbd0d316
-
-do_build() {
- cargo build --release --target ${RUST_TARGET}
-}
+checksum=7485db7471f44de574523152ed14bbda549954794e6c2fd920a9d80b2ebcdb9b
do_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
@ 2020-12-16 14:28 ` ericonr
2020-12-17 20:54 ` [PR PATCH] [Updated] " atk
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-12-16 14:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27197#discussion_r544341387
Comment:
Can you replace do install as well, and only use a post install for the license?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
2020-12-16 14:28 ` [PR REVIEW] " ericonr
@ 2020-12-17 20:54 ` atk
2020-12-17 20:57 ` [PR REVIEW] " atk
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-12-17 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
There is an updated pull request by atk against master on the void-packages repository
https://github.com/atk/void-packages volta-0.9.99
https://github.com/void-linux/void-packages/pull/27197
volta: update to 0.9.99
A patch file from https://github.com/void-linux/void-packages/pull/27197.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volta-0.9.99-27197.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]
From bd4c9d7a6612c8cc07340fd72f2ca3fdeedbd0f4 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Wed, 16 Dec 2020 11:48:12 +0100
Subject: [PATCH] volta: update to 0.9.99
---
srcpkgs/volta/template | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/volta/template b/srcpkgs/volta/template
index 45ebad762e8..84e2144f1e8 100644
--- a/srcpkgs/volta/template
+++ b/srcpkgs/volta/template
@@ -1,26 +1,18 @@
# Template file for 'volta'
pkgname=volta
-version=0.9.3
+version=0.9.99
revision=1
archs="x86_64 i686" # Due to volta pulling pre-built binaries later. Evil.
-build_helper="rust"
-hostmakedepends="cargo pkg-config"
+build_style="cargo"
+hostmakedepends="pkg-config"
makedepends="libressl-devel"
short_desc="JavaScript tool version sync helper"
maintainer="Alex Lohr <alex.lohr@logmein.com>"
license="BSD-2-Clause"
homepage="https://volta.sh/"
distfiles="https://github.com/volta-cli/volta/archive/v${version}.tar.gz"
-checksum=3777585d5ebd24f9f53ac5d41c378c471211ded0d8e0e126110648fefbd0d316
+checksum=7485db7471f44de574523152ed14bbda549954794e6c2fd920a9d80b2ebcdb9b
-do_build() {
- cargo build --release --target ${RUST_TARGET}
-}
-
-do_install() {
+post_install() {
vlicense LICENSE
-
- vbin target/${RUST_TARGET}/release/volta
- vbin target/${RUST_TARGET}/release/volta-shim
- vbin target/${RUST_TARGET}/release/volta-migrate
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
2020-12-16 14:28 ` [PR REVIEW] " ericonr
2020-12-17 20:54 ` [PR PATCH] [Updated] " atk
@ 2020-12-17 20:57 ` atk
2020-12-17 21:08 ` ericonr
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-12-17 20:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/27197#discussion_r545398604
Comment:
Thanks for the suggestion. I'll do it at once.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
` (2 preceding siblings ...)
2020-12-17 20:57 ` [PR REVIEW] " atk
@ 2020-12-17 21:08 ` ericonr
2020-12-17 21:28 ` atk
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-12-17 21:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27197#discussion_r545404700
Comment:
All this done, according to https://github.com/volta-cli/volta/releases/tag/v0.9.99 , this is a pre-release version. I don't think we should be shipping it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
` (3 preceding siblings ...)
2020-12-17 21:08 ` ericonr
@ 2020-12-17 21:28 ` atk
2020-12-19 20:19 ` atk
2020-12-19 20:19 ` [PR PATCH] [Closed]: " atk
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-12-17 21:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
New review comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/27197#discussion_r545414837
Comment:
I will leave that decision to you. I haven't found any regressions since yesterday morning. The new support for npm link is pretty useful in some cases, though, but I guess we can wait the few days until 1.0.0 is released.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
` (4 preceding siblings ...)
2020-12-17 21:28 ` atk
@ 2020-12-19 20:19 ` atk
2020-12-19 20:19 ` [PR PATCH] [Closed]: " atk
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-12-19 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/27197#issuecomment-748520275
Comment:
And 1.0.0 is out, so I can close this PR and open a new one for that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Closed]: volta: update to 0.9.99
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
` (5 preceding siblings ...)
2020-12-19 20:19 ` atk
@ 2020-12-19 20:19 ` atk
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-12-19 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
There's a closed pull request on the void-packages repository
volta: update to 0.9.99
https://github.com/void-linux/void-packages/pull/27197
Description:
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-19 20:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 10:48 [PR PATCH] volta: update to 0.9.99 atk
2020-12-16 14:28 ` [PR REVIEW] " ericonr
2020-12-17 20:54 ` [PR PATCH] [Updated] " atk
2020-12-17 20:57 ` [PR REVIEW] " atk
2020-12-17 21:08 ` ericonr
2020-12-17 21:28 ` atk
2020-12-19 20:19 ` atk
2020-12-19 20:19 ` [PR PATCH] [Closed]: " atk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).