* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
@ 2020-10-04 8:14 ` sgn
2020-10-04 8:14 ` sgn
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04 8:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499218575
Comment:
Why do we need to `make clean` on fresh copy?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
2020-10-04 8:14 ` [PR REVIEW] " sgn
@ 2020-10-04 8:14 ` sgn
2020-10-04 8:14 ` sgn
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04 8:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499218600
Comment:
Why do we need to vendor them?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
2020-10-04 8:14 ` [PR REVIEW] " sgn
2020-10-04 8:14 ` sgn
@ 2020-10-04 8:14 ` sgn
2020-10-05 15:48 ` Zeinok
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04 8:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499218617
Comment:
Does the `Makefile` work? And we generally don't install executable to `usr/lib`, use `usr/libexec` instead.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (2 preceding siblings ...)
2020-10-04 8:14 ` sgn
@ 2020-10-05 15:48 ` Zeinok
2020-10-05 15:51 ` Zeinok
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 15:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
New review comment by Zeinok on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499699269
Comment:
well their tarball isn't clean
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (3 preceding siblings ...)
2020-10-05 15:48 ` Zeinok
@ 2020-10-05 15:51 ` Zeinok
2020-10-05 16:48 ` ericonr
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 15:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New review comment by Zeinok on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499701275
Comment:
the Makefile doesn't have install target so manual copying is required
for `usr/libexec` yes I'll fix it
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (4 preceding siblings ...)
2020-10-05 15:51 ` Zeinok
@ 2020-10-05 16:48 ` ericonr
2020-10-05 16:50 ` Zeinok
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-10-05 16:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499736459
Comment:
Please try talking to upstream about including a desktop file, it doesn't make sense for every distro to carry a random version of it themselves.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (5 preceding siblings ...)
2020-10-05 16:48 ` ericonr
@ 2020-10-05 16:50 ` Zeinok
2020-10-05 16:53 ` [PR PATCH] [Updated] " Zeinok
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
New review comment by Zeinok on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#discussion_r499737520
Comment:
thanks for explaining the situation, then I think not supplying desktop files would be better for now.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Updated] New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (6 preceding siblings ...)
2020-10-05 16:50 ` Zeinok
@ 2020-10-05 16:53 ` Zeinok
2020-12-22 10:20 ` fosslinux
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 16:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
There is an updated pull request by Zeinok against master on the void-packages repository
https://github.com/Zeinok/void-packages goattracker-stereo
https://github.com/void-linux/void-packages/pull/25317
New package: goattracker-stereo-2.76
C64 stereo music tracker
A patch file from https://github.com/void-linux/void-packages/pull/25317.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-goattracker-stereo-25317.patch --]
[-- Type: text/x-diff, Size: 1467 bytes --]
From 138932e71ac2e1bedf44637317dc4a5795742c41 Mon Sep 17 00:00:00 2001
From: Zeinok <zeinok@protonmail.com>
Date: Sat, 28 Mar 2020 16:29:49 +0800
Subject: [PATCH] New package: goattracker-stereo-2.76
---
srcpkgs/goattracker-stereo/template | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 srcpkgs/goattracker-stereo/template
diff --git a/srcpkgs/goattracker-stereo/template b/srcpkgs/goattracker-stereo/template
new file mode 100644
index 00000000000..ee916fdef93
--- /dev/null
+++ b/srcpkgs/goattracker-stereo/template
@@ -0,0 +1,29 @@
+# Template file for 'goattracker-stereo'
+pkgname=goattracker-stereo
+version=2.76
+revision=1
+wrksrc=gt2stereo
+makedepends="SDL-devel"
+short_desc="C64 music tracker (stereo)"
+maintainer="Zeinok <zeinok@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://sourceforge.net/projects/goattracker2/"
+distfiles="${SOURCEFORGE_SITE}/goattracker2/GoatTracker%202%20Stereo/${version}/GoatTracker_${version}_Stereo.zip"
+checksum=878a4194ecf48c48a89ba0a07fcce6d1ad27b3b1c9ec86e52160960ed0199f89
+
+do_build() {
+ cd ${wrksrc}/trunk/src/
+ make clean
+ cd ${wrksrc}/trunk/src/bme/
+ make
+ cd ${wrksrc}/trunk/src/
+ make
+}
+
+do_install() {
+ vbin trunk/linux/gt2stereo
+ vmkdir usr/libexec/gt2stereo
+ vinstall trunk/linux/ins2snd2 755 usr/libexec/gt2stereo
+ vinstall trunk/linux/mod2sng2 755 usr/libexec/gt2stereo
+ vinstall trunk/linux/ss2stereo 755 usr/libexec/gt2stereo
+}
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (7 preceding siblings ...)
2020-10-05 16:53 ` [PR PATCH] [Updated] " Zeinok
@ 2020-12-22 10:20 ` fosslinux
2021-04-18 21:04 ` ericonr
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: fosslinux @ 2020-12-22 10:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#issuecomment-749466816
Comment:
Please also apply changes from your other PR here where required (mainly the makejobs change)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (8 preceding siblings ...)
2020-12-22 10:20 ` fosslinux
@ 2021-04-18 21:04 ` ericonr
2021-05-21 14:50 ` ericonr
2021-05-21 14:50 ` [PR PATCH] [Closed]: " ericonr
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-04-18 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#issuecomment-822061062
Comment:
Ping @Zeinok
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (9 preceding siblings ...)
2021-04-18 21:04 ` ericonr
@ 2021-05-21 14:50 ` ericonr
2021-05-21 14:50 ` [PR PATCH] [Closed]: " ericonr
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-05-21 14:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25317#issuecomment-846006506
Comment:
Closing PR due to inactivity, feel free to reopen :)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: New package: goattracker-stereo-2.76
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
` (10 preceding siblings ...)
2021-05-21 14:50 ` ericonr
@ 2021-05-21 14:50 ` ericonr
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-05-21 14:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
There's a closed pull request on the void-packages repository
New package: goattracker-stereo-2.76
https://github.com/void-linux/void-packages/pull/25317
Description:
C64 stereo music tracker
^ permalink raw reply [flat|nested] 13+ messages in thread