Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: goattracker-stereo-2.76
@ 2020-10-03 16:19 Zeinok
  2020-10-04  8:14 ` [PR REVIEW] " sgn
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: Zeinok @ 2020-10-03 16:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

There is a new pull request by Zeinok against master on the void-packages repository

https://github.com/Zeinok/void-packages goattracker-stereo
https://github.com/void-linux/void-packages/pull/25317

New package: goattracker-stereo-2.76
C64 stereo music tracker 

A patch file from https://github.com/void-linux/void-packages/pull/25317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-goattracker-stereo-25317.patch --]
[-- Type: text/x-diff, Size: 3669 bytes --]

From 2e7513a9736035bcd3526134c6bc44af6b802b59 Mon Sep 17 00:00:00 2001
From: Zeinok <zeinok@protonmail.com>
Date: Sat, 28 Mar 2020 16:29:49 +0800
Subject: [PATCH] New package: goattracker-stereo-2.76

---
 .../files/gt2stereo.desktop                   |   9 +++++
 .../goattracker-stereo/files/gt2stereo.png    | Bin 0 -> 838 bytes
 srcpkgs/goattracker-stereo/template           |  31 ++++++++++++++++++
 3 files changed, 40 insertions(+)
 create mode 100644 srcpkgs/goattracker-stereo/files/gt2stereo.desktop
 create mode 100644 srcpkgs/goattracker-stereo/files/gt2stereo.png
 create mode 100644 srcpkgs/goattracker-stereo/template

diff --git a/srcpkgs/goattracker-stereo/files/gt2stereo.desktop b/srcpkgs/goattracker-stereo/files/gt2stereo.desktop
new file mode 100644
index 00000000000..ee127a32db1
--- /dev/null
+++ b/srcpkgs/goattracker-stereo/files/gt2stereo.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=GoatTracker 2 Stereo
+Exec=gt2stereo %F
+Terminal=false
+X-MultipleArgs=false
+Type=Application
+Icon=gt2stereo
+Categories=AudioVideo;AudioVideoEditing;
+MimeType=audio/sng;
diff --git a/srcpkgs/goattracker-stereo/files/gt2stereo.png b/srcpkgs/goattracker-stereo/files/gt2stereo.png
new file mode 100644
index 0000000000000000000000000000000000000000..bbd3848c12d0f931ff5b18747044d44ac0976ce3
GIT binary patch
literal 838
zcmV-M1G)T(P)<h;3K|Lk000e1NJLTq001BW001Be0ssI2{21+{00009a7bBm000Xk
z000Xk0o$gnMgRZ;_(?=TR7l6QRy{~tQ561e5*K-)yh29l<d&g}IE26p*P%31p?0=&
zhPpf#TR4Sgsf!NTovTn6i$gC49tv(svvpA%9U>^*?CtQS*X#R9Uk4B2adPfC=R1G*
zyr-<ScucARP)Y&#Jjh2{>*b%W^^~>t{kPv!y!X4+8aZQ()@tx2A7lFIr<avZr!yQ5
zePI+ut=LR50FWdJy=))mdl8Y|oBUIHU*EsWHLL*GJ+&f2jFpZGLioSkQ>(RZx7#A(
zpE^p#&YX@m^nDM45C<3b#WQ7$5s}x=)xkw!=Y7{j#GG33Ux4~kxI&R}k}PG9q9_^;
zhy8A~aEhJ;*8oO#+*BcxXw}uoj&lvD>{BZ?47L~mr|y4}BrJDRg_rgaz?|wBW7y|Q
zdk9at>=Xsq0}!gM_5C~PR*f;lm{Xmxedn8HC9F6Ae~S9us_Q`oK!CGQZHWl$=sH1E
z5domJW)h*=3UC(S%%7s{AU!BiZBzxosOg1CP{T1I(r&knF*8crAG++Wu-4iS+q|xP
zl2SZTof=K7wX94OMcL8fk+RnAy}btTYCELybkbUXT^Uoq>@GTP%m9evTdf1PeCW$(
z*oHX1J^tS*IzK<Bba{CMU}vYvVRZ?);%Kd%@|0cVPZ0qwve^+MZ>=^L7WRE1W1n`D
zQ$aNv1CburUjc@0GzKYoDuV~x^eRm~5#h+X8{ioB<LavCmpdD{6Dn)1QXezRe{vx>
z`>xymEOAWBzR|MY9RP2D%flFxBncpZl$oMb29uCe!TQ1^Nkr&fQW+d==<GOEQnBZD
zl?{LBJ%@5P5=(SnlXCk-P?~D&)pR9(*ZAwJJix!dZCo|k@S?AWBCE+pT->~IQpYcD
z-nb+G=@^3f<_?~=lZysmX@1seFU`-AIa#d(I9aWe=aZJy`Tp}4&3Wp)JKKAJ-0WOj
zMSF&LSsmZD5MXih#zo;5ut>-6jV~_*U=dP0E&JUni{s1t-KtB%w|#W_1HWJ!LC}RP
QDgXcg07*qoM6N<$f@CR+Bme*a

literal 0
HcmV?d00001

diff --git a/srcpkgs/goattracker-stereo/template b/srcpkgs/goattracker-stereo/template
new file mode 100644
index 00000000000..583a4ba177c
--- /dev/null
+++ b/srcpkgs/goattracker-stereo/template
@@ -0,0 +1,31 @@
+# Template file for 'goattracker-stereo'
+pkgname=goattracker-stereo
+version=2.76
+revision=1
+wrksrc=gt2stereo
+makedepends="SDL-devel"
+short_desc="C64 music tracker (stereo)"
+maintainer="Zeinok <zeinok@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://sourceforge.net/projects/goattracker2/"
+distfiles="${SOURCEFORGE_SITE}/goattracker2/GoatTracker%202%20Stereo/${version}/GoatTracker_${version}_Stereo.zip"
+checksum=878a4194ecf48c48a89ba0a07fcce6d1ad27b3b1c9ec86e52160960ed0199f89
+
+do_build() {
+	cd ${wrksrc}/trunk/src/
+	make clean
+	cd ${wrksrc}/trunk/src/bme/
+	make
+	cd ${wrksrc}/trunk/src/
+	make
+}
+
+do_install() {
+	vbin trunk/linux/gt2stereo
+	vmkdir usr/lib/gt2stereo
+	vinstall trunk/linux/ins2snd2 755 usr/lib/gt2stereo
+	vinstall trunk/linux/mod2sng2 755 usr/lib/gt2stereo
+	vinstall trunk/linux/ss2stereo 755 usr/lib/gt2stereo
+	vinstall ${FILESDIR}/gt2stereo.desktop 644 usr/share/applications
+	vinstall ${FILESDIR}/gt2stereo.png 644 usr/share/pixmaps
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
@ 2020-10-04  8:14 ` sgn
  2020-10-04  8:14 ` sgn
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04  8:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499218575

Comment:
Why do we need to `make clean` on fresh copy?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
  2020-10-04  8:14 ` [PR REVIEW] " sgn
  2020-10-04  8:14 ` sgn
@ 2020-10-04  8:14 ` sgn
  2020-10-05 15:48 ` Zeinok
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04  8:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499218617

Comment:
Does the `Makefile` work? And we generally don't install executable to `usr/lib`, use `usr/libexec` instead.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
  2020-10-04  8:14 ` [PR REVIEW] " sgn
@ 2020-10-04  8:14 ` sgn
  2020-10-04  8:14 ` sgn
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-04  8:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499218600

Comment:
Why do we need to vendor them?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (2 preceding siblings ...)
  2020-10-04  8:14 ` sgn
@ 2020-10-05 15:48 ` Zeinok
  2020-10-05 15:51 ` Zeinok
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 15:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by Zeinok on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499699269

Comment:
well their tarball isn't clean

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (3 preceding siblings ...)
  2020-10-05 15:48 ` Zeinok
@ 2020-10-05 15:51 ` Zeinok
  2020-10-05 16:48 ` ericonr
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 15:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by Zeinok on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499701275

Comment:
the Makefile doesn't have install target so manual copying is required  
for `usr/libexec` yes I'll fix it

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (4 preceding siblings ...)
  2020-10-05 15:51 ` Zeinok
@ 2020-10-05 16:48 ` ericonr
  2020-10-05 16:50 ` Zeinok
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-10-05 16:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499736459

Comment:
Please try talking to upstream about including a desktop file, it doesn't make sense for every distro to carry a random version of it themselves.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (5 preceding siblings ...)
  2020-10-05 16:48 ` ericonr
@ 2020-10-05 16:50 ` Zeinok
  2020-10-05 16:53 ` [PR PATCH] [Updated] " Zeinok
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 16:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by Zeinok on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#discussion_r499737520

Comment:
thanks for explaining the situation, then I think not supplying desktop files would be better for now.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (6 preceding siblings ...)
  2020-10-05 16:50 ` Zeinok
@ 2020-10-05 16:53 ` Zeinok
  2020-12-22 10:20 ` fosslinux
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Zeinok @ 2020-10-05 16:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

There is an updated pull request by Zeinok against master on the void-packages repository

https://github.com/Zeinok/void-packages goattracker-stereo
https://github.com/void-linux/void-packages/pull/25317

New package: goattracker-stereo-2.76
C64 stereo music tracker 

A patch file from https://github.com/void-linux/void-packages/pull/25317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-goattracker-stereo-25317.patch --]
[-- Type: text/x-diff, Size: 1467 bytes --]

From 138932e71ac2e1bedf44637317dc4a5795742c41 Mon Sep 17 00:00:00 2001
From: Zeinok <zeinok@protonmail.com>
Date: Sat, 28 Mar 2020 16:29:49 +0800
Subject: [PATCH] New package: goattracker-stereo-2.76

---
 srcpkgs/goattracker-stereo/template | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 srcpkgs/goattracker-stereo/template

diff --git a/srcpkgs/goattracker-stereo/template b/srcpkgs/goattracker-stereo/template
new file mode 100644
index 00000000000..ee916fdef93
--- /dev/null
+++ b/srcpkgs/goattracker-stereo/template
@@ -0,0 +1,29 @@
+# Template file for 'goattracker-stereo'
+pkgname=goattracker-stereo
+version=2.76
+revision=1
+wrksrc=gt2stereo
+makedepends="SDL-devel"
+short_desc="C64 music tracker (stereo)"
+maintainer="Zeinok <zeinok@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://sourceforge.net/projects/goattracker2/"
+distfiles="${SOURCEFORGE_SITE}/goattracker2/GoatTracker%202%20Stereo/${version}/GoatTracker_${version}_Stereo.zip"
+checksum=878a4194ecf48c48a89ba0a07fcce6d1ad27b3b1c9ec86e52160960ed0199f89
+
+do_build() {
+	cd ${wrksrc}/trunk/src/
+	make clean
+	cd ${wrksrc}/trunk/src/bme/
+	make
+	cd ${wrksrc}/trunk/src/
+	make
+}
+
+do_install() {
+	vbin trunk/linux/gt2stereo
+	vmkdir usr/libexec/gt2stereo
+	vinstall trunk/linux/ins2snd2 755 usr/libexec/gt2stereo
+	vinstall trunk/linux/mod2sng2 755 usr/libexec/gt2stereo
+	vinstall trunk/linux/ss2stereo 755 usr/libexec/gt2stereo
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (7 preceding siblings ...)
  2020-10-05 16:53 ` [PR PATCH] [Updated] " Zeinok
@ 2020-12-22 10:20 ` fosslinux
  2021-04-18 21:04 ` ericonr
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: fosslinux @ 2020-12-22 10:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#issuecomment-749466816

Comment:
Please also apply changes from your other PR here where required (mainly the makejobs change)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (8 preceding siblings ...)
  2020-12-22 10:20 ` fosslinux
@ 2021-04-18 21:04 ` ericonr
  2021-05-21 14:50 ` ericonr
  2021-05-21 14:50 ` [PR PATCH] [Closed]: " ericonr
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-04-18 21:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#issuecomment-822061062

Comment:
Ping @Zeinok 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (9 preceding siblings ...)
  2021-04-18 21:04 ` ericonr
@ 2021-05-21 14:50 ` ericonr
  2021-05-21 14:50 ` [PR PATCH] [Closed]: " ericonr
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-05-21 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25317#issuecomment-846006506

Comment:
Closing PR due to inactivity, feel free to reopen :)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Closed]: New package: goattracker-stereo-2.76
  2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
                   ` (10 preceding siblings ...)
  2021-05-21 14:50 ` ericonr
@ 2021-05-21 14:50 ` ericonr
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-05-21 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

There's a closed pull request on the void-packages repository

New package: goattracker-stereo-2.76
https://github.com/void-linux/void-packages/pull/25317

Description:
C64 stereo music tracker 

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-05-21 14:50 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-03 16:19 [PR PATCH] New package: goattracker-stereo-2.76 Zeinok
2020-10-04  8:14 ` [PR REVIEW] " sgn
2020-10-04  8:14 ` sgn
2020-10-04  8:14 ` sgn
2020-10-05 15:48 ` Zeinok
2020-10-05 15:51 ` Zeinok
2020-10-05 16:48 ` ericonr
2020-10-05 16:50 ` Zeinok
2020-10-05 16:53 ` [PR PATCH] [Updated] " Zeinok
2020-12-22 10:20 ` fosslinux
2021-04-18 21:04 ` ericonr
2021-05-21 14:50 ` ericonr
2021-05-21 14:50 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).