* [PR PATCH] containerd: Install runc shims
@ 2020-12-27 15:05 tsndqst
2020-12-27 15:27 ` ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: tsndqst @ 2020-12-27 15:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
There is a new pull request by tsndqst against master on the void-packages repository
https://github.com/tsndqst/void-packages containerd-runc-shims
https://github.com/void-linux/void-packages/pull/27469
containerd: Install runc shims
The runc shims were not being installed. I believe this change is all that is needed to get them installed properly.
I tested this by switching my Kubernetes install to use containerd runtime instead of docker.
cc @pauldotknopf
A patch file from https://github.com/void-linux/void-packages/pull/27469.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-containerd-runc-shims-27469.patch --]
[-- Type: text/x-diff, Size: 967 bytes --]
From 46d4a91238f3eaeeefd5782439e204bf8636e0da Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Sun, 27 Dec 2020 08:26:04 -0600
Subject: [PATCH] containerd: Install runc shims
---
srcpkgs/containerd/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/containerd/template b/srcpkgs/containerd/template
index 5c4883a9ceb..fd8d1b10195 100644
--- a/srcpkgs/containerd/template
+++ b/srcpkgs/containerd/template
@@ -1,11 +1,13 @@
# Template file for 'containerd'
pkgname=containerd
version=1.3.9
-revision=1
+revision=2
build_style=go
go_import_path=github.com/containerd/containerd
go_package="${go_import_path}/cmd/containerd
${go_import_path}/cmd/containerd-shim
+ ${go_import_path}/cmd/containerd-shim-runc-v1
+ ${go_import_path}/cmd/containerd-shim-runc-v2
${go_import_path}/cmd/ctr"
go_ldflags="-X ${go_import_path}/version.Version=${version}
-X ${go_import_path}/version.Revision=UNSET"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: containerd: Install runc shims
2020-12-27 15:05 [PR PATCH] containerd: Install runc shims tsndqst
@ 2020-12-27 15:27 ` ericonr
2020-12-27 15:43 ` tsndqst
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-27 15:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27469#issuecomment-751480605
Comment:
Do we need both versions? Might be best to pick one and rename to `containerd-shim-runc`... Unless the default is to have the version numbers there?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: containerd: Install runc shims
2020-12-27 15:05 [PR PATCH] containerd: Install runc shims tsndqst
2020-12-27 15:27 ` ericonr
@ 2020-12-27 15:43 ` tsndqst
2020-12-27 16:11 ` tsndqst
2020-12-30 6:34 ` [PR PATCH] [Closed]: " the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: tsndqst @ 2020-12-27 15:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by tsndqst on void-packages repository
https://github.com/void-linux/void-packages/pull/27469#issuecomment-751482510
Comment:
The default is to have the versions there. They're migrating from v1 to v2 so they include both versions.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: containerd: Install runc shims
2020-12-27 15:05 [PR PATCH] containerd: Install runc shims tsndqst
2020-12-27 15:27 ` ericonr
2020-12-27 15:43 ` tsndqst
@ 2020-12-27 16:11 ` tsndqst
2020-12-30 6:34 ` [PR PATCH] [Closed]: " the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: tsndqst @ 2020-12-27 16:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
New comment by tsndqst on void-packages repository
https://github.com/void-linux/void-packages/pull/27469#issuecomment-751485816
Comment:
The binary archive at https://github.com/containerd/containerd/releases/download/v1.3.9/containerd-1.3.9-linux-amd64.tar.gz has both runc shims.
```
$ tar ztf containerd-1.3.9-linux-amd64.tar.gz
bin/
bin/ctr
bin/containerd-shim
bin/containerd-shim-runc-v1
bin/containerd-shim-runc-v2
bin/containerd
```
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: containerd: Install runc shims
2020-12-27 15:05 [PR PATCH] containerd: Install runc shims tsndqst
` (2 preceding siblings ...)
2020-12-27 16:11 ` tsndqst
@ 2020-12-30 6:34 ` the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: the-maldridge @ 2020-12-30 6:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
There's a closed pull request on the void-packages repository
containerd: Install runc shims
https://github.com/void-linux/void-packages/pull/27469
Description:
The runc shims were not being installed. I believe this change is all that is needed to get them installed properly.
I tested this by switching my Kubernetes install to use containerd runtime instead of docker.
cc @pauldotknopf
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-30 6:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 15:05 [PR PATCH] containerd: Install runc shims tsndqst
2020-12-27 15:27 ` ericonr
2020-12-27 15:43 ` tsndqst
2020-12-27 16:11 ` tsndqst
2020-12-30 6:34 ` [PR PATCH] [Closed]: " the-maldridge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).