* Re: [PR PATCH] [Updated] guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
@ 2020-12-25 11:02 ` DavideMaggio
2020-12-26 5:04 ` ericonr
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-25 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
There is an updated pull request by DavideMaggio against master on the void-packages repository
https://github.com/DavideMaggio/void-packages guitarix2-00
https://github.com/void-linux/void-packages/pull/27420
guitarix2: update to 0.42.0 + added 'faust' build option
#27251
A patch file from https://github.com/void-linux/void-packages/pull/27420.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guitarix2-00-27420.patch --]
[-- Type: text/x-diff, Size: 2382 bytes --]
From 601d5846b4b37083e8bcffe0f83f9563aa6522a8 Mon Sep 17 00:00:00 2001
From: mag <mag-one@autistici.org>
Date: Thu, 24 Dec 2020 17:01:56 +0100
Subject: [PATCH] guitarix2: update to 0.42.0 + added 'faust' build option
---
srcpkgs/guitarix2/template | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/guitarix2/template b/srcpkgs/guitarix2/template
index 95c6253c8da..103f324e8eb 100644
--- a/srcpkgs/guitarix2/template
+++ b/srcpkgs/guitarix2/template
@@ -1,33 +1,37 @@
# Template file for 'guitarix2'
pkgname=guitarix2
-version=0.39.0
+version=0.42.0
revision=1
wrksrc="guitarix-${version}"
build_style=waf3
-configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa --no-faust
- $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')"
+configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa
+ $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')
+ $(vopt_if faust '' '--no-faust')"
make_build_args="--progress"
-hostmakedepends="gperf intltool pkg-config"
-makedepends="boost-devel eigen fftw-devel gtkmm2-devel jack-devel
+hostmakedepends="gperf intltool pkg-config sassc which"
+makedepends="boost-devel eigen fftw-devel gtkmm-devel jack-devel
ladspa-sdk liblrdf-devel libsndfile-devel lilv-devel lv2 sratom-devel
zita-convolver-devel zita-resampler-devel
- $(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)"
+ $(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)
+ $(vopt_if faust faust)"
depends="desktop-file-utils"
short_desc="Virtual guitar amplifier running on Jack Audio Connection Kit"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://guitarix.org"
distfiles="${SOURCEFORGE_SITE}/guitarix/guitarix/guitarix2-${version}.tar.xz"
-checksum=490ff3f856282f776456b8e27366dd074d663870c0a89fccded03d854305c8da
+checksum=fb1b75b7ea9f140c2b2df50982e14616dcaffaf65425ca531fcf6f27dd956405
-build_options="avahi bluez"
+build_options="avahi bluez faust"
desc_option_avahi="Build with avahi support"
desc_option_bluez="Build with bluez support"
+desc_option_faust="Build with faust support"
CXXFLAGS="-fpermissive"
case "$XBPS_TARGET_MACHINE" in
- i686*|x86_64*) ;;
+ x86_64*) ;;
+ i686*) configure_args+=" --cxxflags=-mfxsr" ;;
*) configure_args+=" --disable-sse" ;;
esac
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
2020-12-25 11:02 ` [PR PATCH] [Updated] " DavideMaggio
@ 2020-12-26 5:04 ` ericonr
2020-12-26 8:01 ` [PR PATCH] [Updated] " DavideMaggio
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-12-26 5:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-751318734
Comment:
Looks good, thanks! Would you like to enable any of the options by default?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Updated] guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
2020-12-25 11:02 ` [PR PATCH] [Updated] " DavideMaggio
2020-12-26 5:04 ` ericonr
@ 2020-12-26 8:01 ` DavideMaggio
2020-12-26 8:47 ` DavideMaggio
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-26 8:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
There is an updated pull request by DavideMaggio against master on the void-packages repository
https://github.com/DavideMaggio/void-packages guitarix2-00
https://github.com/void-linux/void-packages/pull/27420
guitarix2: update to 0.42.0 + added 'faust' build option
#27251
A patch file from https://github.com/void-linux/void-packages/pull/27420.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guitarix2-00-27420.patch --]
[-- Type: text/x-diff, Size: 2414 bytes --]
From 1caa264e5ed65dbb8cf51a3351dcaace91e7c83f Mon Sep 17 00:00:00 2001
From: mag <mag-one@autistici.org>
Date: Thu, 24 Dec 2020 17:01:56 +0100
Subject: [PATCH] guitarix2: update to 0.42.0 + added 'faust' build option
---
srcpkgs/guitarix2/template | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/guitarix2/template b/srcpkgs/guitarix2/template
index 95c6253c8da..8b22358f2c1 100644
--- a/srcpkgs/guitarix2/template
+++ b/srcpkgs/guitarix2/template
@@ -1,33 +1,38 @@
# Template file for 'guitarix2'
pkgname=guitarix2
-version=0.39.0
+version=0.42.0
revision=1
wrksrc="guitarix-${version}"
build_style=waf3
-configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa --no-faust
- $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')"
+configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa
+ $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')
+ $(vopt_if faust '' '--no-faust')"
make_build_args="--progress"
-hostmakedepends="gperf intltool pkg-config"
-makedepends="boost-devel eigen fftw-devel gtkmm2-devel jack-devel
+hostmakedepends="gperf intltool pkg-config sassc which"
+makedepends="boost-devel eigen fftw-devel gtkmm-devel jack-devel
ladspa-sdk liblrdf-devel libsndfile-devel lilv-devel lv2 sratom-devel
zita-convolver-devel zita-resampler-devel
- $(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)"
+ $(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)
+ $(vopt_if faust faust)"
depends="desktop-file-utils"
short_desc="Virtual guitar amplifier running on Jack Audio Connection Kit"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://guitarix.org"
distfiles="${SOURCEFORGE_SITE}/guitarix/guitarix/guitarix2-${version}.tar.xz"
-checksum=490ff3f856282f776456b8e27366dd074d663870c0a89fccded03d854305c8da
+checksum=fb1b75b7ea9f140c2b2df50982e14616dcaffaf65425ca531fcf6f27dd956405
-build_options="avahi bluez"
+build_options="avahi bluez faust"
+build_options_default="faust"
desc_option_avahi="Build with avahi support"
desc_option_bluez="Build with bluez support"
+desc_option_faust="Build with faust support"
CXXFLAGS="-fpermissive"
case "$XBPS_TARGET_MACHINE" in
- i686*|x86_64*) ;;
+ x86_64*) ;;
+ i686*) configure_args+=" --cxxflags=-mfxsr" ;;
*) configure_args+=" --disable-sse" ;;
esac
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Updated] guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (2 preceding siblings ...)
2020-12-26 8:01 ` [PR PATCH] [Updated] " DavideMaggio
@ 2020-12-26 8:47 ` DavideMaggio
2020-12-26 9:49 ` DavideMaggio
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-26 8:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
There is an updated pull request by DavideMaggio against master on the void-packages repository
https://github.com/DavideMaggio/void-packages guitarix2-00
https://github.com/void-linux/void-packages/pull/27420
guitarix2: update to 0.42.0 + added 'faust' build option
#27251
A patch file from https://github.com/void-linux/void-packages/pull/27420.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guitarix2-00-27420.patch --]
[-- Type: text/x-diff, Size: 2244 bytes --]
From de0448b727dbe050bb28a4bbbbc431fd48a0f3c9 Mon Sep 17 00:00:00 2001
From: mag <mag-one@autistici.org>
Date: Thu, 24 Dec 2020 17:01:56 +0100
Subject: [PATCH] guitarix2: update to 0.42.0 + added 'faust' build option
---
srcpkgs/guitarix2/template | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/guitarix2/template b/srcpkgs/guitarix2/template
index 95c6253c8da..762c688e877 100644
--- a/srcpkgs/guitarix2/template
+++ b/srcpkgs/guitarix2/template
@@ -1,14 +1,15 @@
# Template file for 'guitarix2'
pkgname=guitarix2
-version=0.39.0
+version=0.42.0
revision=1
wrksrc="guitarix-${version}"
build_style=waf3
-configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa --no-faust
- $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')"
+configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa
+ $(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')
+ $(vopt_if faust '' '--no-faust')"
make_build_args="--progress"
-hostmakedepends="gperf intltool pkg-config"
-makedepends="boost-devel eigen fftw-devel gtkmm2-devel jack-devel
+hostmakedepends="gperf intltool pkg-config sassc which $(vopt_if faust faust)"
+makedepends="boost-devel eigen fftw-devel gtkmm-devel jack-devel
ladspa-sdk liblrdf-devel libsndfile-devel lilv-devel lv2 sratom-devel
zita-convolver-devel zita-resampler-devel
$(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)"
@@ -18,16 +19,19 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://guitarix.org"
distfiles="${SOURCEFORGE_SITE}/guitarix/guitarix/guitarix2-${version}.tar.xz"
-checksum=490ff3f856282f776456b8e27366dd074d663870c0a89fccded03d854305c8da
+checksum=fb1b75b7ea9f140c2b2df50982e14616dcaffaf65425ca531fcf6f27dd956405
-build_options="avahi bluez"
+build_options="avahi bluez faust"
+build_options_default="faust"
desc_option_avahi="Build with avahi support"
desc_option_bluez="Build with bluez support"
+desc_option_faust="Build with faust support"
CXXFLAGS="-fpermissive"
case "$XBPS_TARGET_MACHINE" in
- i686*|x86_64*) ;;
+ x86_64*) ;;
+ i686*) configure_args+=" --cxxflags=-mfxsr" ;;
*) configure_args+=" --disable-sse" ;;
esac
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (3 preceding siblings ...)
2020-12-26 8:47 ` DavideMaggio
@ 2020-12-26 9:49 ` DavideMaggio
2020-12-27 0:57 ` ericonr
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-26 9:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
New comment by DavideMaggio on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-751339718
Comment:
ok, added faust as a default build option but It didn't build on arm* anymore (/usr/bin/faust: not found.).
Solved by changing faust to be host-dependant (instead of target-dependant), that's correct?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (4 preceding siblings ...)
2020-12-26 9:49 ` DavideMaggio
@ 2020-12-27 0:57 ` ericonr
2020-12-29 17:29 ` DavideMaggio
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-12-27 0:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-751412541
Comment:
@DavideMaggio I was taking a look at how guitarix does its thing, it seems we shouldn't enable faust here.
They use it to generate a bunch of files, which are then post processed with some custom tools. Since they might have to fix those tools when using different faust versions, we risk breaking something by enabling faust. It's better to simply use their pre generated files directly, which is what we already do. From what I understand, guitarix doesn't use faust at runtime at all.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (5 preceding siblings ...)
2020-12-27 0:57 ` ericonr
@ 2020-12-29 17:29 ` DavideMaggio
2020-12-29 21:18 ` ericonr
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-29 17:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
New comment by DavideMaggio on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-752174031
Comment:
@ericonr I agree.
I think I could revert all the changes excluding 'version' and 'checksum' fields to at least save the update part.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (6 preceding siblings ...)
2020-12-29 17:29 ` DavideMaggio
@ 2020-12-29 21:18 ` ericonr
2020-12-31 8:09 ` [PR PATCH] [Updated] " DavideMaggio
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-12-29 21:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-752244074
Comment:
Sure :)
I would definitely like to merge the update.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Updated] guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (7 preceding siblings ...)
2020-12-29 21:18 ` ericonr
@ 2020-12-31 8:09 ` DavideMaggio
2021-01-02 2:41 ` ericonr
2021-01-02 2:41 ` [PR PATCH] [Merged]: " ericonr
10 siblings, 0 replies; 12+ messages in thread
From: DavideMaggio @ 2020-12-31 8:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
There is an updated pull request by DavideMaggio against master on the void-packages repository
https://github.com/DavideMaggio/void-packages guitarix2-00
https://github.com/void-linux/void-packages/pull/27420
guitarix2: update to 0.42.0 + added 'faust' build option
#27251
A patch file from https://github.com/void-linux/void-packages/pull/27420.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guitarix2-00-27420.patch --]
[-- Type: text/x-diff, Size: 1906 bytes --]
From 152c0fdc7b741d28c8370917030449a95a0ebaf6 Mon Sep 17 00:00:00 2001
From: mag <mag-one@autistici.org>
Date: Thu, 24 Dec 2020 17:01:56 +0100
Subject: [PATCH] guitarix2: update to 0.42.0
---
srcpkgs/guitarix2/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/guitarix2/template b/srcpkgs/guitarix2/template
index 95c6253c8da..3aabb9c8ff9 100644
--- a/srcpkgs/guitarix2/template
+++ b/srcpkgs/guitarix2/template
@@ -1,14 +1,14 @@
# Template file for 'guitarix2'
pkgname=guitarix2
-version=0.39.0
+version=0.42.0
revision=1
wrksrc="guitarix-${version}"
build_style=waf3
configure_args="--cxxflags-release=-DNDEBUG --ladspa --new-ladspa --no-faust
$(vopt_if avahi '' '--no-avahi') $(vopt_if bluez '' '--no-bluez')"
make_build_args="--progress"
-hostmakedepends="gperf intltool pkg-config"
-makedepends="boost-devel eigen fftw-devel gtkmm2-devel jack-devel
+hostmakedepends="gperf intltool pkg-config sassc"
+makedepends="boost-devel eigen fftw-devel gtkmm-devel jack-devel
ladspa-sdk liblrdf-devel libsndfile-devel lilv-devel lv2 sratom-devel
zita-convolver-devel zita-resampler-devel
$(vopt_if avahi avahi-glib-libs-devel) $(vopt_if bluez libbluetooth-devel)"
@@ -18,7 +18,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="http://guitarix.org"
distfiles="${SOURCEFORGE_SITE}/guitarix/guitarix/guitarix2-${version}.tar.xz"
-checksum=490ff3f856282f776456b8e27366dd074d663870c0a89fccded03d854305c8da
+checksum=fb1b75b7ea9f140c2b2df50982e14616dcaffaf65425ca531fcf6f27dd956405
build_options="avahi bluez"
desc_option_avahi="Build with avahi support"
@@ -27,7 +27,8 @@ desc_option_bluez="Build with bluez support"
CXXFLAGS="-fpermissive"
case "$XBPS_TARGET_MACHINE" in
- i686*|x86_64*) ;;
+ x86_64*) ;;
+ i686*) configure_args+=" --cxxflags=-mfxsr" ;;
*) configure_args+=" --disable-sse" ;;
esac
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (8 preceding siblings ...)
2020-12-31 8:09 ` [PR PATCH] [Updated] " DavideMaggio
@ 2021-01-02 2:41 ` ericonr
2021-01-02 2:41 ` [PR PATCH] [Merged]: " ericonr
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-01-02 2:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-753420419
Comment:
Please ping me when done with changes, otherwise I can miss them :P
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Merged]: guitarix2: update to 0.42.0 + added 'faust' build option
2020-12-25 9:42 [PR PATCH] guitarix2: update to 0.42.0 + added 'faust' build option DavideMaggio
` (9 preceding siblings ...)
2021-01-02 2:41 ` ericonr
@ 2021-01-02 2:41 ` ericonr
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-01-02 2:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
There's a merged pull request on the void-packages repository
guitarix2: update to 0.42.0 + added 'faust' build option
https://github.com/void-linux/void-packages/pull/27420
Description:
#27251
^ permalink raw reply [flat|nested] 12+ messages in thread