* [PR PATCH] Mediainfo
@ 2021-01-14 20:55 gspe
2021-01-14 20:59 ` Mediainfo q66
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: gspe @ 2021-01-14 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
There is a new pull request by gspe against master on the void-packages repository
https://github.com/gspe/void-packages mediainfo
https://github.com/void-linux/void-packages/pull/27936
Mediainfo
This fix a thread safety problem present in `libzen`
https://github.com/sbraz/pymediainfo/issues/105
https://github.com/MediaArea/ZenLib/commit/70868fe21d8c58373389dd318a76695136580a4b
A patch file from https://github.com/void-linux/void-packages/pull/27936.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mediainfo-27936.patch --]
[-- Type: text/x-diff, Size: 3232 bytes --]
From a1fdbf1a8aaa75cb30308d42c01632c364feaf73 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Thu, 14 Jan 2021 21:48:51 +0100
Subject: [PATCH 1/4] libzen: upgrade to 0.4.38
This version solve thread safety problem
https://github.com/sbraz/pymediainfo/issues/105
---
srcpkgs/libzen/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libzen/template b/srcpkgs/libzen/template
index 9294962da97..5c4472c857a 100644
--- a/srcpkgs/libzen/template
+++ b/srcpkgs/libzen/template
@@ -1,14 +1,14 @@
# Template build file for 'libzen'.
pkgname=libzen
-version=0.4.37
-revision=2
+version=0.4.38
+revision=1
short_desc="Shared library for libmediainfo and mediainfo"
homepage="http://mediaarea.net/MediaInfo"
maintainer="Georg Schabel <gescha@posteo.de>"
license="zlib"
distfiles="https://mediaarea.net/download/source/${pkgname}/${version}/${pkgname}_${version}.tar.gz"
-checksum=8c4323bd3f1a286a565b634cb00c9877922296679f49ac55b05f7c6e56d77c43
+checksum=ad98fccec235ed76a40e7da8856f0bcc9c8d07cafe4c3ce30c47407760add786
build_style=gnu-configure
hostmakedepends="automake libtool pkg-config"
From d3316b8c4ac1a2e640c865e6cd6368b614830f04 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Thu, 14 Jan 2021 21:50:26 +0100
Subject: [PATCH 2/4] libmediainfo: revbump for libzen
---
srcpkgs/libmediainfo/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/libmediainfo/template b/srcpkgs/libmediainfo/template
index c0a2eebed2d..46195f09717 100644
--- a/srcpkgs/libmediainfo/template
+++ b/srcpkgs/libmediainfo/template
@@ -1,7 +1,7 @@
# Template file for 'libmediainfo'
pkgname=libmediainfo
version=20.09
-revision=1
+revision=2
_tests_commit=983666091bee260198d8426e2045f1aca85e5e2f
wrksrc=MediaInfoLib
build_wrksrc=Project/GNU/Library
From dc7b7cbcae27287b4c57487dfd414a9708692486 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Thu, 14 Jan 2021 21:51:38 +0100
Subject: [PATCH 3/4] mediainfo: revbump for libzen
---
srcpkgs/mediainfo/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/mediainfo/template b/srcpkgs/mediainfo/template
index 03e2e46b90b..845e7b33717 100644
--- a/srcpkgs/mediainfo/template
+++ b/srcpkgs/mediainfo/template
@@ -1,7 +1,7 @@
# Template file for 'mediainfo'
pkgname=mediainfo
version=20.09
-revision=1
+revision=2
wrksrc=MediaInfo
configure_args="--with-wx-config=wx-config-gtk3"
hostmakedepends="automake libtool pkg-config"
From dc9353bf789d1dd445a8804b45f95fe6eff8016b Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Thu, 14 Jan 2021 21:52:01 +0100
Subject: [PATCH 4/4] MEGAsdk: revbump for libzen
---
srcpkgs/MEGAsdk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/MEGAsdk/template b/srcpkgs/MEGAsdk/template
index 0cb3b292064..09b891189f2 100644
--- a/srcpkgs/MEGAsdk/template
+++ b/srcpkgs/MEGAsdk/template
@@ -1,7 +1,7 @@
# Template file for 'MEGAsdk'
pkgname=MEGAsdk
version=3.7.3c
-revision=1
+revision=2
wrksrc="sdk-${version}"
build_style=gnu-configure
configure_args="--enable-chat --disable-examples $(vopt_with libuv)"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
@ 2021-01-14 20:59 ` q66
2021-01-14 21:19 ` Mediainfo ericonr
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: q66 @ 2021-01-14 20:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760472338
Comment:
remove the revbumps
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
2021-01-14 20:59 ` Mediainfo q66
@ 2021-01-14 21:19 ` ericonr
2021-01-14 21:21 ` Mediainfo ericonr
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760482651
Comment:
Their fix doesn't work...
```
~ ➜ xbps-query -o /usr/lib/libzen.so.0
libzen-0.4.38_1: /usr/lib/libzen.so.0 -> /usr/lib/libzen.so.0.0.0 (link)
~ ➜ nm -D /usr/lib/libzen.so.0 | grep gmtime
U gmtime
```
The library is still using `gmtime`, not `gmtime_r`.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
2021-01-14 20:59 ` Mediainfo q66
2021-01-14 21:19 ` Mediainfo ericonr
@ 2021-01-14 21:21 ` ericonr
2021-01-14 21:21 ` Mediainfo ericonr
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760483854
Comment:
They should have `#define _POSIX_C_SOURCE` at the top of the file and before any `#include`, so `gmtime_r` would be exposed. Keeping their `#ifdef` forest would still work, I guess, but isn't really necessary.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (2 preceding siblings ...)
2021-01-14 21:21 ` Mediainfo ericonr
@ 2021-01-14 21:21 ` ericonr
2021-01-14 21:33 ` Mediainfo ericonr
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760483854
Comment:
They should have `#define _POSIX_C_SOURCE` at the top of the file and before any `#include`, so `gmtime_r` would be exposed. Keeping their `#ifdef` forest would still work, I guess, but isn't really necessary. <-- this is a suggestion for a patch you should add
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (3 preceding siblings ...)
2021-01-14 21:21 ` Mediainfo ericonr
@ 2021-01-14 21:33 ` ericonr
2021-01-14 21:42 ` Mediainfo ericonr
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760490117
Comment:
Ok, this probably worked for you on glibc. Since this is C++, what happens (on Linux) is that `_GNU_SOURCE` is defined. On glibc, this means a bunch of other macros (including some which that ifdef forest tests for) are defined. On musl, `_GNU_SOURCE` being defined just stays that way, so none of the macros expected by the ifdefs are there, and it ends up using `gmtime`. The patch suggestion above should fix it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (4 preceding siblings ...)
2021-01-14 21:33 ` Mediainfo ericonr
@ 2021-01-14 21:42 ` ericonr
2021-01-14 21:42 ` Mediainfo ericonr
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760490117
Comment:
Ok, this probably worked for you on glibc. Since this is C++, what happens (on Linux, with pibstdc++) is that `_GNU_SOURCE` is defined. On glibc, this means a bunch of other macros (including some which that ifdef forest tests for) are defined. On musl, `_GNU_SOURCE` being defined just stays that way, so none of the macros expected by the ifdefs are there, and it ends up using `gmtime`. The patch suggestion above should fix it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (5 preceding siblings ...)
2021-01-14 21:42 ` Mediainfo ericonr
@ 2021-01-14 21:42 ` ericonr
2021-01-14 21:43 ` Mediainfo ericonr
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760490117
Comment:
Ok, this probably worked for you on glibc. Since this is C++, what happens (on Linux, with libstdc++) is that `_GNU_SOURCE` is defined. On glibc, this means a bunch of other macros (including some which that ifdef forest tests for) are defined. On musl, `_GNU_SOURCE` being defined just stays that way, so none of the macros expected by the ifdefs are there, and it ends up using `gmtime`. The patch suggestion above should fix it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (6 preceding siblings ...)
2021-01-14 21:42 ` Mediainfo ericonr
@ 2021-01-14 21:43 ` ericonr
2021-01-15 8:05 ` [PR PATCH] [Updated] Mediainfo gspe
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-14 21:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-760490117
Comment:
Ok, this probably worked for you on glibc. Since this is C++, what happens (on Linux, with libstdc++) is that `_GNU_SOURCE` is defined. On glibc, this means a bunch of other macros (including some which that ifdef forest tests for) are defined. On musl, `_GNU_SOURCE` being defined just stays that way, and doesn't define anything else, so none of the macros expected by the ifdefs are there, and it ends up using `gmtime`. The patch suggestion above should fix it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (7 preceding siblings ...)
2021-01-14 21:43 ` Mediainfo ericonr
@ 2021-01-15 8:05 ` gspe
2021-01-26 3:05 ` Mediainfo ericonr
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: gspe @ 2021-01-15 8:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
There is an updated pull request by gspe against master on the void-packages repository
https://github.com/gspe/void-packages mediainfo
https://github.com/void-linux/void-packages/pull/27936
Mediainfo
This fix a thread safety problem present in `libzen`
https://github.com/sbraz/pymediainfo/issues/105
https://github.com/MediaArea/ZenLib/commit/70868fe21d8c58373389dd318a76695136580a4b
A patch file from https://github.com/void-linux/void-packages/pull/27936.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mediainfo-27936.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]
From a1fdbf1a8aaa75cb30308d42c01632c364feaf73 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Thu, 14 Jan 2021 21:48:51 +0100
Subject: [PATCH] libzen: upgrade to 0.4.38
This version solve thread safety problem
https://github.com/sbraz/pymediainfo/issues/105
---
srcpkgs/libzen/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libzen/template b/srcpkgs/libzen/template
index 9294962da97..5c4472c857a 100644
--- a/srcpkgs/libzen/template
+++ b/srcpkgs/libzen/template
@@ -1,14 +1,14 @@
# Template build file for 'libzen'.
pkgname=libzen
-version=0.4.37
-revision=2
+version=0.4.38
+revision=1
short_desc="Shared library for libmediainfo and mediainfo"
homepage="http://mediaarea.net/MediaInfo"
maintainer="Georg Schabel <gescha@posteo.de>"
license="zlib"
distfiles="https://mediaarea.net/download/source/${pkgname}/${version}/${pkgname}_${version}.tar.gz"
-checksum=8c4323bd3f1a286a565b634cb00c9877922296679f49ac55b05f7c6e56d77c43
+checksum=ad98fccec235ed76a40e7da8856f0bcc9c8d07cafe4c3ce30c47407760add786
build_style=gnu-configure
hostmakedepends="automake libtool pkg-config"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (8 preceding siblings ...)
2021-01-15 8:05 ` [PR PATCH] [Updated] Mediainfo gspe
@ 2021-01-26 3:05 ` ericonr
2021-01-27 21:39 ` Mediainfo JeromeMartinez
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-26 3:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-767258009
Comment:
Ping
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (9 preceding siblings ...)
2021-01-26 3:05 ` Mediainfo ericonr
@ 2021-01-27 21:39 ` JeromeMartinez
2021-01-27 22:25 ` Mediainfo ericonr
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JeromeMartinez @ 2021-01-27 21:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
New comment by JeromeMartinez on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-768594473
Comment:
> They should have #define _POSIX_C_SOURCE at the top of the file and before any #include
IIUC doing that will make `gmtime_r` available in your case but will at the same time create issues on platforms not having `gmtime_r`, something we are actually trying to avoid.
We would like to have a method which is fine for you but at the same time fine for platforms not having `gmtime_r` (and also as multithread is not always used, if we can avoid a mutex... I am aware that it is a lot of conditions).
Checking autoconf, looks like there is a posibility to do:
AC_CHECK_FUNCS([gmtime_r])
in configure.ac
then adding `#ifdef HAVE_GMTIME_R >=1` in the test should work.
If you are able to test it, I am fine for adding it in the upstream source code.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (10 preceding siblings ...)
2021-01-27 21:39 ` Mediainfo JeromeMartinez
@ 2021-01-27 22:25 ` ericonr
2021-01-27 22:56 ` Mediainfo ericonr
2021-02-15 3:47 ` [PR PATCH] [Closed]: Mediainfo ericonr
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-27 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-768619214
Comment:
> We would like to have a method which is fine for you but at the same time fine for platforms not having gmtime_r (and also as multithread is not always used, if we can avoid a mutex... I am aware that it is a lot of conditions).
It would be pretty complicated (and error prone) to build one version of the library for the MT or not case, so always using `gmtime_r` is the least bad alternative. It also shouldn't use a mutex, since the second argument allows it to simply not use any globals.
> IIUC doing that will make gmtime_r available in your case but will at the same time create issues on platforms not having gmtime_r, something we are actually trying to avoid.
Do you know of any platforms that don't have it, besides Windows? (For which you already have an ifdef block).
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (11 preceding siblings ...)
2021-01-27 22:25 ` Mediainfo ericonr
@ 2021-01-27 22:56 ` ericonr
2021-02-15 3:47 ` [PR PATCH] [Closed]: Mediainfo ericonr
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-27 22:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-768633221
Comment:
Anyway, https://github.com/MediaArea/ZenLib/pull/126
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Closed]: Mediainfo
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
` (12 preceding siblings ...)
2021-01-27 22:56 ` Mediainfo ericonr
@ 2021-02-15 3:47 ` ericonr
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-02-15 3:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
There's a closed pull request on the void-packages repository
Mediainfo
https://github.com/void-linux/void-packages/pull/27936
Description:
This fix a thread safety problem present in `libzen`
https://github.com/sbraz/pymediainfo/issues/105
https://github.com/MediaArea/ZenLib/commit/70868fe21d8c58373389dd318a76695136580a4b
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-02-15 3:47 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
2021-01-14 20:59 ` Mediainfo q66
2021-01-14 21:19 ` Mediainfo ericonr
2021-01-14 21:21 ` Mediainfo ericonr
2021-01-14 21:21 ` Mediainfo ericonr
2021-01-14 21:33 ` Mediainfo ericonr
2021-01-14 21:42 ` Mediainfo ericonr
2021-01-14 21:42 ` Mediainfo ericonr
2021-01-14 21:43 ` Mediainfo ericonr
2021-01-15 8:05 ` [PR PATCH] [Updated] Mediainfo gspe
2021-01-26 3:05 ` Mediainfo ericonr
2021-01-27 21:39 ` Mediainfo JeromeMartinez
2021-01-27 22:25 ` Mediainfo ericonr
2021-01-27 22:56 ` Mediainfo ericonr
2021-02-15 3:47 ` [PR PATCH] [Closed]: Mediainfo ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).