[PR PATCH] nginx: build with http_slice_module

[PR PATCH] nginx: build with http_slice_module

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

There is a new pull request by AluminumTank against master on the void-packages repository

https://github.com/AluminumTank/void-packages nginx
https://github.com/void-linux/void-packages/pull/27662

nginx: build with http_slice_module
Add support for slicing. Runtime tested on my server, and builds for armv7l as well.

A patch file from https://github.com/void-linux/void-packages/pull/27662.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-27662.patch --]
[-- Type: text/x-diff, Size: 1351 bytes --]

From 33844b990899a14cd0d59559a73e9811c64cbdf3 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@thebeckmeyers.xyz>
Date: Mon, 4 Jan 2021 12:02:45 -0500
Subject: [PATCH] nginx: build with http_slice_module

---
 srcpkgs/nginx/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index e05fae00b8d..e1aec482739 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -2,7 +2,7 @@
 pkgname=nginx
 reverts="1.17.7_1"
 version=1.18.0
-revision=2
+revision=3
 build_style=gnu-makefile
 hostmakedepends="libressl-devel pcre-devel $(vopt_if geoip geoip-devel)"
 makedepends="${hostmakedepends}"
@@ -32,9 +32,10 @@ make_dirs="/var/log/nginx 0750 root root
  /var/tmp 1777 root root
  /var/tmp/nginx 0750 nginx root"
 
-build_options="geoip stream"
+build_options="geoip stream slice"
 desc_option_stream="Enable support for stream proxies"
-build_options_default="geoip stream"
+desc_option_slice="Enable support for slice filters"
+build_options_default="geoip stream slice"
 
 do_configure() {
 	local cfgdir=/etc/nginx
@@ -76,6 +77,7 @@ do_configure() {
 		--with-http_ssl_module \
 		--with-http_stub_status_module \
 		--with-http_sub_module \
+		--with-http_slice_module \
 		$(vopt_if geoip --with-http_geoip_module) \
 		$(vopt_if stream "$stream_modules")
 }

Re: [PR REVIEW] nginx: build with http_slice_module

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27662#discussion_r551468594

Comment:
Could you remove this reverts line as well, please?

Re: [PR PATCH] [Updated] nginx: build with http_slice_module

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

There is an updated pull request by AluminumTank against master on the void-packages repository

https://github.com/AluminumTank/void-packages nginx
https://github.com/void-linux/void-packages/pull/27662

nginx: build with http_slice_module
Add support for slicing. Runtime tested on my server, and builds for armv7l as well.

A patch file from https://github.com/void-linux/void-packages/pull/27662.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-27662.patch --]
[-- Type: text/x-diff, Size: 1381 bytes --]

From 72692a8cd1e8dc70fe6f1642a834916afe23761f Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@thebeckmeyers.xyz>
Date: Mon, 4 Jan 2021 12:02:45 -0500
Subject: [PATCH] nginx: build with http_slice_module

---
 srcpkgs/nginx/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index e05fae00b8d..269d68013db 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -1,8 +1,7 @@
 # Template file for 'nginx'
 pkgname=nginx
-reverts="1.17.7_1"
 version=1.18.0
-revision=2
+revision=3
 build_style=gnu-makefile
 hostmakedepends="libressl-devel pcre-devel $(vopt_if geoip geoip-devel)"
 makedepends="${hostmakedepends}"
@@ -32,9 +31,10 @@ make_dirs="/var/log/nginx 0750 root root
  /var/tmp 1777 root root
  /var/tmp/nginx 0750 nginx root"
 
-build_options="geoip stream"
+build_options="geoip stream slice"
 desc_option_stream="Enable support for stream proxies"
-build_options_default="geoip stream"
+desc_option_slice="Enable support for slice filters"
+build_options_default="geoip stream slice"
 
 do_configure() {
 	local cfgdir=/etc/nginx
@@ -76,6 +76,7 @@ do_configure() {
 		--with-http_ssl_module \
 		--with-http_stub_status_module \
 		--with-http_sub_module \
+		--with-http_slice_module \
 		$(vopt_if geoip --with-http_geoip_module) \
 		$(vopt_if stream "$stream_modules")
 }

Re: nginx: build with http_slice_module

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/27662#issuecomment-754172251

Comment:
You added a build option, but the option is not used.

Re: [PR PATCH] [Updated] nginx: build with http_slice_module

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

There is an updated pull request by AluminumTank against master on the void-packages repository

https://github.com/AluminumTank/void-packages nginx
https://github.com/void-linux/void-packages/pull/27662

nginx: build with http_slice_module
Add support for slicing. Runtime tested on my server, and builds for armv7l as well.

A patch file from https://github.com/void-linux/void-packages/pull/27662.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-27662.patch --]
[-- Type: text/x-diff, Size: 1432 bytes --]

From efaba9f48fef099f4a184b057a70dbddf2821b64 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@thebeckmeyers.xyz>
Date: Mon, 4 Jan 2021 12:02:45 -0500
Subject: [PATCH] nginx: build with http_slice_module

---
 srcpkgs/nginx/template | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index e05fae00b8d..14dd2dec287 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -1,8 +1,7 @@
 # Template file for 'nginx'
 pkgname=nginx
-reverts="1.17.7_1"
 version=1.18.0
-revision=2
+revision=3
 build_style=gnu-makefile
 hostmakedepends="libressl-devel pcre-devel $(vopt_if geoip geoip-devel)"
 makedepends="${hostmakedepends}"
@@ -32,9 +31,10 @@ make_dirs="/var/log/nginx 0750 root root
  /var/tmp 1777 root root
  /var/tmp/nginx 0750 nginx root"
 
-build_options="geoip stream"
+build_options="geoip stream slice"
 desc_option_stream="Enable support for stream proxies"
-build_options_default="geoip stream"
+desc_option_slice="Enable support for slice filters"
+build_options_default="geoip stream slice"
 
 do_configure() {
 	local cfgdir=/etc/nginx
@@ -77,7 +77,9 @@ do_configure() {
 		--with-http_stub_status_module \
 		--with-http_sub_module \
 		$(vopt_if geoip --with-http_geoip_module) \
-		$(vopt_if stream "$stream_modules")
+		$(vopt_if stream "$stream_modules") \
+		$(vopt_if slice --with-http_slice_module)
+
 }
 
 pre_build() {

Re: nginx: build with http_slice_module

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/27662#issuecomment-754661853

Comment:
I don't think that just because the documentation says it doesn't build by default, we shouldn't have it in our build.

A good example of this is the [SSL module](http://nginx.org/en/docs/http/ngx_http_ssl_module.html), which is not included in the default build. Should Void not include SSL either since it's not default? 

For reference, one of my nginx server blocks uses slice, which is why I'm here. Anecdotally, the build instructions for the package providing this server block config didn't even mention that nginx needs to be built with slice support, so the status quo is that this is a "default" module.

There is likely no easy way to get slice (or other module) support without manually recompiling. The only way I saw was to use dynamic modules, but this requires grabbing the source code for the version of nginx currently on your machine, compiling the modules as dynamic objects, and adding them into the nginx config. This would cause breakage or additional work when the nginx version that Void distributes gets bumped.

Other distributions include this module in their builds as well (I just looked at the PKGBUILD for Arch and ebuild for Gentoo). 

The other option is to package the modules separately as dynamic modules as mentioned above, which I'd be happy to do if this is a better solution.

Re: nginx: build with http_slice_module

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27662#issuecomment-765114679

Comment:
@AluminumTank that would be a big reworking of the nginx package, so perhaps better left to a separate PR.

@the-maldridge ok to merge?

Re: [PR PATCH] [Merged]: nginx: build with http_slice_module

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

There's a merged pull request on the void-packages repository

nginx: build with http_slice_module
https://github.com/void-linux/void-packages/pull/27662

Description:
Add support for slicing. Runtime tested on my server, and builds for armv7l as well.