* [PR PATCH] Ghc build for aarch64, aarch64-musl
@ 2020-05-30 10:30 gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: gogabr @ 2020-05-30 10:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
There is a new pull request by gogabr against master on the void-packages repository
https://github.com/gogabr/void-packages ghc-build
https://github.com/void-linux/void-packages/pull/22426
Ghc build for aarch64, aarch64-musl
aarch64 binaries should probably be moved to a more appropriate place.
A patch file from https://github.com/void-linux/void-packages/pull/22426.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ghc-build-22426.patch --]
[-- Type: text/x-diff, Size: 2890 bytes --]
From dd86f796128905f199997f3127212d0c1014d9ec Mon Sep 17 00:00:00 2001
From: George Bronnikov <yura.bronnikov@gmail.com>
Date: Sat, 30 May 2020 12:53:02 +0300
Subject: [PATCH 1/2] ghc-bin: add aarch64, aarch64-musl binaries
---
srcpkgs/ghc-bin/template | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/ghc-bin/template b/srcpkgs/ghc-bin/template
index f3820a0ac37..8e5e872962b 100644
--- a/srcpkgs/ghc-bin/template
+++ b/srcpkgs/ghc-bin/template
@@ -1,8 +1,8 @@
# Template file for 'ghc-bin'
pkgname=ghc-bin
version=8.8.3
-revision=1
-archs="i686 x86_64* ppc64le"
+revision=2
+archs="i686 x86_64* ppc64le aarch64*"
wrksrc="ghc-${version%[!0-9]}"
hostmakedepends="ncurses perl libffi libnuma"
depends="ncurses perl gcc libffi-devel gmp-devel"
@@ -31,6 +31,18 @@ ppc64le)
distfiles="https://alpha.de.repo.voidlinux.org/distfiles/ghc-${version}-powerpc64le-void-linux.tar.xz"
checksum=0c8df56aa0177459894ba53375115ab76f8eed9f4b1018fae5c332bcc6b79cb4
;;
+aarch64)
+ # create with "make binary-dist"
+ depends+=" llvm"
+ distfiles="https://newstar.rinet.ru/~goga/void/ghc-${version}-aarch64-void-linux-glibc.tar.xz"
+ checksum=46bfdee5add70079c5700791aaddd958bf8630b7dad19aa09e79a612fe399c99
+ ;;
+aarch64-musl)
+ # create with "make binary-dist"
+ depends+=" llvm"
+ distfiles="https://newstar.rinet.ru/~goga/void/ghc-${version}-aarch64-void-linux-musl.tar.xz"
+ checksum=114ea7ddddec0b2fda06c2dbaff2cb1149b850ac17e052e5f5cb848297b06ed7
+ ;;
esac
do_configure() {
From cc42856be6e460015dd9dcf6ccb8e91bd1e1900c Mon Sep 17 00:00:00 2001
From: George Bronnikov <yura.bronnikov@gmail.com>
Date: Sat, 30 May 2020 12:53:28 +0300
Subject: [PATCH 2/2] ghc: build for aarch64, aarch64-musl
---
srcpkgs/ghc/template | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/ghc/template b/srcpkgs/ghc/template
index 12a1a8235db..68ad433518a 100644
--- a/srcpkgs/ghc/template
+++ b/srcpkgs/ghc/template
@@ -2,7 +2,7 @@
pkgname=ghc
# Keep this synchronized with http://www.stackage.org/lts
version=8.8.3
-revision=1
+revision=2
wrksrc="ghc-${version%[!0-9]}"
build_style=gnu-configure
configure_args="--with-system-libffi"
@@ -39,6 +39,19 @@ desc_option_bindist="Create a binary distribution"
# GHC's bundled tarball is from 2017, buggy on some archs
_ffi_rev=4d6d2866ae43e55325e8ee96561221804602cd7a
+case "$XBPS_TARGET_MACHINE" in
+aarch64)
+ hostmakedepends+=" llvm"
+ depends+=" llvm"
+ ;;
+aarch64-musl)
+ # does not work with gold
+ configure_args+=" --disable-ld-override"
+ hostmakedepends+=" llvm"
+ depends+=" llvm"
+ ;;
+esac
+
if [ "$build_option_bindist" ]; then
# Strip --with-system-libffi from configuration
configure_args=${configure_args/--with-system-libffi/}
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
@ 2021-01-29 0:50 ` ericonr
2021-01-29 0:50 ` ericonr
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506120
Comment:
This should probably be added for all archs unconditionally.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
@ 2021-01-29 0:50 ` ericonr
2021-01-29 0:50 ` ericonr
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506536
Comment:
```suggestion
configure_args+=" --disable-ld-override"
case "$XBPS_TARGET_MACHINE" in
aarch64*)
hostmakedepends+=" llvm"
depends+=" llvm"
;;
esac
```
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
2021-01-29 0:50 ` ericonr
@ 2021-01-29 0:50 ` ericonr
2021-02-01 6:31 ` gogabr
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506748
Comment:
Why does only aarch64 require llvm? Could it be made to work with llvm for other targets?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (2 preceding siblings ...)
2021-01-29 0:50 ` ericonr
@ 2021-02-01 6:31 ` gogabr
2021-02-01 6:33 ` gogabr
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-02-01 6:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567589719
Comment:
Gold is supposed to be faster, so if it works on other architectures, why disable it?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (3 preceding siblings ...)
2021-02-01 6:31 ` gogabr
@ 2021-02-01 6:33 ` gogabr
2021-02-01 12:55 ` ericonr
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-02-01 6:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
New review comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567590282
Comment:
Other targets have a native backend, which is way faster than llvm. (Rebuilding ghc takes almost 24 hours on my pinebook.)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (4 preceding siblings ...)
2021-02-01 6:33 ` gogabr
@ 2021-02-01 12:55 ` ericonr
2021-02-01 12:55 ` ericonr
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567803128
Comment:
I think the comment has the wrong indentation.
And yes, I think moving the manual bindists elsewhere would be best. Perhaps do like @q66 and ask to include in distfiles.voidlinux.org?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (5 preceding siblings ...)
2021-02-01 12:55 ` ericonr
@ 2021-02-01 12:55 ` ericonr
2021-02-01 12:57 ` ericonr
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567802379
Comment:
No need to revbump, it will try to build it if the package isn't available for the specific arch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (6 preceding siblings ...)
2021-02-01 12:55 ` ericonr
@ 2021-02-01 12:57 ` ericonr
2021-07-20 19:46 ` ericonr
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567804140
Comment:
While faster, the code base bitrots a bit more with every binutils release and has multiple issues with musl/archs other than x86_64.
We have disabled gold almost everywhere, including chromium.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (7 preceding siblings ...)
2021-02-01 12:57 ` ericonr
@ 2021-07-20 19:46 ` ericonr
2021-07-20 21:01 ` gogabr
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-07-20 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-883649222
Comment:
Ping?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (8 preceding siblings ...)
2021-07-20 19:46 ` ericonr
@ 2021-07-20 21:01 ` gogabr
2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-07-20 21:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
New comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-883705553
Comment:
> Ping?
Sorry, at the time I stopped short of rebuilding both musl and glibc versions, since every recompile took close to 24 hours on my Pinebook Pro.
I need to redo it again, probably making it cross-compile, but I know I won't have time for at least two or three nearest weeks.
Thanks for pinging!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (9 preceding siblings ...)
2021-07-20 21:01 ` gogabr
@ 2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-04-16 2:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-1100506778
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (10 preceding siblings ...)
2022-04-16 2:02 ` github-actions
@ 2022-04-30 2:13 ` github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-04-30 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
There's a closed pull request on the void-packages repository
Ghc build for aarch64, aarch64-musl
https://github.com/void-linux/void-packages/pull/22426
Description:
aarch64 binaries should probably be moved to a more appropriate place.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-04-30 2:13 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
2021-01-29 0:50 ` ericonr
2021-01-29 0:50 ` ericonr
2021-02-01 6:31 ` gogabr
2021-02-01 6:33 ` gogabr
2021-02-01 12:55 ` ericonr
2021-02-01 12:55 ` ericonr
2021-02-01 12:57 ` ericonr
2021-07-20 19:46 ` ericonr
2021-07-20 21:01 ` gogabr
2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).