* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
@ 2021-01-29 0:50 ` ericonr
2021-01-29 0:50 ` ericonr
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506120
Comment:
This should probably be added for all archs unconditionally.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
@ 2021-01-29 0:50 ` ericonr
2021-01-29 0:50 ` ericonr
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506748
Comment:
Why does only aarch64 require llvm? Could it be made to work with llvm for other targets?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
2021-01-29 0:50 ` [PR REVIEW] " ericonr
2021-01-29 0:50 ` ericonr
@ 2021-01-29 0:50 ` ericonr
2021-02-01 6:31 ` gogabr
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-29 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r566506536
Comment:
```suggestion
configure_args+=" --disable-ld-override"
case "$XBPS_TARGET_MACHINE" in
aarch64*)
hostmakedepends+=" llvm"
depends+=" llvm"
;;
esac
```
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (2 preceding siblings ...)
2021-01-29 0:50 ` ericonr
@ 2021-02-01 6:31 ` gogabr
2021-02-01 6:33 ` gogabr
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-02-01 6:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567589719
Comment:
Gold is supposed to be faster, so if it works on other architectures, why disable it?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (3 preceding siblings ...)
2021-02-01 6:31 ` gogabr
@ 2021-02-01 6:33 ` gogabr
2021-02-01 12:55 ` ericonr
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-02-01 6:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
New review comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567590282
Comment:
Other targets have a native backend, which is way faster than llvm. (Rebuilding ghc takes almost 24 hours on my pinebook.)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (4 preceding siblings ...)
2021-02-01 6:33 ` gogabr
@ 2021-02-01 12:55 ` ericonr
2021-02-01 12:55 ` ericonr
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567803128
Comment:
I think the comment has the wrong indentation.
And yes, I think moving the manual bindists elsewhere would be best. Perhaps do like @q66 and ask to include in distfiles.voidlinux.org?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (5 preceding siblings ...)
2021-02-01 12:55 ` ericonr
@ 2021-02-01 12:55 ` ericonr
2021-02-01 12:57 ` ericonr
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567802379
Comment:
No need to revbump, it will try to build it if the package isn't available for the specific arch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (6 preceding siblings ...)
2021-02-01 12:55 ` ericonr
@ 2021-02-01 12:57 ` ericonr
2021-07-20 19:46 ` ericonr
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-02-01 12:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#discussion_r567804140
Comment:
While faster, the code base bitrots a bit more with every binutils release and has multiple issues with musl/archs other than x86_64.
We have disabled gold almost everywhere, including chromium.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (7 preceding siblings ...)
2021-02-01 12:57 ` ericonr
@ 2021-07-20 19:46 ` ericonr
2021-07-20 21:01 ` gogabr
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-07-20 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-883649222
Comment:
Ping?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (8 preceding siblings ...)
2021-07-20 19:46 ` ericonr
@ 2021-07-20 21:01 ` gogabr
2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: gogabr @ 2021-07-20 21:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
New comment by gogabr on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-883705553
Comment:
> Ping?
Sorry, at the time I stopped short of rebuilding both musl and glibc versions, since every recompile took close to 24 hours on my Pinebook Pro.
I need to redo it again, probably making it cross-compile, but I know I won't have time for at least two or three nearest weeks.
Thanks for pinging!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (9 preceding siblings ...)
2021-07-20 21:01 ` gogabr
@ 2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-04-16 2:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/22426#issuecomment-1100506778
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: Ghc build for aarch64, aarch64-musl
2020-05-30 10:30 [PR PATCH] Ghc build for aarch64, aarch64-musl gogabr
` (10 preceding siblings ...)
2022-04-16 2:02 ` github-actions
@ 2022-04-30 2:13 ` github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-04-30 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
There's a closed pull request on the void-packages repository
Ghc build for aarch64, aarch64-musl
https://github.com/void-linux/void-packages/pull/22426
Description:
aarch64 binaries should probably be moved to a more appropriate place.
^ permalink raw reply [flat|nested] 13+ messages in thread