[PR PATCH] testdisk: Add missing ncurses-base dependency

[PR PATCH] testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is a new pull request by jarda-wien against master on the void-packages repository

https://github.com/jarda-wien/void-packages master
https://github.com/void-linux/void-packages/pull/28377

testdisk: Add missing ncurses-base dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28377.patch --]
[-- Type: text/x-diff, Size: 907 bytes --]

From 87ba866f5950aa8f824dca1be2be25ad4284a601 Mon Sep 17 00:00:00 2001
From: Jaroslav Stepanek <xstej70@gmail.com>
Date: Mon, 1 Feb 2021 11:06:10 +0100
Subject: [PATCH] testdisk: Add missing ncurses-base dependency

---
 srcpkgs/testdisk/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/testdisk/template b/srcpkgs/testdisk/template
index a7d635ddb7e..8f532399e57 100644
--- a/srcpkgs/testdisk/template
+++ b/srcpkgs/testdisk/template
@@ -1,12 +1,12 @@
 # Template file for 'testdisk'
 pkgname=testdisk
 version=7.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-ewf --enable-sudo"
 makedepends="libjpeg-turbo-devel libuuid-devel e2fsprogs-devel
  ntfs-3g-devel ncurses-devel"
-depends="sudo"
+depends="sudo ncurses-base"
 short_desc="Powerful free data recovery software"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2"

Re: testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New comment by jarda-wien on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770743897

Comment:
I get this error message without the ncurses package installed:
```bash
testdisk
TestDisk 7.1, Data Recovery Utility, July 2019
Christophe GRENIER <grenier@cgsecurity.org>
https://www.cgsecurity.org
Terminfo file is missing.
Extract all files and subdirectories before running the program.
Press Enter key to quit.
```

Re: testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by jarda-wien on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770744932

Comment:
I am not sure what to do about the xlint failure as this is probably my first contribution and the proposed changes are only minor.

Re: testdisk: Add missing ncurses-base dependency

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770758494

Comment:
You can change the license to `license="GPL-2-or-later"`

Re: testdisk: Add missing ncurses-base dependency

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770758494

Comment:
You can change the license to `license="GPL-2.0-or-later"`

Re: [PR PATCH] [Updated] testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

There is an updated pull request by jarda-wien against master on the void-packages repository

https://github.com/jarda-wien/void-packages master
https://github.com/void-linux/void-packages/pull/28377

testdisk: Add missing ncurses-base dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28377.patch --]
[-- Type: text/x-diff, Size: 1114 bytes --]

From fb5d28754e9fb10dd2768fa7af505a70cba223aa Mon Sep 17 00:00:00 2001
From: Jaroslav Stepanek <xstej70@gmail.com>
Date: Mon, 1 Feb 2021 11:06:10 +0100
Subject: [PATCH] testdisk: Add missing ncurses-base dependency

---
 srcpkgs/testdisk/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/testdisk/template b/srcpkgs/testdisk/template
index a7d635ddb7e..59a3b6116ea 100644
--- a/srcpkgs/testdisk/template
+++ b/srcpkgs/testdisk/template
@@ -1,15 +1,15 @@
 # Template file for 'testdisk'
 pkgname=testdisk
 version=7.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-ewf --enable-sudo"
 makedepends="libjpeg-turbo-devel libuuid-devel e2fsprogs-devel
  ntfs-3g-devel ncurses-devel"
-depends="sudo"
+depends="sudo ncurses-base"
 short_desc="Powerful free data recovery software"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2-or-later"
 homepage="http://www.cgsecurity.org/"
 distfiles="http://www.cgsecurity.org/$pkgname-$version.tar.bz2"
 checksum=1413c47569e48c5b22653b943d48136cb228abcbd6f03da109c4df63382190fe

Re: [PR PATCH] [Updated] testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

There is an updated pull request by jarda-wien against master on the void-packages repository

https://github.com/jarda-wien/void-packages master
https://github.com/void-linux/void-packages/pull/28377

testdisk: Add missing ncurses-base dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28377.patch --]
[-- Type: text/x-diff, Size: 1116 bytes --]

From 8d474bb6f31915d106e7f4327d36ee8cb5699221 Mon Sep 17 00:00:00 2001
From: Jaroslav Stepanek <xstej70@gmail.com>
Date: Mon, 1 Feb 2021 11:06:10 +0100
Subject: [PATCH] testdisk: Add missing ncurses-base dependency

---
 srcpkgs/testdisk/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/testdisk/template b/srcpkgs/testdisk/template
index a7d635ddb7e..4a38d870099 100644
--- a/srcpkgs/testdisk/template
+++ b/srcpkgs/testdisk/template
@@ -1,15 +1,15 @@
 # Template file for 'testdisk'
 pkgname=testdisk
 version=7.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-ewf --enable-sudo"
 makedepends="libjpeg-turbo-devel libuuid-devel e2fsprogs-devel
  ntfs-3g-devel ncurses-devel"
-depends="sudo"
+depends="sudo ncurses-base"
 short_desc="Powerful free data recovery software"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
 homepage="http://www.cgsecurity.org/"
 distfiles="http://www.cgsecurity.org/$pkgname-$version.tar.bz2"
 checksum=1413c47569e48c5b22653b943d48136cb228abcbd6f03da109c4df63382190fe

Re: testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by jarda-wien on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770762829

Comment:
> You can change the license to `license="GPL-2.0-or-later"`

done, thanks

Re: testdisk: Add missing ncurses-base dependency

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770776440

Comment:
The consensus is that packages shouldn't depend on ncurses-base, packages use some terminfo that can't be expressed as dependency as it depends on your TERM variable. Generally ncurses-base should be installed as part of the base system i.e. the base-system metapackage, it's deliberately not Part of base-minimal as it would increase container sizes. If we would start to add ncurses-base to everything that might need it, we would effectively add it to base-minimal as i.e. util-linux's cfdisk "depends" on terminfo descriptions.

Re: testdisk: Add missing ncurses-base dependency

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770776440

Comment:
The consensus is that packages shouldn't depend on ncurses-base, packages use some terminfo that can't be expressed as dependency as it depends on your TERM variable. Generally ncurses-base should be installed as part of the base system i.e. the base-system metapackage, it's deliberately not part of base-minimal as it would increase container sizes. If we would start to add ncurses-base to everything that might need it, we would effectively add it to base-minimal as i.e. util-linux's cfdisk "depends" on terminfo descriptions.

Re: testdisk: Add missing ncurses-base dependency

[jarda-wien]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

New comment by jarda-wien on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770816779

Comment:
> The consensus is that packages shouldn't depend on ncurses-base, packages use some terminfo that can't be expressed as dependency as it depends on your TERM variable. Generally ncurses-base should be installed as part of the base system i.e. the base-system metapackage, it's deliberately not part of base-minimal as it would increase container sizes. If we would start to add ncurses-base to everything that might need it, we would effectively add it to base-minimal as i.e. util-linux's cfdisk "depends" on terminfo descriptions.

My main use case for the testdisk package was having it in a minimal docker container, so I didn't have "base-system" installed. While I understand the reasoning behind *the consensus*, I am not sure if we have any means of at least warning the user that something is missing. Being mostly on archlinux systems, I am not very seasoned in metadata fields provided by void packages. I tried googling something like optional dependecies and came across [this](https://github.com/void-linux/xbps/issues/1).

Please point me to some preferred possibility of informing the user that something is missing in the current environment. If there is no such tool available, I guess you can reject this PR and keep things the way they are.

Re: testdisk: Add missing ncurses-base dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770860413

Comment:
For all normal user, they should use `base-system`. `base-system` is the package which users are told to install in `void-docs`.
IMO, anyone that choose to not install base-system should have enough experience to know what's missing.

Re: [PR PATCH] [Closed]: testdisk: Add missing ncurses-base dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

There's a closed pull request on the void-packages repository

testdisk: Add missing ncurses-base dependency
https://github.com/void-linux/void-packages/pull/28377

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->