[PR PATCH] gdm: enable smooth transition with plymouth.

[PR PATCH] gdm: enable smooth transition with plymouth.

[circhioz]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

There is a new pull request by circhioz against master on the void-packages repository

https://github.com/circhioz/void-packages gdm-plymouth
https://github.com/void-linux/void-packages/pull/28570

gdm: enable smooth transition with plymouth.
Support for smooth transition was disabled years ago, when `plymouth` wasn't in the Void repo. `gdm` checks whether `plymouth` can be pinged at run time so that no hard dependency is required.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28570.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-plymouth-28570.patch --]
[-- Type: text/x-diff, Size: 1519 bytes --]

From 7449bb240a14df0e0a11ba12b6dda1d3e5b14533 Mon Sep 17 00:00:00 2001
From: Francesco Circhetta <francesco.circhetta@gmail.com>
Date: Sun, 7 Feb 2021 18:40:54 +0100
Subject: [PATCH] gdm: enable smooth transition with plymouth.

---
 srcpkgs/gdm/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index 6ef190e057c..e5b84645b4c 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -1,19 +1,20 @@
 # Template file for 'gdm'
 pkgname=gdm
 version=3.38.2.1
-revision=2
+revision=3
 build_helper="gir"
 build_style=meson
 configure_args="
  -Ddefault-pam-config=arch -Dat-spi-registryd-dir=/usr/libexec
  -Dtcp-wrappers=false -Dscreenshot-dir=/var/lib/gdm/greeter
- -Dplymouth=disabled -Dxauth-dir=/run/gdm -Dpid-file=/run/gdm/gdm.pid
+ -Dplymouth=enabled -Dxauth-dir=/run/gdm -Dpid-file=/run/gdm/gdm.pid
  -Dsystemd-journal=false -Dinitial-vt=7 -Dwayland-support=true
  -Dselinux=disabled -Dlibaudit=disabled
  -Dsystemdsystemunitdir=/tmp -Dsystemduserunitdir=/tmp"
 hostmakedepends="dconf gettext itstool pkg-config"
 makedepends="accountsservice-devel elogind-devel gettext-devel glib-devel
- iso-codes libSM-devel libcanberra-devel nss-devel pam-devel upower-devel"
+ iso-codes libSM-devel libcanberra-devel nss-devel pam-devel upower-devel
+ plymouth-devel"
 depends="gnome-settings-daemon gnome-shell gnome-session gnome-themes-extra
  gsettings-desktop-schemas xorg-server xorg-server-xwayland xrdb"
 checkdepends="check-devel"

Re: [PR REVIEW] gdm: enable smooth transition with plymouth.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28570#discussion_r571708432

Comment:
So it checks for the plymouth library at configure time (I could find this line), but doesn't link against it? At least I couldn't see anything about it in the CI log...

Just wondering what it is that it does with the library, and if we need any sort of warning about plymouth library revbump or such.

Re: [PR REVIEW] gdm: enable smooth transition with plymouth.

[circhioz]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New review comment by circhioz on void-packages repository

https://github.com/void-linux/void-packages/pull/28570#discussion_r571723731

Comment:
It does absolutely nothing with the library, yet it requires `ply-boot-client.pc` to be present at configure time. Code just spawns `plymouth` binary and that's all.

The quirky logic comes from a patch written by Fedora devs 8 years ago. My best guess is that it was upstreamed without anyone knowing what it really did.

Re: [PR REVIEW] gdm: enable smooth transition with plymouth.

[circhioz]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New review comment by circhioz on void-packages repository

https://github.com/void-linux/void-packages/pull/28570#discussion_r571723731

Comment:
It does absolutely nothing with the library, yet it requires `ply-boot-client.pc` to be present at configure time. Code just spawns `plymouth` binary and that's all.

The quirky logic comes from a patch written by Fedora devs 11 years ago. My best guess is that it was upstreamed without anyone knowing what it really did.

Re: [PR PATCH] [Merged]: gdm: enable smooth transition with plymouth.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

There's a merged pull request on the void-packages repository

gdm: enable smooth transition with plymouth.
https://github.com/void-linux/void-packages/pull/28570

Description:
Support for smooth transition was disabled years ago, when `plymouth` wasn't in the Void repo. `gdm` checks whether `plymouth` can be pinged at run time so that no hard dependency is required.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->