Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] MPV MPRIS plugin fix
@ 2020-08-15  0:09 harrisonthorne
  2020-08-15  0:39 ` [PR REVIEW] " ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: harrisonthorne @ 2020-08-15  0:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is a new pull request by harrisonthorne against master on the void-packages repository

https://github.com/harrisonthorne/void-packages mpv-mpris-fix
https://github.com/void-linux/void-packages/pull/24285

MPV MPRIS plugin fix
mpv and the mpv-mpris plugin weren't working together out-of-the-box for me, so these edits fix that.

I've confirmed on my end that these changes work :)

The changes made are based on the documentation for mpv-mpris [here](https://github.com/hoyon/mpv-mpris).

A patch file from https://github.com/void-linux/void-packages/pull/24285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpv-mpris-fix-24285.patch --]
[-- Type: text/x-diff, Size: 2748 bytes --]

From b097c4ceac589e0c99a603793a3e0666a1004c7e Mon Sep 17 00:00:00 2001
From: Harrison Thorne <harrisonthorne@protonmail.com>
Date: Fri, 14 Aug 2020 17:44:36 -0600
Subject: [PATCH 1/2] mpv-mpris: Change install directory

This change is part of an effort to fix integration between MPV and its
MPRIS plugin.
---
 srcpkgs/mpv-mpris/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mpv-mpris/template b/srcpkgs/mpv-mpris/template
index 774c21c5965..1d956beb661 100644
--- a/srcpkgs/mpv-mpris/template
+++ b/srcpkgs/mpv-mpris/template
@@ -1,7 +1,7 @@
 # Template file for 'mpv-mpris'
 pkgname=mpv-mpris
 version=0.5
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_target=mpris.so
 hostmakedepends="pkg-config"
@@ -16,6 +16,6 @@ checksum=673aff031e7cc741edea68d7b4b0103d7b031d4a55755abb9e1be5dd4ec4e969
 
 do_install() {
 	vlicense LICENSE
-	vmkdir usr/lib/${pkgname}
-	vinstall mpris.so 0644 usr/lib/${pkgname}
+	vmkdir etc/mpv/scripts
+	vinstall mpris.so 0644 etc/mpv/scripts/
 }

From 3e92e83d35abb6c080209a76edec6a725dde9da0 Mon Sep 17 00:00:00 2001
From: Harrison Thorne <harrisonthorne@protonmail.com>
Date: Fri, 14 Aug 2020 17:47:42 -0600
Subject: [PATCH 2/2] mpv: Add --enable-cplugins config option

This change is part of an effort to fix integration between MPV and its
MPRIS plugin.
---
 srcpkgs/mpv/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index 598624e8949..9535ecc048b 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,15 +1,15 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.32.0
-revision=3
+revision=4
 build_style=waf3
 configure_args="--confdir=/etc/mpv --docdir=/usr/share/examples/mpv
  --enable-dvdnav --enable-cdda --enable-libmpv-shared
- --enable-dvbin --enable-libarchive $(vopt_enable alsa) $(vopt_enable caca)
- $(vopt_enable jack) $(vopt_enable lua) $(vopt_enable oss oss-audio)
- $(vopt_enable pulseaudio pulse) $(vopt_enable sdl2)
- $(vopt_enable smb libsmbclient) $(vopt_enable sndio)
- $(vopt_enable vapoursynth) $(vopt_enable vdpau) $(vopt_enable wayland)
+ --enable-dvbin --enable-libarchive --enable-cplugins $(vopt_enable alsa)
+ $(vopt_enable caca) $(vopt_enable jack) $(vopt_enable lua) 
+ $(vopt_enable oss oss-audio) $(vopt_enable pulseaudio pulse) 
+ $(vopt_enable sdl2) $(vopt_enable smb libsmbclient) $(vopt_enable sndio) 
+ $(vopt_enable vapoursynth) $(vopt_enable vdpau) $(vopt_enable wayland) 
  $(vopt_enable x11) $(vopt_enable vulkan) $(vopt_enable vulkan shaderc)"
 hostmakedepends="pkg-config python3-docutils perl $(vopt_if wayland wayland-devel)"
 makedepends="MesaLib-devel ffmpeg-devel harfbuzz-devel lcms2-devel libXv-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-02-11  2:05 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15  0:09 [PR PATCH] MPV MPRIS plugin fix harrisonthorne
2020-08-15  0:39 ` [PR REVIEW] " ericonr
2020-08-15  1:18 ` flexibeast
2020-08-22 19:12 ` harrisonthorne
2020-08-22 20:38 ` ericonr
2020-08-24 18:37 ` [PR PATCH] [Updated] " harrisonthorne
2020-08-24 18:40 ` harrisonthorne
2020-08-24 18:43 ` [PR REVIEW] " harrisonthorne
2020-08-24 19:23 ` ericonr
2021-02-11  2:05 ` ericonr
2021-02-11  2:05 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).