[PR PATCH] tvbrowser: depends on virtual java-runtime package.

[PR PATCH] tvbrowser: depends on virtual java-runtime package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages tv
https://github.com/void-linux/void-packages/pull/28504

tvbrowser: depends on virtual java-runtime package.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28504.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tv-28504.patch --]
[-- Type: text/x-diff, Size: 951 bytes --]

From ec96e6684d2176117956d94ecdb75caf627484ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 5 Feb 2021 01:44:55 -0300
Subject: [PATCH] tvbrowser: depends on virtual java-runtime package.

---
 srcpkgs/tvbrowser/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tvbrowser/template b/srcpkgs/tvbrowser/template
index 5619ce740a2..54f8bf901ce 100644
--- a/srcpkgs/tvbrowser/template
+++ b/srcpkgs/tvbrowser/template
@@ -1,8 +1,8 @@
 # Template file for 'tvbrowser'
 pkgname=tvbrowser
 version=4.2.1
-revision=2
-depends="java-runtime>=11 hicolor-icon-theme bash"
+revision=3
+depends="virtual?java-runtime>=11 hicolor-icon-theme bash"
 short_desc="Ad free open source TV guide for more than 1000 channels"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="GPL-3.0-or-later, GPL-2.0-or-later, LPPL-1.0, Apache-2.0, LGPL-2.1-or-later, custom:other"

Re: tvbrowser: depends on virtual java-runtime package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28504#issuecomment-773790069

Comment:
Hm, this seems to work mostly because at some point the repository will already have packages that provide `java-runtime` and xbps-src will magically query them instead of looking through virtual or `srcpkgs`.

@pullmoll the solution here would be to build `openjdk11` first :p 

Or we make this package depend directly on `opendjk11`.

Re: [PR PATCH] [Updated] tvbrowser: depends on virtual java-runtime package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages tv
https://github.com/void-linux/void-packages/pull/28504

tvbrowser: depends on virtual java-runtime package.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28504.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tv-28504.patch --]
[-- Type: text/x-diff, Size: 1210 bytes --]

From 87e2f7931c600213d203a5a62481b6f4bd02dcd2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 5 Feb 2021 01:44:55 -0300
Subject: [PATCH] tvbrowser: depends openjdk11.

It is possible to depend on `java-runtime>=11`, but only if the
openjdk11 package has already been built. Until xbps-src has a mechanism
for dealing with this, and openjdk11 is our latest java runtime,
depending directly on openjdk11 works fine.
---
 srcpkgs/tvbrowser/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tvbrowser/template b/srcpkgs/tvbrowser/template
index 5619ce740a2..3810d485928 100644
--- a/srcpkgs/tvbrowser/template
+++ b/srcpkgs/tvbrowser/template
@@ -1,8 +1,8 @@
 # Template file for 'tvbrowser'
 pkgname=tvbrowser
 version=4.2.1
-revision=2
-depends="java-runtime>=11 hicolor-icon-theme bash"
+revision=3
+depends="openjdk11 hicolor-icon-theme bash" # XXX: openjdk11 or later version, when available
 short_desc="Ad free open source TV guide for more than 1000 channels"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="GPL-3.0-or-later, GPL-2.0-or-later, LPPL-1.0, Apache-2.0, LGPL-2.1-or-later, custom:other"

Re: [PR PATCH] [Updated] tvbrowser: depends on virtual java-runtime package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages tv
https://github.com/void-linux/void-packages/pull/28504

tvbrowser: depends on virtual java-runtime package.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28504.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tv-28504.patch --]
[-- Type: text/x-diff, Size: 1219 bytes --]

From 227db00d12d4dc805eabd4e4cbd65af833a71861 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 5 Feb 2021 01:44:55 -0300
Subject: [PATCH] tvbrowser: depends on openjdk11.

It is possible to depend on `java-runtime>=11`, but only if the
openjdk11 package has already been built. Until xbps-src has a mechanism
for dealing with this, and while openjdk11 is our latest java runtime,
depending directly on openjdk11 works fine.
---
 srcpkgs/tvbrowser/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tvbrowser/template b/srcpkgs/tvbrowser/template
index 5619ce740a2..3810d485928 100644
--- a/srcpkgs/tvbrowser/template
+++ b/srcpkgs/tvbrowser/template
@@ -1,8 +1,8 @@
 # Template file for 'tvbrowser'
 pkgname=tvbrowser
 version=4.2.1
-revision=2
-depends="java-runtime>=11 hicolor-icon-theme bash"
+revision=3
+depends="openjdk11 hicolor-icon-theme bash" # XXX: openjdk11 or later version, when available
 short_desc="Ad free open source TV guide for more than 1000 channels"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="GPL-3.0-or-later, GPL-2.0-or-later, LPPL-1.0, Apache-2.0, LGPL-2.1-or-later, custom:other"

Re: [PR PATCH] [Merged]: tvbrowser: depends on virtual java-runtime package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

There's a merged pull request on the void-packages repository

tvbrowser: depends on virtual java-runtime package.
https://github.com/void-linux/void-packages/pull/28504

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->