[PR PATCH] newsboat: update to 2.22.1.

Github messages for voidlinux
 help / color / mirror / Atom feed

* [PR PATCH] newsboat: update to 2.22.1.
@ 2021-01-13 20:57 subsonik
  2021-01-13 21:28 ` Minoru
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: subsonik @ 2021-01-13 20:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is a new pull request by subsonik against master on the void-packages repository

https://github.com/subsonik/void-packages newsboat
https://github.com/void-linux/void-packages/pull/27902

newsboat: update to 2.22.1.


A patch file from https://github.com/void-linux/void-packages/pull/27902.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-27902.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]

From 61a9e33e0f4269cd9e95e6f15efb03bbc06d80b1 Mon Sep 17 00:00:00 2001
From: John Rowley <hey@johnrowley.me>
Date: Wed, 13 Jan 2021 21:55:35 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..d9fc235194c 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,6 +1,6 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
@@ -16,7 +16,7 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
 do_check() {
 	make test

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
@ 2021-01-13 21:28 ` Minoru
  2021-01-13 22:01 ` subsonik
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Minoru @ 2021-01-13 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-759750365

Comment:
Hi, Newsboat maintainer again :wave: Please see https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 and https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 (someone else was preparing a PR with an update, and I ended up commenting in their fork).

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
  2021-01-13 21:28 ` Minoru
@ 2021-01-13 22:01 ` subsonik
  2021-01-20  0:19 ` ericonr
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: subsonik @ 2021-01-13 22:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

New comment by subsonik on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-759765730

Comment:
Thanks for the input @Minoru :)

I've ran the test suite on my machine using an x86_64 chroot and everything passed as an unprivileged user. The x86_64-musl tests fail, as previously noted, but I can confirm that the app itself is working fine on my machine (x86_64-musl).

I'm inexperienced with Void packaging/Travis, unfortunately, so I'm not sure if I can get the tests to run on Travis as an unprivileged user.

I think someone more knowledgeable will need to weigh in here, but in my opinion, besides the musl test failures and Travis running the test suite as a privileged user, this update is good to go. Maybe the test phase should be skipped?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
  2021-01-13 21:28 ` Minoru
  2021-01-13 22:01 ` subsonik
@ 2021-01-20  0:19 ` ericonr
  2021-01-20  2:03 ` tibequadorian
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-01-20  0:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763236473

Comment:
@tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
                   ` (2 preceding siblings ...)
  2021-01-20  0:19 ` ericonr
@ 2021-01-20  2:03 ` tibequadorian
  2021-01-20  2:03 ` tibequadorian
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: tibequadorian @ 2021-01-20  2:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch()` and checks were indeed successful, but the CI still fails.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
                   ` (3 preceding siblings ...)
  2021-01-20  2:03 ` tibequadorian
@ 2021-01-20  2:03 ` tibequadorian
  2021-01-20  2:04 ` tibequadorian
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: tibequadorian @ 2021-01-20  2:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful, but the CI still fails.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
                   ` (4 preceding siblings ...)
  2021-01-20  2:03 ` tibequadorian
@ 2021-01-20  2:04 ` tibequadorian
  2021-01-20  2:06 ` tibequadorian
  2021-02-18  2:51 ` [PR PATCH] [Closed]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: tibequadorian @ 2021-01-20  2:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
                   ` (5 preceding siblings ...)
  2021-01-20  2:04 ` tibequadorian
@ 2021-01-20  2:06 ` tibequadorian
  2021-02-18  2:51 ` [PR PATCH] [Closed]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: tibequadorian @ 2021-01-20  2:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However parts of the `ci-check` target in the Makefile look quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: newsboat: update to 2.22.1.
  2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
                   ` (6 preceding siblings ...)
  2021-01-20  2:06 ` tibequadorian
@ 2021-02-18  2:51 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-18  2:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a closed pull request on the void-packages repository

newsboat: update to 2.22.1.
https://github.com/void-linux/void-packages/pull/27902

Description:


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-02-18  2:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 20:57 [PR PATCH] newsboat: update to 2.22.1 subsonik
2021-01-13 21:28 ` Minoru
2021-01-13 22:01 ` subsonik
2021-01-20  0:19 ` ericonr
2021-01-20  2:03 ` tibequadorian
2021-01-20  2:03 ` tibequadorian
2021-01-20  2:04 ` tibequadorian
2021-01-20  2:06 ` tibequadorian
2021-02-18  2:51 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).