From: 4ricci <4ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] go: update to 1.16
Date: Fri, 19 Feb 2021 17:14:04 +0100 [thread overview]
Message-ID: <20210219161404.KwurlJ7kA09qpSJfuvaa0iW8CuhHilOgyp90vzVnKWU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28825@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]
There is an updated pull request by 4ricci against master on the void-packages repository
https://github.com/4ricci/void-packages go
https://github.com/void-linux/void-packages/pull/28825
go: update to 1.16
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.
~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~
Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28825.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-28825.patch --]
[-- Type: text/x-diff, Size: 1802 bytes --]
From b9e5b9cd345495ee7b4684738c2da277f9feacae Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Wed, 17 Feb 2021 10:23:09 +0100
Subject: [PATCH 1/2] go: update to 1.16
---
srcpkgs/go/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..20781ce682d 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
# Template file for 'go'
pkgname=go
-version=1.15.8
+version=1.16
revision=1
create_wrksrc=yes
build_wrksrc=go
@@ -9,8 +9,9 @@ short_desc="Go Programming Language"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="BSD-3-Clause"
homepage="http://golang.org/"
+changelog="https://golang.org/doc/devel/release.html"
distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
nostrip=yes
noverifyrdeps=yes
From 06bd8863f6046ab23d3f6330b0ed48b4809899d5 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 19 Feb 2021 16:56:32 +0100
Subject: [PATCH 2/2] build-style/go: set GO111MODULE=off when using GOPATH
---
common/build-style/go.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index c9f476b95c7..7b1209f4b3b 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -36,6 +36,7 @@ do_build() {
go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
else
# Otherwise, build using GOPATH
+ export GO111MODULE=off
go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
fi
}
next prev parent reply other threads:[~2021-02-19 16:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 18:49 [PR PATCH] " 4ricci
2021-02-17 21:36 ` the-maldridge
2021-02-18 16:32 ` 4ricci
2021-02-18 17:18 ` Chocimier
2021-02-18 17:31 ` 4ricci
2021-02-19 5:18 ` the-maldridge
2021-02-19 16:14 ` 4ricci [this message]
2021-02-19 16:15 ` 4ricci
2021-02-20 6:40 ` ericonr
2021-02-20 6:57 ` the-maldridge
2021-02-24 4:09 ` ericonr
2021-03-01 11:30 ` ernierasta
2021-03-01 11:32 ` the-maldridge
2021-03-11 0:15 ` [PR PATCH] [Updated] " 4ricci
2021-03-11 13:21 ` 4ricci
2021-03-11 18:01 ` [PR REVIEW] " ericonr
2021-03-11 18:57 ` [PR PATCH] [Updated] " 4ricci
2021-03-12 13:12 ` 4ricci
2021-03-15 4:02 ` [PR REVIEW] " travankor
2021-03-15 4:02 ` travankor
2021-03-15 9:20 ` kaey
2021-03-15 12:54 ` [PR REVIEW] " ericonr
2021-03-15 12:54 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219161404.KwurlJ7kA09qpSJfuvaa0iW8CuhHilOgyp90vzVnKWU@z \
--to=4ricci@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).