Github messages for voidlinux
 help / color / mirror / Atom feed
From: kaey <kaey@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: go: update to 1.16
Date: Mon, 15 Mar 2021 10:20:39 +0100	[thread overview]
Message-ID: <20210315092039.2FnZ0YVS5QBeYr_tPZFV-jTDiBSv8kYwwZ2Yshkzg0M@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28825@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

New comment by kaey on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-799257479

Comment:
> So, Go 1.16 seems to be behaving very weirdly
> 
> See https://gist.github.com/Foxboron/94163c11a2c43ab523d3bc5597e4c49d
> 
> And from IRC:
> 
> ```
> 2021-02-23 12:01:55     ericonr Foxboron: what exactly am I looking at? are the results different just because of the command you used?
> 2021-02-23 12:02:03     Foxboron        ericonr: Yes
> 2021-02-23 12:02:43     Foxboron        ericonr: It's intended. -buildmode=pie uses another codepath that doesn't always include cgo. That introduces a 2 year old bug nobody has figured out where sometimes Go decides to not include CGO even if requested.
> 2021-02-23 12:03:01     Foxboron        The workaround is to always use -ldflags=-extldflags. But you can't win that fight with GOFLAGS since the parser is broken
> ```

`ldflags` in this example are incorrect. it should be `-ldflags=all=-linkmode=external`.
In any case FORTIFY_SOURCE is completely useless for pure go binaries (which fzf is) and RELRO is useless (IIUC) for static binaries, which is again true for pure go binaries.

  parent reply	other threads:[~2021-03-15  9:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 18:49 [PR PATCH] " 4ricci
2021-02-17 21:36 ` the-maldridge
2021-02-18 16:32 ` 4ricci
2021-02-18 17:18 ` Chocimier
2021-02-18 17:31 ` 4ricci
2021-02-19  5:18 ` the-maldridge
2021-02-19 16:14 ` [PR PATCH] [Updated] " 4ricci
2021-02-19 16:15 ` 4ricci
2021-02-20  6:40 ` ericonr
2021-02-20  6:57 ` the-maldridge
2021-02-24  4:09 ` ericonr
2021-03-01 11:30 ` ernierasta
2021-03-01 11:32 ` the-maldridge
2021-03-11  0:15 ` [PR PATCH] [Updated] " 4ricci
2021-03-11 13:21 ` 4ricci
2021-03-11 18:01 ` [PR REVIEW] " ericonr
2021-03-11 18:57 ` [PR PATCH] [Updated] " 4ricci
2021-03-12 13:12 ` 4ricci
2021-03-15  4:02 ` [PR REVIEW] " travankor
2021-03-15  4:02 ` travankor
2021-03-15  9:20 ` kaey [this message]
2021-03-15 12:54 ` ericonr
2021-03-15 12:54 ` [PR PATCH] [Merged]: " ericonr
2021-02-24 13:05 [PR PATCH] " saqfish
2021-02-24 13:06 ` FollieHiyuki
2021-02-25 15:38 [PR PATCH] " endigma
2021-02-25 15:46 ` FollieHiyuki
2021-02-25 15:46 ` endigma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315092039.2FnZ0YVS5QBeYr_tPZFV-jTDiBSv8kYwwZ2Yshkzg0M@z \
    --to=kaey@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).