Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: go: update to 1.16
Date: Mon, 15 Mar 2021 13:54:50 +0100	[thread overview]
Message-ID: <20210315125450.ds5iE56yTFETDMXXcUHCrh6hNoUuIebcogNfj090728@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28825@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

There's a merged pull request on the void-packages repository

go: update to 1.16
https://github.com/void-linux/void-packages/pull/28825

Description:
<!-- Mark items with [x] where applicable -->
Tested on x86_64-glibc.

~~According to the release notes, this version no more supports x87 on the 386 arch, but only SSE2 and softfloat. I think SSE2 was the default even in older releases.
Since Void's i686 port must not require SSE2, we should both export `GO386=softfloat` when building the compiler (if needed) and set it as the default for the package. I don't know how to do it however. Setting it in `do_build()` makes the build fail.~~

Also, `GO111MODULE` now defaults to `on` instead of `auto`. Should we provide an INSTALL.msg?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


      parent reply	other threads:[~2021-03-15 12:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 18:49 [PR PATCH] " 4ricci
2021-02-17 21:36 ` the-maldridge
2021-02-18 16:32 ` 4ricci
2021-02-18 17:18 ` Chocimier
2021-02-18 17:31 ` 4ricci
2021-02-19  5:18 ` the-maldridge
2021-02-19 16:14 ` [PR PATCH] [Updated] " 4ricci
2021-02-19 16:15 ` 4ricci
2021-02-20  6:40 ` ericonr
2021-02-20  6:57 ` the-maldridge
2021-02-24  4:09 ` ericonr
2021-03-01 11:30 ` ernierasta
2021-03-01 11:32 ` the-maldridge
2021-03-11  0:15 ` [PR PATCH] [Updated] " 4ricci
2021-03-11 13:21 ` 4ricci
2021-03-11 18:01 ` [PR REVIEW] " ericonr
2021-03-11 18:57 ` [PR PATCH] [Updated] " 4ricci
2021-03-12 13:12 ` 4ricci
2021-03-15  4:02 ` [PR REVIEW] " travankor
2021-03-15  4:02 ` travankor
2021-03-15  9:20 ` kaey
2021-03-15 12:54 ` [PR REVIEW] " ericonr
2021-03-15 12:54 ` ericonr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315125450.ds5iE56yTFETDMXXcUHCrh6hNoUuIebcogNfj090728@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).