[PR PATCH] milkytracker: update to 1.03.00.

[PR PATCH] milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

There is a new pull request by rc-05 against master on the void-packages repository

https://github.com/rc-05/void-packages milkytracker
https://github.com/void-linux/void-packages/pull/28224

milkytracker: update to 1.03.00.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/28224.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-milkytracker-28224.patch --]
[-- Type: text/x-diff, Size: 2266 bytes --]

From d66471200f2ce4dcf4d1da722c67f0288f9b7d7e Mon Sep 17 00:00:00 2001
From: rc-05 <rc23@email.it>
Date: Mon, 25 Jan 2021 18:07:27 +0000
Subject: [PATCH] milkytracker: update to 1.03.00.

---
 .../milkytracker/patches/fix-jack-library-call.patch  | 11 -----------
 srcpkgs/milkytracker/template                         |  8 ++++----
 2 files changed, 4 insertions(+), 15 deletions(-)
 delete mode 100644 srcpkgs/milkytracker/patches/fix-jack-library-call.patch

diff --git a/srcpkgs/milkytracker/patches/fix-jack-library-call.patch b/srcpkgs/milkytracker/patches/fix-jack-library-call.patch
deleted file mode 100644
index c297c38e47f..00000000000
--- a/srcpkgs/milkytracker/patches/fix-jack-library-call.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- ./src/milkyplay/drivers/jack/AudioDriver_JACK.cpp.orig
-+++ ./src/milkyplay/drivers/jack/AudioDriver_JACK.cpp	
-@@ -92,7 +92,7 @@
- mp_sint32 AudioDriver_JACK::initDevice(mp_sint32 bufferSizeInWords, mp_uint32 mixFrequency, MasterMixer* mixer)
- {
- 	// First load libjack
--	libJack = dlopen("libjack.so", RTLD_LAZY);
-+	libJack = dlopen("libjack.so.0", RTLD_LAZY);
- 	if(!libJack) {
- 		fprintf(stderr, "JACK: Can't load libjack (is it installed?)\n");
- 		return -1;
diff --git a/srcpkgs/milkytracker/template b/srcpkgs/milkytracker/template
index 9f5cffd6130..086ff9928ed 100644
--- a/srcpkgs/milkytracker/template
+++ b/srcpkgs/milkytracker/template
@@ -1,18 +1,18 @@
 # Template file for 'milkytracker'
 pkgname=milkytracker
-version=1.02.00
-revision=2
+version=1.03.00
+revision=1
 wrksrc=MilkyTracker-${version}
 build_style=cmake
 configure_args="--with-alsa --with-jack"
 makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel rtmidi-devel"
 depends="libjack rtmidi"
 short_desc="Fast Tracker II inspired music tracker"
-maintainer="bra1nwave <brainwave@openmailbox.org>"
+maintainer="rc-05 <rc23@email.it>"
 license="GPL-3.0-only"
 homepage="http://milkytracker.titandemo.org/"
 distfiles="https://github.com/milkytracker/MilkyTracker/archive/v${version}.tar.gz"
-checksum=6bcb6e74ee333e831137435a25c0f2f3da6e1462864deec9e693ef7d23a16023
+checksum=72d5357e303380b52383b66b51f944a77cd77e2b3bfeb227d87cc0e72ab292f7
 
 post_install() {
 	vinstall resources/milkytracker.desktop 644 usr/share/applications

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-766996748

Comment:
They are looking for SDL2 in the wrong place for cross, it seems :/

Since it used to work, you probably need to make a patch reverting some commit in their build system.

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767002430

Comment:
Maybe https://github.com/milkytracker/MilkyTracker/commit/87d0f55cd8868d91472f96cccafaf6fdb9e0cbbc ? But then we need to fix SDL2 / Cmake instead.

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767002785

Comment:
> They are looking for SDL2 in the wrong place for cross, it seems :/
> 
> Since it used to work, you probably need to make a patch reverting some commit in their build system.

I'll fix it as soon as possible. I simply need to apply the patch exclusively to the cross targets: the question is how do I patch the cross targets?

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767009769

Comment:
Nah, you should be able to apply it for all.

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767009769

Comment:
Nah, it should be ok to apply it for all.

Still, I'd prefer to figure out what CMake is doing wrong.

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767123678

Comment:
> Nah, it should be ok to apply it for all.
> 
> Still, I'd prefer to figure out what CMake is doing wrong.

I do not understand why this error pops up in the first place: the source tarball is the same for all targets and yet on non-ARM architectures this builds correctly.

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767124845

Comment:
How CMake (and other tools) search for dependencies can change (and have flaws) when cross building. That's the main difference. The upstream commit works on native builds, but it broke something for cross.

Re: milkytracker: update to 1.03.00.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-767390077

Comment:
Imo just revert the commit. Fixing the SDL2 provided stuff is far more pain.

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-768150598

Comment:
> Imo just revert the commit. Fixing the SDL2 provided stuff is far more pain.

Maybe I can restrict the number of architectures in the mean time so at least this package can be pushed forward, then when a fix is found (or upstream fixes this problem), I can push a new revision

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-768168441

Comment:
I've opened an issue to upstream, maybe they'll look into it and fix it

Re: milkytracker: update to 1.03.00.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-768318498

Comment:
I'm not sure upstream will want to fix it. The issue is how SDL2's cmake files are created, because they are using the correct way of finding the dependency.

Have you tried adding a patch that reverts the commit I linked?

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-784530603

Comment:
Sorry to say this but I am not using Void Linux anymore: it's not a problem if someone wants to maintain milkytracker in my place.

Re: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by rc-05 on void-packages repository

https://github.com/void-linux/void-packages/pull/28224#issuecomment-784530603

Comment:
Sorry to say this but I am not using Void Linux anymore so I will not pursue further with this PR. I've also closed these PRs in the meantime: #25410 #20739 #21258 #22969

Re: [PR PATCH] [Closed]: milkytracker: update to 1.03.00.

[rc-05]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

There's a closed pull request on the void-packages repository

milkytracker: update to 1.03.00.
https://github.com/void-linux/void-packages/pull/28224

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl