[PR PATCH] go: update to 1.16

[PR PATCH] go: update to 1.16

[endigma]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

There is a new pull request by endigma against master on the void-packages repository

https://github.com/endigma/void-packages patch-2
https://github.com/void-linux/void-packages/pull/29054

go: update to 1.16


A patch file from https://github.com/void-linux/void-packages/pull/29054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-29054.patch --]
[-- Type: text/x-diff, Size: 915 bytes --]

From 1ce96d7216ca6f4ea3d399a98c8e5b8f9f3d969a Mon Sep 17 00:00:00 2001
From: endigma <endigmamc@gmail.com>
Date: Thu, 25 Feb 2021 11:36:52 -0400
Subject: [PATCH] go: update to 1.16

---
 srcpkgs/go/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 186575b0676..6c21c781cec 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.15.8
+version=1.16
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -10,7 +10,7 @@ maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://golang.org/"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
-checksum=540c0ab7781084d124991321ed1458e479982de94454a98afab6acadf38497c2
+checksum=7688063d55656105898f323d90a79a39c378d86fe89ae192eb3b7fc46347c95a
 nostrip=yes
 noverifyrdeps=yes
 

Re: go: update to 1.16

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29054#issuecomment-785998591

Comment:
Duplicated of #28825 

Re: go: update to 1.16

[endigma]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/29054#issuecomment-785998779

Comment:
> Duplicated of #28825

Re: [PR PATCH] [Closed]: go: update to 1.16

[endigma]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

There's a closed pull request on the void-packages repository

go: update to 1.16
https://github.com/void-linux/void-packages/pull/29054

Description:

Re: go: update to 1.16

[kaey]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

New comment by kaey on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-799257479

Comment:
> So, Go 1.16 seems to be behaving very weirdly
> 
> See https://gist.github.com/Foxboron/94163c11a2c43ab523d3bc5597e4c49d
> 
> And from IRC:
> 
> ```
> 2021-02-23 12:01:55     ericonr Foxboron: what exactly am I looking at? are the results different just because of the command you used?
> 2021-02-23 12:02:03     Foxboron        ericonr: Yes
> 2021-02-23 12:02:43     Foxboron        ericonr: It's intended. -buildmode=pie uses another codepath that doesn't always include cgo. That introduces a 2 year old bug nobody has figured out where sometimes Go decides to not include CGO even if requested.
> 2021-02-23 12:03:01     Foxboron        The workaround is to always use -ldflags=-extldflags. But you can't win that fight with GOFLAGS since the parser is broken
> ```

`ldflags` in this example are incorrect. it should be `-ldflags=all=-linkmode=external`.
In any case FORTIFY_SOURCE is completely useless for pure go binaries (which fzf is) and RELRO is useless (IIUC) for static binaries, which is again true for pure go binaries.

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-787878622

Comment:
Resources are spread a bit thin right now with the gear up for the openssl rebuild.  Your patience is greatly appreciated.

Re: go: update to 1.16

[ernierasta]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ernierasta on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-787877733

Comment:
Hi! Any news on that? I would love to have 1.16 in repo. ;-)

Re: go: update to 1.16

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29026#issuecomment-785061714

Comment:
There is #28825

Re: go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-784740352

Comment:
So, Go 1.16 seems to be behaving very weirdly

See https://gist.github.com/Foxboron/94163c11a2c43ab523d3bc5597e4c49d

And from IRC:

```
2021-02-23 12:01:55     ericonr Foxboron: what exactly am I looking at? are the results different just because of the command you used?
2021-02-23 12:02:03     Foxboron        ericonr: Yes
2021-02-23 12:02:43     Foxboron        ericonr: It's intended. -buildmode=pie uses another codepath that doesn't always include cgo. That introduces a 2 year old bug nobody has figured out where sometimes Go decides to not include CGO even if requested.
2021-02-23 12:03:01     Foxboron        The workaround is to always use -ldflags=-extldflags. But you can't win that fight with GOFLAGS since the parser is broken
```

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782574832

Comment:
vmdfmt is a disaster zone, I'm not convinced that we need to hold the release on it.

Re: go: update to 1.16

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782572720

Comment:
`vmdfmt` will probably fail to build as well.

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-782176506

Comment:
`GOPATH` mode is still supported but now it's not enabled by default. Almost all of our packages use modules, but some use `GOPATH`, so it can't be removed from the build style.
Theese few packages need `GO111MODULE=off` (or `=auto`). For instance, `keybase` does not build with go-1.16 and the current build style (I didn't notice this before).

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781828607

Comment:
@4ricci its not entirely clear to me if the `GOPATH` is still in use.  If it is not, then the configuration logic in `common/build-style/go.sh` should be removed.  

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781511499

Comment:
> Void i686 does require SSE2: #21486 , https://docs.voidlinux.org/installation/index.html

I remember reading somewhere that Void i686 was without SSE2, but apparently I'm wrong. Well, better that way.

Re: go: update to 1.16

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781502744

Comment:
Void i686 does require SSE2: https://github.com/void-linux/void-packages/issues/21486 , https://docs.voidlinux.org/installation/index.html

Re: go: update to 1.16

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-781470555

Comment:
Sorry, but I'm not sure about what should be changed. The build style seems to work fine. Which variables are obsolete?

Re: go: update to 1.16

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/28825#issuecomment-780870153

Comment:
INSTALL.msg is reserved for thing that will break your system if you don't attend to them (think sshd updates that require immediate restart).  Since this is just a compiler, we should not ship an installer message for it.  The build_style though should be updated to remove the now obsolete variables.