[PR PATCH] wildmidi: update to 0.4.4

[PR PATCH] wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There is a new pull request by Oreo639 against master on the void-packages repository

https://github.com/Oreo639/void-packages wildmidi
https://github.com/void-linux/void-packages/pull/29668

wildmidi: update to 0.4.4
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29668.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wildmidi-29668.patch --]
[-- Type: text/x-diff, Size: 2527 bytes --]

From e1f5dba9637fc9fc9ee94e5a6fd4f02211615868 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 21 Mar 2021 12:50:35 -0700
Subject: [PATCH] wildmidi: update to 0.4.4

---
 srcpkgs/wildmidi/patches/fix-midi_file.patch | 17 -----------------
 srcpkgs/wildmidi/template                    |  6 +++---
 2 files changed, 3 insertions(+), 20 deletions(-)
 delete mode 100644 srcpkgs/wildmidi/patches/fix-midi_file.patch

diff --git a/srcpkgs/wildmidi/patches/fix-midi_file.patch b/srcpkgs/wildmidi/patches/fix-midi_file.patch
deleted file mode 100644
index 99c56fba6290..000000000000
--- a/srcpkgs/wildmidi/patches/fix-midi_file.patch
+++ /dev/null
@@ -1,17 +0,0 @@
---- src/wildmidi.c	2018-11-24 09:55:50.000000000 +0100
-+++ src/wildmidi.c	2020-01-23 17:07:12.497649804 +0100
-@@ -1978,12 +1978,8 @@
-                         if (!real_file) real_file = argv[optind];
-                         else real_file++;
- 
--                        strncpy(midi_file, real_file, strlen(real_file));
--                        midi_file[strlen(real_file)-4] = '.';
--                        midi_file[strlen(real_file)-3] = 'm';
--                        midi_file[strlen(real_file)-2] = 'i';
--                        midi_file[strlen(real_file)-1] = 'd';
--
-+                        snprintf(midi_file, sizeof(midi_file), "%.*s.mid",
-+                            (int)(strlen(real_file) - 4), real_file);
-                         printf("\rWriting %s: %u bytes.\r\n", midi_file, getmidisize);
-                         write_midi_output(getmidibuffer,getmidisize);
-                         free(getmidibuffer);
diff --git a/srcpkgs/wildmidi/template b/srcpkgs/wildmidi/template
index e6772c66ca00..33843c0b7f4e 100644
--- a/srcpkgs/wildmidi/template
+++ b/srcpkgs/wildmidi/template
@@ -1,7 +1,7 @@
 # Template file for 'wildmidi'
 pkgname=wildmidi
-version=0.4.3
-revision=6
+version=0.4.4
+revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"
 build_style=cmake
 configure_args="-DWANT_ALSA=1 -DWANT_OSS=1 -DWANT_OPENAL=1"
@@ -13,7 +13,7 @@ maintainer="Jürgen Buchmüller <pullmoll@t-online.de>"
 license="GPL-3.0-or-later, LGPL-3.0-only"
 homepage="http://www.mindwerks.net/projects/wildmidi"
 distfiles="https://github.com/Mindwerks/${pkgname}/archive/${pkgname}-${version}.tar.gz"
-checksum=498e5a96455bb4b91b37188ad6dcb070824e92c44f5ed452b90adbaec8eef3c5
+checksum=6f267c8d331e9859906837e2c197093fddec31829d2ebf7b958cf6b7ae935430
 
 post_install() {
 	vsconf ${FILESDIR}/wildmidi.cfg

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803650740

Comment:
Save as midi seems to still be broken. I'll have to make a new patch.

Re: [PR REVIEW] wildmidi: update to 0.4.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#discussion_r598336907

Comment:
Would you mind switching to `https` here?

Re: [PR PATCH] [Updated] wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

There is an updated pull request by Oreo639 against master on the void-packages repository

https://github.com/Oreo639/void-packages wildmidi
https://github.com/void-linux/void-packages/pull/29668

wildmidi: update to 0.4.4
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29668.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wildmidi-29668.patch --]
[-- Type: text/x-diff, Size: 3537 bytes --]

From 9db11eb875814174f563f026384e6c1c405ec9fd Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 21 Mar 2021 12:50:35 -0700
Subject: [PATCH] wildmidi: update to 0.4.4

---
 srcpkgs/wildmidi/patches/fix-midi_file.patch | 17 -----------------
 srcpkgs/wildmidi/patches/save_midi.patch     | 13 +++++++++++++
 srcpkgs/wildmidi/template                    |  6 +++---
 3 files changed, 16 insertions(+), 20 deletions(-)
 delete mode 100644 srcpkgs/wildmidi/patches/fix-midi_file.patch
 create mode 100644 srcpkgs/wildmidi/patches/save_midi.patch

diff --git a/srcpkgs/wildmidi/patches/fix-midi_file.patch b/srcpkgs/wildmidi/patches/fix-midi_file.patch
deleted file mode 100644
index 99c56fba6290..000000000000
--- a/srcpkgs/wildmidi/patches/fix-midi_file.patch
+++ /dev/null
@@ -1,17 +0,0 @@
---- src/wildmidi.c	2018-11-24 09:55:50.000000000 +0100
-+++ src/wildmidi.c	2020-01-23 17:07:12.497649804 +0100
-@@ -1978,12 +1978,8 @@
-                         if (!real_file) real_file = argv[optind];
-                         else real_file++;
- 
--                        strncpy(midi_file, real_file, strlen(real_file));
--                        midi_file[strlen(real_file)-4] = '.';
--                        midi_file[strlen(real_file)-3] = 'm';
--                        midi_file[strlen(real_file)-2] = 'i';
--                        midi_file[strlen(real_file)-1] = 'd';
--
-+                        snprintf(midi_file, sizeof(midi_file), "%.*s.mid",
-+                            (int)(strlen(real_file) - 4), real_file);
-                         printf("\rWriting %s: %u bytes.\r\n", midi_file, getmidisize);
-                         write_midi_output(getmidibuffer,getmidisize);
-                         free(getmidibuffer);
diff --git a/srcpkgs/wildmidi/patches/save_midi.patch b/srcpkgs/wildmidi/patches/save_midi.patch
new file mode 100644
index 000000000000..6f8cf832ad67
--- /dev/null
+++ b/srcpkgs/wildmidi/patches/save_midi.patch
@@ -0,0 +1,13 @@
+diff --git src/wildmidi.c src/wildmidi.c
+index a9ae0f1..fd9c5e7 100644
+--- src/wildmidi.c
++++ src/wildmidi.c
+@@ -1997,7 +1997,7 @@ int main(int argc, char **argv) {
+                         WildMidi_ClearError();
+                     } else {
+                         char *real_file = FIND_LAST_DIRSEP(argv[optind-1]);
+-                        if (!real_file) real_file = argv[optind];
++                        if (!real_file) real_file = argv[optind-1];
+                         else real_file++;
+                         mk_midifile_name(real_file);
+                         printf("\rWriting %s: %u bytes.\r\n", midi_file, getmidisize);
diff --git a/srcpkgs/wildmidi/template b/srcpkgs/wildmidi/template
index e6772c66ca00..33843c0b7f4e 100644
--- a/srcpkgs/wildmidi/template
+++ b/srcpkgs/wildmidi/template
@@ -1,7 +1,7 @@
 # Template file for 'wildmidi'
 pkgname=wildmidi
-version=0.4.3
-revision=6
+version=0.4.4
+revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"
 build_style=cmake
 configure_args="-DWANT_ALSA=1 -DWANT_OSS=1 -DWANT_OPENAL=1"
@@ -13,7 +13,7 @@ maintainer="Jürgen Buchmüller <pullmoll@t-online.de>"
 license="GPL-3.0-or-later, LGPL-3.0-only"
 homepage="http://www.mindwerks.net/projects/wildmidi"
 distfiles="https://github.com/Mindwerks/${pkgname}/archive/${pkgname}-${version}.tar.gz"
-checksum=498e5a96455bb4b91b37188ad6dcb070824e92c44f5ed452b90adbaec8eef3c5
+checksum=6f267c8d331e9859906837e2c197093fddec31829d2ebf7b958cf6b7ae935430
 
 post_install() {
 	vsconf ${FILESDIR}/wildmidi.cfg

Re: [PR PATCH] [Updated] wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

There is an updated pull request by Oreo639 against master on the void-packages repository

https://github.com/Oreo639/void-packages wildmidi
https://github.com/void-linux/void-packages/pull/29668

wildmidi: update to 0.4.4
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29668.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wildmidi-29668.patch --]
[-- Type: text/x-diff, Size: 3687 bytes --]

From 509aee4caf32a22243c70568c3ac8db96e4bbc89 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 21 Mar 2021 12:50:35 -0700
Subject: [PATCH] wildmidi: update to 0.4.4

---
 srcpkgs/wildmidi/patches/fix-midi_file.patch | 17 -----------------
 srcpkgs/wildmidi/patches/save_midi.patch     | 13 +++++++++++++
 srcpkgs/wildmidi/template                    |  8 ++++----
 3 files changed, 17 insertions(+), 21 deletions(-)
 delete mode 100644 srcpkgs/wildmidi/patches/fix-midi_file.patch
 create mode 100644 srcpkgs/wildmidi/patches/save_midi.patch

diff --git a/srcpkgs/wildmidi/patches/fix-midi_file.patch b/srcpkgs/wildmidi/patches/fix-midi_file.patch
deleted file mode 100644
index 99c56fba6290..000000000000
--- a/srcpkgs/wildmidi/patches/fix-midi_file.patch
+++ /dev/null
@@ -1,17 +0,0 @@
---- src/wildmidi.c	2018-11-24 09:55:50.000000000 +0100
-+++ src/wildmidi.c	2020-01-23 17:07:12.497649804 +0100
-@@ -1978,12 +1978,8 @@
-                         if (!real_file) real_file = argv[optind];
-                         else real_file++;
- 
--                        strncpy(midi_file, real_file, strlen(real_file));
--                        midi_file[strlen(real_file)-4] = '.';
--                        midi_file[strlen(real_file)-3] = 'm';
--                        midi_file[strlen(real_file)-2] = 'i';
--                        midi_file[strlen(real_file)-1] = 'd';
--
-+                        snprintf(midi_file, sizeof(midi_file), "%.*s.mid",
-+                            (int)(strlen(real_file) - 4), real_file);
-                         printf("\rWriting %s: %u bytes.\r\n", midi_file, getmidisize);
-                         write_midi_output(getmidibuffer,getmidisize);
-                         free(getmidibuffer);
diff --git a/srcpkgs/wildmidi/patches/save_midi.patch b/srcpkgs/wildmidi/patches/save_midi.patch
new file mode 100644
index 000000000000..6f8cf832ad67
--- /dev/null
+++ b/srcpkgs/wildmidi/patches/save_midi.patch
@@ -0,0 +1,13 @@
+diff --git src/wildmidi.c src/wildmidi.c
+index a9ae0f1..fd9c5e7 100644
+--- src/wildmidi.c
++++ src/wildmidi.c
+@@ -1997,7 +1997,7 @@ int main(int argc, char **argv) {
+                         WildMidi_ClearError();
+                     } else {
+                         char *real_file = FIND_LAST_DIRSEP(argv[optind-1]);
+-                        if (!real_file) real_file = argv[optind];
++                        if (!real_file) real_file = argv[optind-1];
+                         else real_file++;
+                         mk_midifile_name(real_file);
+                         printf("\rWriting %s: %u bytes.\r\n", midi_file, getmidisize);
diff --git a/srcpkgs/wildmidi/template b/srcpkgs/wildmidi/template
index e6772c66ca00..e7f6a9152235 100644
--- a/srcpkgs/wildmidi/template
+++ b/srcpkgs/wildmidi/template
@@ -1,7 +1,7 @@
 # Template file for 'wildmidi'
 pkgname=wildmidi
-version=0.4.3
-revision=6
+version=0.4.4
+revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"
 build_style=cmake
 configure_args="-DWANT_ALSA=1 -DWANT_OSS=1 -DWANT_OPENAL=1"
@@ -11,9 +11,9 @@ depends="libwildmidi"
 short_desc="Simple software midi player and core softsynth library"
 maintainer="Jürgen Buchmüller <pullmoll@t-online.de>"
 license="GPL-3.0-or-later, LGPL-3.0-only"
-homepage="http://www.mindwerks.net/projects/wildmidi"
+homepage="https://www.mindwerks.net/projects/wildmidi"
 distfiles="https://github.com/Mindwerks/${pkgname}/archive/${pkgname}-${version}.tar.gz"
-checksum=498e5a96455bb4b91b37188ad6dcb070824e92c44f5ed452b90adbaec8eef3c5
+checksum=6f267c8d331e9859906837e2c197093fddec31829d2ebf7b958cf6b7ae935430
 
 post_install() {
 	vsconf ${FILESDIR}/wildmidi.cfg

Re: [PR REVIEW] wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New review comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#discussion_r598337243

Comment:
Sure.

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803650740

Comment:
Save as midi seems to still be broken. I'll have to make a new patch. (Done.)

Re: wildmidi: update to 0.4.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660015

Comment:
Ugh, the release notes have 

> Fixed broken file name handling for 'save as midi' command during playback.

but don't show the fix. How is it broken? I can help with the patch, if you need it (and please look into upstreaming it as well).

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than the issue before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than the issue before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

(If you play a song and try to save as midi while playing the song, if there isn't a path seperator in the name, it will try to read the wrong `argv[]`)

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than the issue before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

(If you play a song and try to save as midi while playing a song, if there isn't a path separator in the name, it will try to read the wrong `argv[]`)

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than the issue before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

(The issue here is that if you play a song and try to save as midi while playing a song, if there isn't a path separator in the name, it will try to read the wrong `argv[]`)

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

(The issue here is that if you play a song and try to save as midi while playing a song, if there isn't a path separator in the name, it will try to read the wrong `argv[]`)

Re: wildmidi: update to 0.4.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803662607

Comment:
Could you please open an issue/PR upstream so we can get thoughts on whatever patch we decide to ship? Thanks for the info.

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803663009

Comment:
Already did, but thanks for asking.
https://github.com/Mindwerks/wildmidi/issues/227/

Re: wildmidi: update to 0.4.4

[Oreo639]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803663009

Comment:
Already did, but thanks for checking.
https://github.com/Mindwerks/wildmidi/issues/227/

Re: wildmidi: update to 0.4.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803664393

Comment:
Great, thanks :)

Re: [PR PATCH] [Merged]: wildmidi: update to 0.4.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

There's a merged pull request on the void-packages repository

wildmidi: update to 0.4.4
https://github.com/void-linux/void-packages/pull/29668

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->