* [PR PATCH] New package: lsp-plugins-1.1.30
@ 2021-04-01 14:09 paper42
2021-04-01 14:12 ` [PR REVIEW] " ericonr
` (6 more replies)
0 siblings, 7 replies; 38+ messages in thread
From: paper42 @ 2021-04-01 14:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages lsp-plugins
https://github.com/void-linux/void-packages/pull/29932
New package: lsp-plugins-1.1.30
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
very useful with pulseeffects
A patch file from https://github.com/void-linux/void-packages/pull/29932.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-plugins-29932.patch --]
[-- Type: text/x-diff, Size: 1190 bytes --]
From 056f3e59a8b169e5ccc1579556288aa15d138097 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:19:47 +0100
Subject: [PATCH] New package: lsp-plugins-1.1.30
---
srcpkgs/lsp-plugins/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/lsp-plugins/template
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
new file mode 100644
index 000000000000..052294c1296c
--- /dev/null
+++ b/srcpkgs/lsp-plugins/template
@@ -0,0 +1,18 @@
+# Template file for 'lsp-plugins'
+pkgname=lsp-plugins
+version=1.1.30
+revision=1
+build_style=gnu-makefile
+hostmakedepends="pkg-config php"
+makedepends="libsndfile-devel libX11-devel libglvnd-devel lv2 cairo-devel ladspa-sdk
+ jack-devel libstdc++-devel"
+short_desc="Collection of free plugins compatible with LADSPA, LV2 and LinuxVST"
+maintainer="Paper <paper@tilde.institute>"
+license="LGPL-3.0-or-later"
+homepage="https://lsp-plug.in/"
+distfiles="https://github.com/sadko4u/lsp-plugins/archive/${version}/${version}.tar.gz"
+checksum=9cf43257729093c240375b3640b1514dff34b092b83b54a5ee68d7e8565c8f80
+
+do_build() {
+ make CFLAGS="-fno-rtti"
+}
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
@ 2021-04-01 14:12 ` ericonr
2021-04-01 14:24 ` sgn
` (5 subsequent siblings)
6 siblings, 0 replies; 38+ messages in thread
From: ericonr @ 2021-04-01 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#discussion_r605690759
Comment:
Can you leave a comment explaining this?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
` (2 preceding siblings ...)
2021-04-01 14:24 ` sgn
@ 2021-04-01 14:24 ` sgn
2021-06-26 15:15 ` Logarithmus
` (2 subsequent siblings)
6 siblings, 0 replies; 38+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#discussion_r605694381
Comment:
Don't put `libstdc++-devel` there.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
2021-04-01 14:12 ` [PR REVIEW] " ericonr
2021-04-01 14:24 ` sgn
@ 2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
` (3 subsequent siblings)
6 siblings, 0 replies; 38+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#discussion_r605695858
Comment:
Please patch their Makefile, remove all change to `CFLAGS` `CXXFLAGS` for `test` target.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
2021-04-01 14:12 ` [PR REVIEW] " ericonr
@ 2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
` (4 subsequent siblings)
6 siblings, 0 replies; 38+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#discussion_r605699358
Comment:
Don't do this, it will reset our hardening `CFLAGS`, put it outside of `do_build` instead. Anyway, isn't `-fno-rtti` for C++ only?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
` (3 preceding siblings ...)
2021-04-01 14:24 ` sgn
@ 2021-06-26 15:15 ` Logarithmus
2022-03-29 20:46 ` paper42
2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
6 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-06-26 15:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#issuecomment-869016942
Comment:
@paper42 seems this PR haven't been active for a while, so I decided to create another one based on your work: https://github.com/void-linux/void-packages/pull/31663
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
` (4 preceding siblings ...)
2021-06-26 15:15 ` Logarithmus
@ 2022-03-29 20:46 ` paper42
2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
6 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2022-03-29 20:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/29932#issuecomment-1082357531
Comment:
outdated and superseded by 3 other PRs
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR PATCH] [Closed]: New package: lsp-plugins-1.1.30
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
` (5 preceding siblings ...)
2022-03-29 20:46 ` paper42
@ 2022-03-29 20:46 ` paper42
6 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2022-03-29 20:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]
There's a closed pull request on the void-packages repository
New package: lsp-plugins-1.1.30
https://github.com/void-linux/void-packages/pull/29932
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
very useful with pulseeffects
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (28 preceding siblings ...)
2021-08-10 2:29 ` Logarithmus
@ 2021-08-10 2:31 ` Logarithmus
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-08-10 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r685645828
Comment:
I've removed parallel tests commit because it finally builds fine for all targets.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (27 preceding siblings ...)
2021-08-10 2:29 ` Logarithmus
@ 2021-08-10 2:29 ` Logarithmus
2021-08-10 2:31 ` Logarithmus
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-08-10 2:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r685644554
Comment:
In https://github.com/sadko4u/lsp-plugins/pull/202 I've added `SKIP_CC_LD_ARCH` Make variable which tells `lsp-plugins` to use target-specific compile flags provided by external build system (e. g. `xbps-src`) (https://github.com/sadko4u/lsp-plugins/pull/202/files#diff-22fa0ab7e014806e5e5665b66a6fca7768bb8872c476ead96677f9cce8b1ab69R67-R69).
Basically, that's equivalent to a generic profile.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (26 preceding siblings ...)
2021-08-10 2:28 ` Logarithmus
@ 2021-08-10 2:29 ` Logarithmus
2021-08-10 2:29 ` Logarithmus
2021-08-10 2:31 ` Logarithmus
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-08-10 2:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r685644554
Comment:
In https://github.com/sadko4u/lsp-plugins/pull/202 I've added `SKIP_CC_LD_ARCH` Make variable which tells `lsp-plugins` to use target-specific compile flags provided by external build system (e. g. `xbps`) (https://github.com/sadko4u/lsp-plugins/pull/202/files#diff-22fa0ab7e014806e5e5665b66a6fca7768bb8872c476ead96677f9cce8b1ab69R67-R69).
Basically, that's equivalent to a generic profile.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (25 preceding siblings ...)
2021-07-31 19:59 ` ericonr
@ 2021-08-10 2:28 ` Logarithmus
2021-08-10 2:29 ` Logarithmus
` (2 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-08-10 2:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r685644554
Comment:
In https://github.com/sadko4u/lsp-plugins/pull/202 I've added `SKIP_CC_LD_ARCH` Make variable which tells `lsp-plugins` to use target-specific compile flags provided by external build system (e. g. `xbps`) (https://github.com/sadko4u/lsp-plugins/pull/202/files#diff-22fa0ab7e014806e5e5665b66a6fca7768bb8872c476ead96677f9cce8b1ab69R67-R69)
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (24 preceding siblings ...)
2021-07-31 11:03 ` paper42
@ 2021-07-31 19:59 ` ericonr
2021-08-10 2:28 ` Logarithmus
` (3 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: ericonr @ 2021-07-31 19:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680402915
Comment:
> its a draft PR work in progress.
But it's being developed in the open, and pointing things out early helps with the final review later on.
> You are not even Void team member
That doesn't mean anything. Anyone can review per Void's packaging guidelines, and paper does that quite well.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (23 preceding siblings ...)
2021-07-31 11:00 ` paper42
@ 2021-07-31 11:03 ` paper42
2021-07-31 19:59 ` ericonr
` (4 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-31 11:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680344867
Comment:
> @paper42 its a draft PR work in progress. So please hold your complaints until its ready for review.
>
> You are not even Void team member but you act like you are superior to me
I guess my reviews can sound a bit hostile sometimes, I am sorry for that, I don't mean it that way. Of course my reviews are not authoritative, I just want to help a bit.
It's rude to copy a PR without talking to the author first. If you had asked me before making this PR, I would have just told you to go on and open your own. I will wait until you figure it out, I am not interested in helping you anymore.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (22 preceding siblings ...)
2021-07-31 10:34 ` Logarithmus
@ 2021-07-31 11:00 ` paper42
2021-07-31 11:03 ` paper42
` (5 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-31 11:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680344867
Comment:
> @paper42 its a draft PR work in progress. So please hold your complaints until its ready for review.
>
> You are not even Void team member but you act like you are superior to me
I guess my reviews can sound a bit hostile sometimes, I am sorry for that, I don't mean it that way. Of course my reviews are not authoritative, I just want to help a bit. I will wait until you figure it out, I am not interested in helping you anymore.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (21 preceding siblings ...)
2021-07-31 10:32 ` Logarithmus
@ 2021-07-31 10:34 ` Logarithmus
2021-07-31 11:00 ` paper42
` (6 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-31 10:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680342039
Comment:
@paper42 its a draft PR work in progress. So please hold your complaints until its ready for review.
You are not even Void team member but you act like you are superior to me
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (20 preceding siblings ...)
2021-07-31 10:22 ` Logarithmus
@ 2021-07-31 10:32 ` Logarithmus
2021-07-31 10:34 ` Logarithmus
` (7 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-31 10:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680342039
Comment:
@paper42 its a draft PR work in progress. So please hold your complaints until its ready for review.
You are not even Void team member but you act like you are superior than me
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (19 preceding siblings ...)
2021-07-31 10:19 ` Logarithmus
@ 2021-07-31 10:22 ` Logarithmus
2021-07-31 10:32 ` Logarithmus
` (8 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-31 10:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680340592
Comment:
@paper42 of course I test on my computer first. But I don't want to install cross toolchains for all possible architectures, so when I want to test for something like `armv6-musl`, I do it on CI.
If you didn't know, Github Actions provides 2 virtual cores, so parallel tests are useful even on CI.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (18 preceding siblings ...)
2021-07-31 8:43 ` paper42
@ 2021-07-31 10:19 ` Logarithmus
2021-07-31 10:22 ` Logarithmus
` (9 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-31 10:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680340592
Comment:
@paper42 of course I test on my computer first. But I don't want to install cross toolchains for all possible architectures, so when I want to test for something like `armv6-musl`, I do it on CI.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (17 preceding siblings ...)
2021-07-31 8:43 ` paper42
@ 2021-07-31 8:43 ` paper42
2021-07-31 10:19 ` Logarithmus
` (10 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-31 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680330514
Comment:
break at 80 characters
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (16 preceding siblings ...)
2021-07-31 8:43 ` paper42
@ 2021-07-31 8:43 ` paper42
2021-07-31 8:43 ` paper42
` (11 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-31 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680330732
Comment:
you know that you can test it on your own computer, right? or are the issues CI specific? also you can push only commits that should be in this PR.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (15 preceding siblings ...)
2021-07-28 21:27 ` paper42
@ 2021-07-31 8:43 ` paper42
2021-07-31 8:43 ` paper42
` (12 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-31 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r680330910
Comment:
why export? also this variable is not used anymore? why?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (14 preceding siblings ...)
2021-07-28 20:21 ` Logarithmus
@ 2021-07-28 21:27 ` paper42
2021-07-31 8:43 ` paper42
` (13 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-28 21:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678664103
Comment:
If it works with exporting CXXFLAGS, I think it has to work. Did you test it?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (13 preceding siblings ...)
2021-07-28 20:19 ` Logarithmus
@ 2021-07-28 20:21 ` Logarithmus
2021-07-28 21:27 ` paper42
` (14 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-28 20:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678624788
Comment:
> I think it would be nice to avoid exporting CXXFLAGS with `CXXFLAGS="..." make test` or even override the variable in the Makefile with `make test CXXFLAGS="..."`
I'm afraid it's not possible https://github.com/void-linux/void-packages/blob/0da27cc76d0765677b4f7dc2c8ce3937489bfe3b/srcpkgs/lsp-plugins/patches/00-makefile-test-remove-cflags.patch
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (12 preceding siblings ...)
2021-07-28 20:19 ` Logarithmus
@ 2021-07-28 20:19 ` Logarithmus
2021-07-28 20:21 ` Logarithmus
` (15 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-28 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678623571
Comment:
@paper42 looks like `lsp-plugins/scripts/make/configure.mk` doesn't contain a generic profile, so you are probably right about `archs=`.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (11 preceding siblings ...)
2021-07-28 20:10 ` Logarithmus
@ 2021-07-28 20:19 ` Logarithmus
2021-07-28 20:19 ` Logarithmus
` (16 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-28 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678623571
Comment:
@paper42 looks like `lsp-plugins/scripts/make/configure.mk` doesn't contain a generic profile, so you are probably right about `archs=""`.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (10 preceding siblings ...)
2021-07-28 20:10 ` Logarithmus
@ 2021-07-28 20:10 ` Logarithmus
2021-07-28 20:19 ` Logarithmus
` (17 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-28 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678618350
Comment:
> The issue is straightforward, so I don't think you have to link it, just mention that lsp-plugins needs C++98+.
See https://github.com/void-linux/void-packages/pull/31664#discussion_r659215151
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (9 preceding siblings ...)
2021-07-28 20:08 ` paper42
@ 2021-07-28 20:10 ` Logarithmus
2021-07-28 20:10 ` Logarithmus
` (18 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-07-28 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678618350
Comment:
> The issue is straightforward, so I don't think you have to link it, just mention that lsp-plugins needs C++98+.
>
> `CXXFLAGS="-std=c++98"` is enough. After the template is imported, the value of default CXXFLAGGS is merged with CXXFLAGS from the template.
See https://github.com/void-linux/void-packages/pull/31664#discussion_r659215151
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (8 preceding siblings ...)
2021-07-28 20:04 ` paper42
@ 2021-07-28 20:08 ` paper42
2021-07-28 20:10 ` Logarithmus
` (19 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-28 20:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678617275
Comment:
The issue is straightforward, so I don't think you have to link it, just mention that lsp-plugins needs C++98+.
`CXXFLAGS="-std=c++98"` is enough. After the template is imported, the value of default CXXFLAGGS is merged with CXXFLAGS from the template.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (7 preceding siblings ...)
2021-07-28 20:04 ` paper42
@ 2021-07-28 20:04 ` paper42
2021-07-28 20:08 ` paper42
` (20 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-28 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678610217
Comment:
```
_arch="${XBPS_TARGET_MACHINE%%-musl}"
```
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (6 preceding siblings ...)
2021-07-28 20:04 ` paper42
@ 2021-07-28 20:04 ` paper42
2021-07-28 20:04 ` paper42
` (21 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-28 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678614254
Comment:
I think it would be nice to avoid exporting CXXFLAGS with `CXXFLAGS="..." make test` or even override the variable in the Makefile with `make test CXXFLAGS="..."`
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (5 preceding siblings ...)
2021-06-27 17:06 ` Logarithmus
@ 2021-07-28 20:04 ` paper42
2021-07-28 20:04 ` paper42
` (22 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-07-28 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r678611083
Comment:
Are only some architectures supported or is there a generic profile for the rest? If there is no generic profile, do you think this package should specify archs=""
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (4 preceding siblings ...)
2021-06-27 17:05 ` Logarithmus
@ 2021-06-27 17:06 ` Logarithmus
2021-07-28 20:04 ` paper42
` (23 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-06-27 17:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659349877
Comment:
https://github.com/sadko4u/lsp-plugins/issues/191#issuecomment-812847630
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (3 preceding siblings ...)
2021-06-27 17:03 ` Logarithmus
@ 2021-06-27 17:05 ` Logarithmus
2021-06-27 17:06 ` Logarithmus
` (24 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-06-27 17:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659349590
Comment:
See https://github.com/void-linux/void-packages/pull/29932#discussion_r605695858
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
` (2 preceding siblings ...)
2021-06-26 19:32 ` ericonr
@ 2021-06-27 17:03 ` Logarithmus
2021-06-27 17:05 ` Logarithmus
` (25 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: Logarithmus @ 2021-06-27 17:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659349590
Comment:
See https://github.com/void-linux/void-packages/pull/29932
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
2021-06-26 19:32 ` [PR REVIEW] " paper42
2021-06-26 19:32 ` ericonr
@ 2021-06-26 19:32 ` ericonr
2021-06-27 17:03 ` Logarithmus
` (26 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: ericonr @ 2021-06-26 19:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659214988
Comment:
Why?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
2021-06-26 19:32 ` [PR REVIEW] " paper42
@ 2021-06-26 19:32 ` ericonr
2021-06-26 19:32 ` ericonr
` (27 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: ericonr @ 2021-06-26 19:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659215151
Comment:
Where is this requirement documented?
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
2021-06-26 15:59 [PR PATCH] " Logarithmus
@ 2021-06-26 19:32 ` paper42
2021-06-26 19:32 ` ericonr
` (28 subsequent siblings)
29 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2021-06-26 19:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31664#discussion_r659215149
Comment:
`CXXFLAGS=-std=c++98` instead of the pre_build function should be enough
^ permalink raw reply [flat|nested] 38+ messages in thread
end of thread, other threads:[~2022-03-29 20:46 UTC | newest]
Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
2021-04-01 14:12 ` [PR REVIEW] " ericonr
2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
2021-06-26 15:15 ` Logarithmus
2022-03-29 20:46 ` paper42
2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
2021-06-26 15:59 [PR PATCH] " Logarithmus
2021-06-26 19:32 ` [PR REVIEW] " paper42
2021-06-26 19:32 ` ericonr
2021-06-26 19:32 ` ericonr
2021-06-27 17:03 ` Logarithmus
2021-06-27 17:05 ` Logarithmus
2021-06-27 17:06 ` Logarithmus
2021-07-28 20:04 ` paper42
2021-07-28 20:04 ` paper42
2021-07-28 20:04 ` paper42
2021-07-28 20:08 ` paper42
2021-07-28 20:10 ` Logarithmus
2021-07-28 20:10 ` Logarithmus
2021-07-28 20:19 ` Logarithmus
2021-07-28 20:19 ` Logarithmus
2021-07-28 20:21 ` Logarithmus
2021-07-28 21:27 ` paper42
2021-07-31 8:43 ` paper42
2021-07-31 8:43 ` paper42
2021-07-31 8:43 ` paper42
2021-07-31 10:19 ` Logarithmus
2021-07-31 10:22 ` Logarithmus
2021-07-31 10:32 ` Logarithmus
2021-07-31 10:34 ` Logarithmus
2021-07-31 11:00 ` paper42
2021-07-31 11:03 ` paper42
2021-07-31 19:59 ` ericonr
2021-08-10 2:28 ` Logarithmus
2021-08-10 2:29 ` Logarithmus
2021-08-10 2:29 ` Logarithmus
2021-08-10 2:31 ` Logarithmus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).