* [PR PATCH] devilutionX: update to 1.2.1
@ 2021-04-21 2:07 bugcrazy
2021-04-21 16:49 ` [PR REVIEW] " ericonr
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-21 2:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
There is a new pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 1465 bytes --]
From 0858b10593973e371a38e6418b00f98551addd6c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH] devilutionX: update to 1.2.1
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..732cd6e31edd 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
@ 2021-04-21 16:49 ` ericonr
2021-04-21 17:33 ` Chocimier
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-21 16:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r617718377
Comment:
```suggestion
configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\"
-DVERSION_NUM=$version"
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
2021-04-21 16:49 ` [PR REVIEW] " ericonr
@ 2021-04-21 17:33 ` Chocimier
2021-04-21 21:01 ` [PR PATCH] [Updated] " bugcrazy
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2021-04-21 17:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#issuecomment-824235228
Comment:
This version cross builds.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
2021-04-21 16:49 ` [PR REVIEW] " ericonr
2021-04-21 17:33 ` Chocimier
@ 2021-04-21 21:01 ` bugcrazy
2021-04-21 21:03 ` [PR REVIEW] " bugcrazy
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-21 21:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
There is an updated pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 2465 bytes --]
From 0858b10593973e371a38e6418b00f98551addd6c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH 1/2] devilutionX: update to 1.2.1
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..732cd6e31edd 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
From 18446e4e13738fe0f7277da375169fecde81752e Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Wed, 21 Apr 2021 18:01:48 -0300
Subject: [PATCH 2/2] Applied suggested changes
---
srcpkgs/devilutionX/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index 732cd6e31edd..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -3,7 +3,7 @@ pkgname=devilutionX
version=1.2.1
revision=1
build_style=cmake
-configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (2 preceding siblings ...)
2021-04-21 21:01 ` [PR PATCH] [Updated] " bugcrazy
@ 2021-04-21 21:03 ` bugcrazy
2021-04-21 21:09 ` ericonr
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-21 21:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
New review comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r617874721
Comment:
This new argument is necessary for compilation, but each time changes appear in the tools they compile, forcing you to change the code in the templates! diasurgical/devilutionX#1401
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (3 preceding siblings ...)
2021-04-21 21:03 ` [PR REVIEW] " bugcrazy
@ 2021-04-21 21:09 ` ericonr
2021-04-21 21:10 ` ericonr
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-21 21:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r617878227
Comment:
I am aware it's necessary, just moved it to a different line so the line didn't get too big.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (4 preceding siblings ...)
2021-04-21 21:09 ` ericonr
@ 2021-04-21 21:10 ` ericonr
2021-04-22 4:34 ` [PR PATCH] [Updated] " bugcrazy
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-21 21:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#issuecomment-824359600
Comment:
What Chocimier meant is that `nocross` should be removed.
And please squash all the commits together :)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (5 preceding siblings ...)
2021-04-21 21:10 ` ericonr
@ 2021-04-22 4:34 ` bugcrazy
2021-04-22 6:09 ` bugcrazy
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-22 4:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
There is an updated pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 3964 bytes --]
From 0858b10593973e371a38e6418b00f98551addd6c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH 1/3] devilutionX: update to 1.2.1
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..732cd6e31edd 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
From 18446e4e13738fe0f7277da375169fecde81752e Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Wed, 21 Apr 2021 18:01:48 -0300
Subject: [PATCH 2/3] Applied suggested changes
---
srcpkgs/devilutionX/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index 732cd6e31edd..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -3,7 +3,7 @@ pkgname=devilutionX
version=1.2.1
revision=1
build_style=cmake
-configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
From 7b7111bd70ec25026de1b840d35f9bf55d6c11df Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH 3/3] devilutionX: update to 1.2.1
Applied suggested changes
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (6 preceding siblings ...)
2021-04-22 4:34 ` [PR PATCH] [Updated] " bugcrazy
@ 2021-04-22 6:09 ` bugcrazy
2021-04-22 6:17 ` [PR REVIEW] " bugcrazy
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-22 6:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
There is an updated pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 1494 bytes --]
From afca6c32a51b9494e3d37c1dd5b79437044c592c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH] devilutionX: update to 1.2.1
Applied suggested changes
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (7 preceding siblings ...)
2021-04-22 6:09 ` bugcrazy
@ 2021-04-22 6:17 ` bugcrazy
2021-04-22 6:20 ` bugcrazy
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-22 6:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New review comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r618108868
Comment:
I understand!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (8 preceding siblings ...)
2021-04-22 6:17 ` [PR REVIEW] " bugcrazy
@ 2021-04-22 6:20 ` bugcrazy
2021-04-22 13:37 ` [PR REVIEW] " ericonr
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-22 6:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#issuecomment-824571932
Comment:
Squash all the commits, done!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (9 preceding siblings ...)
2021-04-22 6:20 ` bugcrazy
@ 2021-04-22 13:37 ` ericonr
2021-04-22 23:59 ` [PR PATCH] [Updated] " bugcrazy
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-22 13:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r618408377
Comment:
Please remove this line.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (10 preceding siblings ...)
2021-04-22 13:37 ` [PR REVIEW] " ericonr
@ 2021-04-22 23:59 ` bugcrazy
2021-04-23 0:03 ` bugcrazy
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-22 23:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
There is an updated pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 2357 bytes --]
From afca6c32a51b9494e3d37c1dd5b79437044c592c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH 1/2] devilutionX: update to 1.2.1
Applied suggested changes
---
srcpkgs/devilutionX/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
From d8b79aa29a95855be7eaff599a03bdc92c26f3d8 Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Thu, 22 Apr 2021 20:59:02 -0300
Subject: [PATCH 2/2] Removed nocross
---
srcpkgs/devilutionX/template | 1 -
1 file changed, 1 deletion(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index 4b5282b210c6..829ff248926b 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -11,7 +11,6 @@ license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
-nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (11 preceding siblings ...)
2021-04-22 23:59 ` [PR PATCH] [Updated] " bugcrazy
@ 2021-04-23 0:03 ` bugcrazy
2021-04-23 0:05 ` [PR REVIEW] " bugcrazy
2021-04-23 0:16 ` [PR PATCH] [Merged]: " ericonr
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-23 0:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
There is an updated pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400
devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 1531 bytes --]
From 3034993102b5c3c3c28610e72571908c5ab7aeb4 Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH] devilutionX: update to 1.2.1
Applied suggested changes
Removed nocross
---
srcpkgs/devilutionX/template | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..829ff248926b 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,17 +1,16 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.1.0
+version=1.2.1
revision=1
build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
short_desc="Diablo I engine for modern operating systems"
maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
-nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (12 preceding siblings ...)
2021-04-23 0:03 ` bugcrazy
@ 2021-04-23 0:05 ` bugcrazy
2021-04-23 0:16 ` [PR PATCH] [Merged]: " ericonr
14 siblings, 0 replies; 16+ messages in thread
From: bugcrazy @ 2021-04-23 0:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New review comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/30400#discussion_r618827708
Comment:
Done!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Merged]: devilutionX: update to 1.2.1
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
` (13 preceding siblings ...)
2021-04-23 0:05 ` [PR REVIEW] " bugcrazy
@ 2021-04-23 0:16 ` ericonr
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-23 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
There's a merged pull request on the void-packages repository
devilutionX: update to 1.2.1
https://github.com/void-linux/void-packages/pull/30400
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-04-23 0:16 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 2:07 [PR PATCH] devilutionX: update to 1.2.1 bugcrazy
2021-04-21 16:49 ` [PR REVIEW] " ericonr
2021-04-21 17:33 ` Chocimier
2021-04-21 21:01 ` [PR PATCH] [Updated] " bugcrazy
2021-04-21 21:03 ` [PR REVIEW] " bugcrazy
2021-04-21 21:09 ` ericonr
2021-04-21 21:10 ` ericonr
2021-04-22 4:34 ` [PR PATCH] [Updated] " bugcrazy
2021-04-22 6:09 ` bugcrazy
2021-04-22 6:17 ` [PR REVIEW] " bugcrazy
2021-04-22 6:20 ` bugcrazy
2021-04-22 13:37 ` [PR REVIEW] " ericonr
2021-04-22 23:59 ` [PR PATCH] [Updated] " bugcrazy
2021-04-23 0:03 ` bugcrazy
2021-04-23 0:05 ` [PR REVIEW] " bugcrazy
2021-04-23 0:16 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).