[PR PATCH] fossil: fix distfiles url

[PR PATCH] fossil: fix distfiles url

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

There is a new pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages fossil-fix
https://github.com/void-linux/void-packages/pull/31614

fossil: fix distfiles url
Tarballs are [generated on demand](https://fossil-scm.org/home/help?cmd=/tarball) by fossil. The name of the file in the URL only specifies the name of the root directory inside the tarball, while the `release` parameter selects which tree to download.

All the URLs in the download page include a commit hash, which I wanted to avoid when I made #31609. I thought that omitting it was enough, but this resulted in downloading the most recent commit. Using the tag name works too.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31614.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fossil-fix-31614.patch --]
[-- Type: text/x-diff, Size: 1148 bytes --]

From 6a01be9038711ff5b51cfe8834097ea7cc683893 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 22 Jun 2021 11:49:17 +0200
Subject: [PATCH] fossil: fix distfiles url

---
 srcpkgs/fossil/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/fossil/template b/srcpkgs/fossil/template
index 0f27d910cc7c..6612883fae57 100644
--- a/srcpkgs/fossil/template
+++ b/srcpkgs/fossil/template
@@ -11,9 +11,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://www.fossil-scm.org"
 changelog="https://www.fossil-scm.org/home/doc/trunk/www/changes.wiki"
-distfiles="https://www.fossil-scm.org/home/tarball/fossil-${version}.tar.gz"
-checksum=1844918eacdfa625e1d7efbec688875a6f89eb6c639edc12f158c46ba585494a
-broken="checksum changed after 4 hours https://github.com/void-linux/void-packages/pull/31609"
+distfiles="https://fossil-scm.org/home/tarball/version-${version}/fossil-${version}.tar.gz"
+checksum=39f5a3960ebaa4984fcc953c3307ead5c0f21da4f66ecad516872f89843fcf79
 
 post_extract() {
 	vsed -i 's/test_system_sqlite$/# &/' auto.def  # failing on cross

Re: fossil: fix distfiles url

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/31614#issuecomment-866168047

Comment:
from Manual.md

```
If a distfile changes its checksum for every download because it is packaged
on the fly on the server, like e.g. snapshot tarballs from any of the
`https://*.googlesource.com/` sites, the checksum of the `archive contents`
can be specified by prepending a commercial at (@).
For tarballs you can find the contents checksum by using the command
`tar xf <tarball.ext> --to-stdout | sha256sum`.
```

Re: fossil: fix distfiles url

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/31614#issuecomment-866232824

Comment:
AFAIK the checksum does not change if an exact commit hash or tag name is provided as the `release` parameter of the URL. It changes only if this parameter is omitted (as I did in #31609), because it defaults to the most recent commit.

Re: fossil: fix distfiles url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31614#issuecomment-866269801

Comment:
Can you include the explanation in the commit message?

Re: [PR PATCH] [Updated] fossil: fix distfiles url

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages fossil-fix
https://github.com/void-linux/void-packages/pull/31614

fossil: fix distfiles url
Tarballs are [generated on demand](https://fossil-scm.org/home/help?cmd=/tarball) by fossil. The name of the file in the URL only specifies the name of the root directory inside the tarball, while the `release` parameter selects which tree to download.

All the URLs in the download page include a commit hash, which I wanted to avoid when I made #31609. I thought that omitting it was enough, but this resulted in downloading the most recent commit. Using the tag name works too.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31614.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fossil-fix-31614.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]

From 0901645a24c0fc49420b4ef9bd29df489a57064f Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 22 Jun 2021 11:49:17 +0200
Subject: [PATCH] fossil: fix distfiles url

Tarballs are generated on demand as described at
https://fossil-scm.org/home/help?cmd=/tarball.
The URL in our template has the form
https://fossil-scm.org/home/tarball/<release>/<name>.tar.gz,
where <release> is the commit hash or tag name (defaults to
"trunk" if omitted) and <name> is used as the top-level
directory inside the tarball.
---
 srcpkgs/fossil/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/fossil/template b/srcpkgs/fossil/template
index 0f27d910cc7c..6612883fae57 100644
--- a/srcpkgs/fossil/template
+++ b/srcpkgs/fossil/template
@@ -11,9 +11,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://www.fossil-scm.org"
 changelog="https://www.fossil-scm.org/home/doc/trunk/www/changes.wiki"
-distfiles="https://www.fossil-scm.org/home/tarball/fossil-${version}.tar.gz"
-checksum=1844918eacdfa625e1d7efbec688875a6f89eb6c639edc12f158c46ba585494a
-broken="checksum changed after 4 hours https://github.com/void-linux/void-packages/pull/31609"
+distfiles="https://fossil-scm.org/home/tarball/version-${version}/fossil-${version}.tar.gz"
+checksum=39f5a3960ebaa4984fcc953c3307ead5c0f21da4f66ecad516872f89843fcf79
 
 post_extract() {
 	vsed -i 's/test_system_sqlite$/# &/' auto.def  # failing on cross

Re: fossil: fix distfiles url

[sgn]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31614#issuecomment-866427835

Comment:
Checksum matched with https://www.fossil-scm.org/home/tarball/7cfd58d771e77123dcccfce67da9da633fdba912b6e7019a84912146aa8f06ba/fossil-2.15.2.tar.gz which is available in https://www.fossil-scm.org/home/uv/download.html

Re: [PR PATCH] [Merged]: fossil: fix distfiles url

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There's a merged pull request on the void-packages repository

fossil: fix distfiles url
https://github.com/void-linux/void-packages/pull/31614

Description:
Tarballs are [generated on demand](https://fossil-scm.org/home/help?cmd=/tarball) by fossil. The name of the file in the URL only specifies the name of the root directory inside the tarball, while the `release` parameter selects which tree to download.

All the URLs in the download page include a commit hash, which I wanted to avoid when I made #31609. I thought that omitting it was enough, but this resulted in downloading the most recent commit. Using the tag name works too.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->