[PR PATCH] New packages: xplr-0.14.2

[PR PATCH] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

There is a new pull request by shubham-cpp against master on the void-packages repository

https://github.com/shubham-cpp/void-packages support_xplr
https://github.com/void-linux/void-packages/pull/31606

New packages: xplr-0.14.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31606.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-support_xplr-31606.patch --]
[-- Type: text/x-diff, Size: 3473 bytes --]

From 4378939c469889a684182061845fe24d23ca5f83 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:24:24 +0530
Subject: [PATCH 1/2] Minimalistic X11 color picker written is Rust

---
 srcpkgs/xcolor/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
new file mode 100644
index 000000000000..8ff7421e540f
--- /dev/null
+++ b/srcpkgs/xcolor/template
@@ -0,0 +1,25 @@
+# Template file for 'xcolor'
+pkgname=xcolor
+version=0.5.0
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+build_style=cargo
+makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
+hostmakedepends="rust python3 git pkg-config"
+short_desc="Lightweight color picker for X11 written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/Soft/xcolor"
+# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
+checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
+
+do_fetch() {
+    git clone https://github.com/Soft/xcolor.git ${wrksrc}
+}
+
+post_install() {
+    vman man/xcolor.1
+    vinstall extra/xcolor.desktop 644 usr/share/applications
+    vlicense LICENSE
+}

From 133fd31de17df80ee9185133f81232577dfe7c2f Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:41:55 +0530
Subject: [PATCH 2/2] New packages: xplr-0.14.2

---
 srcpkgs/xplr/README.md |  9 +++++++++
 srcpkgs/xplr/template  | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/xplr/README.md
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/README.md b/srcpkgs/xplr/README.md
new file mode 100644
index 000000000000..b31daee5e4cb
--- /dev/null
+++ b/srcpkgs/xplr/README.md
@@ -0,0 +1,9 @@
+# Usage
+```bash
+# Create a xplr config dir if doesn't exists already
+mkdir -p ~/.config/xplr
+# Copy an example config file
+cp /usr/share/examples/xplr/init.lua ~/.config/xplr
+# Now run the program itself
+xplr
+```
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..8bf742b506cf
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,36 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.14.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+create_wrksrc=yes
+makedepends="libgcc-devel"
+hostmakedepends="curl tar"
+# depends=""
+short_desc="A hackable, minimal, fast TUI file explorer written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+# distfiles="${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz"
+checksum=af7c7cb98a1e7b003c9ae1294fb7f7091ed48fe89ec01bfccac9aba154162c87
+
+do_fetch() {
+    mkdir ${wrksrc}
+    cd ${wrksrc}
+    curl -OLC - ${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz
+    curl -OLC - ${homepage}/raw/v${version}/LICENSE
+    curl -OLC - ${homepage}/raw/v${version}/README.md
+    curl -OLC - ${homepage}/raw/v${version}/src/init.lua
+    curl -OLC - ${homepage}/raw/v${version}/assets/desktop/${pkgname}.desktop
+}
+
+do_install() {
+    cd ${wrksrc}
+	tar fxz ${pkgname}-linux.tar.gz
+    vbin xplr
+    vdoc README.md
+    vsconf init.lua
+    vlicense LICENSE
+    vinstall ${pkgname}.desktop 644 /usr/share/applications
+}

Re: [PR REVIEW] New packages: xplr-0.14.2

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r656145932

Comment:
Why curl and the "do_fetch" rutine and not let xbps-src just do its thing?

Re: New packages: xplr-0.14.2

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-865919770

Comment:
Also only one pkg per PR

Re: New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866041685

Comment:
This nowhere near meets quality requirements, not for commit names, not for package style, not for building, not for getting the distfiles, not for 1 package per PR (but acceptable in this case, please force push to this PR when you fix things, instead of losing history), nor for supported architectures.

Re: [PR REVIEW] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r656306734

Comment:
The manual for xbps mentions that **distfiles** must end with archive format. Can we specify *.desktop,etc file in **distfiles** section

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866060642

Comment:
I didn't know there were so many requirements. I did look at [quality requirement](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality_requirements) section before hand

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866068617

Comment:
Also I have closed the PR of xcolor since the author doesn't seem to create next release

Re: New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866073924

Comment:
In principle these packages can be merged.

However they can not be merged with these templates. Please fix the outstanding quality problems.

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866099800

Comment:
> not for commit names, not for package style,

Didn't understand these

> not for building

By reading this [package-build-phases](https://github.com/void-linux/void-packages/blob/master/Manual.md#package-build-phases). I understand that I need to create `do_extract()` and `do_clean()`

> not for getting the distfiles, 

So I removed the `do_fetch()` and now it shows `ERROR: xplr-0.14.2_1: unknown distfile suffix for LICENSE.`
> not for 1 package per PR (but acceptable in this case, please force push to this PR when you fix things, instead of losing history), 

Fixed this by removing xcolor PR

> nor for supported architectures.

Can't verify this but will look to build on a 32-bit architecture using virtualbox

If there are resources I can look into to gain knowledge, please share. I'm a fan of void and would like to contribute as a gesture for appreciation of this distro

Re: New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866108168

Comment:
> > not for commit names, not for package style,
> 
> Didn't understand these

Commit names are documented at the bottom of the Manual.



> > not for building
> 
> By reading this [package-build-phases](https://github.com/void-linux/void-packages/blob/master/Manual.md#package-build-phases). I understand that I need to create `do_extract()` and `do_clean()`

No, you want to avoid creating any functions at all.


> > not for getting the distfiles,
> 
> So I removed the `do_fetch()` and now it shows `ERROR: xplr-0.14.2_1: unknown distfile suffix for LICENSE.`

Better than having the `do_fetch`. This error can be fixed.

> > not for 1 package per PR (but acceptable in this case, please force push to this PR when you fix things, instead of losing history),
> 
> Fixed this by removing xcolor PR

Acceptable, thank you for doing this and staying within this PR.

> > nor for supported architectures.
> 
> Can't verify this but will look to build on a 32-bit architecture using virtualbox

`xbps-src` will cross build if you tell it to.

> If there are resources I can look into to gain knowledge, please share. I'm a fan of void and would like to contribute as a gesture for appreciation of this distro

The Manual is a great source. Between the Manual and README, you should have all the reference material necessary. You can also look at other rust packages to see how it's done there.

Re: [PR PATCH] [Updated] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

There is an updated pull request by shubham-cpp against master on the void-packages repository

https://github.com/shubham-cpp/void-packages support_xplr
https://github.com/void-linux/void-packages/pull/31606

New packages: xplr-0.14.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31606.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-support_xplr-31606.patch --]
[-- Type: text/x-diff, Size: 4875 bytes --]

From 4378939c469889a684182061845fe24d23ca5f83 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:24:24 +0530
Subject: [PATCH 1/3] Minimalistic X11 color picker written is Rust

---
 srcpkgs/xcolor/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
new file mode 100644
index 000000000000..8ff7421e540f
--- /dev/null
+++ b/srcpkgs/xcolor/template
@@ -0,0 +1,25 @@
+# Template file for 'xcolor'
+pkgname=xcolor
+version=0.5.0
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+build_style=cargo
+makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
+hostmakedepends="rust python3 git pkg-config"
+short_desc="Lightweight color picker for X11 written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/Soft/xcolor"
+# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
+checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
+
+do_fetch() {
+    git clone https://github.com/Soft/xcolor.git ${wrksrc}
+}
+
+post_install() {
+    vman man/xcolor.1
+    vinstall extra/xcolor.desktop 644 usr/share/applications
+    vlicense LICENSE
+}

From 133fd31de17df80ee9185133f81232577dfe7c2f Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:41:55 +0530
Subject: [PATCH 2/3] New packages: xplr-0.14.2

---
 srcpkgs/xplr/README.md |  9 +++++++++
 srcpkgs/xplr/template  | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/xplr/README.md
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/README.md b/srcpkgs/xplr/README.md
new file mode 100644
index 000000000000..b31daee5e4cb
--- /dev/null
+++ b/srcpkgs/xplr/README.md
@@ -0,0 +1,9 @@
+# Usage
+```bash
+# Create a xplr config dir if doesn't exists already
+mkdir -p ~/.config/xplr
+# Copy an example config file
+cp /usr/share/examples/xplr/init.lua ~/.config/xplr
+# Now run the program itself
+xplr
+```
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..8bf742b506cf
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,36 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.14.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+create_wrksrc=yes
+makedepends="libgcc-devel"
+hostmakedepends="curl tar"
+# depends=""
+short_desc="A hackable, minimal, fast TUI file explorer written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+# distfiles="${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz"
+checksum=af7c7cb98a1e7b003c9ae1294fb7f7091ed48fe89ec01bfccac9aba154162c87
+
+do_fetch() {
+    mkdir ${wrksrc}
+    cd ${wrksrc}
+    curl -OLC - ${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz
+    curl -OLC - ${homepage}/raw/v${version}/LICENSE
+    curl -OLC - ${homepage}/raw/v${version}/README.md
+    curl -OLC - ${homepage}/raw/v${version}/src/init.lua
+    curl -OLC - ${homepage}/raw/v${version}/assets/desktop/${pkgname}.desktop
+}
+
+do_install() {
+    cd ${wrksrc}
+	tar fxz ${pkgname}-linux.tar.gz
+    vbin xplr
+    vdoc README.md
+    vsconf init.lua
+    vlicense LICENSE
+    vinstall ${pkgname}.desktop 644 /usr/share/applications
+}

From 2927c46698963275b08f3e3ddf8e604368c58095 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <31388020+shubham-cpp@users.noreply.github.com>
Date: Wed, 23 Jun 2021 09:03:28 +0530
Subject: [PATCH 3/3] Author wont create a release

This template does not meet the requirements, so decided to delete it
---
 srcpkgs/xcolor/template | 25 -------------------------
 1 file changed, 25 deletions(-)
 delete mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
deleted file mode 100644
index 8ff7421e540f..000000000000
--- a/srcpkgs/xcolor/template
+++ /dev/null
@@ -1,25 +0,0 @@
-# Template file for 'xcolor'
-pkgname=xcolor
-version=0.5.0
-revision=1
-archs="x86_64"
-wrksrc=${pkgname}
-build_style=cargo
-makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
-hostmakedepends="rust python3 git pkg-config"
-short_desc="Lightweight color picker for X11 written in Rust"
-maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
-license="MIT"
-homepage="https://github.com/Soft/xcolor"
-# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
-checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
-
-do_fetch() {
-    git clone https://github.com/Soft/xcolor.git ${wrksrc}
-}
-
-post_install() {
-    vman man/xcolor.1
-    vinstall extra/xcolor.desktop 644 usr/share/applications
-    vlicense LICENSE
-}

Re: [PR PATCH] [Updated] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

There is an updated pull request by shubham-cpp against master on the void-packages repository

https://github.com/shubham-cpp/void-packages support_xplr
https://github.com/void-linux/void-packages/pull/31606

New packages: xplr-0.14.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31606.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-support_xplr-31606.patch --]
[-- Type: text/x-diff, Size: 3647 bytes --]

From 4378939c469889a684182061845fe24d23ca5f83 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:24:24 +0530
Subject: [PATCH 1/2] Minimalistic X11 color picker written is Rust

---
 srcpkgs/xcolor/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
new file mode 100644
index 000000000000..8ff7421e540f
--- /dev/null
+++ b/srcpkgs/xcolor/template
@@ -0,0 +1,25 @@
+# Template file for 'xcolor'
+pkgname=xcolor
+version=0.5.0
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+build_style=cargo
+makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
+hostmakedepends="rust python3 git pkg-config"
+short_desc="Lightweight color picker for X11 written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/Soft/xcolor"
+# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
+checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
+
+do_fetch() {
+    git clone https://github.com/Soft/xcolor.git ${wrksrc}
+}
+
+post_install() {
+    vman man/xcolor.1
+    vinstall extra/xcolor.desktop 644 usr/share/applications
+    vlicense LICENSE
+}

From b9b4797a27a52464b9d5a4d2547df67e5a27225d Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:41:55 +0530
Subject: [PATCH 2/2] New packages: xplr-0.14.2

Removed do_fetch() and now using xbps-src distfiles.
---
 srcpkgs/xplr/README.md |  9 +++++++++
 srcpkgs/xplr/template  | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 srcpkgs/xplr/README.md
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/README.md b/srcpkgs/xplr/README.md
new file mode 100644
index 000000000000..b31daee5e4cb
--- /dev/null
+++ b/srcpkgs/xplr/README.md
@@ -0,0 +1,9 @@
+# Usage
+```bash
+# Create a xplr config dir if doesn't exists already
+mkdir -p ~/.config/xplr
+# Copy an example config file
+cp /usr/share/examples/xplr/init.lua ~/.config/xplr
+# Now run the program itself
+xplr
+```
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..62b31a810ab6
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,37 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.14.2
+revision=1
+archs="i686* x86_64*"
+hostmakedepends="tar"
+makedepends="libgcc-devel"
+short_desc="Hackable, minimal, fast TUI file explorer written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz
+	${homepage}/raw/v${version}/LICENSE
+	${homepage}/raw/v${version}/README.md
+	${homepage}/raw/v${version}/src/init.lua
+	${homepage}/raw/v${version}/assets/desktop/${pkgname}.desktop"
+
+checksum="39686ea1cdd1803ed334b19700c59e2e9b2294a28a585f2420b1f8fdfddf33b4
+ 393e9f5a12c614e476ff7067b3fd330dc63304e92d6c3762fa9120cedc7e6b9c
+ bad22089fb474285b73037a069dcbc54432242f97264544c8b368f2763a9772b
+ 1366bbea16fcc66c99f0ab2b11f65ec1a0d8e97b38294f5b3c6c64b1e6667dd4
+ f71844576ef72820b9baddd34c49a04e1f0655dcc88c693eb509589907bdf86f"
+
+tags="file-manager rust"
+
+do_extract() {
+	tar fxz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-linux.tar.gz
+}
+
+do_install() {
+	vbin xplr
+	cd ${XBPS_SRCDISTDIR}/${pkgname}-${version}
+	vdoc README.md
+	vsconf init.lua
+	vlicense LICENSE
+	vinstall ${pkgname}.desktop 644 /usr/share/applications
+}

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866499254

Comment:
1. Removed do_fetch
2. Added tags variable
3. Updated checksums

Also used `xbps-src pkg -a i686 xplr` and it built successfully but it failed for `-a armv7l` and `-a aarch64`. 
Just gave me error that it couldn't built for  armv7l/aarch64 nothing more than that.

The only issue now is regarding 
> commit names

So should I create a new PR(as mentioned in [continuous-integration](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)) or will this be accepted?

Re: New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866505113

Comment:
Please do not create a new PR.

Remove `archs` line and try cross building again.

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866511329

Comment:
Ok noted 📝

Re: [PR PATCH] [Updated] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

There is an updated pull request by shubham-cpp against master on the void-packages repository

https://github.com/shubham-cpp/void-packages support_xplr
https://github.com/void-linux/void-packages/pull/31606

New packages: xplr-0.14.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31606.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-support_xplr-31606.patch --]
[-- Type: text/x-diff, Size: 3818 bytes --]

From 4378939c469889a684182061845fe24d23ca5f83 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:24:24 +0530
Subject: [PATCH 1/2] Minimalistic X11 color picker written is Rust

---
 srcpkgs/xcolor/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
new file mode 100644
index 000000000000..8ff7421e540f
--- /dev/null
+++ b/srcpkgs/xcolor/template
@@ -0,0 +1,25 @@
+# Template file for 'xcolor'
+pkgname=xcolor
+version=0.5.0
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+build_style=cargo
+makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
+hostmakedepends="rust python3 git pkg-config"
+short_desc="Lightweight color picker for X11 written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/Soft/xcolor"
+# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
+checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
+
+do_fetch() {
+    git clone https://github.com/Soft/xcolor.git ${wrksrc}
+}
+
+post_install() {
+    vman man/xcolor.1
+    vinstall extra/xcolor.desktop 644 usr/share/applications
+    vlicense LICENSE
+}

From ec0ead0588946dcb3bdaa62b090dac2e364b6bed Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:41:55 +0530
Subject: [PATCH 2/2] New packages: xplr-0.14.2

Removed do_fetch() and now using xbps-src distfiles.

Add arch x86_64* i686* aarch64* armv[67]l* armv[67]hf*
---
 srcpkgs/xplr/README.md |  9 +++++++++
 srcpkgs/xplr/template  | 43 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 srcpkgs/xplr/README.md
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/README.md b/srcpkgs/xplr/README.md
new file mode 100644
index 000000000000..b31daee5e4cb
--- /dev/null
+++ b/srcpkgs/xplr/README.md
@@ -0,0 +1,9 @@
+# Usage
+```bash
+# Create a xplr config dir if doesn't exists already
+mkdir -p ~/.config/xplr
+# Copy an example config file
+cp /usr/share/examples/xplr/init.lua ~/.config/xplr
+# Now run the program itself
+xplr
+```
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..6aa9c1d338cc
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,43 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.14.2
+revision=1
+archs="x86_64* i686* aarch64* armv[67]l* armv[67]hf*"
+hostmakedepends="tar"
+makedepends="libgcc-devel"
+short_desc="Hackable, minimal, fast TUI file explorer written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-linux.tar.gz
+	${homepage}/raw/v${version}/LICENSE
+	${homepage}/raw/v${version}/README.md
+	${homepage}/raw/v${version}/src/init.lua
+	${homepage}/raw/v${version}/assets/desktop/${pkgname}.desktop"
+
+checksum="39686ea1cdd1803ed334b19700c59e2e9b2294a28a585f2420b1f8fdfddf33b4
+ 393e9f5a12c614e476ff7067b3fd330dc63304e92d6c3762fa9120cedc7e6b9c
+ bad22089fb474285b73037a069dcbc54432242f97264544c8b368f2763a9772b
+ 1366bbea16fcc66c99f0ab2b11f65ec1a0d8e97b38294f5b3c6c64b1e6667dd4
+ f71844576ef72820b9baddd34c49a04e1f0655dcc88c693eb509589907bdf86f"
+
+tags="file-manager rust"
+
+case "$XBPS_TARGET_MACHINE" in
+	aarch64*|arm*)
+		nostrip=yes
+		;;
+esac
+
+do_extract() {
+	tar fxz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-linux.tar.gz
+}
+
+do_install() {
+	vbin xplr
+	cd ${XBPS_SRCDISTDIR}/${pkgname}-${version}
+	vdoc README.md
+	vsconf init.lua
+	vlicense LICENSE
+	vinstall ${pkgname}.desktop 644 /usr/share/applications
+}

Re: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866557596

Comment:
So I ran `xbps-src pkg -f -a <arch_name> -K xplr` on 
- x86_64* 
- i686*
-  aarch64* 
- armv[67]l* 
- armv[67]hf*

The command did gave me following errors errors
- ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/ppc64-musl-repodata':
- ERROR: base-files-0.142_11: [unpack] failed to extract file `./bin': Directory not empty

For following architectures  
- armv5te
- mips-musl
- ppc64
- ppcle

Re: New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#issuecomment-866969625

Comment:
Do you still have your own `do_extract`?

Stop that.

Re: [PR REVIEW] New packages: xplr-0.14.2

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657274123

Comment:
Drop.
These files are all present in the source pkg and therefore also correct checksum to only one ..

Re: [PR REVIEW] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657287182

Comment:
The [xplr](https://github.com/sayanarijit/xplr/releases/download/v0.14.2/xplr-linux.tar.gz) release includes only binary and noting else. I have used [PKGBUILD](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xplr-bin) as reference

Re: [PR REVIEW] New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657303842

Comment:
and no source code? You can't get the source code somehow?

Re: [PR REVIEW] New packages: xplr-0.14.2

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657304273

Comment:
PKGBUILDs, apparently, are not a good reference for Void packages. We prefer building from source. Please correct this defect in these templates.

Re: [PR REVIEW] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657340871

Comment:
Bare with my ignorance, but the whole point of using void is to have binary packages and compile less as compared to arch, etc

Re: [PR REVIEW] New packages: xplr-0.14.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657341843

Comment:
Binary packages are still built from some source. We prefer to be the ones to build from source, not just repackage files provided by upstream

Re: [PR REVIEW] New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31606#discussion_r657359025

Comment:
Then I don't think we need this template. Because we could just install xplr using cargo. 

Re: [PR PATCH] [Closed]: New packages: xplr-0.14.2

[shubham-cpp]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

There's a closed pull request on the void-packages repository

New packages: xplr-0.14.2
https://github.com/void-linux/void-packages/pull/31606

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl