Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: go: reduce package size by stripping binaries and removing pkg
Date: Sat, 17 Jul 2021 22:36:04 +0200	[thread overview]
Message-ID: <20210717203604._m2nXFHC7md2fMr40_Ee6zYZmqrji8R-m8kmr01UvDU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32016@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32016#issuecomment-881956642

Comment:
Thanks for the reference.

I think removing the testdata, thus allowing `nostrip=yes` to be removed from the template, is a good idea. Avoids manually calling `$STRIP`.

Your commit should document that Go 1.12, which we use for bootstrap and therefore matters re. what options the compiler can be built with, is from 2019 and new enough.

You should also remove `nostrip=yes` from the `go` build style (if the compiler can be stripped, so should the resulting binaries). The build style change should be a separate commit.

I'm not sure how I feel about removing the pre-built standard library... @Vaelatern and @Gottox might have thoughts on that idea, but I would initially be weakly against it. Removing `/usr/lib/go/pkg/linux_$arch/cmd/` sounds more reasonable; I don't think it can be imported either.

  parent reply	other threads:[~2021-07-17 20:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17  4:59 [PR PATCH] " arp242
2021-07-17  5:00 ` arp242
2021-07-17  5:06 ` [PR PATCH] [Updated] " arp242
2021-07-17 19:41 ` arp242
2021-07-17 20:36 ` ericonr [this message]
2021-07-18  5:56 ` [PR PATCH] [Updated] " arp242
2021-07-18  6:07 ` arp242
2021-07-18 21:27 ` ericonr
2021-07-19  6:31 ` arp242
2021-07-20 19:00 ` [PR PATCH] [Updated] " arp242
2021-10-12  1:07 ` [PR PATCH] [Closed]: " arp242

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210717203604._m2nXFHC7md2fMr40_Ee6zYZmqrji8R-m8kmr01UvDU@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).