Re: [PR PATCH] [Updated] go: reduce package size by stripping binaries and removing pkg

[arp242 <arp242@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3047 bytes --]

There is an updated pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages gosize
https://github.com/void-linux/void-packages/pull/32016

go: reduce package size by stripping binaries and removing pkg
A very long time ago strip didn't always work well on Go binaries, but this has
been fixed for almost a decade[1], so there is no need to keep this.

Just the standard strip hook won't work, as it will try (and fail) to strip
files in testdata and some other things. You can add nostrip_files, but that
would be a long list.

[1]: http://dominik.honnef.co/posts/2016/10/go-and-strip/

---

This also removes the pkg/linux_arch directory from the installation. This is a
pre-compiled cache of the standard library, and isn't really needed. The only
downside of not installing it is that the first compile will take a few seconds
longer (after which it's in the cache), and since the Go compiler is fairly fast
it's not a big deal IMO.

Alternatively, only pkg/cmd could be removed. This contains the cache for the go
command and "go tool [..]" commands, but you can never import this as it's all
"package main", so it's a useless cache AFAIK. It's also the biggest contributor
to the size.

---

Comparison of sizes (each one relative to the previous one):

	current       Package:   111M         Installed: 369M
	rm pkg/cmd    Package:    90M (-21M)  Installed: 268M (-101M)
	strip         Package:    62M (-28M)  Installed: 236M (-32M)
	rm pkg        Package:    45M (-17M)  Installed: 158M (-78M)

So that's a total saving of 66M in the package size, and 211M for the installed
size.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32016.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gosize-32016.patch --]
[-- Type: text/x-diff, Size: 4853 bytes --]

From 66b8464642c1c27f9b4fdeb08a93e774e8a16a2b Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Sat, 17 Jul 2021 12:52:50 +0800
Subject: [PATCH 1/2] go: reduce package size by stripping binaries and
 removing pkg

A very long time ago strip didn't always work well on Go binaries, but this has
been fixed for almost a decade[1], so there is no need to keep this.

Just the standard strip hook won't work, as it will try (and fail) to strip
files in testdata and some other things. You can add nostrip_files, but that
would be a long list.

[1]: http://dominik.honnef.co/posts/2016/10/go-and-strip/

---

This also removes the pkg/linux_arch directory from the installation. This is a
pre-compiled cache of the standard library, and isn't really needed. The only
downside of not installing it is that the first compile will take a few seconds
longer (after which it's in the cache), and since the Go compiler is fairly fast
it's not a big deal IMO.

Alternatively, only pkg/cmd could be removed. This contains the cache for the go
command and "go tool [..]" commands, but you can never import this as it's all
"package main", so it's a useless cache AFAIK. It's also the biggest contributor
to the size.

---

Comparison of sizes (each one relative to the previous one):

	current       Package:   111M         Installed: 369M
	rm pkg/cmd    Package:    90M (-21M)  Installed: 268M (-101M)
	strip         Package:    62M (-28M)  Installed: 236M (-32M)
	rm pkg        Package:    45M (-17M)  Installed: 158M (-78M)

So that's a total saving of 66M in the package size, and 211M for the installed
size.
---
 srcpkgs/go/template | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index d9e2c5a9ba69..8a496fd23e84 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,7 +1,7 @@
 # Template file for 'go'
 pkgname=go
 version=1.16.6
-revision=1
+revision=2
 create_wrksrc=yes
 build_wrksrc=go
 hostmakedepends="go1.12-bootstrap"
@@ -64,6 +64,13 @@ do_install() {
 	cp -r doc misc -t ${DESTDIR}/usr/share/go
 	ln -s /usr/share/go/doc ${DESTDIR}/usr/lib/go/doc
 
+	if [ -z "$XBPS_DEBUG_PKGS" ]; then
+		/usr/bin/$STRIP \
+			${DESTDIR}/usr/bin/go \
+			${DESTDIR}/usr/bin/gofmt \
+			${DESTDIR}/usr/lib/go/pkg/tool/linux_${_goarch}/*
+	fi
+
 	# This is to make go get code.google.com/p/go-tour/gotour and
 	# then running the gotour executable work out of the box.
 	#
@@ -81,6 +88,7 @@ do_install() {
 	rm -f ${DESTDIR}/usr/lib/go/pkg/tool/*/api
 	rm -rf ${DESTDIR}/usr/lib/go/pkg/bootstrap
 	rm -rf ${DESTDIR}/usr/lib/go/pkg/obj
+	rm -rf ${DESTDIR}/usr/lib/go/pkg/linux_${_goarch}
 
 	vlicense LICENSE
 }

From 80cede50f4a6b0ff94d2103620b7cb20d3fe2b64 Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Sun, 18 Jul 2021 13:53:44 +0800
Subject: [PATCH 2/2] Also remove some stuff from src

Don't really need _test.go files or testdata

The cmd package is only useful for "go doc cmd/.."; which is referenced
in various places in "go help [..]". We can't really remove all of that
without breaking it, but we can at least remove the internal and
vendored stuff, which is quite a lot of data.
---
 srcpkgs/go/template | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 8a496fd23e84..55c9bde0e1a4 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -12,7 +12,7 @@ homepage="http://golang.org/"
 changelog="https://golang.org/doc/devel/release.html"
 distfiles="https://golang.org/dl/go${version}.src.tar.gz"
 checksum=a3a5d4bc401b51db065e4f93b523347a4d343ae0c0b08a65c3423b05a138037d
-nostrip=yes
+nopie=yes
 noverifyrdeps=yes
 
 case "${XBPS_TARGET_MACHINE}" in
@@ -64,12 +64,12 @@ do_install() {
 	cp -r doc misc -t ${DESTDIR}/usr/share/go
 	ln -s /usr/share/go/doc ${DESTDIR}/usr/lib/go/doc
 
-	if [ -z "$XBPS_DEBUG_PKGS" ]; then
-		/usr/bin/$STRIP \
-			${DESTDIR}/usr/bin/go \
-			${DESTDIR}/usr/bin/gofmt \
-			${DESTDIR}/usr/lib/go/pkg/tool/linux_${_goarch}/*
-	fi
+	# Remove things from src that we don't need.
+	find ${DESTDIR}/usr/lib/go/src -name '*_test.go' -o -name 'testdata' -exec rm -rf {} \+
+	rm ${DESTDIR}/usr/lib/go/src/*.{bash,rc,bat,dist}
+
+	# cmd source is only useful for "go doc cmd/...".
+	find ${DESTDIR}/usr/lib/go/src/cmd -name 'internal' -o -name 'vendor' -exec rm -rf {} \+
 
 	# This is to make go get code.google.com/p/go-tour/gotour and
 	# then running the gotour executable work out of the box.
@@ -77,7 +77,6 @@ do_install() {
 	# Also, /usr/bin is the place for system-wide executables,
 	# not /usr/lib/go/bin. Users should use different paths by
 	# setting the appropriate environment variables.
-	#
 	ln -sf /usr/bin ${DESTDIR}/usr/lib/go/bin
 
 	# <dominikh> sigh. well, someone fix the template and add