Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: go: reduce package size by stripping binaries and removing pkg
Date: Sun, 18 Jul 2021 23:27:09 +0200	[thread overview]
Message-ID: <20210718212709.XEUjcjtxlpIOhL_VMdCrVHoQgGYESQyACfD6DdmZg1Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32016@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32016#issuecomment-882118894

Comment:
 > I don't really follow what you mean with that? As in, I understand the go-bootstrap package, but I don't follow how this relates to this change/commit? We don't really build anything with Go directly, it just uses the make.bash script (which assumes Go 1.4).

This matters because the Go binaries would have been built with the old toolchain, so its runtime also needs to support stripped binaries. But I think we do a double bootstrap, so it might not matter after all. Would have to check.

> As for the pre-built stdlib, personally I don't really see a reason to ship it; especially for containers etc. it's comparatively large, and unlike Python's .pyc files they can just be generated as-needed, which also keeps all the Go cache in one place which is kinda nice IMO.

It's bigger for a container, but it's a "time saver", possibly... I'd like to have thoughts from other before merging that part.

> We'd have to add back nostrip back with the manual strip call if we do decide to add it btw, as the strip hook will try and fail to strip those .a files.

Ugh :/ That's a reasonable reason for it, unfortunately.

  parent reply	other threads:[~2021-07-18 21:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17  4:59 [PR PATCH] " arp242
2021-07-17  5:00 ` arp242
2021-07-17  5:06 ` [PR PATCH] [Updated] " arp242
2021-07-17 19:41 ` arp242
2021-07-17 20:36 ` ericonr
2021-07-18  5:56 ` [PR PATCH] [Updated] " arp242
2021-07-18  6:07 ` arp242
2021-07-18 21:27 ` ericonr [this message]
2021-07-19  6:31 ` arp242
2021-07-20 19:00 ` [PR PATCH] [Updated] " arp242
2021-10-12  1:07 ` [PR PATCH] [Closed]: " arp242

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210718212709.XEUjcjtxlpIOhL_VMdCrVHoQgGYESQyACfD6DdmZg1Y@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).