* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
@ 2021-07-30 0:38 ` Naia-love
2021-07-30 9:46 ` [PR REVIEW] " paper42
` (24 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 0:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 2750 bytes --]
From c2eb5261b19424227630a841dde594dbc1d43848 Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 42 +++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..5d74acedd685
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=/usr/share/icons/hicolor/1024x1024/apps/session.png
+Exec=session
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..ab8562fb0720
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,42 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 don't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+pre_build() {
+ git lfs install
+ yarn install --frozen-lockfile
+}
+
+do_build() {
+ yarn grunt --force
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+ vinstall images/session/session_icon_1024.png 644 usr/share/icons/hicolor/1024x1024/apps/ session.png
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
2021-07-30 0:38 ` [PR PATCH] [Updated] " Naia-love
@ 2021-07-30 9:46 ` paper42
2021-07-30 11:13 ` Naia-love
` (23 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: paper42 @ 2021-07-30 9:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679797020
Comment:
Icon=session should be enough, the DE will then select a prefered size and format.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
2021-07-30 0:38 ` [PR PATCH] [Updated] " Naia-love
2021-07-30 9:46 ` [PR REVIEW] " paper42
@ 2021-07-30 11:13 ` Naia-love
2021-07-30 11:21 ` Naia-love
` (22 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 11:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679845361
Comment:
Yes that what I thought. But as it have only one size, on the DE (at least Plasma for me) there's just no icon shown 🤷♀️
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (2 preceding siblings ...)
2021-07-30 11:13 ` Naia-love
@ 2021-07-30 11:21 ` Naia-love
2021-07-30 11:21 ` Naia-love
` (21 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 11:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679845361
Comment:
Yes that what I thought. But as it have only one size (a png of 1024), on the DE (at least Plasma for me) there's just no icon shown 🤷♀️.
There's also a .svg, but idk where to put it ^^' (but u could generate some more . png with it)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (3 preceding siblings ...)
2021-07-30 11:21 ` Naia-love
@ 2021-07-30 11:21 ` Naia-love
2021-07-30 11:22 ` Naia-love
` (20 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 11:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679845361
Comment:
Yes that what I thought. But as it have only one size (a png of 1024), on the DE (at least Plasma for me) there's just no icon shown 🤷♀️.
There's also a .svg, but idk where to put it ^^' (but I could generate some more . png with it)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (4 preceding siblings ...)
2021-07-30 11:21 ` Naia-love
@ 2021-07-30 11:22 ` Naia-love
2021-07-30 12:30 ` [PR PATCH] [Updated] " Naia-love
` (19 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 11:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679845361
Comment:
Yes that what I thought. But as it have only one size (a png of 1024), on the DE (at least Plasma for me) there's just no icon shown 🤷♀️.
There's also a .svg, but idk where to put it ^^' (but I could generate some more .png with it)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (5 preceding siblings ...)
2021-07-30 11:22 ` Naia-love
@ 2021-07-30 12:30 ` Naia-love
2021-07-30 12:32 ` Naia-love
` (18 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 12:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 2750 bytes --]
From 7d2d8b57203805e8f28e17bf06ba7cdb2965e26d Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 42 +++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..5d74acedd685
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=/usr/share/icons/hicolor/1024x1024/apps/session.png
+Exec=session
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..ab8562fb0720
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,42 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 don't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+pre_build() {
+ git lfs install
+ yarn install --frozen-lockfile
+}
+
+do_build() {
+ yarn grunt --force
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+ vinstall images/session/session_icon_1024.png 644 usr/share/icons/hicolor/1024x1024/apps/ session.png
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (6 preceding siblings ...)
2021-07-30 12:30 ` [PR PATCH] [Updated] " Naia-love
@ 2021-07-30 12:32 ` Naia-love
2021-07-30 12:37 ` Naia-love
` (17 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 12:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 2750 bytes --]
From 75eca1b9beafbc4b117eb733ff15000e1c8ceb2a Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 42 +++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..5d74acedd685
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=/usr/share/icons/hicolor/1024x1024/apps/session.png
+Exec=session
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..ab8562fb0720
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,42 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 don't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+pre_build() {
+ git lfs install
+ yarn install --frozen-lockfile
+}
+
+do_build() {
+ yarn grunt --force
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+ vinstall images/session/session_icon_1024.png 644 usr/share/icons/hicolor/1024x1024/apps/ session.png
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (7 preceding siblings ...)
2021-07-30 12:32 ` Naia-love
@ 2021-07-30 12:37 ` Naia-love
2021-07-30 13:01 ` [PR REVIEW] " paper42
` (16 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 12:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 2790 bytes --]
From 1d47d932ce560accd14304c1f7b79fed9a1b1fd7 Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 46 +++++++++++++++++++
2 files changed, 55 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..250e8dd9d039
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=session
+Exec=session
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..5cfb090af24c
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,46 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 don't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar ImageMagick"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+pre_build() {
+ git lfs install
+ yarn install --frozen-lockfile
+}
+
+do_build() {
+ yarn grunt --force
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+
+ for size in 16 32 48 128 256 480 512 1024; do
+ convert -size ${size}x${size} -background none images/session/session_icon.svg images/session/icon_${size}.png
+ vinstall images/session/icon_${size}.png 644 usr/share/icons/hicolor/${size}x${size}/apps/ session.png
+ done
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (8 preceding siblings ...)
2021-07-30 12:37 ` Naia-love
@ 2021-07-30 13:01 ` paper42
2021-07-30 13:05 ` Naia-love
` (15 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: paper42 @ 2021-07-30 13:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679907227
Comment:
`/usr/share/icons/hicolor/scalable/apps/`
Isn't upstream providing a desktop file? Don't they have a Makefile which installs everything?
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (9 preceding siblings ...)
2021-07-30 13:01 ` [PR REVIEW] " paper42
@ 2021-07-30 13:05 ` Naia-love
2021-07-30 13:21 ` FollieHiyuki
` (14 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 13:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679909355
Comment:
They don't, it's built with yarn (the build system is basically the same as signal-desktop as it's a *now pretty much different* fork). I also modified to generate some png.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (10 preceding siblings ...)
2021-07-30 13:05 ` Naia-love
@ 2021-07-30 13:21 ` FollieHiyuki
2021-07-30 13:25 ` paper42
` (13 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: FollieHiyuki @ 2021-07-30 13:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
New review comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679919892
Comment:
I think the consensus is to not restricting archs. Instead use a `broken` statement (with comment). You can grep for that in the repository.
Also typo : `aarch64 doesn't seem very stable for now and isn't officially supported`
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (11 preceding siblings ...)
2021-07-30 13:21 ` FollieHiyuki
@ 2021-07-30 13:25 ` paper42
2021-07-30 13:29 ` FollieHiyuki
` (12 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: paper42 @ 2021-07-30 13:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679923046
Comment:
I think this is fine, but is it also broken on x86_64-musl?
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (12 preceding siblings ...)
2021-07-30 13:25 ` paper42
@ 2021-07-30 13:29 ` FollieHiyuki
2021-07-30 13:54 ` Naia-love
` (11 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: FollieHiyuki @ 2021-07-30 13:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
New review comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679919892
Comment:
I think the consensus is to not restrict archs. Instead use a `broken` statement (with comment). You can grep for that in the repository.
Also typo : `aarch64 doesn't seem very stable for now and isn't officially supported`
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (13 preceding siblings ...)
2021-07-30 13:29 ` FollieHiyuki
@ 2021-07-30 13:54 ` Naia-love
2021-07-30 14:06 ` [PR PATCH] [Updated] " Naia-love
` (10 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 13:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679943383
Comment:
Electron doesn't official support musl, there are patches but so it would to edit the builds scripts of Session, so it fetches the patched version of Electron, and I don't know how to do that (I could search tho)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (14 preceding siblings ...)
2021-07-30 13:54 ` Naia-love
@ 2021-07-30 14:06 ` Naia-love
2021-07-30 14:12 ` [PR REVIEW] " FollieHiyuki
` (9 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 2790 bytes --]
From b183116d8166f7675079cae0ed1382608235cdc8 Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 46 +++++++++++++++++++
2 files changed, 55 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..250e8dd9d039
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=session
+Exec=session
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..5cfb090af24c
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,46 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 don't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar ImageMagick"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+pre_build() {
+ git lfs install
+ yarn install --frozen-lockfile
+}
+
+do_build() {
+ yarn grunt --force
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+
+ for size in 16 32 48 128 256 480 512 1024; do
+ convert -size ${size}x${size} -background none images/session/session_icon.svg images/session/icon_${size}.png
+ vinstall images/session/icon_${size}.png 644 usr/share/icons/hicolor/${size}x${size}/apps/ session.png
+ done
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (15 preceding siblings ...)
2021-07-30 14:06 ` [PR PATCH] [Updated] " Naia-love
@ 2021-07-30 14:12 ` FollieHiyuki
2021-07-30 15:33 ` Johnnynator
` (8 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: FollieHiyuki @ 2021-07-30 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r679957437
Comment:
We have some Electron packages (Element, Vscode, RockerChat). You can look into those for the way to make the package use the system Electron.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (16 preceding siblings ...)
2021-07-30 14:12 ` [PR REVIEW] " FollieHiyuki
@ 2021-07-30 15:33 ` Johnnynator
2021-07-30 15:50 ` Naia-love
` (7 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Johnnynator @ 2021-07-30 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r680018632
Comment:
They use Electron 8.2.0, which is over 1y old...
( https://github.com/oxen-io/session-desktop/blob/v1.6.9/yarn.lock#L3351
https://github.com/electron/electron/releases/tag/v8.2.0 )
So using system electron isn't a option right now (We do not, and never will ship electron 8, it is long EOL and I would rather not add a package which depends on it.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (17 preceding siblings ...)
2021-07-30 15:33 ` Johnnynator
@ 2021-07-30 15:50 ` Naia-love
2021-07-30 17:42 ` Naia-love
` (6 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 15:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r680029580
Comment:
> They use Electron 8.2.0, which is over 1y old...
> ( https://github.com/oxen-io/session-desktop/blob/v1.6.9/yarn.lock#L3351
> https://github.com/electron/electron/releases/tag/v8.2.0 )
>
> So using system electron isn't a option right now (We do not, and never will ship electron 8, it is long EOL and I would rather not add a package which depends on it.
The app seems to run fine using electron 12 from what i'm testing rn ^^
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (18 preceding siblings ...)
2021-07-30 15:50 ` Naia-love
@ 2021-07-30 17:42 ` Naia-love
2021-07-30 18:03 ` [PR PATCH] [Updated] " Naia-love
` (5 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 17:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r680029580
Comment:
> They use Electron 8.2.0, which is over 1y old...
> ( https://github.com/oxen-io/session-desktop/blob/v1.6.9/yarn.lock#L3351
> https://github.com/electron/electron/releases/tag/v8.2.0 )
>
> So using system electron isn't a option right now (We do not, and never will ship electron 8, it is long EOL and I would rather not add a package which depends on it.
The app seems to run fine using electron 12 from what i'm testing rn ^^
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Updated] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (19 preceding siblings ...)
2021-07-30 17:42 ` Naia-love
@ 2021-07-30 18:03 ` Naia-love
2021-07-30 18:09 ` [PR REVIEW] " Naia-love
` (4 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 18:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
There is an updated pull request by Naia-love against master on the void-packages repository
https://github.com/Naia-love/void-packages session-desktop
https://github.com/void-linux/void-packages/pull/32252
New package: session-desktop-1.6.9
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/32252.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-session-desktop-32252.patch --]
[-- Type: text/x-diff, Size: 3111 bytes --]
From ab434a4594fbdac819e05131c79d450d9dd255ef Mon Sep 17 00:00:00 2001
From: Naia-love <love.naia@protonmail.com>
Date: Fri, 30 Jul 2021 02:26:00 +0200
Subject: [PATCH] New package: session-desktop-1.6.9
---
srcpkgs/session-desktop/files/session.desktop | 9 ++++
srcpkgs/session-desktop/template | 53 +++++++++++++++++++
2 files changed, 62 insertions(+)
create mode 100644 srcpkgs/session-desktop/files/session.desktop
create mode 100644 srcpkgs/session-desktop/template
diff --git a/srcpkgs/session-desktop/files/session.desktop b/srcpkgs/session-desktop/files/session.desktop
new file mode 100644
index 000000000000..5ba00d506acb
--- /dev/null
+++ b/srcpkgs/session-desktop/files/session.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Session
+GenericName=Messenger
+Comment=Session is an end-to-end encrypted messenger.
+Icon=session
+Exec=session --use-tray-icon
+Categories=Network;Messenger;
+StartupNotify=true
diff --git a/srcpkgs/session-desktop/template b/srcpkgs/session-desktop/template
new file mode 100644
index 000000000000..dea2a2a19f2f
--- /dev/null
+++ b/srcpkgs/session-desktop/template
@@ -0,0 +1,53 @@
+# Template file for 'session-desktop'
+pkgname=session-desktop
+version=1.6.9
+revision=1
+# discontinued Electron 32-bit support: https://www.electronjs.org/blog/linux-32bit-support
+# aarch64 dosen't seems very stable for now and isn't officialy supported: https://github.com/oxen-io/session-desktop/issues/1635
+archs="x86_64"
+hostmakedepends="curl nodejs python yarn git git-lfs tar ImageMagick"
+depends="cairo gtk+3 libvips pango alsa-lib nss libXtst dbus-libs libnotify"
+short_desc="Session is an end-to-end encrypted messenger"
+maintainer="Naia-love <me@naia.gay>"
+license="GPL-3.0-or-later"
+homepage="https://getsession.org"
+distfiles="https://github.com/oxen-io/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4abf94eb2233a19687c9d87a7644d51eb7199ae0f04deba9647cbe4c7c0a3afa
+
+
+pre_build() {
+ # fix for systray
+ for size in 16 32 48 128 256 480 512 1024; do
+ convert -size ${size}x${size} -background none images/session/session_icon.svg images/session/session_icon_${size}.png
+ done
+
+ git lfs install
+ yarn install --frozen-lockfile --arch=x64
+
+ sed -i 's/"updatesEnabled": true/"updatesEnabled": false/' config/production.json # disable updates's notification
+}
+
+do_build() {
+ yarn generate
+ yarn build-release
+}
+
+do_install() {
+ vmkdir usr/lib/session-desktop
+
+ vcopy release/linux-unpacked/* usr/lib/session-desktop
+
+ vmkdir usr/bin
+ ln -s /usr/lib/session-desktop/session-desktop ${DESTDIR}/usr/bin/session
+ ln -s /usr/lib/session-desktop/session-desktop-bin ${DESTDIR}/usr/bin/
+
+ vmkdir usr/share/applications
+ vinstall ${FILESDIR}/session.desktop 644 usr/share/applications/
+
+ vmkdir usr/share/icons/hicolor
+
+ for size in 16 32 48 128 256 480 512 1024; do
+ vinstall images/session/session_icon_${size}.png 644 usr/share/icons/hicolor/${size}x${size}/apps/ session.png
+ done
+ vinstall images/session/session_icon.svg 644 usr/share/icons/hicolor/scalable/apps/ session.svg
+}
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR REVIEW] New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (20 preceding siblings ...)
2021-07-30 18:03 ` [PR PATCH] [Updated] " Naia-love
@ 2021-07-30 18:09 ` Naia-love
2021-10-08 20:20 ` HadetTheUndying
` (3 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-07-30 18:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r680133178
Comment:
So I have spent a few hours trying to make it work with musl, but didn't get very far ^^'
I guess it'd require some patching (main problem is yea the fact it uses an old electron version. Also, just that I wasn't able to make the install script not download electron and doing AppImage *which don't seems to work on musl* despite heavily modifying it, but about that I may just have done something wrong tho ^^').
Besides, signal do not either support musl, or Session is a fork of it.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (21 preceding siblings ...)
2021-07-30 18:09 ` [PR REVIEW] " Naia-love
@ 2021-10-08 20:20 ` HadetTheUndying
2021-10-08 20:25 ` Naia-love
` (2 subsequent siblings)
25 siblings, 0 replies; 27+ messages in thread
From: HadetTheUndying @ 2021-10-08 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
New comment by HadetTheUndying on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#issuecomment-939094484
Comment:
I had a conversation with the devs recently on Twitter. Session should build against the latest Electron do you mind giving this another go or if I were to take over?
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (22 preceding siblings ...)
2021-10-08 20:20 ` HadetTheUndying
@ 2021-10-08 20:25 ` Naia-love
2022-05-31 2:13 ` github-actions
2022-06-14 2:13 ` [PR PATCH] [Closed]: " github-actions
25 siblings, 0 replies; 27+ messages in thread
From: Naia-love @ 2021-10-08 20:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
New comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#issuecomment-939096837
Comment:
> I had a conversation with the devs recently on Twitter. Session should build against the latest Electron do you mind giving this another go or if I were to take over?
yes go ahead, I was getting some troubles to even just try to use system's electron ^^'
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (23 preceding siblings ...)
2021-10-08 20:25 ` Naia-love
@ 2022-05-31 2:13 ` github-actions
2022-06-14 2:13 ` [PR PATCH] [Closed]: " github-actions
25 siblings, 0 replies; 27+ messages in thread
From: github-actions @ 2022-05-31 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#issuecomment-1141597490
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PR PATCH] [Closed]: New package: session-desktop-1.6.9
2021-07-30 0:33 [PR PATCH] New package: session-desktop-1.6.9 Naia-love
` (24 preceding siblings ...)
2022-05-31 2:13 ` github-actions
@ 2022-06-14 2:13 ` github-actions
25 siblings, 0 replies; 27+ messages in thread
From: github-actions @ 2022-06-14 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There's a closed pull request on the void-packages repository
New package: session-desktop-1.6.9
https://github.com/void-linux/void-packages/pull/32252
Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
^ permalink raw reply [flat|nested] 27+ messages in thread