* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
@ 2021-08-07 17:35 ` paper42
2021-08-07 20:10 ` teldra
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-08-07 17:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684658701
Comment:
they don't have tests, why is this here? can we also remove do_check, because it doesn't do anything?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
2021-08-07 17:35 ` [PR REVIEW] " paper42
@ 2021-08-07 20:10 ` teldra
2021-08-08 20:53 ` ericonr
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-07 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New review comment by teldra on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684672699
Comment:
https://github.com/void-linux/void-packages/pull/28806#discussion_r578131916
This is the reason.
I am open to delete it.
Ping @ericonr
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
2021-08-07 17:35 ` [PR REVIEW] " paper42
2021-08-07 20:10 ` teldra
@ 2021-08-08 20:53 ` ericonr
2021-08-08 21:30 ` [PR PATCH] [Updated] " teldra
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-08 20:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684827577
Comment:
Feel free to remove, ahesford's complained about me recommending adding checkdepends when tests aren't defined too.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (2 preceding siblings ...)
2021-08-08 20:53 ` ericonr
@ 2021-08-08 21:30 ` teldra
2021-08-08 21:32 ` teldra
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387
volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64-musl
- [x] armv7l
- [x] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1357 bytes --]
From c547ee42f739773d08c9a7928b8c1a40a655a7ad Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.
---
srcpkgs/volctl/template | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..b8e4f0ee3689 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
# Template file for 'volctl'
pkgname=volctl
-version=0.8.2
+version=0.9.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
short_desc="Lightweight volume control for pulseaudio in your systray"
maintainer="teldra <teldra@rotce.de>"
license="GPL-2.0-only"
homepage="https://buzz.github.io/volctl/"
distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
- xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=extended
\ No newline at end of file
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (3 preceding siblings ...)
2021-08-08 21:30 ` [PR PATCH] [Updated] " teldra
@ 2021-08-08 21:32 ` teldra
2021-08-08 21:33 ` [PR REVIEW] " teldra
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387
volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64-musl
- [x] armv7l
- [x] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1329 bytes --]
From 84fa6d81ac043a09dcf69755b2d8d2917f9c10d0 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.
---
srcpkgs/volctl/template | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..de3da69c7d30 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
# Template file for 'volctl'
pkgname=volctl
-version=0.8.2
+version=0.9.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
short_desc="Lightweight volume control for pulseaudio in your systray"
maintainer="teldra <teldra@rotce.de>"
license="GPL-2.0-only"
homepage="https://buzz.github.io/volctl/"
distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
- xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=extended
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (4 preceding siblings ...)
2021-08-08 21:32 ` teldra
@ 2021-08-08 21:33 ` teldra
2021-08-08 21:35 ` ericonr
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
New review comment by teldra on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684832097
Comment:
If make_check=extended is correct, this can be marked as resolved. If I should use make_check=no, let me know.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (5 preceding siblings ...)
2021-08-08 21:33 ` [PR REVIEW] " teldra
@ 2021-08-08 21:35 ` ericonr
2021-08-08 21:36 ` [PR PATCH] [Updated] " teldra
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-08 21:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684832250
Comment:
I suppose it'd be `make_check=no`, since there aren't any to be run.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (6 preceding siblings ...)
2021-08-08 21:35 ` ericonr
@ 2021-08-08 21:36 ` teldra
2021-08-08 21:36 ` [PR REVIEW] " paper42
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387
volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64-musl
- [x] armv7l
- [x] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]
From cb3775efa00403cc3bac4d55a874467ce8f0e85a Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.
---
srcpkgs/volctl/template | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..6e952096dad1 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
# Template file for 'volctl'
pkgname=volctl
-version=0.8.2
+version=0.9.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
short_desc="Lightweight volume control for pulseaudio in your systray"
maintainer="teldra <teldra@rotce.de>"
license="GPL-2.0-only"
homepage="https://buzz.github.io/volctl/"
distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
- xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=no
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (7 preceding siblings ...)
2021-08-08 21:36 ` [PR PATCH] [Updated] " teldra
@ 2021-08-08 21:36 ` paper42
2021-08-08 21:38 ` paper42
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-08-08 21:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684832384
Comment:
You should use `make_check=no # no tests, but check fails with a non-zero return code` or something similar
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (8 preceding siblings ...)
2021-08-08 21:36 ` [PR REVIEW] " paper42
@ 2021-08-08 21:38 ` paper42
2021-08-08 21:39 ` [PR PATCH] [Updated] " teldra
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-08-08 21:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684832612
Comment:
oops, I was a few seconds late. Anyway, a comment with the reason would be nice.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (9 preceding siblings ...)
2021-08-08 21:38 ` paper42
@ 2021-08-08 21:39 ` teldra
2021-08-08 21:41 ` [PR REVIEW] " teldra
2021-08-08 21:46 ` [PR PATCH] [Merged]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387
volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64-musl
- [x] armv7l
- [x] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]
From ddef1c3ef73f6cddddd9b9372b8f2186a0b67b77 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.
---
srcpkgs/volctl/template | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..73e735257f72 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
# Template file for 'volctl'
pkgname=volctl
-version=0.8.2
+version=0.9.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
short_desc="Lightweight volume control for pulseaudio in your systray"
maintainer="teldra <teldra@rotce.de>"
license="GPL-2.0-only"
homepage="https://buzz.github.io/volctl/"
distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
- xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=no # no tests, but check fails with a non-zero return code
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (10 preceding siblings ...)
2021-08-08 21:39 ` [PR PATCH] [Updated] " teldra
@ 2021-08-08 21:41 ` teldra
2021-08-08 21:46 ` [PR PATCH] [Merged]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: teldra @ 2021-08-08 21:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New review comment by teldra on void-packages repository
https://github.com/void-linux/void-packages/pull/32387#discussion_r684832860
Comment:
@paper42 your are right about a comment. Added.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Merged]: volctl: update to 0.9.0.
2021-08-07 8:30 [PR PATCH] volctl: update to 0.9.0 teldra
` (11 preceding siblings ...)
2021-08-08 21:41 ` [PR REVIEW] " teldra
@ 2021-08-08 21:46 ` paper42
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-08-08 21:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
There's a merged pull request on the void-packages repository
volctl: update to 0.9.0.
https://github.com/void-linux/void-packages/pull/32387
Description:
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [x] aarch64-musl
- [x] armv7l
- [x] armv6l-musl
^ permalink raw reply [flat|nested] 14+ messages in thread