[PR PATCH] New package: Shortwave-2.0.1

[PR PATCH] New package: Shortwave-2.0.1

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages Shortwave
https://github.com/void-linux/void-packages/pull/32425

New package: Shortwave-2.0.1
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/32425.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Shortwave-32425.patch --]
[-- Type: text/x-diff, Size: 1164 bytes --]

From 7e7b15254a8fb6f63085157f743d2c1dd1273a59 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Mon, 9 Aug 2021 16:41:06 +0300
Subject: [PATCH] New package: Shortwave-2.0.1

---
 srcpkgs/Shortwave/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/Shortwave/template

diff --git a/srcpkgs/Shortwave/template b/srcpkgs/Shortwave/template
new file mode 100644
index 000000000000..f42d5801d5f9
--- /dev/null
+++ b/srcpkgs/Shortwave/template
@@ -0,0 +1,15 @@
+# Template file for 'Shortwave'
+pkgname=Shortwave
+version=2.0.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config git rust cargo"
+makedepends="sqlite-devel gtk4-devel gstreamer1-devel openssl-devel libadwaita-devel
+ gettext"
+short_desc="Internet radio player"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://gitlab.gnome.org/World/Shortwave"
+distfiles="https://gitlab.gnome.org/World/Shortwave/-/archive/${version}/Shortwave-${version}.tar.bz2"
+checksum=78d0af38be3cc915b0e9814b7c5944f00d64b835bffc4d1e3e7ac3c30a3ed772
+nocross=yes # weird issues, the build system uses meson and cargo

Re: New package: Shortwave-2.0.1

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32425#issuecomment-895235705

Comment:
This is the successor to gradio, which is in the repos.

Re: New package: Shortwave-2.0.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32425#issuecomment-895255396

Comment:
Duplicate #29157 

Re: [PR PATCH] [Closed]: New package: Shortwave-2.0.1

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

There's a closed pull request on the void-packages repository

New package: Shortwave-2.0.1
https://github.com/void-linux/void-packages/pull/32425

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (x86_64-glibc)

Re: New package: Shortwave-2.0.1

[oynqr]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

New comment by oynqr on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-1088387375

Comment:
I am no longer interested in packaging this, as I neither use gnome itself nor any apps from its ecosystem anymore. To anyone trying to package this themselves, feel free to use this template as a base.

Re: New package: Shortwave-2.0.1

[MPC7500]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by MPC7500 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-1053756216

Comment:
With the latest version of libadwaita Shortwave is stable. But you need now also libshumate which is alpha.
https://gitlab.gnome.org/GNOME/libshumate

Re: New package: Shortwave-2.0.1

[MPC7500]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by MPC7500 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-1053756216

Comment:
With the latest version of libadwaita Shortwave is stable. But you need now also libshumate ehich is alpha.
https://gitlab.gnome.org/GNOME/libshumate

Re: New package: Shortwave-2.0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-896298247

Comment:
> > there are random crashes related to libadwaita
> 
> I also had a few crashes, I have RUST_BACKTRACE=1 set right now, so I will see what's going on. I don't think libadwaita is to blame, maybe the rust bindings?

So we have a problem - Shortwave 2.0.1 was written before the first libadwaita release, so it depends on behavior that is changed in v1 which makes it crash. I don't think we should downgrade libadwaita for this, we should wait for Shortwave to fix this. The flatpak version works, because it packages a specific libadwaita version.

Could you try if building from their master branch fixes it? If yes, we could maybe ask for a 2.0.2 release or make an exception and package a specific commit? @ericonr

https://gitlab.gnome.org/World/Shortwave/-/issues/586

Re: New package: Shortwave-2.0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-896274491

Comment:
> it doesn't respect any of the global "prefer dark theme" options I throw at it

That's probably because you are setting a GTK3 dark theme variant, afaik GTK4 doesn't have the concept of a theme variants, so you need to set a dark theme (and GTK4 settings are separate from GTK3, so GTK3 settings won't work).

> doesn't play a lot of streams when using pipewire

It seems like we are hitting https://gitlab.gnome.org/World/Shortwave/-/issues/576 and https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1210

> there are random crashes related to libadwaita

I also had a few crashes, I have RUST_BACKTRACE=1 set right now, so I will see what's going on. I don't think libadwaita is to blame, maybe the rust bindings?

> fonts are wonky

Probably something with not having the correct fonts configured for GTK4, my fonts are fine.

Re: New package: Shortwave-2.0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-896260895

Comment:
I think you wanted to push only one commit.

Re: New package: Shortwave-2.0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-896260895

Comment:
I think you to push only one commit.

Re: New package: shortwave-2.0.1

[oynqr]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

New comment by oynqr on void-packages repository

https://github.com/void-linux/void-packages/pull/29157#issuecomment-895009641

Comment:
I am really not impressed with this new version, it doesn't respect any of the global "prefer dark theme" options I throw at it, doesn't play a lot of streams when using pipewire, there are random crashes related to libadwaita and fonts are wonky.

The crashes don't seem to happen with the flatpak version, so I'm gonna have to look into that.