[PR PATCH] New package: mkbootimg-2021.04.27

[PR PATCH] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is a new pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages mkbootimg-osm0sis
https://github.com/void-linux/void-packages/pull/32226

New package: mkbootimg-2021.04.27
`abootimg` simply doesn't cut it anymore for newer Android devices which have an [updated boot.img header format](https://source.android.com/devices/bootloader/boot-image-header) with additional required configuration.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32226.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mkbootimg-osm0sis-32226.patch --]
[-- Type: text/x-diff, Size: 1256 bytes --]

From 76112e2f9a5c913d0ea1933d54bb7ef0737506b1 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 28 Jul 2021 13:46:01 +0300
Subject: [PATCH] New package: mkbootimg-2021.04.27

abootimg simply doesn't cut it anymore for newer Android devices which
have an updated boot.img header format with additional required
configuration.
---
 srcpkgs/mkbootimg/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/mkbootimg/template

diff --git a/srcpkgs/mkbootimg/template b/srcpkgs/mkbootimg/template
new file mode 100644
index 000000000000..114eca254fde
--- /dev/null
+++ b/srcpkgs/mkbootimg/template
@@ -0,0 +1,21 @@
+# Template file for 'mkbootimg'
+pkgname=mkbootimg
+version=2021.04.27
+revision=1
+build_style=meta
+short_desc="Android mkbootimg + unpackbootimg, updated osm0sis fork"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/osm0sis/mkbootimg"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum="a77a2c1a12804ea02cb808c08d80901ff7439d6184fbaa15726fcac4e167303d"
+
+do_build() {
+	make CC="$CC" AR="$AR rc"
+}
+
+do_install() {
+	vbin mkbootimg
+	vbin unpackbootimg
+	vlicense NOTICE
+}

Re: New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#issuecomment-888213659

Comment:
Btw I'm happy to switch the `build_style` to `gnu-makefile` if I can somehow configure `AR`; without being able to tweak this the build fails and simply setting `AR="$AR rc"` or `export`ing it didn't help :/

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678239679

Comment:
You can still use gnu-makefile and override only do_build.

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678240324

Comment:
Try `make_build_args="AR=$AR AR+=rc"`

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678263438

Comment:
Interestingly enough this results in `AR=rc`

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678267046

Comment:
`make_build_args="AR+=rc"` alone did the trick! ^^

Re: [PR PATCH] [Updated] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages mkbootimg-osm0sis
https://github.com/void-linux/void-packages/pull/32226

New package: mkbootimg-2021.04.27
`abootimg` simply doesn't cut it anymore for newer Android devices which have an [updated boot.img header format](https://source.android.com/devices/bootloader/boot-image-header) with additional required configuration.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32226.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mkbootimg-osm0sis-32226.patch --]
[-- Type: text/x-diff, Size: 1240 bytes --]

From 8869d9b0bd513dbe601b50a60273483d861b3795 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 28 Jul 2021 13:46:01 +0300
Subject: [PATCH] New package: mkbootimg-2021.04.27

abootimg simply doesn't cut it anymore for newer Android devices which
have an updated boot.img header format with additional required
configuration.
---
 srcpkgs/mkbootimg/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/mkbootimg/template

diff --git a/srcpkgs/mkbootimg/template b/srcpkgs/mkbootimg/template
new file mode 100644
index 000000000000..90a8ca69bebe
--- /dev/null
+++ b/srcpkgs/mkbootimg/template
@@ -0,0 +1,18 @@
+# Template file for 'mkbootimg'
+pkgname=mkbootimg
+version=2021.04.27
+revision=1
+build_style=gnu-makefile
+make_build_args="AR+=rc"
+short_desc="Android mkbootimg + unpackbootimg, updated osm0sis fork"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/osm0sis/mkbootimg"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum="a77a2c1a12804ea02cb808c08d80901ff7439d6184fbaa15726fcac4e167303d"
+
+do_install() {
+	vbin mkbootimg
+	vbin unpackbootimg
+	vlicense NOTICE
+}

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678274282

Comment:
I'll keep that in mind, there isn't an `install` target in the Makefile so I'll still keep the `vbin`'s there.

Re: [PR REVIEW] New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#discussion_r678274282

Comment:
I'll keep that in mind, there isn't an `install` target in the Makefile so I'll still keep the `vbin`'s here.

Re: New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32226#issuecomment-895880864

Comment:
I'll actually go ahead and close this (for now); I found out about [Google's own mkbootimg Python scripts](https://android.googlesource.com/platform/system/tools/mkbootimg/+/refs/tags/android-11.0.0_r40) which may be a better choice to package in the long run.

After I have time again and can consider things I'll get back to this :)

Re: [PR PATCH] [Closed]: New package: mkbootimg-2021.04.27

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

There's a closed pull request on the void-packages repository

New package: mkbootimg-2021.04.27
https://github.com/void-linux/void-packages/pull/32226

Description:
`abootimg` simply doesn't cut it anymore for newer Android devices which have an [updated boot.img header format](https://source.android.com/devices/bootloader/boot-image-header) with additional required configuration.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->