* [PR PATCH] New package: wluma-1.2.2
@ 2021-08-13 22:53 raninninn
2021-08-14 0:11 ` biopsin
` (9 more replies)
0 siblings, 10 replies; 23+ messages in thread
From: raninninn @ 2021-08-13 22:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
There is a new pull request by raninninn against master on the void-packages repository
https://github.com/raninninn/void-packages master
https://github.com/void-linux/void-packages/pull/32485
New package: wluma-1.2.2
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/32485.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32485.patch --]
[-- Type: text/x-diff, Size: 2288 bytes --]
From ee803597fc3a90344355bb1396855f5f49766699 Mon Sep 17 00:00:00 2001
From: raninninn <matteshilli@gmail.com>
Date: Fri, 13 Aug 2021 23:56:37 +0200
Subject: [PATCH 1/2] New package: wluma-1.2.2
---
srcpkgs/wluma/template | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/wluma/template
diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
new file mode 100644
index 000000000000..69e15a6fe785
--- /dev/null
+++ b/srcpkgs/wluma/template
@@ -0,0 +1,24 @@
+# Template file for 'wluma'
+pkgname=wluma
+version=1.2.2
+revision=2
+archs="x86_64"
+#wrksrc=
+#create_wrksrc=yes
+build_style=gnu-makefile
+make_cmd="make build"
+hostmakedepends="pkg-config meson ninja"
+makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
+depends="wayland vulkan-loader mesa-vulkan-intel"
+short_desc="Automatic screen brightness based on ambient light"
+maintainer="raninninn <raninninn-devel@protonmail.com>"
+license="MIT"
+homepage="https://github.com/maximbaz/wluma"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=dabd6cdf0b9c644af52ad6fad40861829f43c534d42123af2f1f4465b31d5bed
+make_check=no # wluma provides no check suite
+
+do_install() {
+ vbin build/wluma
+ vlicense LICENSE
+}
From 9e8a84dab92c67f705a7e1751877c91c62bdeb7f Mon Sep 17 00:00:00 2001
From: raninninn <72137457+raninninn@users.noreply.github.com>
Date: Sat, 14 Aug 2021 00:39:38 +0200
Subject: [PATCH 2/2] wluma: add mesa-vulkan-radeon as dependency
---
srcpkgs/wluma/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
index 69e15a6fe785..249529437eee 100644
--- a/srcpkgs/wluma/template
+++ b/srcpkgs/wluma/template
@@ -1,7 +1,7 @@
# Template file for 'wluma'
pkgname=wluma
version=1.2.2
-revision=2
+revision=3
archs="x86_64"
#wrksrc=
#create_wrksrc=yes
@@ -9,7 +9,7 @@ build_style=gnu-makefile
make_cmd="make build"
hostmakedepends="pkg-config meson ninja"
makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
-depends="wayland vulkan-loader mesa-vulkan-intel"
+depends="wayland vulkan-loader mesa-vulkan-intel mesa-vulkan-radeon"
short_desc="Automatic screen brightness based on ambient light"
maintainer="raninninn <raninninn-devel@protonmail.com>"
license="MIT"
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
@ 2021-08-14 0:11 ` biopsin
2021-08-14 1:11 ` [PR REVIEW] " ericonr
` (8 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: biopsin @ 2021-08-14 0:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by biopsin on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#issuecomment-898777224
Comment:
You need to squash into one commit and change revision to one.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
2021-08-14 0:11 ` biopsin
@ 2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
` (7 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-14 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#discussion_r688841873
Comment:
What you want is `make_build_target=build`
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
2021-08-14 0:11 ` biopsin
2021-08-14 1:11 ` [PR REVIEW] " ericonr
@ 2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-14 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#discussion_r688841929
Comment:
```suggestion
make_check=no # wluma provides no test suite
```
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (3 preceding siblings ...)
2021-08-14 1:11 ` ericonr
@ 2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
` (4 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-14 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#discussion_r688841884
Comment:
remove commented out fields
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (2 preceding siblings ...)
2021-08-14 1:11 ` ericonr
@ 2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
` (5 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-14 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#discussion_r688842209
Comment:
`wayland` and `vulkan-loader` are detected automatically:
```
=> wluma-1.2.2_3: running pre-pkg hook: 04-generate-runtime-deps ...
SONAME: libvulkan.so.1 <-> vulkan-loader>=1.0.57.0_1
SONAME: libm.so.6 <-> glibc>=2.32_1
SONAME: libwayland-client.so.0 <-> wayland>=1.10.0_1
SONAME: libc.so.6 <-> glibc>=2.32_1
```
And I don't think we should force the vulkan drivers either, so I'd be against them. In other words, you can completely remove `depends`.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (4 preceding siblings ...)
2021-08-14 1:11 ` ericonr
@ 2021-08-14 1:11 ` ericonr
2021-08-14 18:01 ` [PR PATCH] [Updated] " raninninn
` (3 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-14 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#discussion_r688842274
Comment:
No reason to limit this.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR PATCH] [Updated] New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (5 preceding siblings ...)
2021-08-14 1:11 ` ericonr
@ 2021-08-14 18:01 ` raninninn
2021-08-15 3:58 ` ericonr
` (2 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: raninninn @ 2021-08-14 18:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
There is an updated pull request by raninninn against master on the void-packages repository
https://github.com/raninninn/void-packages master
https://github.com/void-linux/void-packages/pull/32485
New package: wluma-1.2.2
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/32485.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32485.patch --]
[-- Type: text/x-diff, Size: 1134 bytes --]
From 595647341219768fc5074223e884515256a10a6e Mon Sep 17 00:00:00 2001
From: raninninn <matteshilli@gmail.com>
Date: Fri, 13 Aug 2021 22:20:20 +0200
Subject: [PATCH] New package: wluma-1.2.2
---
srcpkgs/wluma/template | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 srcpkgs/wluma/template
diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
new file mode 100644
index 000000000000..fce5228a5321
--- /dev/null
+++ b/srcpkgs/wluma/template
@@ -0,0 +1,20 @@
+# Template file for 'wluma'
+pkgname=wluma
+version=1.2.2
+revision=1
+build_style=gnu-makefile
+make_build_target=build
+hostmakedepends="pkg-config meson ninja"
+makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
+short_desc="Automatic screen brightness based on ambient light"
+maintainer="raninninn <raninninn-devel@protonmail.com>"
+license="MIT"
+homepage="https://github.com/maximbaz/wluma"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=dabd6cdf0b9c644af52ad6fad40861829f43c534d42123af2f1f4465b31d5bed
+make_check=no # wluma provides no test suite
+
+do_install() {
+ vbin build/wluma
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (6 preceding siblings ...)
2021-08-14 18:01 ` [PR PATCH] [Updated] " raninninn
@ 2021-08-15 3:58 ` ericonr
2021-08-15 10:10 ` raninninn
2021-08-15 10:10 ` [PR PATCH] [Closed]: " raninninn
9 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-08-15 3:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#issuecomment-898991715
Comment:
Well, I now see this uses meson, so you should probably use that build style directly.
Also, they are rewriting in Rust, so the direction of the package is quite open, I don't think it should be packaged just yet.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (7 preceding siblings ...)
2021-08-15 3:58 ` ericonr
@ 2021-08-15 10:10 ` raninninn
2021-08-15 10:10 ` [PR PATCH] [Closed]: " raninninn
9 siblings, 0 replies; 23+ messages in thread
From: raninninn @ 2021-08-15 10:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New comment by raninninn on void-packages repository
https://github.com/void-linux/void-packages/pull/32485#issuecomment-899027097
Comment:
Okay, thanks for all the help and advice.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR PATCH] [Closed]: New package: wluma-1.2.2
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
` (8 preceding siblings ...)
2021-08-15 10:10 ` raninninn
@ 2021-08-15 10:10 ` raninninn
9 siblings, 0 replies; 23+ messages in thread
From: raninninn @ 2021-08-15 10:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
There's a closed pull request on the void-packages repository
New package: wluma-1.2.2
https://github.com/void-linux/void-packages/pull/32485
Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (10 preceding siblings ...)
2021-06-12 0:02 ` abenson
@ 2021-06-12 0:11 ` Logarithmus
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-12 0:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650317401
Comment:
Somehow the build fails when I use `lld` linker. I use it for my local builds because it's faster than GNU `ld`. With the default GNU `ld` `wluma` builds just fine.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (9 preceding siblings ...)
2021-06-12 0:02 ` abenson
@ 2021-06-12 0:02 ` abenson
2021-06-12 0:11 ` Logarithmus
11 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2021-06-12 0:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650315907
Comment:
```
=> wluma-1.2.2_1: running do_build ...
ninja: Entering directory `build'
[1/7] Generating 'protocol/libclient_protos.a.p/wlr-export-dmabuf-unstable-v1-protocol.c'.
[2/7] Generating 'protocol/libclient_protos.a.p/wlr-export-dmabuf-unstable-v1-client-protocol.h'.
[3/7] Generating 'wluma.p/wlr-export-dmabuf-unstable-v1-client-protocol.h'.
[4/7] Compiling C object protocol/libclient_protos.a.p/meson-generated_wlr-export-dmabuf-unstable-v1-protocol.c.o
[5/7] Linking static target protocol/libclient_protos.a
[6/7] Compiling C object wluma.p/src_main.c.o
[7/7] Linking target wluma
```
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (8 preceding siblings ...)
2021-06-12 0:01 ` Logarithmus
@ 2021-06-12 0:02 ` abenson
2021-06-12 0:02 ` abenson
2021-06-12 0:11 ` Logarithmus
11 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2021-06-12 0:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650315838
Comment:
I'm having trouble recreating that issue.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (7 preceding siblings ...)
2021-06-12 0:01 ` Logarithmus
@ 2021-06-12 0:01 ` Logarithmus
2021-06-12 0:02 ` abenson
` (2 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-12 0:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313971
Comment:
@abenson because it doesn't work, not sure why (I'd appreciate your help):
```
[1/1] Linking target wluma
FAILED: wluma
cc -o wluma wluma.p/src_main.c.o -flto -Wl,--as-needed -Wl,--no-undefined -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--start-group protocol/libclient_protos.a /usr/lib64/libvulkan.so -lm /usr/lib64/libwayland-client.so -Wl,--end-group -Wl,-rpath,/usr/lib64 -Wl,-rpath-link,/usr/lib64
ld.lld: error: undefined symbol: main
>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104)
>>> /usr/lib64/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../lib64/Scrt1.o:(_start)
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
BTW, it builds just fine by manually running `meson build && ninja -C build`. So it might be `xbps-src` interfering with something.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (6 preceding siblings ...)
2021-06-12 0:00 ` Logarithmus
@ 2021-06-12 0:01 ` Logarithmus
2021-06-12 0:01 ` Logarithmus
` (3 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-12 0:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313971
Comment:
@abenson because it doesn't work, not sure why (I'd appreciate your help):
```
[1/1] Linking target wluma
FAILED: wluma
cc -o wluma wluma.p/src_main.c.o -flto -Wl,--as-needed -Wl,--no-undefined -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--start-group protocol/libclient_protos.a /usr/lib64/libvulkan.so -lm /usr/lib64/libwayland-client.so -Wl,--end-group -Wl,-rpath,/usr/lib64 -Wl,-rpath-link,/usr/lib64
ld.lld: error: undefined symbol: main
>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104)
>>> /usr/lib64/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../lib64/Scrt1.o:(_start)
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
BTW, it builds just fine by manually running `meson build && ninja -C build`
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (5 preceding siblings ...)
2021-06-11 23:58 ` abenson
@ 2021-06-12 0:00 ` Logarithmus
2021-06-12 0:01 ` Logarithmus
` (4 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-12 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650315472
Comment:
OK
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (4 preceding siblings ...)
2021-06-11 23:55 ` Logarithmus
@ 2021-06-11 23:58 ` abenson
2021-06-12 0:00 ` Logarithmus
` (5 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2021-06-11 23:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650315154
Comment:
To fix cross-build, because that's the package `wayland-scanner` is in
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (3 preceding siblings ...)
2021-06-11 23:52 ` Logarithmus
@ 2021-06-11 23:55 ` Logarithmus
2021-06-11 23:58 ` abenson
` (6 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-11 23:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313971
Comment:
@abenson because it doesn't work, not sure why (I'd appreciate your help):
```
[1/1] Linking target wluma
FAILED: wluma
cc -o wluma wluma.p/src_main.c.o -flto -Wl,--as-needed -Wl,--no-undefined -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--start-group protocol/libclient_protos.a /usr/lib64/libvulkan.so -lm /usr/lib64/libwayland-client.so -Wl,--end-group -Wl,-rpath,/usr/lib64 -Wl,-rpath-link,/usr/lib64
ld.lld: error: undefined symbol: main
>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104)
>>> /usr/lib64/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../lib64/Scrt1.o:(_start)
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
` (2 preceding siblings ...)
2021-06-11 23:51 ` Logarithmus
@ 2021-06-11 23:52 ` Logarithmus
2021-06-11 23:55 ` Logarithmus
` (7 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-11 23:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313971
Comment:
@abenson because it doesn't work, not sure why:
```
[1/1] Linking target wluma
FAILED: wluma
cc -o wluma wluma.p/src_main.c.o -flto -Wl,--as-needed -Wl,--no-undefined -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--start-group protocol/libclient_protos.a /usr/lib64/libvulkan.so -lm /usr/lib64/libwayland-client.so -Wl,--end-group -Wl,-rpath,/usr/lib64 -Wl,-rpath-link,/usr/lib64
ld.lld: error: undefined symbol: main
>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104)
>>> /usr/lib64/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../lib64/Scrt1.o:(_start)
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
2021-06-11 23:48 ` [PR REVIEW] " abenson
2021-06-11 23:48 ` abenson
@ 2021-06-11 23:51 ` Logarithmus
2021-06-11 23:52 ` Logarithmus
` (8 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: Logarithmus @ 2021-06-11 23:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New review comment by Logarithmus on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313686
Comment:
Why?
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
2021-06-11 23:48 ` [PR REVIEW] " abenson
@ 2021-06-11 23:48 ` abenson
2021-06-11 23:51 ` Logarithmus
` (9 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2021-06-11 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313056
Comment:
Why not `build_style=meson`?
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PR REVIEW] New package: wluma-1.2.2
2021-06-11 22:54 [PR PATCH] " Logarithmus
@ 2021-06-11 23:48 ` abenson
2021-06-11 23:48 ` abenson
` (10 subsequent siblings)
11 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2021-06-11 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/31431#discussion_r650313012
Comment:
You need `wayland-devel` here as well
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2021-08-15 10:10 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 22:53 [PR PATCH] New package: wluma-1.2.2 raninninn
2021-08-14 0:11 ` biopsin
2021-08-14 1:11 ` [PR REVIEW] " ericonr
2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
2021-08-14 1:11 ` ericonr
2021-08-14 18:01 ` [PR PATCH] [Updated] " raninninn
2021-08-15 3:58 ` ericonr
2021-08-15 10:10 ` raninninn
2021-08-15 10:10 ` [PR PATCH] [Closed]: " raninninn
-- strict thread matches above, loose matches on Subject: below --
2021-06-11 22:54 [PR PATCH] " Logarithmus
2021-06-11 23:48 ` [PR REVIEW] " abenson
2021-06-11 23:48 ` abenson
2021-06-11 23:51 ` Logarithmus
2021-06-11 23:52 ` Logarithmus
2021-06-11 23:55 ` Logarithmus
2021-06-11 23:58 ` abenson
2021-06-12 0:00 ` Logarithmus
2021-06-12 0:01 ` Logarithmus
2021-06-12 0:01 ` Logarithmus
2021-06-12 0:02 ` abenson
2021-06-12 0:02 ` abenson
2021-06-12 0:11 ` Logarithmus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).