[PR PATCH] New package: wluma-1.2.2

[PR PATCH] New package: wluma-1.2.2

[raninninn]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

There is a new pull request by raninninn against master on the void-packages repository

https://github.com/raninninn/void-packages master
https://github.com/void-linux/void-packages/pull/32485

New package: wluma-1.2.2
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32485.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32485.patch --]
[-- Type: text/x-diff, Size: 2288 bytes --]

From ee803597fc3a90344355bb1396855f5f49766699 Mon Sep 17 00:00:00 2001
From: raninninn <matteshilli@gmail.com>
Date: Fri, 13 Aug 2021 23:56:37 +0200
Subject: [PATCH 1/2] New package: wluma-1.2.2

---
 srcpkgs/wluma/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/wluma/template

diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
new file mode 100644
index 000000000000..69e15a6fe785
--- /dev/null
+++ b/srcpkgs/wluma/template
@@ -0,0 +1,24 @@
+# Template file for 'wluma'
+pkgname=wluma
+version=1.2.2
+revision=2
+archs="x86_64"
+#wrksrc=
+#create_wrksrc=yes
+build_style=gnu-makefile
+make_cmd="make build"
+hostmakedepends="pkg-config meson ninja"
+makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
+depends="wayland vulkan-loader mesa-vulkan-intel"
+short_desc="Automatic screen brightness based on ambient light"
+maintainer="raninninn <raninninn-devel@protonmail.com>"
+license="MIT"
+homepage="https://github.com/maximbaz/wluma"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=dabd6cdf0b9c644af52ad6fad40861829f43c534d42123af2f1f4465b31d5bed
+make_check=no	# wluma provides no check suite
+
+do_install() {
+	vbin build/wluma
+	vlicense LICENSE
+}

From 9e8a84dab92c67f705a7e1751877c91c62bdeb7f Mon Sep 17 00:00:00 2001
From: raninninn <72137457+raninninn@users.noreply.github.com>
Date: Sat, 14 Aug 2021 00:39:38 +0200
Subject: [PATCH 2/2] wluma: add mesa-vulkan-radeon as dependency

---
 srcpkgs/wluma/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
index 69e15a6fe785..249529437eee 100644
--- a/srcpkgs/wluma/template
+++ b/srcpkgs/wluma/template
@@ -1,7 +1,7 @@
 # Template file for 'wluma'
 pkgname=wluma
 version=1.2.2
-revision=2
+revision=3
 archs="x86_64"
 #wrksrc=
 #create_wrksrc=yes
@@ -9,7 +9,7 @@ build_style=gnu-makefile
 make_cmd="make build"
 hostmakedepends="pkg-config meson ninja"
 makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
-depends="wayland vulkan-loader mesa-vulkan-intel"
+depends="wayland vulkan-loader mesa-vulkan-intel mesa-vulkan-radeon"
 short_desc="Automatic screen brightness based on ambient light"
 maintainer="raninninn <raninninn-devel@protonmail.com>"
 license="MIT"

Re: New package: wluma-1.2.2

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#issuecomment-898777224

Comment:
You need to squash into one commit and change revision to one.

Re: [PR REVIEW] New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#discussion_r688841873

Comment:
What you want is `make_build_target=build`

Re: [PR REVIEW] New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#discussion_r688841929

Comment:
```suggestion
make_check=no	# wluma provides no test suite
```

Re: [PR REVIEW] New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#discussion_r688841884

Comment:
remove commented out fields

Re: [PR REVIEW] New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#discussion_r688842209

Comment:
`wayland` and `vulkan-loader` are detected automatically:

```
=> wluma-1.2.2_3: running pre-pkg hook: 04-generate-runtime-deps ...
   SONAME: libvulkan.so.1 <-> vulkan-loader>=1.0.57.0_1
   SONAME: libm.so.6 <-> glibc>=2.32_1
   SONAME: libwayland-client.so.0 <-> wayland>=1.10.0_1
   SONAME: libc.so.6 <-> glibc>=2.32_1
```

And I don't think we should force the vulkan drivers either, so I'd be against them. In other words, you can completely remove `depends`.

Re: [PR REVIEW] New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#discussion_r688842274

Comment:
No reason to limit this.

Re: [PR PATCH] [Updated] New package: wluma-1.2.2

[raninninn]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

There is an updated pull request by raninninn against master on the void-packages repository

https://github.com/raninninn/void-packages master
https://github.com/void-linux/void-packages/pull/32485

New package: wluma-1.2.2
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32485.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32485.patch --]
[-- Type: text/x-diff, Size: 1134 bytes --]

From 595647341219768fc5074223e884515256a10a6e Mon Sep 17 00:00:00 2001
From: raninninn <matteshilli@gmail.com>
Date: Fri, 13 Aug 2021 22:20:20 +0200
Subject: [PATCH] New package: wluma-1.2.2

---
 srcpkgs/wluma/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/wluma/template

diff --git a/srcpkgs/wluma/template b/srcpkgs/wluma/template
new file mode 100644
index 000000000000..fce5228a5321
--- /dev/null
+++ b/srcpkgs/wluma/template
@@ -0,0 +1,20 @@
+# Template file for 'wluma'
+pkgname=wluma
+version=1.2.2
+revision=1
+build_style=gnu-makefile
+make_build_target=build
+hostmakedepends="pkg-config meson ninja"
+makedepends="Vulkan-Headers wayland-devel Vulkan-Tools"
+short_desc="Automatic screen brightness based on ambient light"
+maintainer="raninninn <raninninn-devel@protonmail.com>"
+license="MIT"
+homepage="https://github.com/maximbaz/wluma"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=dabd6cdf0b9c644af52ad6fad40861829f43c534d42123af2f1f4465b31d5bed
+make_check=no	# wluma provides no test suite
+
+do_install() {
+	vbin build/wluma
+	vlicense LICENSE
+}

Re: New package: wluma-1.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#issuecomment-898991715

Comment:
Well, I now see this uses meson, so you should probably use that build style directly.

Also, they are rewriting in Rust, so the direction of the package is quite open, I don't think it should be packaged just yet.

Re: New package: wluma-1.2.2

[raninninn]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by raninninn on void-packages repository

https://github.com/void-linux/void-packages/pull/32485#issuecomment-899027097

Comment:
Okay, thanks for all the help and advice.

Re: [PR PATCH] [Closed]: New package: wluma-1.2.2

[raninninn]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There's a closed pull request on the void-packages repository

New package: wluma-1.2.2
https://github.com/void-linux/void-packages/pull/32485

Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Re: New package: wluma-1.2.2

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31431#issuecomment-1133802432

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: wluma-1.2.2

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31431#issuecomment-863918628

Comment:
> 1.2.2 is MIT licensed.

Fixed

Re: New package: wluma-1.2.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31431#issuecomment-862876197

Comment:
1.2.2 is MIT licensed.

Re: New package: wluma-1.2.2

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31431#issuecomment-859965797

Comment:
@abenson I guess now everything is fine?