* [PR PATCH] python3-txtorcon: update to 21.1.0.
@ 2021-08-22 5:00 travankor
2021-08-22 5:11 ` [PR PATCH] [Updated] " travankor
` (15 more replies)
0 siblings, 16 replies; 17+ messages in thread
From: travankor @ 2021-08-22 5:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
There is a new pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages python3-txtorcon
https://github.com/void-linux/void-packages/pull/32624
python3-txtorcon: update to 21.1.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32624.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-txtorcon-32624.patch --]
[-- Type: text/x-diff, Size: 1299 bytes --]
From 90d7b1eb0db4a408df5df2fd61806fba785fb0ad Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Sat, 21 Aug 2021 20:18:42 -0700
Subject: [PATCH] python3-txtorcon: update to 21.1.0.
---
srcpkgs/python3-txtorcon/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/python3-txtorcon/template b/srcpkgs/python3-txtorcon/template
index 5a0683f1760d..93a980c94a89 100644
--- a/srcpkgs/python3-txtorcon/template
+++ b/srcpkgs/python3-txtorcon/template
@@ -1,17 +1,18 @@
# Template file for 'python3-txtorcon'
pkgname=python3-txtorcon
-version=20.0.0
-revision=2
+version=21.1.0
+revision=1
wrksrc="txtorcon-${version}"
build_style=python3-module
hostmakedepends="python3 python3-setuptools"
depends="python3-automat python3-Twisted"
+checkdepends="lsof python3-mock python3-Twisted tox"
short_desc="Twisted-based asynchronous Tor control protocol implementation"
maintainer="travankor <travankor@tuta.io>"
license="MIT"
homepage="https://txtorcon.readthedocs.io/en/latest/"
distfiles="https://github.com/meejah/txtorcon/archive/v${version}.tar.gz"
-checksum=8b5f5587ab03bb965c4d162b8ef86c6853c06041b200f2f8a2272caa4bd7cac4
+checksum=61ef40e110a2b52255a6033293d02647dedb63ed9311ce572571c777b2302750
post-install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
@ 2021-08-22 5:11 ` travankor
2021-08-22 7:28 ` [PR REVIEW] " paper42
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-22 5:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages python3-txtorcon
https://github.com/void-linux/void-packages/pull/32624
python3-txtorcon: update to 21.1.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32624.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-txtorcon-32624.patch --]
[-- Type: text/x-diff, Size: 1320 bytes --]
From 6512a4929da62cb9196312e8fad6ac156d4efaf0 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Sat, 21 Aug 2021 20:18:42 -0700
Subject: [PATCH] python3-txtorcon: update to 21.1.0.
---
srcpkgs/python3-txtorcon/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/python3-txtorcon/template b/srcpkgs/python3-txtorcon/template
index 5a0683f1760d..62ed112254a1 100644
--- a/srcpkgs/python3-txtorcon/template
+++ b/srcpkgs/python3-txtorcon/template
@@ -1,17 +1,19 @@
# Template file for 'python3-txtorcon'
pkgname=python3-txtorcon
-version=20.0.0
-revision=2
+version=21.1.0
+revision=1
wrksrc="txtorcon-${version}"
build_style=python3-module
hostmakedepends="python3 python3-setuptools"
depends="python3-automat python3-Twisted"
+checkdepends="lsof python3-mock python3-Twisted tox"
short_desc="Twisted-based asynchronous Tor control protocol implementation"
maintainer="travankor <travankor@tuta.io>"
license="MIT"
homepage="https://txtorcon.readthedocs.io/en/latest/"
distfiles="https://github.com/meejah/txtorcon/archive/v${version}.tar.gz"
-checksum=8b5f5587ab03bb965c4d162b8ef86c6853c06041b200f2f8a2272caa4bd7cac4
+checksum=61ef40e110a2b52255a6033293d02647dedb63ed9311ce572571c777b2302750
+make_check=ci-skip
post-install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
2021-08-22 5:11 ` [PR PATCH] [Updated] " travankor
@ 2021-08-22 7:28 ` paper42
2021-08-22 10:34 ` travankor
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 7:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693457296
Comment:
could you explain why in a comment?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
2021-08-22 5:11 ` [PR PATCH] [Updated] " travankor
2021-08-22 7:28 ` [PR REVIEW] " paper42
@ 2021-08-22 10:34 ` travankor
2021-08-22 18:08 ` paper42
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-22 10:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
New review comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693480227
Comment:
is [this](https://pipelines.actions.githubusercontent.com/GbMGR0ISmtcNwrR1js8irbYChG8pi1T6JBrmuKRQmPX1bdcFkV/_apis/pipelines/1/runs/41520/signedlogcontent/5?urlExpires=2021-08-22T10%3A33%3A49.2317977Z&urlSigningMethod=HMACV1&urlSignature=UzMgbluztX2bBZ5XA6rIzqF8ThSny2UveLFllmxo%2FZ0%3D) log as a comment alright?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (2 preceding siblings ...)
2021-08-22 10:34 ` travankor
@ 2021-08-22 18:08 ` paper42
2021-08-22 18:08 ` paper42
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 18:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693536930
Comment:
* lsof is a runtime dependency: https://github.com/meejah/txtorcon/search?q=lsof
* then `checkdepends="$depends python3-mox tox"` will be more readable
* you can replace tox with python3-pytest
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (3 preceding siblings ...)
2021-08-22 18:08 ` paper42
@ 2021-08-22 18:08 ` paper42
2021-08-22 18:09 ` paper42
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 18:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693537021
Comment:
I am not really sure why the failure is happening, maybe something with GH limiting open ports? Let's leave it without a comment then.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (4 preceding siblings ...)
2021-08-22 18:08 ` paper42
@ 2021-08-22 18:09 ` paper42
2021-08-22 18:25 ` paper42
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 18:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693536930
Comment:
* lsof is a runtime dependency: https://github.com/meejah/txtorcon/search?q=lsof
* then `checkdepends="$depends python3-mock tox"` will be more readable
* you can replace tox with python3-pytest
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (5 preceding siblings ...)
2021-08-22 18:09 ` paper42
@ 2021-08-22 18:25 ` paper42
2021-08-22 20:34 ` travankor
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693538905
Comment:
I think we are missing some dependencies, could you verify them? - six, zope.interface and cryptography
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (6 preceding siblings ...)
2021-08-22 18:25 ` paper42
@ 2021-08-22 20:34 ` travankor
2021-08-22 20:35 ` [PR PATCH] [Updated] " travankor
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-22 20:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New review comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693553446
Comment:
these should be dependencies of python3-automat, python3-Twisted, and python3-openssl (from Twisted)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (7 preceding siblings ...)
2021-08-22 20:34 ` travankor
@ 2021-08-22 20:35 ` travankor
2021-08-22 20:38 ` travankor
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-22 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages python3-txtorcon
https://github.com/void-linux/void-packages/pull/32624
python3-txtorcon: update to 21.1.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32624.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-txtorcon-32624.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]
From 7bd676de65f44c9eefe179ddbe7831dffe923bf7 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Sat, 21 Aug 2021 20:18:42 -0700
Subject: [PATCH] python3-txtorcon: update to 21.1.0.
---
srcpkgs/python3-txtorcon/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-txtorcon/template b/srcpkgs/python3-txtorcon/template
index 5a0683f1760d..6829bfa1c5a4 100644
--- a/srcpkgs/python3-txtorcon/template
+++ b/srcpkgs/python3-txtorcon/template
@@ -1,17 +1,19 @@
# Template file for 'python3-txtorcon'
pkgname=python3-txtorcon
-version=20.0.0
-revision=2
+version=21.1.0
+revision=1
wrksrc="txtorcon-${version}"
build_style=python3-module
hostmakedepends="python3 python3-setuptools"
-depends="python3-automat python3-Twisted"
+depends="lsof python3-automat python3-Twisted"
+checkdepends="${depends} python3-mock python3-pytest"
short_desc="Twisted-based asynchronous Tor control protocol implementation"
maintainer="travankor <travankor@tuta.io>"
license="MIT"
homepage="https://txtorcon.readthedocs.io/en/latest/"
distfiles="https://github.com/meejah/txtorcon/archive/v${version}.tar.gz"
-checksum=8b5f5587ab03bb965c4d162b8ef86c6853c06041b200f2f8a2272caa4bd7cac4
+checksum=61ef40e110a2b52255a6033293d02647dedb63ed9311ce572571c777b2302750
+#make_check=ci-skip
post-install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (8 preceding siblings ...)
2021-08-22 20:35 ` [PR PATCH] [Updated] " travankor
@ 2021-08-22 20:38 ` travankor
2021-08-22 21:15 ` [PR REVIEW] " paper42
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-22 20:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages python3-txtorcon
https://github.com/void-linux/void-packages/pull/32624
python3-txtorcon: update to 21.1.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32624.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-txtorcon-32624.patch --]
[-- Type: text/x-diff, Size: 1372 bytes --]
From 3b79c9511fa49338d3d702508bd2ba6f2befcd22 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Sat, 21 Aug 2021 20:18:42 -0700
Subject: [PATCH] python3-txtorcon: update to 21.1.0.
---
srcpkgs/python3-txtorcon/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-txtorcon/template b/srcpkgs/python3-txtorcon/template
index 5a0683f1760d..e27b1371e673 100644
--- a/srcpkgs/python3-txtorcon/template
+++ b/srcpkgs/python3-txtorcon/template
@@ -1,17 +1,19 @@
# Template file for 'python3-txtorcon'
pkgname=python3-txtorcon
-version=20.0.0
-revision=2
+version=21.1.0
+revision=1
wrksrc="txtorcon-${version}"
build_style=python3-module
hostmakedepends="python3 python3-setuptools"
-depends="python3-automat python3-Twisted"
+depends="lsof python3-automat python3-Twisted"
+checkdepends="${depends} python3-mock python3-pytest"
short_desc="Twisted-based asynchronous Tor control protocol implementation"
maintainer="travankor <travankor@tuta.io>"
license="MIT"
homepage="https://txtorcon.readthedocs.io/en/latest/"
distfiles="https://github.com/meejah/txtorcon/archive/v${version}.tar.gz"
-checksum=8b5f5587ab03bb965c4d162b8ef86c6853c06041b200f2f8a2272caa4bd7cac4
+checksum=61ef40e110a2b52255a6033293d02647dedb63ed9311ce572571c777b2302750
+make_check=ci-skip
post-install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (9 preceding siblings ...)
2021-08-22 20:38 ` travankor
@ 2021-08-22 21:15 ` paper42
2021-08-24 23:09 ` travankor
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-22 21:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693558124
Comment:
It seems like they all are pulled in by other dependencies, but I would list them explicitly anyway, because txtorcon imports them.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (10 preceding siblings ...)
2021-08-22 21:15 ` [PR REVIEW] " paper42
@ 2021-08-24 23:09 ` travankor
2021-08-24 23:17 ` travankor
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-24 23:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
New review comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r695276213
Comment:
Do you think this would be a good idea to add to `Manual.md` (ie: add dependencies if the package imports them)?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (11 preceding siblings ...)
2021-08-24 23:09 ` travankor
@ 2021-08-24 23:17 ` travankor
2021-08-24 23:21 ` [PR PATCH] [Updated] " travankor
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-24 23:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r695276213
Comment:
Do you think this would be a good idea to add to `Manual.md` (ie: explicitly add dependencies if the package imports them)?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (12 preceding siblings ...)
2021-08-24 23:17 ` travankor
@ 2021-08-24 23:21 ` travankor
2021-08-25 21:12 ` [PR REVIEW] " paper42
2021-08-25 21:14 ` [PR PATCH] [Merged]: " paper42
15 siblings, 0 replies; 17+ messages in thread
From: travankor @ 2021-08-24 23:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages python3-txtorcon
https://github.com/void-linux/void-packages/pull/32624
python3-txtorcon: update to 21.1.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32624.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-txtorcon-32624.patch --]
[-- Type: text/x-diff, Size: 1431 bytes --]
From 27cb214a60e68ae31fdf73efecf4a99f2c915a31 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Sat, 21 Aug 2021 20:18:42 -0700
Subject: [PATCH] python3-txtorcon: update to 21.1.0.
---
srcpkgs/python3-txtorcon/template | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-txtorcon/template b/srcpkgs/python3-txtorcon/template
index 5a0683f1760d..3f31d4ccdf79 100644
--- a/srcpkgs/python3-txtorcon/template
+++ b/srcpkgs/python3-txtorcon/template
@@ -1,17 +1,20 @@
# Template file for 'python3-txtorcon'
pkgname=python3-txtorcon
-version=20.0.0
-revision=2
+version=21.1.0
+revision=1
wrksrc="txtorcon-${version}"
build_style=python3-module
hostmakedepends="python3 python3-setuptools"
-depends="python3-automat python3-Twisted"
+depends="lsof python3-automat python3-cryptography python3-six python3-Twisted
+ python3-zope.interface"
+checkdepends="${depends} python3-mock python3-pytest"
short_desc="Twisted-based asynchronous Tor control protocol implementation"
maintainer="travankor <travankor@tuta.io>"
license="MIT"
homepage="https://txtorcon.readthedocs.io/en/latest/"
distfiles="https://github.com/meejah/txtorcon/archive/v${version}.tar.gz"
-checksum=8b5f5587ab03bb965c4d162b8ef86c6853c06041b200f2f8a2272caa4bd7cac4
+checksum=61ef40e110a2b52255a6033293d02647dedb63ed9311ce572571c777b2302750
+make_check=ci-skip
post-install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (13 preceding siblings ...)
2021-08-24 23:21 ` [PR PATCH] [Updated] " travankor
@ 2021-08-25 21:12 ` paper42
2021-08-25 21:14 ` [PR PATCH] [Merged]: " paper42
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-25 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r696117127
Comment:
That's a tough question I can not answer. In some cases it makes sense, but I have not explored this idea throughly yet, so there might be some cases where it wouldn't make sense. I would leave it to reviewers and contributors right now.
I have been playing with a simple python script that parses source files and finds all imports - https://github.com/paper42/python-detect-deps, that's why I notice this.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Merged]: python3-txtorcon: update to 21.1.0.
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
` (14 preceding siblings ...)
2021-08-25 21:12 ` [PR REVIEW] " paper42
@ 2021-08-25 21:14 ` paper42
15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-08-25 21:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
There's a merged pull request on the void-packages repository
python3-txtorcon: update to 21.1.0.
https://github.com/void-linux/void-packages/pull/32624
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-08-25 21:14 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 5:00 [PR PATCH] python3-txtorcon: update to 21.1.0 travankor
2021-08-22 5:11 ` [PR PATCH] [Updated] " travankor
2021-08-22 7:28 ` [PR REVIEW] " paper42
2021-08-22 10:34 ` travankor
2021-08-22 18:08 ` paper42
2021-08-22 18:08 ` paper42
2021-08-22 18:09 ` paper42
2021-08-22 18:25 ` paper42
2021-08-22 20:34 ` travankor
2021-08-22 20:35 ` [PR PATCH] [Updated] " travankor
2021-08-22 20:38 ` travankor
2021-08-22 21:15 ` [PR REVIEW] " paper42
2021-08-24 23:09 ` travankor
2021-08-24 23:17 ` travankor
2021-08-24 23:21 ` [PR PATCH] [Updated] " travankor
2021-08-25 21:12 ` [PR REVIEW] " paper42
2021-08-25 21:14 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).