* [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
@ 2021-09-23 4:39 Twilighttony
2021-09-23 4:43 ` [PR REVIEW] " abenson
` (35 more replies)
0 siblings, 36 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 4:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
There is a new pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1835 bytes --]
From cf123b97201d144dc435dbe306e35486cfad2c16 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..69cdd84e550f
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,37 @@
+# Template file for 'NetworkManager-openvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+configure_args="--disable-static"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+
+do_configure() {
+ ./configure --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --libexecdir=/usr/lib/networkmanager \
+ --disable-static \
+ --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
+ make
+}
+
+post_extract() {
+ sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
+ shared/nm-service-defines.h
+}
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
@ 2021-09-23 4:43 ` abenson
2021-09-23 4:43 ` abenson
` (34 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: abenson @ 2021-09-23 4:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714467407
Comment:
`_pppver` is never defined.
Also, you can probably drop all of this and replace it with
configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
2021-09-23 4:43 ` [PR REVIEW] " abenson
@ 2021-09-23 4:43 ` abenson
2021-09-23 4:44 ` abenson
` (33 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: abenson @ 2021-09-23 4:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714467407
Comment:
`_pppver` is never defined.
Also, you can probably drop all of `do_configure` and replace it with
configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
2021-09-23 4:43 ` [PR REVIEW] " abenson
2021-09-23 4:43 ` abenson
@ 2021-09-23 4:44 ` abenson
2021-09-23 4:51 ` cinerea0
` (32 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: abenson @ 2021-09-23 4:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714467653
Comment:
Maybe give it its own directory? Does it store any files?
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (2 preceding siblings ...)
2021-09-23 4:44 ` abenson
@ 2021-09-23 4:51 ` cinerea0
2021-09-23 4:52 ` cinerea0
` (31 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: cinerea0 @ 2021-09-23 4:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714469710
Comment:
This should be the same as the package name.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (3 preceding siblings ...)
2021-09-23 4:51 ` cinerea0
@ 2021-09-23 4:52 ` cinerea0
2021-09-23 4:53 ` Twilighttony
` (30 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: cinerea0 @ 2021-09-23 4:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714470018
Comment:
You should probably use [vsed](https://github.com/void-linux/void-packages/blob/master/Manual.md#global-functions) for this.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (4 preceding siblings ...)
2021-09-23 4:52 ` cinerea0
@ 2021-09-23 4:53 ` Twilighttony
2021-09-23 5:10 ` [PR PATCH] [Updated] " Twilighttony
` (29 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 4:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by Twilighttony on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714470314
Comment:
I’m surprised I didn’t catch that earlier. I’ll change that now.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (5 preceding siblings ...)
2021-09-23 4:53 ` Twilighttony
@ 2021-09-23 5:10 ` Twilighttony
2021-09-23 5:22 ` Twilighttony
` (28 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 5:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 2571 bytes --]
From cf123b97201d144dc435dbe306e35486cfad2c16 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH 1/2] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..69cdd84e550f
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,37 @@
+# Template file for 'NetworkManager-openvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+configure_args="--disable-static"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+
+do_configure() {
+ ./configure --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --libexecdir=/usr/lib/networkmanager \
+ --disable-static \
+ --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
+ make
+}
+
+post_extract() {
+ sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
+ shared/nm-service-defines.h
+}
+
+pre_configure() {
+ autoreconf -fi
+}
From 96e501b96d0e23f047c6ef4276dcf55ee9a5a6c4 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:10:13 -0400
Subject: [PATCH 2/2] change to proper template name
---
srcpkgs/NetworkManager-fortisslvpn/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 69cdd84e550f..1cb8af84e92a 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -1,4 +1,4 @@
-# Template file for 'NetworkManager-openvpn'
+# Template file for 'NetworkManager-fortisslvpn'
pkgname=NetworkManager-fortisslvpn
version=1.3.90
revision=1
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (6 preceding siblings ...)
2021-09-23 5:10 ` [PR PATCH] [Updated] " Twilighttony
@ 2021-09-23 5:22 ` Twilighttony
2021-09-23 5:23 ` [PR REVIEW] " Twilighttony
` (27 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 5:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 3756 bytes --]
From cf123b97201d144dc435dbe306e35486cfad2c16 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH 1/3] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..69cdd84e550f
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,37 @@
+# Template file for 'NetworkManager-openvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+configure_args="--disable-static"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+
+do_configure() {
+ ./configure --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --libexecdir=/usr/lib/networkmanager \
+ --disable-static \
+ --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
+ make
+}
+
+post_extract() {
+ sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
+ shared/nm-service-defines.h
+}
+
+pre_configure() {
+ autoreconf -fi
+}
From 96e501b96d0e23f047c6ef4276dcf55ee9a5a6c4 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:10:13 -0400
Subject: [PATCH 2/3] change to proper template name
---
srcpkgs/NetworkManager-fortisslvpn/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 69cdd84e550f..1cb8af84e92a 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -1,4 +1,4 @@
-# Template file for 'NetworkManager-openvpn'
+# Template file for 'NetworkManager-fortisslvpn'
pkgname=NetworkManager-fortisslvpn
version=1.3.90
revision=1
From 8ed5a8aaa368e83f25c5a5f1a997b11b5ab90aae Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:22:25 -0400
Subject: [PATCH 3/3] fix _pppver issues
---
srcpkgs/NetworkManager-fortisslvpn/template | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 1cb8af84e92a..fe776b25e3a8 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -16,16 +16,10 @@ checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
system_accounts="_nm_openfortivpn"
lib32disabled=yes
_nm_openfortivpn_homedir="/var/empty"
+_pppver=2.4.9
+
+configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
-do_configure() {
- ./configure --prefix=/usr \
- --sysconfdir=/etc \
- --localstatedir=/var \
- --libexecdir=/usr/lib/networkmanager \
- --disable-static \
- --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
- make
-}
post_extract() {
sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (7 preceding siblings ...)
2021-09-23 5:22 ` Twilighttony
@ 2021-09-23 5:23 ` Twilighttony
2021-09-23 16:53 ` cinerea0
` (26 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 5:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by Twilighttony on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714479067
Comment:
Added and committed.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (8 preceding siblings ...)
2021-09-23 5:23 ` [PR REVIEW] " Twilighttony
@ 2021-09-23 16:53 ` cinerea0
2021-09-23 23:05 ` abenson
` (25 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: cinerea0 @ 2021-09-23 16:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714983734
Comment:
You should probably move this to the "configure_args" line above.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (9 preceding siblings ...)
2021-09-23 16:53 ` cinerea0
@ 2021-09-23 23:05 ` abenson
2021-09-23 23:14 ` [PR PATCH] [Updated] " Twilighttony
` (24 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: abenson @ 2021-09-23 23:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r715212542
Comment:
Nevermind, I see that tracks with the other plugins.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (10 preceding siblings ...)
2021-09-23 23:05 ` abenson
@ 2021-09-23 23:14 ` Twilighttony
2021-09-24 21:29 ` Twilighttony
` (23 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-23 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 4613 bytes --]
From cf123b97201d144dc435dbe306e35486cfad2c16 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH 1/4] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..69cdd84e550f
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,37 @@
+# Template file for 'NetworkManager-openvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+configure_args="--disable-static"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+
+do_configure() {
+ ./configure --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --libexecdir=/usr/lib/networkmanager \
+ --disable-static \
+ --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
+ make
+}
+
+post_extract() {
+ sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
+ shared/nm-service-defines.h
+}
+
+pre_configure() {
+ autoreconf -fi
+}
From 96e501b96d0e23f047c6ef4276dcf55ee9a5a6c4 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:10:13 -0400
Subject: [PATCH 2/4] change to proper template name
---
srcpkgs/NetworkManager-fortisslvpn/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 69cdd84e550f..1cb8af84e92a 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -1,4 +1,4 @@
-# Template file for 'NetworkManager-openvpn'
+# Template file for 'NetworkManager-fortisslvpn'
pkgname=NetworkManager-fortisslvpn
version=1.3.90
revision=1
From 8ed5a8aaa368e83f25c5a5f1a997b11b5ab90aae Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:22:25 -0400
Subject: [PATCH 3/4] fix _pppver issues
---
srcpkgs/NetworkManager-fortisslvpn/template | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 1cb8af84e92a..fe776b25e3a8 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -16,16 +16,10 @@ checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
system_accounts="_nm_openfortivpn"
lib32disabled=yes
_nm_openfortivpn_homedir="/var/empty"
+_pppver=2.4.9
+
+configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
-do_configure() {
- ./configure --prefix=/usr \
- --sysconfdir=/etc \
- --localstatedir=/var \
- --libexecdir=/usr/lib/networkmanager \
- --disable-static \
- --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
- make
-}
post_extract() {
sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
From f09c4d758d9ccc508eff57aa0789f330d0a6ae0e Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 19:14:29 -0400
Subject: [PATCH 4/4] removed sed from template
---
srcpkgs/NetworkManager-fortisslvpn/template | 6 ------
1 file changed, 6 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index fe776b25e3a8..9dd535e1d5da 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -20,12 +20,6 @@ _pppver=2.4.9
configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
-
-post_extract() {
- sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
- shared/nm-service-defines.h
-}
-
pre_configure() {
autoreconf -fi
}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (11 preceding siblings ...)
2021-09-23 23:14 ` [PR PATCH] [Updated] " Twilighttony
@ 2021-09-24 21:29 ` Twilighttony
2021-09-24 23:58 ` [PR REVIEW] " Twilighttony
` (22 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-24 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 5850 bytes --]
From cf123b97201d144dc435dbe306e35486cfad2c16 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH 1/5] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..69cdd84e550f
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,37 @@
+# Template file for 'NetworkManager-openvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+configure_args="--disable-static"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+
+do_configure() {
+ ./configure --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --libexecdir=/usr/lib/networkmanager \
+ --disable-static \
+ --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
+ make
+}
+
+post_extract() {
+ sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
+ shared/nm-service-defines.h
+}
+
+pre_configure() {
+ autoreconf -fi
+}
From 96e501b96d0e23f047c6ef4276dcf55ee9a5a6c4 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:10:13 -0400
Subject: [PATCH 2/5] change to proper template name
---
srcpkgs/NetworkManager-fortisslvpn/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 69cdd84e550f..1cb8af84e92a 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -1,4 +1,4 @@
-# Template file for 'NetworkManager-openvpn'
+# Template file for 'NetworkManager-fortisslvpn'
pkgname=NetworkManager-fortisslvpn
version=1.3.90
revision=1
From 8ed5a8aaa368e83f25c5a5f1a997b11b5ab90aae Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 01:22:25 -0400
Subject: [PATCH 3/5] fix _pppver issues
---
srcpkgs/NetworkManager-fortisslvpn/template | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 1cb8af84e92a..fe776b25e3a8 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -16,16 +16,10 @@ checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
system_accounts="_nm_openfortivpn"
lib32disabled=yes
_nm_openfortivpn_homedir="/var/empty"
+_pppver=2.4.9
+
+configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
-do_configure() {
- ./configure --prefix=/usr \
- --sysconfdir=/etc \
- --localstatedir=/var \
- --libexecdir=/usr/lib/networkmanager \
- --disable-static \
- --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver
- make
-}
post_extract() {
sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
From f09c4d758d9ccc508eff57aa0789f330d0a6ae0e Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 19:14:29 -0400
Subject: [PATCH 4/5] removed sed from template
---
srcpkgs/NetworkManager-fortisslvpn/template | 6 ------
1 file changed, 6 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index fe776b25e3a8..9dd535e1d5da 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -20,12 +20,6 @@ _pppver=2.4.9
configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
-
-post_extract() {
- sed -i 's/\(#define NM_OPENFORTIVPN_\(USER\|GROUP\)\).*/\1 "_nm_openfortivpn"/' \
- shared/nm-service-defines.h
-}
-
pre_configure() {
autoreconf -fi
}
From 4c1d481260f82eb59ca65e0cedfb41ef9cbe5381 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Fri, 24 Sep 2021 17:18:36 -0400
Subject: [PATCH 5/5] merge configure-args into one line
---
srcpkgs/NetworkManager-fortisslvpn/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
index 9dd535e1d5da..9e70853f76bd 100644
--- a/srcpkgs/NetworkManager-fortisslvpn/template
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -3,7 +3,6 @@ pkgname=NetworkManager-fortisslvpn
version=1.3.90
revision=1
build_style=gnu-configure
-configure_args="--disable-static"
hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
depends="openfortivpn"
@@ -18,7 +17,7 @@ lib32disabled=yes
_nm_openfortivpn_homedir="/var/empty"
_pppver=2.4.9
-configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
pre_configure() {
autoreconf -fi
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (12 preceding siblings ...)
2021-09-24 21:29 ` Twilighttony
@ 2021-09-24 23:58 ` Twilighttony
2021-09-25 3:05 ` abenson
` (21 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-24 23:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by Twilighttony on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r715956964
Comment:
I have fixed this now.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (13 preceding siblings ...)
2021-09-24 23:58 ` [PR REVIEW] " Twilighttony
@ 2021-09-25 3:05 ` abenson
2021-09-25 5:27 ` [PR PATCH] [Updated] " Twilighttony
` (20 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: abenson @ 2021-09-25 3:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r715980794
Comment:
This should go after `build_style`
Check with `xlint` from `xtools`
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (14 preceding siblings ...)
2021-09-25 3:05 ` abenson
@ 2021-09-25 5:27 ` Twilighttony
2021-09-25 5:35 ` Twilighttony
` (19 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 5:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1583 bytes --]
From 5a8da6eaee49aed84de710b781c071ab317a8bcb Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 24 +++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..9e70853f76bd
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,24 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+_nm_openfortivpn_homedir="/var/empty"
+_pppver=2.4.9
+
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (15 preceding siblings ...)
2021-09-25 5:27 ` [PR PATCH] [Updated] " Twilighttony
@ 2021-09-25 5:35 ` Twilighttony
2021-09-25 5:35 ` [PR REVIEW] " Twilighttony
` (18 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 5:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1583 bytes --]
From ce39433839d965522560ec5c8d8559d204f9b0a5 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 24 +++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..ff5ccbaa6e39
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,24 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_nm_openfortivpn_homedir="/var/empty"
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+lib32disabled=yes
+
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (16 preceding siblings ...)
2021-09-25 5:35 ` Twilighttony
@ 2021-09-25 5:35 ` Twilighttony
2021-09-25 5:43 ` [PR PATCH] [Updated] " Twilighttony
` (17 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 5:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New review comment by Twilighttony on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r715994897
Comment:
Done
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (17 preceding siblings ...)
2021-09-25 5:35 ` [PR REVIEW] " Twilighttony
@ 2021-09-25 5:43 ` Twilighttony
2021-09-25 5:59 ` Twilighttony
` (16 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 5:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1579 bytes --]
From bd1177d82dfdee652dc4dc2e74aa2dd208e06c05 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 22 +++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..f11c4ed583d6
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,22 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/empty"
+lib32disabled=yes
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (18 preceding siblings ...)
2021-09-25 5:43 ` [PR PATCH] [Updated] " Twilighttony
@ 2021-09-25 5:59 ` Twilighttony
2021-09-25 6:31 ` Twilighttony
` (15 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 5:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1581 bytes --]
From b3ec58a8b04f66702e3717b053b1b9749d699681 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..7854b59759a1
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,23 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/empty"
+lib32disabled=yes
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (19 preceding siblings ...)
2021-09-25 5:59 ` Twilighttony
@ 2021-09-25 6:31 ` Twilighttony
2021-09-25 6:49 ` Twilighttony
` (14 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 6:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1606 bytes --]
From 854339ac01e3a8a731d60b4bfff81ec16eaf917a Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..74cf16979766
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,23 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/lib/NetworkManager-fortisslvpn"
+lib32disabled=yes
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (20 preceding siblings ...)
2021-09-25 6:31 ` Twilighttony
@ 2021-09-25 6:49 ` Twilighttony
2021-10-04 3:19 ` the-maldridge
` (13 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-09-25 6:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1698 bytes --]
From 841d4fbab5b358f07e612cff13be56815888c2eb Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 26 +++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..fa1e10a61813
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,26 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/lib/NetworkManager-fortisslvpn"
+make_dirs="/var/lib/NetworkManager-fortisslvpn 0755 _nm_openfortivpn _nm_openfortivpn"
+lib32disabled=yes
+
+pre_configure() {
+ autoreconf -fi
+}
+
+
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (21 preceding siblings ...)
2021-09-25 6:49 ` Twilighttony
@ 2021-10-04 3:19 ` the-maldridge
2021-10-04 3:22 ` [PR PATCH] [Updated] " Twilighttony
` (12 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: the-maldridge @ 2021-10-04 3:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#issuecomment-933110485
Comment:
Needs rebase.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (22 preceding siblings ...)
2021-10-04 3:19 ` the-maldridge
@ 2021-10-04 3:22 ` Twilighttony
2021-10-04 3:33 ` Twilighttony
` (11 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-10-04 3:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1694 bytes --]
From 7e68baa5379e73b28bea1a9c773912ddfa10de30 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 24 +++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..99c113d39748
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,24 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/lib/NetworkManager-fortisslvpn"
+make_dirs="/var/lib/NetworkManager-fortisslvpn 0755 _nm_openfortivpn _nm_openfortivpn"
+lib32disabled=yes
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR PATCH] [Updated] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (23 preceding siblings ...)
2021-10-04 3:22 ` [PR PATCH] [Updated] " Twilighttony
@ 2021-10-04 3:33 ` Twilighttony
2021-10-04 3:36 ` Twilighttony
` (10 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-10-04 3:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by Twilighttony against master on the void-packages repository
https://github.com/Twilighttony/void-packages NetworkManager-fortisslvpn
https://github.com/void-linux/void-packages/pull/33066
New Package: NetworkManager-fortisslvpn-1.3.90
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33066.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NetworkManager-fortisslvpn-33066.patch --]
[-- Type: text/x-diff, Size: 1694 bytes --]
From 6fe54f9cdc65ea554b795ecc5388bec18cf04410 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Thu, 23 Sep 2021 00:19:44 -0400
Subject: [PATCH] New Package: NetworkManager-fortisslvpn-1.3.90
---
srcpkgs/NetworkManager-fortisslvpn/template | 24 +++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/NetworkManager-fortisslvpn/template
diff --git a/srcpkgs/NetworkManager-fortisslvpn/template b/srcpkgs/NetworkManager-fortisslvpn/template
new file mode 100644
index 000000000000..99c113d39748
--- /dev/null
+++ b/srcpkgs/NetworkManager-fortisslvpn/template
@@ -0,0 +1,24 @@
+# Template file for 'NetworkManager-fortisslvpn'
+pkgname=NetworkManager-fortisslvpn
+version=1.3.90
+revision=1
+build_style=gnu-configure
+_pppver=2.4.9
+configure_args="--disable-static --libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
+hostmakedepends="automake gettext-devel glib-devel intltool libtool pkg-config"
+makedepends="ppp-devel gtk+3-devel libglib-devel libnma-devel libsecret-devel"
+depends="openfortivpn"
+short_desc="NetworkManager VPN plugin for OpenFortiVPN"
+maintainer="Twilighttony <starrbeartony14@zoho.com>"
+license="GPL-2.0-or-later"
+homepage="https://wiki.gnome.org/Projects/NetworkManager"
+distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=884a7432bb38ae9c942e094f23d0a3feb504432153c3d2869ab71a4dd244d0fb
+system_accounts="_nm_openfortivpn"
+_nm_openfortivpn_homedir="/var/lib/NetworkManager-fortisslvpn"
+make_dirs="/var/lib/NetworkManager-fortisslvpn 0755 _nm_openfortivpn _nm_openfortivpn"
+lib32disabled=yes
+
+pre_configure() {
+ autoreconf -fi
+}
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (24 preceding siblings ...)
2021-10-04 3:33 ` Twilighttony
@ 2021-10-04 3:36 ` Twilighttony
2021-10-05 15:23 ` classabbyamp
` (9 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: Twilighttony @ 2021-10-04 3:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New comment by Twilighttony on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#issuecomment-933115077
Comment:
> Needs rebase.
Done.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (25 preceding siblings ...)
2021-10-04 3:36 ` Twilighttony
@ 2021-10-05 15:23 ` classabbyamp
2022-06-05 2:14 ` github-actions
` (8 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: classabbyamp @ 2021-10-05 15:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#issuecomment-934509832
Comment:
related issue that can be closed if this is merged: #20462
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (26 preceding siblings ...)
2021-10-05 15:23 ` classabbyamp
@ 2022-06-05 2:14 ` github-actions
2023-02-03 18:28 ` [PR REVIEW] " classabbyamp
` (7 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: github-actions @ 2022-06-05 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#issuecomment-1146725042
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (27 preceding siblings ...)
2022-06-05 2:14 ` github-actions
@ 2023-02-03 18:28 ` classabbyamp
2023-02-03 18:28 ` classabbyamp
` (6 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: classabbyamp @ 2023-02-03 18:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1096122102
Comment:
```suggestion
configure_args="--disable-static --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
```
this is not correct, other networkmanager vpn clients use `/usr/libexec`
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (28 preceding siblings ...)
2023-02-03 18:28 ` [PR REVIEW] " classabbyamp
@ 2023-02-03 18:28 ` classabbyamp
2023-02-03 18:28 ` classabbyamp
` (5 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: classabbyamp @ 2023-02-03 18:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1096122478
Comment:
```suggestion
distfiles="${GNOME_SITE}/NetworkManager-fortisslvpn/${version%.*}/NetworkManager-fortisslvpn-${version}.tar.xz"
```
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (29 preceding siblings ...)
2023-02-03 18:28 ` classabbyamp
@ 2023-02-03 18:28 ` classabbyamp
2023-08-27 22:05 ` slimjimsoftware
` (4 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: classabbyamp @ 2023-02-03 18:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1096122102
Comment:
```suggestion
configure_args="--disable-static --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
```
this is not correct, other networkmanager vpn clients use `/usr/libexec` (see `xlocate /usr/libexec/nm-`)
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (30 preceding siblings ...)
2023-02-03 18:28 ` classabbyamp
@ 2023-08-27 22:05 ` slimjimsoftware
2023-08-27 22:06 ` slimjimsoftware
` (3 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: slimjimsoftware @ 2023-08-27 22:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by slimjimsoftware on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1306729530
Comment:
```suggestion
depends="openfortivpn ppp"
```
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (31 preceding siblings ...)
2023-08-27 22:05 ` slimjimsoftware
@ 2023-08-27 22:06 ` slimjimsoftware
2024-04-01 10:51 ` [PR REVIEW] " Eloitor
` (2 subsequent siblings)
35 siblings, 0 replies; 37+ messages in thread
From: slimjimsoftware @ 2023-08-27 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
New comment by slimjimsoftware on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#issuecomment-1694772866
Comment:
> I'm having trouble with this, I get this error when trying to activate a fortissl vpn connection via networkmanager:
>
> ```
> 2023-02-03T18:24:03.86897 daemon.info: Feb 3 13:24:03 NetworkManager[924]: <info> [1675448643.8688] audit: op="connection-activate" uuid="..." name="Foo" pid=3677 uid=1000 result="fail" reason="The VPN service 'org.freedesktop.NetworkManager.fortisslvpn' was not installed."
> ```
This depends on ppp and you need to reboot after installing, I can confirm after this change and a reboot it works on aarch64
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (32 preceding siblings ...)
2023-08-27 22:06 ` slimjimsoftware
@ 2024-04-01 10:51 ` Eloitor
2024-04-01 10:51 ` Eloitor
2024-04-01 10:52 ` Eloitor
35 siblings, 0 replies; 37+ messages in thread
From: Eloitor @ 2024-04-01 10:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New review comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1546208237
Comment:
New version is 1.4.0
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (33 preceding siblings ...)
2024-04-01 10:51 ` [PR REVIEW] " Eloitor
@ 2024-04-01 10:51 ` Eloitor
2024-04-01 10:52 ` Eloitor
35 siblings, 0 replies; 37+ messages in thread
From: Eloitor @ 2024-04-01 10:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New review comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1546210247
Comment:
Maybe you could add the changelog
https://gitlab.gnome.org/GNOME/NetworkManager-fortisslvpn/-/raw/main/NEWS
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
` (34 preceding siblings ...)
2024-04-01 10:51 ` Eloitor
@ 2024-04-01 10:52 ` Eloitor
35 siblings, 0 replies; 37+ messages in thread
From: Eloitor @ 2024-04-01 10:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r1546211514
Comment:
Is this required? I thought that `makedepends="ppp-devel` already makes the package depend on `ppp`...
^ permalink raw reply [flat|nested] 37+ messages in thread
end of thread, other threads:[~2024-04-01 10:52 UTC | newest]
Thread overview: 37+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 4:39 [PR PATCH] New Package: NetworkManager-fortisslvpn-1.3.90 Twilighttony
2021-09-23 4:43 ` [PR REVIEW] " abenson
2021-09-23 4:43 ` abenson
2021-09-23 4:44 ` abenson
2021-09-23 4:51 ` cinerea0
2021-09-23 4:52 ` cinerea0
2021-09-23 4:53 ` Twilighttony
2021-09-23 5:10 ` [PR PATCH] [Updated] " Twilighttony
2021-09-23 5:22 ` Twilighttony
2021-09-23 5:23 ` [PR REVIEW] " Twilighttony
2021-09-23 16:53 ` cinerea0
2021-09-23 23:05 ` abenson
2021-09-23 23:14 ` [PR PATCH] [Updated] " Twilighttony
2021-09-24 21:29 ` Twilighttony
2021-09-24 23:58 ` [PR REVIEW] " Twilighttony
2021-09-25 3:05 ` abenson
2021-09-25 5:27 ` [PR PATCH] [Updated] " Twilighttony
2021-09-25 5:35 ` Twilighttony
2021-09-25 5:35 ` [PR REVIEW] " Twilighttony
2021-09-25 5:43 ` [PR PATCH] [Updated] " Twilighttony
2021-09-25 5:59 ` Twilighttony
2021-09-25 6:31 ` Twilighttony
2021-09-25 6:49 ` Twilighttony
2021-10-04 3:19 ` the-maldridge
2021-10-04 3:22 ` [PR PATCH] [Updated] " Twilighttony
2021-10-04 3:33 ` Twilighttony
2021-10-04 3:36 ` Twilighttony
2021-10-05 15:23 ` classabbyamp
2022-06-05 2:14 ` github-actions
2023-02-03 18:28 ` [PR REVIEW] " classabbyamp
2023-02-03 18:28 ` classabbyamp
2023-02-03 18:28 ` classabbyamp
2023-08-27 22:05 ` slimjimsoftware
2023-08-27 22:06 ` slimjimsoftware
2024-04-01 10:51 ` [PR REVIEW] " Eloitor
2024-04-01 10:51 ` Eloitor
2024-04-01 10:52 ` Eloitor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).