[PR PATCH] New package: aspell-sk-2.01.2

[PR PATCH] New package: aspell-sk-2.01.2

[priner]

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

There is a new pull request by priner against master on the void-packages repository

https://github.com/priner/void-packages aspell-sk
https://github.com/void-linux/void-packages/pull/33654

New package: aspell-sk-2.01.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Different aspell dictionaries use completely different versioning schemes and usually contain dashes. Versions of void packages can't. I wasn't quite sure how to work around that, aspell-en and aspell-cs do it in different ways.

The `xbps-src update-check` doesn't quite work as i would hoped for,
2.01-2 doesn't compare as a newer version than 2.01-1. (and I believe that this is handled improperly in other aspell dict packages, cause they seem to compare one version with a dash against another where it's replaced with a dot)

A patch file from https://github.com/void-linux/void-packages/pull/33654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aspell-sk-33654.patch --]
[-- Type: text/x-diff, Size: 1387 bytes --]

From eddc08cd501e1b8f7c2d7916f6411928ab03c7b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Priner?= <jan@priner.net>
Date: Wed, 20 Oct 2021 20:01:14 +0200
Subject: [PATCH] New package: aspell-sk-2.01.2

---
 srcpkgs/aspell-sk/template | 13 +++++++++++++
 srcpkgs/aspell-sk/update   |  2 ++
 2 files changed, 15 insertions(+)
 create mode 100644 srcpkgs/aspell-sk/template
 create mode 100644 srcpkgs/aspell-sk/update

diff --git a/srcpkgs/aspell-sk/template b/srcpkgs/aspell-sk/template
new file mode 100644
index 000000000000..482afc262cd4
--- /dev/null
+++ b/srcpkgs/aspell-sk/template
@@ -0,0 +1,13 @@
+# Template file for 'aspell-sk'
+pkgname=aspell-sk
+version=2.01.2
+revision=1
+wrksrc="aspell6-sk-${version%.*}-${version##*.}"
+build_style=configure
+hostmakedepends="aspell-devel which"
+short_desc="Slovak dictionary for aspell"
+maintainer="Ján Priner <jan@priner.net>"
+license="LGPL-2.1-only, GPL-2.0-only, MPL-1.1"
+homepage="http://aspell.net/"
+distfiles="${GNU_SITE}/aspell/dict/sk/aspell6-sk-${version%.*}-${version##*.}.tar.bz2"
+checksum=c6a80a2989c305518e0d71af1196b7484fda26fe53be4e49eec7b15b76a860a6
diff --git a/srcpkgs/aspell-sk/update b/srcpkgs/aspell-sk/update
new file mode 100644
index 000000000000..783f3dcc477f
--- /dev/null
+++ b/srcpkgs/aspell-sk/update
@@ -0,0 +1,2 @@
+pattern="aspell6-sk-\K[\d.-]+(?=\.)"
+version=${version%.*}-${version##*.}

Re: [PR REVIEW] New package: aspell-sk-2.01.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33654#discussion_r733071510

Comment:
> 2.01-2 doesn't compare as a newer version than 2.01-1


It does after you remove this version rewrite. `update-check` rewrites remote dashes to dots.

Re: [PR PATCH] [Updated] New package: aspell-sk-2.01.2

[priner]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

There is an updated pull request by priner against master on the void-packages repository

https://github.com/priner/void-packages aspell-sk
https://github.com/void-linux/void-packages/pull/33654

New package: aspell-sk-2.01.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Different aspell dictionaries use completely different versioning schemes and usually contain dashes. Versions of void packages can't. I wasn't quite sure how to work around that, aspell-en and aspell-cs do it in different ways.

The `xbps-src update-check` doesn't quite work as i would hoped for,
2.01-2 doesn't compare as a newer version than 2.01-1. (and I believe that this is handled improperly in other aspell dict packages, cause they seem to compare one version with a dash against another where it's replaced with a dot)

A patch file from https://github.com/void-linux/void-packages/pull/33654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aspell-sk-33654.patch --]
[-- Type: text/x-diff, Size: 1346 bytes --]

From 07d301e5691267b6444fa6880ad4d4e5d10578e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Priner?= <jan@priner.net>
Date: Wed, 20 Oct 2021 20:01:14 +0200
Subject: [PATCH] New package: aspell-sk-2.01.2

---
 srcpkgs/aspell-sk/template | 13 +++++++++++++
 srcpkgs/aspell-sk/update   |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 srcpkgs/aspell-sk/template
 create mode 100644 srcpkgs/aspell-sk/update

diff --git a/srcpkgs/aspell-sk/template b/srcpkgs/aspell-sk/template
new file mode 100644
index 000000000000..482afc262cd4
--- /dev/null
+++ b/srcpkgs/aspell-sk/template
@@ -0,0 +1,13 @@
+# Template file for 'aspell-sk'
+pkgname=aspell-sk
+version=2.01.2
+revision=1
+wrksrc="aspell6-sk-${version%.*}-${version##*.}"
+build_style=configure
+hostmakedepends="aspell-devel which"
+short_desc="Slovak dictionary for aspell"
+maintainer="Ján Priner <jan@priner.net>"
+license="LGPL-2.1-only, GPL-2.0-only, MPL-1.1"
+homepage="http://aspell.net/"
+distfiles="${GNU_SITE}/aspell/dict/sk/aspell6-sk-${version%.*}-${version##*.}.tar.bz2"
+checksum=c6a80a2989c305518e0d71af1196b7484fda26fe53be4e49eec7b15b76a860a6
diff --git a/srcpkgs/aspell-sk/update b/srcpkgs/aspell-sk/update
new file mode 100644
index 000000000000..930c9c56fce7
--- /dev/null
+++ b/srcpkgs/aspell-sk/update
@@ -0,0 +1 @@
+pattern="aspell6-sk-\K[\d.-]+(?=\.)"

Re: [PR REVIEW] New package: aspell-sk-2.01.2

[priner]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by priner on void-packages repository

https://github.com/void-linux/void-packages/pull/33654#discussion_r733080026

Comment:
Ah sorry, didn't know about that.

Re: [PR PATCH] [Merged]: New package: aspell-sk-2.01.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

There's a merged pull request on the void-packages repository

New package: aspell-sk-2.01.2
https://github.com/void-linux/void-packages/pull/33654

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Different aspell dictionaries use completely different versioning schemes and usually contain dashes. Versions of void packages can't. I wasn't quite sure how to work around that, aspell-en and aspell-cs do it in different ways.

The `xbps-src update-check` doesn't quite work as i would hoped for,
2.01-2 doesn't compare as a newer version than 2.01-1. (and I believe that this is handled improperly in other aspell dict packages, cause they seem to compare one version with a dash against another where it's replaced with a dot)