* [PR PATCH] nvimpager: update to 0.10.3
@ 2021-10-29 10:32 crater2150
2021-10-30 18:06 ` ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: crater2150 @ 2021-10-29 10:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
There is a new pull request by crater2150 against master on the void-packages repository
https://github.com/crater2150/void-packages nvimpager
https://github.com/void-linux/void-packages/pull/33805
nvimpager: update to 0.10.3
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Besides updating to 0.10.3, this fixes a problem that occurred for me recently (probably from the 0.10.2 update): the script is configured via the makefile, inserting the `PREFIX` to pass the right paths to nvim. But the `gnu-makefile` build style only passes `PREFIX` during `do_install`, not during `do_build`. As the first non-wildcard target in the makefile is `install`, I just skipped `do_build`.
A patch file from https://github.com/void-linux/void-packages/pull/33805.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvimpager-33805.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]
From 79801094181814a27b87e8d273ca7d4059918ece Mon Sep 17 00:00:00 2001
From: Alexander Gehrke <github@qwertyuiop.de>
Date: Fri, 29 Oct 2021 12:25:09 +0200
Subject: [PATCH] nvimpager: update to 0.10.3
---
| 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--git a/srcpkgs/nvimpager/template b/srcpkgs/nvimpager/template
index 8bff26dc2439..f8073699f40d 100644
--- a/srcpkgs/nvimpager/template
+++ b/srcpkgs/nvimpager/template
@@ -1,6 +1,6 @@
# Template file for 'nvimpager'
pkgname=nvimpager
-version=0.10.2
+version=0.10.3
revision=1
build_style=gnu-makefile
hostmakedepends="neovim scdoc"
@@ -10,7 +10,11 @@ maintainer="Adrian Herath <adrianisuru@gmail.com>"
license="BSD-2-Clause"
homepage="https://github.com/lucc/nvimpager"
distfiles="https://github.com/lucc/nvimpager/archive/v${version}.tar.gz"
-checksum=58d77fe301a6451098eef2677011cc99138c3735b34859a17cbaa6caba7e0ef4
+checksum=c369c75f3de0c95d8ceca5ab13deaae22626b08bcd2f98b2b42df85ca60d7609
+
+do_build() {
+ :
+}
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nvimpager: update to 0.10.3
2021-10-29 10:32 [PR PATCH] nvimpager: update to 0.10.3 crater2150
@ 2021-10-30 18:06 ` ericonr
2021-10-31 18:50 ` [PR PATCH] [Updated] " crater2150
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-10-30 18:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33805#issuecomment-955571169
Comment:
> Besides updating to 0.10.3, this fixes a problem that occurred for me recently (probably from the 0.10.2 update): the script is configured via the makefile, inserting the PREFIX to pass the right paths to nvim. But the gnu-makefile build style only passes PREFIX during do_install, not during do_build. As the first non-wildcard target in the makefile is install, I just skipped do_build.
This explanation can be included in the commit message, and it'd be of great help there.
Adding a comment to template saying `# nothing to build` is also friendly :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] nvimpager: update to 0.10.3
2021-10-29 10:32 [PR PATCH] nvimpager: update to 0.10.3 crater2150
2021-10-30 18:06 ` ericonr
@ 2021-10-31 18:50 ` crater2150
2021-10-31 18:51 ` crater2150
2021-10-31 21:18 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: crater2150 @ 2021-10-31 18:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
There is an updated pull request by crater2150 against master on the void-packages repository
https://github.com/crater2150/void-packages nvimpager
https://github.com/void-linux/void-packages/pull/33805
nvimpager: update to 0.10.3
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Besides updating to 0.10.3, this fixes a problem that occurred for me recently (probably from the 0.10.2 update): the script is configured via the makefile, inserting the `PREFIX` to pass the right paths to nvim. But the `gnu-makefile` build style only passes `PREFIX` during `do_install`, not during `do_build`. As the first non-wildcard target in the makefile is `install`, I just skipped `do_build`.
A patch file from https://github.com/void-linux/void-packages/pull/33805.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvimpager-33805.patch --]
[-- Type: text/x-diff, Size: 1291 bytes --]
From 34670b69a3815759e46616a257a374d43c6264b3 Mon Sep 17 00:00:00 2001
From: Alexander Gehrke <github@qwertyuiop.de>
Date: Fri, 29 Oct 2021 12:25:09 +0200
Subject: [PATCH] nvimpager: update to 0.10.3
This also fixes a wrong path being passed to neovim, because the
makefile inserts the PREFIX into the script, which is not set during
do_build. As there aren't any binary build steps, do_build is skipped.
---
| 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--git a/srcpkgs/nvimpager/template b/srcpkgs/nvimpager/template
index 8bff26dc2439..9df927579740 100644
--- a/srcpkgs/nvimpager/template
+++ b/srcpkgs/nvimpager/template
@@ -1,6 +1,6 @@
# Template file for 'nvimpager'
pkgname=nvimpager
-version=0.10.2
+version=0.10.3
revision=1
build_style=gnu-makefile
hostmakedepends="neovim scdoc"
@@ -10,7 +10,11 @@ maintainer="Adrian Herath <adrianisuru@gmail.com>"
license="BSD-2-Clause"
homepage="https://github.com/lucc/nvimpager"
distfiles="https://github.com/lucc/nvimpager/archive/v${version}.tar.gz"
-checksum=58d77fe301a6451098eef2677011cc99138c3735b34859a17cbaa6caba7e0ef4
+checksum=c369c75f3de0c95d8ceca5ab13deaae22626b08bcd2f98b2b42df85ca60d7609
+
+do_build() {
+ : # nothing to build
+}
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nvimpager: update to 0.10.3
2021-10-29 10:32 [PR PATCH] nvimpager: update to 0.10.3 crater2150
2021-10-30 18:06 ` ericonr
2021-10-31 18:50 ` [PR PATCH] [Updated] " crater2150
@ 2021-10-31 18:51 ` crater2150
2021-10-31 21:18 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: crater2150 @ 2021-10-31 18:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New comment by crater2150 on void-packages repository
https://github.com/void-linux/void-packages/pull/33805#issuecomment-955773096
Comment:
Ok, I updated the template and commit accordingly.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: nvimpager: update to 0.10.3
2021-10-29 10:32 [PR PATCH] nvimpager: update to 0.10.3 crater2150
` (2 preceding siblings ...)
2021-10-31 18:51 ` crater2150
@ 2021-10-31 21:18 ` ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-10-31 21:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
There's a merged pull request on the void-packages repository
nvimpager: update to 0.10.3
https://github.com/void-linux/void-packages/pull/33805
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Besides updating to 0.10.3, this fixes a problem that occurred for me recently (probably from the 0.10.2 update): the script is configured via the makefile, inserting the `PREFIX` to pass the right paths to nvim. But the `gnu-makefile` build style only passes `PREFIX` during `do_install`, not during `do_build`. As the first non-wildcard target in the makefile is `install`, I just skipped `do_build`.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-31 21:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 10:32 [PR PATCH] nvimpager: update to 0.10.3 crater2150
2021-10-30 18:06 ` ericonr
2021-10-31 18:50 ` [PR PATCH] [Updated] " crater2150
2021-10-31 18:51 ` crater2150
2021-10-31 21:18 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).