From: freshprince <freshprince@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: synapse: update to 1.49.2.
Date: Thu, 30 Dec 2021 11:44:29 +0100 [thread overview]
Message-ID: <20211230104429.Wjw48AEAE8N5zYc3WlTfeKO2e6boYegi4jVhJD--5_0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34676@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
New comment by freshprince on void-packages repository
https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002971905
Comment:
> Was curious what benefit directly execing logger has? I have this running on my system and synapse is already logging to daemon.notice.
I was used to see error output in the logging space of `runsvdir`, when I saw that there was a logging service running for synapse there was no easy way for me to see where it is logging to. All other services I use do have explicitly set where they are logging to and in this case explicit is better than implicit because if you want to check logs you shouldn't need to know what's the default behaviour of vlogger.
> For patching config files, I'd like to have the config file updates installed so that e.g. xdiff from xtools can be used to easily manage updates/changes to the synapse configuration. Currently that's waiting on void-linux/xbps#426, then hopefully we can install to /etc/synapse instead of vsconf.
If you read the [first three paragraphs of the config file that you want to install](https://github.com/matrix-org/synapse/blob/develop/docs/sample_config.yaml) you see that this config file is not intendet to be copied into `/etc/synapse`, patched or otherwise. The config does contain several secrets that should be randomly generated and for this the correct and documented way is to use `generate_config`. Regardles of the behaviour of xbps that resulted in https://github.com/void-linux/xbps/issues/441.
Please test your patches before you create pull requests.
next prev parent reply other threads:[~2021-12-30 10:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 7:53 [PR PATCH] " freshprince
2021-12-23 8:01 ` [PR PATCH] [Updated] " freshprince
2021-12-30 2:57 ` TinfoilSubmarine
2021-12-30 2:59 ` TinfoilSubmarine
2021-12-30 3:11 ` TinfoilSubmarine
2021-12-30 10:44 ` freshprince [this message]
2021-12-30 10:54 ` freshprince
2021-12-30 14:49 ` TinfoilSubmarine
2021-12-31 8:51 ` [PR PATCH] [Updated] " freshprince
2021-12-31 8:53 ` freshprince
2021-12-31 9:02 ` freshprince
2021-12-31 9:11 ` [PR PATCH] [Updated] synapse: minor changes freshprince
2021-12-31 17:09 ` TinfoilSubmarine
2022-01-03 8:55 ` freshprince
2022-01-03 16:03 ` TinfoilSubmarine
2022-01-03 16:20 ` freshprince
2022-01-03 17:44 ` TinfoilSubmarine
2022-01-03 17:44 ` TinfoilSubmarine
2022-01-05 0:58 ` TinfoilSubmarine
2022-01-05 8:20 ` [PR PATCH] [Updated] " freshprince
2022-01-05 12:18 ` freshprince
2022-01-19 10:45 ` freshprince
2022-01-19 10:45 ` [PR PATCH] [Closed]: " freshprince
2021-12-23 22:40 [PR PATCH] synapse: update to 1.49.2 TinfoilSubmarine
2021-12-23 22:43 ` TinfoilSubmarine
2021-12-25 16:22 ` TinfoilSubmarine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230104429.Wjw48AEAE8N5zYc3WlTfeKO2e6boYegi4jVhJD--5_0@z \
--to=freshprince@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).