Github messages for voidlinux
 help / color / mirror / Atom feed
From: TinfoilSubmarine <TinfoilSubmarine@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: synapse: minor changes.
Date: Fri, 31 Dec 2021 18:09:23 +0100	[thread overview]
Message-ID: <20211231170923.TsGhligFF56rfZXB2fM9OKTBz8q6soUgmc8CmqFLyGQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34676@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1003420015

Comment:
> For synapse, logging of stderr doesn't really make sense anyway since it only
> produces output when there's a problem with the configuration.

Being able to see those configuration problems raised in syslog makes debugging easier.

> Sure you can ignore what the authors of the software and people that use it
> tell you and do it anyway.

The `sample_config.yaml` file is generated by running `generate_config --header-file docs/.sample_config_header.yaml -o docs/sample_config.yaml`, so this is just removing the header of an otherwise valid config file.

> If registering a user in the command line (which you do when you follow the
> installation instructions) is advanced functionality for you.

I missed this when I was testing, thanks for pointing it out. I was struggling to find a "beginner" use-case that would be a blocker requiring that the secrets be generated and couldn't come up with one.

However, this isn't necessarily a bad thing. The Debian package maintained by the authors does the same thing -- they generate a default config without generated secrets and the user must manually supply them, see https://github.com/matrix-org/synapse/blob/develop/debian/build_virtualenv.

  parent reply	other threads:[~2021-12-31 17:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23  7:53 [PR PATCH] synapse: update to 1.49.2 freshprince
2021-12-23  8:01 ` [PR PATCH] [Updated] " freshprince
2021-12-30  2:57 ` TinfoilSubmarine
2021-12-30  2:59 ` TinfoilSubmarine
2021-12-30  3:11 ` TinfoilSubmarine
2021-12-30 10:44 ` freshprince
2021-12-30 10:54 ` freshprince
2021-12-30 14:49 ` TinfoilSubmarine
2021-12-31  8:51 ` [PR PATCH] [Updated] " freshprince
2021-12-31  8:53 ` freshprince
2021-12-31  9:02 ` freshprince
2021-12-31  9:11 ` [PR PATCH] [Updated] synapse: minor changes freshprince
2021-12-31 17:09 ` TinfoilSubmarine [this message]
2022-01-03  8:55 ` freshprince
2022-01-03 16:03 ` TinfoilSubmarine
2022-01-03 16:20 ` freshprince
2022-01-03 17:44 ` TinfoilSubmarine
2022-01-03 17:44 ` TinfoilSubmarine
2022-01-05  0:58 ` TinfoilSubmarine
2022-01-05  8:20 ` [PR PATCH] [Updated] " freshprince
2022-01-05 12:18 ` freshprince
2022-01-19 10:45 ` freshprince
2022-01-19 10:45 ` [PR PATCH] [Closed]: " freshprince

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211231170923.TsGhligFF56rfZXB2fM9OKTBz8q6soUgmc8CmqFLyGQ@z \
    --to=tinfoilsubmarine@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).